Build Bitcoin-ABC / Diffs / Diff Testing passed.
Oct 7 2019
Reverted changes to -proxyipvX.
Fixed typo wipte -> wipe.
Was superseded by D4221.
Good point on the composability aspect. I started to notice issues arising from the current design while working on D4213. It's more clear to me now that a composable design would make it more robust in addition to providing the caller with more customization of the build.
Fix according to feedback
Fix failing check-java tests
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR
Applying const T x : seq where T is a built-in type.
Duplicated with D4191.
Reason: arc usage error.
Oct 6 2019
Added locking annotations for all functions remaining in validation.cpp/h with AssertLockHeld(cs_main).