Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 7 2019
Oct 7 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reverted changes to -proxyipvX.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fixed typo wipte -> wipe.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito updated the test plan for D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
fpelliccioni committed rABC50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>).
cli: Ignore libevent warnings
nakihito requested review of D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Nico Guiton <nico@bitframe.org> committed rABCefb39b6c2741: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety
jasonbcox committed rABC79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Nico Guiton <nico@bitframe.org> committed rABC295d250b94d3: Added translations for new send coins dialog box (authored by Nico Guiton <nico@bitframe.org>).
Added translations for new send coins dialog box
Nico Guiton <nico@bitframe.org> committed rABC6b6d0ee541c9: Merge #13158: [Qt]: Improve sendcoinsdialog readability (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13158: [Qt]: Improve sendcoinsdialog readability
Nico Guiton <nico@bitframe.org> committed rABC677f3d051472: Bump wallet version for pre split keypool (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Bump wallet version for pre split keypool
Nico Guiton <nico@bitframe.org> committed rABC39892cfb1e39: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys… (authored by Andrew Chow <achow101-github@achow101.com>).
Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys…
teamcity added a comment to D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing passed.
fpelliccioni abandoned D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Was superseded by D4221.
teamcity added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Good point on the composability aspect. I started to notice issues arising from the current design while working on D4213. It's more clear to me now that a composable design would make it more robust in addition to providing the caller with more customization of the build.
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Fix according to feedback
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fix failing check-java tests
Harbormaster failed remote builds in B7703: Diff 13378 for D4213: [build-configurations] Make BUILD_DIR configurable!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Applying const T x : seq where T is a built-in type.
fpelliccioni abandoned D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Duplicated with D4191.
Reason: arc usage error.
teamcity added a comment to D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni committed rABCfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant assignments (dead stores)
Build Bitcoin-ABC / Diffs / Diff Testing passed.
deadalnix committed rABCa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop ParseHashUV in favor of calling ParseHashStr
Build Bitcoin-ABC / Diffs / Diff Testing started.
Oct 6 2019
Oct 6 2019
nakihito retitled D4175: Merge #12924: Fix hdmaster-key / seed-key confusion from Merge #12924: Fix hdmaster-key / seed-key confusion (scripted diff) to Merge #12924: Fix hdmaster-key / seed-key confusion.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Ping ?
nakihito planned changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Added locking annotations for all functions remaining in validation.cpp/h with AssertLockHeld(cs_main).