Page MenuHomePhabricator
Feed All Stories

Oct 7 2019

nakihito planned changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Oct 7 2019, 23:51
nakihito created D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Oct 7 2019, 23:51
teamcity added a comment to D4224: Rename some seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 23:48
teamcity added a comment to D4224: Rename some seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 23:46
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Oct 7 2019, 23:39
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 23:36
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Oct 7 2019, 23:35
nakihito updated the test plan for D4190: Rename master key to seed.
Oct 7 2019, 23:35
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 23:32
teamcity added a comment to D4224: Rename some seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:32
nakihito updated the diff for D4224: Rename some seeder options.

Reverted changes to -proxyipvX.

Oct 7 2019, 23:31
nakihito planned changes to D4224: Rename some seeder options.
Oct 7 2019, 23:31
nakihito updated the test plan for D4222: Update seeder files to use fprintf() instead of printf().
Oct 7 2019, 23:29
nakihito updated the test plan for D4224: Rename some seeder options.
Oct 7 2019, 23:29
nakihito updated the summary of D4224: Rename some seeder options.
Oct 7 2019, 23:29
nakihito updated the summary of D4223: Update Seeder to use ArgsManager.
Oct 7 2019, 23:28
nakihito planned changes to D4223: Update Seeder to use ArgsManager.
Oct 7 2019, 23:28
teamcity added a comment to D4224: Rename some seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:28
nakihito planned changes to D4224: Rename some seeder options.
Oct 7 2019, 23:28
nakihito created D4224: Rename some seeder options.
Oct 7 2019, 23:28
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:23
nakihito updated the diff for D4223: Update Seeder to use ArgsManager.

Fixed typo wipte -> wipe.

Oct 7 2019, 23:23
teamcity added a comment to D4222: Update seeder files to use fprintf() instead of printf().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 23:19
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:18
nakihito planned changes to D4223: Update Seeder to use ArgsManager.
Oct 7 2019, 23:14
nakihito created D4223: Update Seeder to use ArgsManager.
Oct 7 2019, 23:14
nakihito updated the summary of D4222: Update seeder files to use fprintf() instead of printf().
Oct 7 2019, 23:10
teamcity added a comment to D4222: Update seeder files to use fprintf() instead of printf().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:09
nakihito planned changes to D4222: Update seeder files to use fprintf() instead of printf().
Oct 7 2019, 23:08
nakihito created D4222: Update seeder files to use fprintf() instead of printf().
Oct 7 2019, 23:08
nakihito requested review of D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Oct 7 2019, 23:00
nakihito updated the test plan for D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Oct 7 2019, 23:00
nakihito abandoned D4217: Fix up Seeder file header guards.

See D4218.

Oct 7 2019, 22:51
fpelliccioni committed rABC50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>).
cli: Ignore libevent warnings
Oct 7 2019, 20:50
fpelliccioni closed D4005: cli: Ignore libevent warnings.
Oct 7 2019, 20:50
nakihito requested review of D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Oct 7 2019, 19:00
Nico Guiton <nico@bitframe.org> committed rABCefb39b6c2741: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety
Oct 7 2019, 18:54
Nico Guiton <nico@bitframe.org> closed D4166: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety.
Oct 7 2019, 18:54
jasonbcox committed rABC79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Oct 7 2019, 18:44
jasonbcox closed D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Oct 7 2019, 18:44
Nico Guiton <nico@bitframe.org> committed rABC295d250b94d3: Added translations for new send coins dialog box (authored by Nico Guiton <nico@bitframe.org>).
Added translations for new send coins dialog box
Oct 7 2019, 18:41
Nico Guiton <nico@bitframe.org> closed D4208: Added translations for new send coins dialog box.
Oct 7 2019, 18:41
Nico Guiton <nico@bitframe.org> committed rABC6b6d0ee541c9: Merge #13158: [Qt]: Improve sendcoinsdialog readability (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13158: [Qt]: Improve sendcoinsdialog readability
Oct 7 2019, 18:25
Nico Guiton <nico@bitframe.org> closed D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Oct 7 2019, 18:24
Nico Guiton <nico@bitframe.org> closed D4207: Bump wallet version for pre split keypool.
Oct 7 2019, 18:03
Nico Guiton <nico@bitframe.org> committed rABC677f3d051472: Bump wallet version for pre split keypool (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Bump wallet version for pre split keypool
Oct 7 2019, 18:03
Nico Guiton <nico@bitframe.org> committed rABC39892cfb1e39: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys… (authored by Andrew Chow <achow101-github@achow101.com>).
Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys…
Oct 7 2019, 18:03
teamcity added a comment to D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 18:03
Nico Guiton <nico@bitframe.org> closed D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 7 2019, 18:02
fpelliccioni updated the summary of D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 17:52
fpelliccioni abandoned D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Was superseded by D4221.

Oct 7 2019, 17:50
teamcity added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 17:49
teamcity added a comment to D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:47
fpelliccioni created D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 17:47
teamcity added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:39
nakihito planned changes to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Oct 7 2019, 17:39
nakihito created D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Oct 7 2019, 17:39
deadalnix accepted D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Oct 7 2019, 17:31
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 17:23
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:14
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 17:13
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:13
jasonbcox added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Good point on the composability aspect. I started to notice issues arising from the current design while working on D4213. It's more clear to me now that a composable design would make it more robust in addition to providing the caller with more customization of the build.

Oct 7 2019, 17:13
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:12
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:10
jasonbcox updated the diff for D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Fix according to feedback

Oct 7 2019, 17:10
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 17:04
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fix failing check-java tests

Oct 7 2019, 17:04
Harbormaster failed remote builds in B7703: Diff 13378 for D4213: [build-configurations] Make BUILD_DIR configurable!
Oct 7 2019, 16:42
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 7 2019, 16:42
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 16:28
jasonbcox planned changes to D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 7 2019, 16:28
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

Oct 7 2019, 16:28
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 14:35
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 14:25
teamcity added a comment to D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 14:24
fpelliccioni updated the summary of D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 14:24
teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 14:24
fpelliccioni updated the diff for D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Applying const T x : seq where T is a built-in type.

Oct 7 2019, 14:23
fpelliccioni abandoned D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Duplicated with D4191.
Reason: arc usage error.

Oct 7 2019, 14:20
teamcity added a comment to D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 14:08
fpelliccioni created D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 14:08
fpelliccioni committed rABCfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant assignments (dead stores)
Oct 7 2019, 13:08
fpelliccioni closed D4189: Remove redundant assignments (dead stores).
Oct 7 2019, 13:08
teamcity added a comment to D4218: [LINTER] Check for header guard closure comment.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 7 2019, 12:54
deadalnix committed rABCa5735aaa11de: Drop ParseHashUV in favor of calling ParseHashStr (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop ParseHashUV in favor of calling ParseHashStr
Oct 7 2019, 12:50
deadalnix closed D4215: Drop ParseHashUV in favor of calling ParseHashStr.
Oct 7 2019, 12:50
teamcity added a comment to D4218: [LINTER] Check for header guard closure comment.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 12:44
Fabien created D4218: [LINTER] Check for header guard closure comment.
Oct 7 2019, 12:44
Fabien accepted D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Oct 7 2019, 07:57
Fabien accepted D4215: Drop ParseHashUV in favor of calling ParseHashStr.
Oct 7 2019, 07:36

Oct 6 2019

nakihito retitled D4175: Merge #12924: Fix hdmaster-key / seed-key confusion from Merge #12924: Fix hdmaster-key / seed-key confusion (scripted diff) to Merge #12924: Fix hdmaster-key / seed-key confusion.
Oct 6 2019, 22:31
nakihito updated the test plan for D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Oct 6 2019, 22:29
nakihito updated the test plan for D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Oct 6 2019, 22:29
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 6 2019, 21:32
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 6 2019, 21:20
nakihito planned changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Oct 6 2019, 21:20
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Added locking annotations for all functions remaining in validation.cpp/h with AssertLockHeld(cs_main).

Oct 6 2019, 21:20
teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 6 2019, 19:32
teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 6 2019, 19:21