Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Oct 9 2019

fpelliccioni committed rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).

mempool, validation: Explain cs_main locking semantics

Oct 9 2019, 17:21

fpelliccioni closed D4227: mempool, validation: Explain cs_main locking semantics.

Oct 9 2019, 17:21

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 13:12

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 13:03

Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Pick better names for the wrapper function and its cmake file.
Make the install_target() a function to separate its scope from the caller's.

Oct 9 2019, 13:03

teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 12:53

deadalnix accepted D4227: mempool, validation: Explain cs_main locking semantics.

Oct 9 2019, 12:44

Fabien accepted D4228: Do not cache version in cmake build.

Oct 9 2019, 12:43

deadalnix requested changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Oct 9 2019, 12:40

teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 12:38

teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 12:38

fpelliccioni updated the diff for D4227: mempool, validation: Explain cs_main locking semantics.

fix squashing

Oct 9 2019, 12:37

teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 12:28

deadalnix updated the diff for D4228: Do not cache version in cmake build.

Fix doc

Oct 9 2019, 12:28

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 12:02

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 11:56

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 11:51

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 11:50

Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Missing newline.

Oct 9 2019, 11:50

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 11:46

Fabien created D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Oct 9 2019, 11:46

Fabien requested changes to D4228: Do not cache version in cmake build.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

Oct 9 2019, 06:27

nakihito planned changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 9 2019, 01:26

nakihito added a comment to D4190: Rename master key to seed.

The behavioral changes made by this diff will be moved to D4175.

Oct 9 2019, 01:25

nakihito planned changes to D4190: Rename master key to seed.

Oct 9 2019, 01:15

nakihito requested review of D4222: Update seeder files to use fprintf() instead of printf().

Edited summary to better express the reasoning behind this change. Also removed unnecessary dependency.

Oct 9 2019, 01:14

nakihito updated the summary of D4222: Update seeder files to use fprintf() instead of printf().

Oct 9 2019, 01:12

nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

In D4225#101505, @deadalnix wrote:

2/3 of the PR are missing.

Oct 9 2019, 01:05

nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Oct 9 2019, 01:04

nakihito planned changes to D4224: Rename some seeder options.

Oct 9 2019, 00:25

jasonbcox requested changes to D4224: Rename some seeder options.

+1 to release notes

Oct 9 2019, 00:20

teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 9 2019, 00:16

teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 9 2019, 00:05

deadalnix created D4228: Do not cache version in cmake build.

Oct 9 2019, 00:05

Oct 8 2019

nakihito planned changes to D4223: Update Seeder to use ArgsManager.

Oct 8 2019, 21:46

jasonbcox committed rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).

[build-configurations] Make BUILD_DIR configurable

Oct 8 2019, 21:45

jasonbcox closed D4213: [build-configurations] Make BUILD_DIR configurable.

Oct 8 2019, 21:45

Fabien committed rABC7ae2dc514d8f: [LINTER] Check for header guard closure comment (authored by Fabien).

[LINTER] Check for header guard closure comment

Oct 8 2019, 19:32

Fabien closed D4218: [LINTER] Check for header guard closure comment.

Oct 8 2019, 19:31

teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 19:25

fpelliccioni planned changes to D4227: mempool, validation: Explain cs_main locking semantics.

I don't know what happened with Squash... I lost some of the changes...

Oct 8 2019, 19:12

fpelliccioni updated the test plan for D4227: mempool, validation: Explain cs_main locking semantics.

Oct 8 2019, 19:10

teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 19:09

fpelliccioni created D4227: mempool, validation: Explain cs_main locking semantics.

Oct 8 2019, 19:09

Nico Guiton <nico@bitframe.org> committed rABC0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime (authored by Jonas Schnelli <dev@jonasschnelli.ch>).

Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime

Oct 8 2019, 17:49

Nico Guiton <nico@bitframe.org> closed D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Oct 8 2019, 17:49

fpelliccioni abandoned D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Duplicated D4220

Oct 8 2019, 17:47

deadalnix requested changes to D4190: Rename master key to seed.

Oct 8 2019, 17:09

deadalnix accepted D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Oct 8 2019, 17:04

nakihito added a reviewer for D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime: fpelliccioni.

Oct 8 2019, 16:58

fpelliccioni added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

Oct 8 2019, 16:44

fpelliccioni added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

In D4226#101538, @nakihito wrote:

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Oct 8 2019, 16:41

Nico Guiton <nico@bitframe.org> committed rABC18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen() (authored by Nico Guiton <nico@bitframe.org>).

Update Seeder to use fsbridge::fopen() instead of fopen()

Oct 8 2019, 16:35

Nico Guiton <nico@bitframe.org> closed D4216: Update Seeder to use fsbridge::fopen() instead of fopen().

Oct 8 2019, 16:35

nakihito requested changes to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Oct 8 2019, 16:27

teamcity added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 16:15

deadalnix requested changes to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Oct 8 2019, 16:14

deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Oct 8 2019, 16:12

fpelliccioni committed rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).

Make objects in range declarations immutable by default. Avoid unnecessary…

Oct 8 2019, 16:08

fpelliccioni closed D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Oct 8 2019, 16:08

fpelliccioni updated the summary of D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Oct 8 2019, 16:06

teamcity added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 16:05

fpelliccioni created D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Oct 8 2019, 16:05

deadalnix requested changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

2/3 of the PR are missing.

Oct 8 2019, 15:58

deadalnix accepted D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Oct 8 2019, 15:56

deadalnix added a comment to D4223: Update Seeder to use ArgsManager.

Ha, this also breaks single letter parameters names, without release notes or any documentation, because why wouldn't it?

Oct 8 2019, 15:20

deadalnix requested changes to D4224: Rename some seeder options.

Randomly changing parameters without updating the doc or even writing release note is indeed the shortest path toward success.

Oct 8 2019, 15:20

deadalnix requested changes to D4223: Update Seeder to use ArgsManager.

There was a nice separation between argument processing and application initialization before, now there isn't. This clearly makes the code worse.

Oct 8 2019, 15:16

deadalnix requested changes to D4222: Update seeder files to use fprintf() instead of printf().

What is the goal of this? Why does it depends on D4216?

Oct 8 2019, 14:56

deadalnix accepted D4216: Update Seeder to use fsbridge::fopen() instead of fopen().

Oct 8 2019, 14:52

deadalnix accepted D4218: [LINTER] Check for header guard closure comment.

Oct 8 2019, 14:20

teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 00:52

teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 00:45

nakihito requested review of D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 8 2019, 00:43

nakihito requested review of D4190: Rename master key to seed.

Oct 8 2019, 00:42

teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 00:35

nakihito planned changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 8 2019, 00:35

nakihito updated the diff for D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Rebased and changed release note to better reflect changes.

Oct 8 2019, 00:35

teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 00:31

nakihito planned changes to D4190: Rename master key to seed.

Oct 8 2019, 00:30

nakihito updated the diff for D4190: Rename master key to seed.

Rebased.

Oct 8 2019, 00:30

Harbormaster failed remote builds in B7715: Diff 13400 for D4190: Rename master key to seed!

Oct 8 2019, 00:21

teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 8 2019, 00:21

teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 00:20

nakihito planned changes to D4190: Rename master key to seed.

Oct 8 2019, 00:19

nakihito updated the diff for D4190: Rename master key to seed.

Rebased.

Oct 8 2019, 00:19

teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 00:17

nakihito requested review of D4224: Rename some seeder options.

Oct 8 2019, 00:09

nakihito requested review of D4223: Update Seeder to use ArgsManager.

Oct 8 2019, 00:08

nakihito requested review of D4222: Update seeder files to use fprintf() instead of printf().

Oct 8 2019, 00:07

nakihito requested review of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Oct 8 2019, 00:06

nakihito updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Oct 8 2019, 00:06

teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 8 2019, 00:04

nakihito planned changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Oct 8 2019, 00:04

nakihito updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Removed functionally correct, but unwanted changes to merkleblock.cpp/h. The issue of code ownership was decided when D3371 was landed. Changes are now only directed to tests.

Oct 8 2019, 00:04

teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 8 2019, 00:03

Oct 7 2019

nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Oct 7 2019, 23:52

nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Oct 7 2019, 23:52

teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 7 2019, 23:52

nakihito requested review of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Oct 7 2019, 23:52