Page MenuHomePhabricator
Feed All Stories

Wed, Oct 9

fpelliccioni committed rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).
mempool, validation: Explain cs_main locking semantics
Wed, Oct 9, 17:21
fpelliccioni closed D4227: mempool, validation: Explain cs_main locking semantics.
Wed, Oct 9, 17:21
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 13:12
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 13:03
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Pick better names for the wrapper function and its cmake file.
Make the install_target() a function to separate its scope from the caller's.

Wed, Oct 9, 13:03
teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 12:53
deadalnix accepted D4227: mempool, validation: Explain cs_main locking semantics.
Wed, Oct 9, 12:44
Fabien accepted D4228: Do not cache version in cmake build.
Wed, Oct 9, 12:43
deadalnix requested changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 9, 12:40
teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 12:38
teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 12:38
fpelliccioni updated the diff for D4227: mempool, validation: Explain cs_main locking semantics.

fix squashing

Wed, Oct 9, 12:37
teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 12:28
deadalnix updated the diff for D4228: Do not cache version in cmake build.

Fix doc

Wed, Oct 9, 12:28
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 12:02
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 11:56
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 11:51
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 11:50
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Missing newline.

Wed, Oct 9, 11:50
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 11:46
Fabien created D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Wed, Oct 9, 11:46
Fabien requested changes to D4228: Do not cache version in cmake build.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

Wed, Oct 9, 06:27
nakihito planned changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Wed, Oct 9, 01:26
nakihito added a comment to D4190: Rename master key to seed.

The behavioral changes made by this diff will be moved to D4175.

Wed, Oct 9, 01:25
nakihito planned changes to D4190: Rename master key to seed.
Wed, Oct 9, 01:15
nakihito requested review of D4222: Update seeder files to use fprintf() instead of printf().

Edited summary to better express the reasoning behind this change. Also removed unnecessary dependency.

Wed, Oct 9, 01:14
nakihito updated the summary of D4222: Update seeder files to use fprintf() instead of printf().
Wed, Oct 9, 01:12
nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

2/3 of the PR are missing.

Wed, Oct 9, 01:05
nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Wed, Oct 9, 01:04
nakihito planned changes to D4224: Rename some seeder options.
Wed, Oct 9, 00:25
jasonbcox requested changes to D4224: Rename some seeder options.

+1 to release notes

Wed, Oct 9, 00:20
teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Oct 9, 00:16
teamcity added a comment to D4228: Do not cache version in cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Oct 9, 00:05
deadalnix created D4228: Do not cache version in cmake build.
Wed, Oct 9, 00:05

Tue, Oct 8

nakihito planned changes to D4223: Update Seeder to use ArgsManager.
Tue, Oct 8, 21:46
jasonbcox committed rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).
[build-configurations] Make BUILD_DIR configurable
Tue, Oct 8, 21:45
jasonbcox closed D4213: [build-configurations] Make BUILD_DIR configurable.
Tue, Oct 8, 21:45
Fabien committed rABC7ae2dc514d8f: [LINTER] Check for header guard closure comment (authored by Fabien).
[LINTER] Check for header guard closure comment
Tue, Oct 8, 19:32
Fabien closed D4218: [LINTER] Check for header guard closure comment.
Tue, Oct 8, 19:31
teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 19:25
fpelliccioni planned changes to D4227: mempool, validation: Explain cs_main locking semantics.

I don't know what happened with Squash... I lost some of the changes...

Tue, Oct 8, 19:12
fpelliccioni updated the test plan for D4227: mempool, validation: Explain cs_main locking semantics.
Tue, Oct 8, 19:10
teamcity added a comment to D4227: mempool, validation: Explain cs_main locking semantics.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 19:09
fpelliccioni created D4227: mempool, validation: Explain cs_main locking semantics.
Tue, Oct 8, 19:09
Nico Guiton <nico@bitframe.org> committed rABC0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime
Tue, Oct 8, 17:49
Nico Guiton <nico@bitframe.org> closed D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Tue, Oct 8, 17:49
fpelliccioni abandoned D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Duplicated D4220

Tue, Oct 8, 17:47
deadalnix requested changes to D4190: Rename master key to seed.
Tue, Oct 8, 17:09
deadalnix accepted D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Tue, Oct 8, 17:04
nakihito added a reviewer for D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime: fpelliccioni.
Tue, Oct 8, 16:58
fpelliccioni added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

Tue, Oct 8, 16:44
fpelliccioni added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Tue, Oct 8, 16:41
Nico Guiton <nico@bitframe.org> committed rABC18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen() (authored by Nico Guiton <nico@bitframe.org>).
Update Seeder to use fsbridge::fopen() instead of fopen()
Tue, Oct 8, 16:35
Nico Guiton <nico@bitframe.org> closed D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Tue, Oct 8, 16:35
nakihito requested changes to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Tue, Oct 8, 16:27
teamcity added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 16:15
deadalnix requested changes to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.
Tue, Oct 8, 16:14
deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Tue, Oct 8, 16:12
fpelliccioni committed rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make objects in range declarations immutable by default. Avoid unnecessary…
Tue, Oct 8, 16:08
fpelliccioni closed D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Tue, Oct 8, 16:08
fpelliccioni updated the summary of D4226: [wallet] `createwallet` RPC - create new wallet at runtime.
Tue, Oct 8, 16:06
teamcity added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 16:05
fpelliccioni created D4226: [wallet] `createwallet` RPC - create new wallet at runtime.
Tue, Oct 8, 16:05
deadalnix requested changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

2/3 of the PR are missing.

Tue, Oct 8, 15:58
deadalnix accepted D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Tue, Oct 8, 15:56
deadalnix added a comment to D4223: Update Seeder to use ArgsManager.

Ha, this also breaks single letter parameters names, without release notes or any documentation, because why wouldn't it?

Tue, Oct 8, 15:20
deadalnix requested changes to D4224: Rename some seeder options.

Randomly changing parameters without updating the doc or even writing release note is indeed the shortest path toward success.

Tue, Oct 8, 15:20
deadalnix requested changes to D4223: Update Seeder to use ArgsManager.

There was a nice separation between argument processing and application initialization before, now there isn't. This clearly makes the code worse.

Tue, Oct 8, 15:16
deadalnix requested changes to D4222: Update seeder files to use fprintf() instead of printf().

What is the goal of this? Why does it depends on D4216?

Tue, Oct 8, 14:56
deadalnix accepted D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Tue, Oct 8, 14:52
deadalnix accepted D4218: [LINTER] Check for header guard closure comment.
Tue, Oct 8, 14:20
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 00:52
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 00:45
nakihito requested review of D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Tue, Oct 8, 00:43
nakihito requested review of D4190: Rename master key to seed.
Tue, Oct 8, 00:42
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 00:35
nakihito planned changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Tue, Oct 8, 00:35
nakihito updated the diff for D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Rebased and changed release note to better reflect changes.

Tue, Oct 8, 00:35
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 00:31
nakihito planned changes to D4190: Rename master key to seed.
Tue, Oct 8, 00:30
nakihito updated the diff for D4190: Rename master key to seed.

Rebased.

Tue, Oct 8, 00:30
Harbormaster failed remote builds in B7715: Diff 13400 for D4190: Rename master key to seed!
Tue, Oct 8, 00:21
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Tue, Oct 8, 00:21
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 00:20
nakihito planned changes to D4190: Rename master key to seed.
Tue, Oct 8, 00:19
nakihito updated the diff for D4190: Rename master key to seed.

Rebased.

Tue, Oct 8, 00:19
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 00:17
nakihito requested review of D4224: Rename some seeder options.
Tue, Oct 8, 00:09
nakihito requested review of D4223: Update Seeder to use ArgsManager.
Tue, Oct 8, 00:08
nakihito requested review of D4222: Update seeder files to use fprintf() instead of printf().
Tue, Oct 8, 00:07
nakihito requested review of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Tue, Oct 8, 00:06
nakihito updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Tue, Oct 8, 00:06
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Oct 8, 00:04
nakihito planned changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Tue, Oct 8, 00:04
nakihito updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Removed functionally correct, but unwanted changes to merkleblock.cpp/h. The issue of code ownership was decided when D3371 was landed. Changes are now only directed to tests.

Tue, Oct 8, 00:04
teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Oct 8, 00:03

Mon, Oct 7

nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Mon, Oct 7, 23:52
nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.
Mon, Oct 7, 23:52
teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Oct 7, 23:52
nakihito requested review of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Mon, Oct 7, 23:52