Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Oct 15 2019

nakihito updated the diff for D4250: Introduce constant default variables to initialize seeder options.

Changed constants to upper snake case and made static.

Oct 15 2019, 18:24
nakihito updated the test plan for D4190: Rename master key to seed.
Oct 15 2019, 17:30
nakihito updated the summary of D4190: Rename master key to seed.
Oct 15 2019, 17:28
nakihito requested review of D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

Updated test plan.

Oct 15 2019, 17:27
nakihito updated the test plan for D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Oct 15 2019, 17:19
teamcity added a comment to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 16:44
teamcity added a comment to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 16:33
nakihito updated the diff for D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Added braces.

Oct 15 2019, 16:33
jasonbcox requested changes to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Oct 15 2019, 15:38
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.
Oct 15 2019, 15:37
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 14:35
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 14:20
deadalnix created D4258: Implement PSBT Structures and un/serialization methods per BIP 174.
Oct 15 2019, 14:20
teamcity added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 14:19
teamcity added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 14:05
fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

fix the rebase

Oct 15 2019, 14:05
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 14:00
fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.
In D4234#102134, @deadalnix wrote:

It looks like you have dependencies to backport first.

Oct 15 2019, 13:58
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 13:47
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix rebase error

Oct 15 2019, 13:47
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 15 2019, 13:46
deadalnix requested changes to D4190: Rename master key to seed.

The diff doesn't match the description anymore. It's also unclear to me why the double outputs wasn't stacked first.

Oct 15 2019, 13:46
deadalnix accepted D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

You shouldn't have made this dependent on the other

Oct 15 2019, 13:44
deadalnix requested changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 15 2019, 13:42
deadalnix added inline comments to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 15 2019, 13:42
teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 12:38
teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 12:23
Fabien created D4257: [CMAKE] Propagate requirements for cmake >= 3.12.
Oct 15 2019, 12:22
deadalnix accepted D4256: [CMAKE] Add resource file to bitcoin-qt.
Oct 15 2019, 10:38
Fabien requested changes to D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

The test plan doesn't cover the change.

Oct 15 2019, 09:33
teamcity added a comment to D4256: [CMAKE] Add resource file to bitcoin-qt.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 08:48
teamcity added a comment to D4256: [CMAKE] Add resource file to bitcoin-qt.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 08:37
Fabien created D4256: [CMAKE] Add resource file to bitcoin-qt.
Oct 15 2019, 08:37
nakihito updated the summary of D4253: rpc: Add unloadwallet RPC, release notes, and tests.
Oct 15 2019, 03:16
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 03:08
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 02:58
nakihito updated the diff for D4254: ui: Support wallets unloaded dynamically.

Fixed braces.

Oct 15 2019, 02:57
nakihito requested review of D4253: rpc: Add unloadwallet RPC, release notes, and tests.
Oct 15 2019, 02:55
nakihito requested review of D4254: ui: Support wallets unloaded dynamically.
Oct 15 2019, 02:55
nakihito requested review of D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Oct 15 2019, 02:44
nakihito requested review of D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Oct 15 2019, 02:41
teamcity added a comment to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 02:39
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 02:38
teamcity added a comment to D4253: rpc: Add unloadwallet RPC, release notes, and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 02:38
teamcity added a comment to D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 15 2019, 02:32
teamcity added a comment to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 02:28
nakihito planned changes to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Oct 15 2019, 02:27
nakihito created D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Oct 15 2019, 02:27
teamcity added a comment to D4254: ui: Support wallets unloaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 02:26
nakihito planned changes to D4254: ui: Support wallets unloaded dynamically.
Oct 15 2019, 02:26
nakihito created D4254: ui: Support wallets unloaded dynamically.
Oct 15 2019, 02:26
teamcity added a comment to D4253: rpc: Add unloadwallet RPC, release notes, and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 02:24
nakihito planned changes to D4253: rpc: Add unloadwallet RPC, release notes, and tests.
Oct 15 2019, 02:24
nakihito created D4253: rpc: Add unloadwallet RPC, release notes, and tests.
Oct 15 2019, 02:24
teamcity added a comment to D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 15 2019, 02:23
nakihito planned changes to D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Oct 15 2019, 02:22
nakihito created D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Oct 15 2019, 02:22
nakihito requested review of D4250: Introduce constant default variables to initialize seeder options.
Oct 15 2019, 00:33
nakihito updated the test plan for D4250: Introduce constant default variables to initialize seeder options.
Oct 15 2019, 00:33
jasonbcox accepted D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

I don't agree that this is easier to read, but I do agree with where this is heading and that it will integrate with ArgsManager better.

Oct 15 2019, 00:20

Oct 14 2019

nakihito updated the test plan for D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 23:54
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.

testplan doesn't verify that all modified defaults are still set as expected

Oct 14 2019, 23:42
nakihito requested review of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Updated summary to reflect discuss on why changes were reverted.

Oct 14 2019, 22:34
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 22:31
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 22:29
Nico Guiton <nico@bitframe.org> committed rABCc24fca0bdad2: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where…
Oct 14 2019, 22:26
Nico Guiton <nico@bitframe.org> closed D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.
Oct 14 2019, 22:26
nakihito requested review of D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:24
nakihito requested review of D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 22:24
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 22:22
nakihito planned changes to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:22
nakihito updated the diff for D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Rebased.

Oct 14 2019, 22:22
nakihito updated the test plan for D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:19
nakihito updated the summary of D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:16
nakihito planned changes to D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 22:16
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 22:14
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 22:13
nakihito updated the diff for D4250: Introduce constant default variables to initialize seeder options.

Reverted the std::string constants to const char*. The const char*s will be changed to std::string in another diff.

Oct 14 2019, 22:13
nakihito updated the test plan for D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 22:11
nakihito updated the test plan for D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 22:06
teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 22:05
nakihito planned changes to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:05
nakihito created D4251: Change CDnsSeedOpts to use std::string instead of c-strings.
Oct 14 2019, 22:05
jasonbcox accepted D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.
Oct 14 2019, 21:08
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.

For testing the defaults, the testplan should *not* include various arguments.

Oct 14 2019, 21:06
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 20:38
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 20:28
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 20:24
nakihito updated the diff for D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Rebased.

Oct 14 2019, 20:23
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 20:15
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 20:15
nakihito updated the diff for D4190: Rename master key to seed.

Formatting changes to wallet_keypool.py undone.

Oct 14 2019, 20:09
nakihito planned changes to D4223: Update Seeder to use ArgsManager.
Oct 14 2019, 20:05
teamcity added a comment to D4250: Introduce constant default variables to initialize seeder options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 20:05
nakihito created D4250: Introduce constant default variables to initialize seeder options.
Oct 14 2019, 20:05
Nico Guiton <nico@bitframe.org> committed rABCe29b97d0d32d: Fix --wipeignore and add message indicating if wipe options are set and… (authored by Nico Guiton <nico@bitframe.org>).
Fix --wipeignore and add message indicating if wipe options are set and…
Oct 14 2019, 20:03
Nico Guiton <nico@bitframe.org> closed D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.
Oct 14 2019, 20:03
jasonbcox accepted D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.

Good catch.

Oct 14 2019, 20:00
teamcity added a comment to D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 19:32
teamcity added a comment to D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 19:20
First
Prev
Next