Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 8 2019
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added enum class and changed return value of ParseCommandLine() to make use of it.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
I've also updated the summary to provide rationale for why this script should be one piece, as it may not be obvious at first glance.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rename to autopatch in order to not confuse rebasing being the primary goal of the script.
Nov 7 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.
In D4395#105833, @Fabien wrote:You may want to run builds (and ideally tests) on some other platforms, as this code embeds platform-dependent behavior.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
It appears that CMAKE_INSTALL_NAME_TOOL is an existing undocumented CMake variable.
Use it instead of creating a new duplicate, and use the same syntax for otool.
Nov 6 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
In D4402#105849, @Fabien wrote:How do you test for determinism ?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fixed comment formatting.
In D4396#105834, @Fabien wrote:Can you run some benchmark on this change, and add it to the test plan ?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Add release notes, sort imports
How do you test for determinism ?
The while thing could use size_t instead of int, but it's outside the scope of this PR.
Running the benchmarks is welcome
Can you run some benchmark on this change, and add it to the test plan ?
You may want to run builds (and ideally tests) on some other platforms, as this code embeds platform-dependent behavior.
The release notes discussion from D4357 applies here as well.
For reference, these changes are documented for core in the 0.17.0 release notes.