Page MenuHomePhabricator
Feed All Stories

Fri, Nov 8

teamcity added a comment to D4300: Replace getopts() with gArgs in the Seeder..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fri, Nov 8, 04:07
teamcity added a comment to D4300: Replace getopts() with gArgs in the Seeder..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fri, Nov 8, 03:57
nakihito updated the diff for D4300: Replace getopts() with gArgs in the Seeder..

Added enum class and changed return value of ParseCommandLine() to make use of it.

Fri, Nov 8, 03:57
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fri, Nov 8, 00:58
jasonbcox added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

I've also updated the summary to provide rationale for why this script should be one piece, as it may not be obvious at first glance.

Fri, Nov 8, 00:57
jasonbcox retitled D4279: Added autopatch script for patching and rebasing phabricator diffs from Added a rebase script for automation purposes to Added autopatch script for patching and rebasing phabricator diffs.
Fri, Nov 8, 00:56
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fri, Nov 8, 00:49
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.

Rename to autopatch in order to not confuse rebasing being the primary goal of the script.

Fri, Nov 8, 00:49

Thu, Nov 7

jasonbcox requested changes to D4384: [CMAKE] Actually build the DMG image.
Thu, Nov 7, 23:42
teamcity added a comment to D4411: Updated seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 23:40
teamcity added a comment to D4411: Updated seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 23:31
jasonbcox created D4411: Updated seeds.
Thu, Nov 7, 23:30
teamcity added a comment to D4410: Updated manpages for 0.20.6 release.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 22:52
teamcity added a comment to D4409: Updated chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 22:48
teamcity added a comment to D4410: Updated manpages for 0.20.6 release.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 22:41
jasonbcox created D4410: Updated manpages for 0.20.6 release.
Thu, Nov 7, 22:41
teamcity added a comment to D4409: Updated chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 22:39
jasonbcox created D4409: Updated chainparams.
Thu, Nov 7, 22:39
teamcity added a comment to D4408: Added a release note regarding builds needing python 3.5.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 22:36
jasonbcox accepted D4383: [CMAKE] Complete the dist directory to prepare for the DMG image build.
Thu, Nov 7, 22:33
teamcity added a comment to D4395: Switch all RNG code to the built-in PRNG..

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Thu, Nov 7, 22:24
teamcity added a comment to D4408: Added a release note regarding builds needing python 3.5.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 22:22
jasonbcox created D4408: Added a release note regarding builds needing python 3.5.
Thu, Nov 7, 22:22
teamcity added a comment to D4395: Switch all RNG code to the built-in PRNG..

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Thu, Nov 7, 22:15
teamcity added a comment to D4395: Switch all RNG code to the built-in PRNG..

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Thu, Nov 7, 22:11
teamcity added a comment to D4395: Switch all RNG code to the built-in PRNG..

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Thu, Nov 7, 22:11
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Thu, Nov 7, 22:06
Fabien requested changes to D4242: [gitian-build] Split apart building and signing the build.
Thu, Nov 7, 21:05
Fabien accepted D4396: Sprinkle some sweet noexcepts over the RNG code.
Thu, Nov 7, 20:35
jasonbcox accepted D4382: [CMAKE] Build the background dist image on native OSX.
Thu, Nov 7, 19:59
jasonbcox accepted D4381: [CMAKE] Add the background image to the dist directory.
Thu, Nov 7, 19:54
jasonbcox added inline comments to D4379: [CMAKE] Prepare the application bundle for localization.
Thu, Nov 7, 19:53
jasonbcox accepted D4379: [CMAKE] Prepare the application bundle for localization.
Thu, Nov 7, 19:52
Fabien requested review of D4381: [CMAKE] Add the background image to the dist directory.
Thu, Nov 7, 19:42
Fabien requested review of D4379: [CMAKE] Prepare the application bundle for localization.
Thu, Nov 7, 19:37
jasonbcox requested changes to D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 7, 19:26
jasonbcox requested changes to D4381: [CMAKE] Add the background image to the dist directory.
Thu, Nov 7, 19:19
nakihito added a comment to D4402: Merge #15324: test: Make bloom tests deterministic.

Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.

Thu, Nov 7, 19:14
jasonbcox accepted D4380: [CMAKE] Create a distribution directory with translations.
Thu, Nov 7, 19:12
nakihito added a comment to D4395: Switch all RNG code to the built-in PRNG..

You may want to run builds (and ideally tests) on some other platforms, as this code embeds platform-dependent behavior.

Thu, Nov 7, 19:07
jasonbcox requested changes to D4379: [CMAKE] Prepare the application bundle for localization.
Thu, Nov 7, 18:13
Fabien committed rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script (authored by Fabien).
[CMAKE] Generate the split-debug.sh script
Thu, Nov 7, 16:18
Fabien closed D4350: [CMAKE] Generate the split-debug.sh script.
Thu, Nov 7, 16:18
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 15:59
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 15:44
Fabien created D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Thu, Nov 7, 15:44
teamcity added a comment to D4406: [CMAKE] Build a stripped version of the application bundle and use it.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 15:22
teamcity added a comment to D4406: [CMAKE] Build a stripped version of the application bundle and use it.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 15:12
Fabien created D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Thu, Nov 7, 15:12
deadalnix accepted D4350: [CMAKE] Generate the split-debug.sh script.
Thu, Nov 7, 15:12
teamcity added a comment to D4380: [CMAKE] Create a distribution directory with translations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Nov 7, 15:08
deadalnix accepted D4396: Sprinkle some sweet noexcepts over the RNG code.
Thu, Nov 7, 15:07
teamcity added a comment to D4380: [CMAKE] Create a distribution directory with translations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Nov 7, 14:54
Fabien updated the diff for D4380: [CMAKE] Create a distribution directory with translations.

It appears that CMAKE_INSTALL_NAME_TOOL is an existing undocumented CMake variable.
Use it instead of creating a new duplicate, and use the same syntax for otool.

Thu, Nov 7, 14:53
Fabien requested changes to D4357: Add scantxoutset RPC method.
Thu, Nov 7, 07:00

Wed, Nov 6

nakihito planned changes to D4402: Merge #15324: test: Make bloom tests deterministic.
Wed, Nov 6, 21:09
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Nov 6, 20:45
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Nov 6, 20:35
Fabien created D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.
Wed, Nov 6, 20:35
teamcity added a comment to D4403: [CMAKE] Install DLL to bin/ by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Nov 6, 20:28
teamcity added a comment to D4403: [CMAKE] Install DLL to bin/ by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Nov 6, 20:15
Fabien created D4403: [CMAKE] Install DLL to bin/ by default.
Wed, Nov 6, 20:15
nakihito updated the test plan for D4398: DRY: Implement GetRand using FastRandomContext::randrange.
Wed, Nov 6, 20:09
nakihito added a comment to D4402: Merge #15324: test: Make bloom tests deterministic.

How do you test for determinism ?

Wed, Nov 6, 19:47
teamcity added a comment to D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Nov 6, 19:18
teamcity added a comment to D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Nov 6, 19:02
nakihito updated the diff for D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.

Fixed comment formatting.

Wed, Nov 6, 19:02
nakihito requested review of D4396: Sprinkle some sweet noexcepts over the RNG code.

Can you run some benchmark on this change, and add it to the test plan ?

Wed, Nov 6, 18:59
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 18:56
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 18:56
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:50
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:49
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:49
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Nov 6, 16:21
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Nov 6, 16:05
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Add release notes, sort imports

Wed, Nov 6, 16:05
deadalnix committed rABC6e5278d36615: Create utility RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create utility RPCs for PSBT
Wed, Nov 6, 15:13
deadalnix closed D4351: Create utility RPCs for PSBT.
Wed, Nov 6, 15:13
Fabien committed rABC92a22eb2564f: [CMAKE] Use native strip on OSX (authored by Fabien).
[CMAKE] Use native strip on OSX
Wed, Nov 6, 10:44
Fabien closed D4378: [CMAKE] Use native strip on OSX.
Wed, Nov 6, 10:44
Fabien committed rABC68a51c880e22: build: depends: Switch to python3 (authored by MarcoFalke <falke.marco@gmail.com>).
build: depends: Switch to python3
Wed, Nov 6, 10:42
Fabien closed D4377: build: depends: Switch to python3.
Wed, Nov 6, 10:41
Fabien committed rABC18ded4a80b1a: depends: biplist 1.0.3 (authored by fanquake <fanquake@gmail.com>).
depends: biplist 1.0.3
Wed, Nov 6, 10:39
Fabien closed D4376: depends: biplist 1.0.3.
Wed, Nov 6, 10:39
Fabien committed rABCf170e3f679e3: Upgrade mac_alias to 2.0.7 (authored by Douglas Roark <joroark@vt.edu>).
Upgrade mac_alias to 2.0.7
Wed, Nov 6, 10:37
Fabien closed D4364: Upgrade mac_alias to 2.0.7.
Wed, Nov 6, 10:37
Fabien committed rABCb5ec30539ea4: [depends] mac_alias 2.0.6, ds_store 1.1.2 (authored by fanquake <fanquake@gmail.com>).
[depends] mac_alias 2.0.6, ds_store 1.1.2
Wed, Nov 6, 10:35
Fabien closed D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.
Wed, Nov 6, 10:34
Fabien added a comment to D4402: Merge #15324: test: Make bloom tests deterministic.

How do you test for determinism ?

Wed, Nov 6, 10:26
Fabien accepted D4401: Document RNG design in random.h.
Wed, Nov 6, 10:14
Fabien accepted D4400: Use secure allocator for RNG state.
Wed, Nov 6, 10:10
Fabien accepted D4399: Encapsulate RNGState better.

The while thing could use size_t instead of int, but it's outside the scope of this PR.

Wed, Nov 6, 10:04
Fabien added a comment to D4398: DRY: Implement GetRand using FastRandomContext::randrange.

Running the benchmarks is welcome

Wed, Nov 6, 10:01
Fabien accepted D4398: DRY: Implement GetRand using FastRandomContext::randrange.
Wed, Nov 6, 10:00
Fabien accepted D4397: Remove hwrand_initialized..
Wed, Nov 6, 09:56
Fabien requested changes to D4396: Sprinkle some sweet noexcepts over the RNG code.

Can you run some benchmark on this change, and add it to the test plan ?

Wed, Nov 6, 09:32
Fabien added a comment to D4395: Switch all RNG code to the built-in PRNG..

You may want to run builds (and ideally tests) on some other platforms, as this code embeds platform-dependent behavior.

Wed, Nov 6, 09:26
Fabien requested changes to D4357: Add scantxoutset RPC method.
Wed, Nov 6, 07:43
Fabien accepted D4351: Create utility RPCs for PSBT.

The release notes discussion from D4357 applies here as well.
For reference, these changes are documented for core in the 0.17.0 release notes.

Wed, Nov 6, 07:43
Fabien added inline comments to D4357: Add scantxoutset RPC method.
Wed, Nov 6, 07:33