Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Nov 30 2019

teamcity added a comment to D4596: validation: assert that pindexPrev is non-null when required.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 20:06
deadalnix created D4596: validation: assert that pindexPrev is non-null when required.
Nov 30 2019, 20:06
deadalnix accepted D4587: [CMAKE] Avoid rebuilding sec256k1.

Cool, I was wondering WTF was up with this one.

Nov 30 2019, 17:54
deadalnix accepted D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.
Nov 30 2019, 17:51
deadalnix accepted D4577: remove NULLDUMMY.
Nov 30 2019, 17:51
deadalnix committed rABCc1ff716fb035: Rationalize lock anotation in validation code (authored by deadalnix).
Rationalize lock anotation in validation code
Nov 30 2019, 17:45
deadalnix closed D4581: Rationalize lock anotation in validation code.
Nov 30 2019, 17:44
deadalnix committed rABCa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview… (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add missing cs_main locks required when accessing pcoinsdbview…
Nov 30 2019, 17:37
deadalnix closed D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.
Nov 30 2019, 17:37
deadalnix committed rABC1450d42778b0: Introduce BlockHash to represent a block hash (authored by deadalnix).
Introduce BlockHash to represent a block hash
Nov 30 2019, 17:34
deadalnix closed D4595: Introduce BlockHash to represent a block hash.
Nov 30 2019, 17:33
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 17:18
Fabien accepted D4595: Introduce BlockHash to represent a block hash.
Nov 30 2019, 17:07
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 17:02
deadalnix updated the diff for D4595: Introduce BlockHash to represent a block hash.

Update

Nov 30 2019, 17:02
deadalnix added inline comments to D4595: Introduce BlockHash to represent a block hash.
Nov 30 2019, 16:31
Fabien requested changes to D4595: Introduce BlockHash to represent a block hash.
Nov 30 2019, 14:49
Fabien requested review of D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.

There is one (hidden) assignation, the BUILD_TYPE_FLAGS variable from string(TOUPPER "CMAKE_C_FLAGS_${CMAKE_BUILD_TYPE}" BUILD_TYPE_FLAGS)

Nov 30 2019, 14:11
Fabien accepted D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.
Nov 30 2019, 14:09
deadalnix added a comment to D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.
In D4592#110791, @Fabien wrote:

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

Nov 30 2019, 13:21
deadalnix committed rABC7035796c5c42: Add braces in block.h (authored by deadalnix).
Add braces in block.h
Nov 30 2019, 12:27
deadalnix closed D4593: Add braces in block.h.
Nov 30 2019, 12:26
deadalnix committed rABC5ab9397fa15a: Use size_t where apropriate in skiplist_tests.cpp (authored by deadalnix).
Use size_t where apropriate in skiplist_tests.cpp
Nov 30 2019, 12:26
deadalnix closed D4594: Use size_t where apropriate in skiplist_tests.cpp.
Nov 30 2019, 12:26
deadalnix committed rABC21f85a0674cd: Add Benchmark to test input de-duplication worst case (authored by Jeremy Rubin <jeremy.l.rubin@gmail.com>).
Add Benchmark to test input de-duplication worst case
Nov 30 2019, 12:21
deadalnix closed D4591: Add Benchmark to test input de-duplication worst case.
Nov 30 2019, 12:21
Fabien accepted D4581: Rationalize lock anotation in validation code.
Nov 30 2019, 10:01
Fabien accepted D4594: Use size_t where apropriate in skiplist_tests.cpp.
Nov 30 2019, 10:00
Fabien accepted D4593: Add braces in block.h.
Nov 30 2019, 09:59
Fabien added a comment to D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

Nov 30 2019, 09:53
Fabien accepted D4591: Add Benchmark to test input de-duplication worst case.
Nov 30 2019, 09:41
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 03:21
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 03:18
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 03:03
teamcity added a comment to D4593: Add braces in block.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 03:03
deadalnix updated the diff for D4595: Introduce BlockHash to represent a block hash.

Update copyright year

Nov 30 2019, 03:03
teamcity added a comment to D4595: Introduce BlockHash to represent a block hash.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 03:01
deadalnix created D4595: Introduce BlockHash to represent a block hash.
Nov 30 2019, 03:01
teamcity added a comment to D4594: Use size_t where apropriate in skiplist_tests.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 02:59
teamcity added a comment to D4594: Use size_t where apropriate in skiplist_tests.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 02:49
deadalnix created D4594: Use size_t where apropriate in skiplist_tests.cpp.
Nov 30 2019, 02:48
teamcity added a comment to D4593: Add braces in block.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 30 2019, 02:47
deadalnix created D4593: Add braces in block.h.
Nov 30 2019, 02:47
teamcity added a comment to D4581: Rationalize lock anotation in validation code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 00:12
teamcity added a comment to D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 00:08
majcosta committed rABC1fd19cd4f4c0: Add const modifier to HTTPRequest methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Add const modifier to HTTPRequest methods
Nov 30 2019, 00:02
majcosta closed D4590: Add const modifier to HTTPRequest methods.
Nov 30 2019, 00:02
teamcity added a comment to D4591: Add Benchmark to test input de-duplication worst case.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 30 2019, 00:01

Nov 29 2019

teamcity added a comment to D4581: Rationalize lock anotation in validation code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 23:58
deadalnix updated the diff for D4581: Rationalize lock anotation in validation code.

Rebase on top of D4592

Nov 29 2019, 23:58
deadalnix updated the summary of D4581: Rationalize lock anotation in validation code.
Nov 29 2019, 23:58
teamcity added a comment to D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 23:57
deadalnix created D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.
Nov 29 2019, 23:57
teamcity added a comment to D4591: Add Benchmark to test input de-duplication worst case.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 23:51
deadalnix created D4591: Add Benchmark to test input de-duplication worst case.
Nov 29 2019, 23:50
teamcity added a comment to D4590: Add const modifier to HTTPRequest methods.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 23:49
majcosta updated the summary of D4590: Add const modifier to HTTPRequest methods.
Nov 29 2019, 23:44
deadalnix accepted D4590: Add const modifier to HTTPRequest methods.
Nov 29 2019, 23:35
teamcity added a comment to D4590: Add const modifier to HTTPRequest methods.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 23:35
majcosta created D4590: Add const modifier to HTTPRequest methods.
Nov 29 2019, 23:29
deadalnix committed rABCf565beaa0b1b: Add braces in txdb.cpp (authored by deadalnix).
Add braces in txdb.cpp
Nov 29 2019, 23:11
deadalnix closed D4589: Add braces in txdb.cpp.
Nov 29 2019, 23:11
deadalnix committed rABC0dde45fa7ec5: Move pindexFinalized in CChainState (authored by deadalnix).
Move pindexFinalized in CChainState
Nov 29 2019, 23:10
deadalnix closed D4582: Move pindexFinalized in CChainState.
Nov 29 2019, 23:10
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Nov 29 2019, 22:53
teamcity added a comment to D4588: [tests] Add libFuzzer support..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 20:50
teamcity added a comment to D4588: [tests] Add libFuzzer support..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 20:39
Fabien updated the diff for D4588: [tests] Add libFuzzer support..

Add missing static.

Nov 29 2019, 20:38
Fabien accepted D4589: Add braces in txdb.cpp.
Nov 29 2019, 20:26
Fabien requested changes to D4581: Rationalize lock anotation in validation code.

This reveals 3 warnings in txvalidationcache_tests.cpp

Nov 29 2019, 20:24
Fabien accepted D4582: Move pindexFinalized in CChainState.
Nov 29 2019, 20:24
Fabien requested changes to D4582: Move pindexFinalized in CChainState.
Nov 29 2019, 20:23
deadalnix closed D4586: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader.
Nov 29 2019, 20:09
deadalnix committed rABC4c0e89ae44cc: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader (authored by Sjors Provoost <sjors@sprovoost.nl>).
Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader
Nov 29 2019, 20:09
teamcity added a comment to D4589: Add braces in txdb.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 20:09
Fabien accepted D4586: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader.
Nov 29 2019, 20:05
deadalnix committed rABC368c4cbb242f: Remove unnecessary const_cast (authored by Julian Fleischer <scravy@users.noreply.github.com>).
Remove unnecessary const_cast
Nov 29 2019, 20:05
deadalnix closed D4583: Remove unnecessary const_cast.
Nov 29 2019, 20:04
deadalnix committed rABCa6af523bafce: Fix activation_tests (authored by deadalnix).
Fix activation_tests
Nov 29 2019, 20:03
deadalnix closed D4585: Fix activation_tests.
Nov 29 2019, 20:03
teamcity added a comment to D4589: Add braces in txdb.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 19:58
deadalnix created D4589: Add braces in txdb.cpp.
Nov 29 2019, 19:58
Fabien accepted D4585: Fix activation_tests.
Nov 29 2019, 19:41
Fabien accepted D4583: Remove unnecessary const_cast.
Nov 29 2019, 19:41
Mengerian added a revision to T653: Clean up past upgrades: D4577: remove NULLDUMMY.
Nov 29 2019, 18:12
Mengerian added a task to D4577: remove NULLDUMMY: T653: Clean up past upgrades.
Nov 29 2019, 18:12
teamcity added a comment to D4588: [tests] Add libFuzzer support..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 17:38
teamcity added a comment to D4588: [tests] Add libFuzzer support..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 17:28
Fabien created D4588: [tests] Add libFuzzer support..
Nov 29 2019, 17:28
teamcity added a comment to D4587: [CMAKE] Avoid rebuilding sec256k1.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 16:57
teamcity added a comment to D4587: [CMAKE] Avoid rebuilding sec256k1.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 16:47
Fabien created D4587: [CMAKE] Avoid rebuilding sec256k1.
Nov 29 2019, 16:47
teamcity added a comment to D4586: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 16:45
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Nov 29 2019, 16:40
teamcity added a comment to D4586: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 16:35
deadalnix created D4586: Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader.
Nov 29 2019, 16:34
teamcity added a comment to D4585: Fix activation_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 16:33
teamcity added a comment to D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 16:28
teamcity added a comment to D4585: Fix activation_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 16:22
deadalnix created D4585: Fix activation_tests.
Nov 29 2019, 16:22
First
Prev
Next