Page MenuHomePhabricator
Feed All Stories

Mon, Dec 2

deadalnix committed rABC3489ac50107f: Use TxId in setInventoryTxToSend (authored by deadalnix).
Use TxId in setInventoryTxToSend
Mon, Dec 2, 14:22
deadalnix closed D4597: Use TxId in setInventoryTxToSend.
Mon, Dec 2, 14:22
deadalnix committed rABC24049bf5a8eb: refactor: Drop boost::this_thread::interruption_point and boost… (authored by Chun Kuan Lee <ken2812221@gmail.com>).
refactor: Drop boost::this_thread::interruption_point and boost…
Mon, Dec 2, 14:13
deadalnix closed D4608: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread.
Mon, Dec 2, 14:13
deadalnix committed rABC3c003d3d2bb7: Use BlockHash in BlockTransactionsRequest (authored by deadalnix).
Use BlockHash in BlockTransactionsRequest
Mon, Dec 2, 14:10
deadalnix closed D4602: Use BlockHash in BlockTransactionsRequest.
Mon, Dec 2, 14:10
deadalnix committed rABC36791c4a595c: [cmake] link test runners by default (authored by deadalnix).
[cmake] link test runners by default
Mon, Dec 2, 14:03
deadalnix closed D4607: [cmake] link test runners by default.
Mon, Dec 2, 14:03
deadalnix committed rABC535e7c83dd4f: Drop minor GetSerializeSize template (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop minor GetSerializeSize template
Mon, Dec 2, 13:58
deadalnix closed D4606: Drop minor GetSerializeSize template.
Mon, Dec 2, 13:58
teamcity added a comment to D4612: tests: Use MakeUnique to construct objects owned by unique_ptrs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 2, 13:58
deadalnix committed rABC9f49375e4158: Avoid creating a temporary vector for size-prefixed elements (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Avoid creating a temporary vector for size-prefixed elements
Mon, Dec 2, 13:55
deadalnix closed D4605: Avoid creating a temporary vector for size-prefixed elements.
Mon, Dec 2, 13:55
Fabien accepted D4597: Use TxId in setInventoryTxToSend.
Mon, Dec 2, 13:48
deadalnix committed rABCe1ba1a45f750: Drop unused GetType() from CSizeComputer (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop unused GetType() from CSizeComputer
Mon, Dec 2, 13:42
deadalnix closed D4603: Drop unused GetType() from CSizeComputer.
Mon, Dec 2, 13:42
deadalnix requested review of D4597: Use TxId in setInventoryTxToSend.
Mon, Dec 2, 13:38
deadalnix committed rABC444a000d3fde: validation: assert that pindexPrev is non-null when required (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
validation: assert that pindexPrev is non-null when required
Mon, Dec 2, 13:37
deadalnix closed D4596: validation: assert that pindexPrev is non-null when required.
Mon, Dec 2, 13:37
teamcity added a comment to D4612: tests: Use MakeUnique to construct objects owned by unique_ptrs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 2, 13:36
Fabien created D4612: tests: Use MakeUnique to construct objects owned by unique_ptrs.
Mon, Dec 2, 13:36
teamcity added a comment to D4611: Bugfix: Include <memory> for std::unique_ptr.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Dec 2, 13:16
teamcity added a comment to D4611: Bugfix: Include <memory> for std::unique_ptr.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Dec 2, 12:59
Fabien created D4611: Bugfix: Include <memory> for std::unique_ptr.
Mon, Dec 2, 12:59
Fabien retitled D4610: Make TxIndex::FindTx use BlockHash from Make TxIndex::FindTx us BlockHash to Make TxIndex::FindTx use BlockHash.
Mon, Dec 2, 08:54
Fabien accepted D4610: Make TxIndex::FindTx use BlockHash.
Mon, Dec 2, 08:53
Fabien accepted D4609: Update GetTransaction's parameters.
Mon, Dec 2, 08:51
Fabien accepted D4608: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread.
Mon, Dec 2, 08:48
Fabien accepted D4607: [cmake] link test runners by default.

Thanks, this one was on my list :)

Mon, Dec 2, 08:47
Fabien accepted D4606: Drop minor GetSerializeSize template.
Mon, Dec 2, 08:43
Fabien accepted D4605: Avoid creating a temporary vector for size-prefixed elements.
Mon, Dec 2, 08:41
Fabien added a comment to D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.

It should not be necessary as per https://cmake.org/cmake/help/v3.12/command/add_custom_target.html:

If COMMAND specifies an executable target name (created by the add_executable() command) it will automatically be replaced by the location of the executable created at build time. If set, the CROSSCOMPILING_EMULATOR executable target property will also be prepended to the command to allow the executable to run on the host. **Additionally a target-level dependency will be added so that the executable target will be built before this custom target.**
Mon, Dec 2, 08:36
Fabien updated the summary of D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.
Mon, Dec 2, 08:33
Fabien accepted D4598: Update mempool's mapTx to index from TxId..
Mon, Dec 2, 08:32
Fabien accepted D4603: Drop unused GetType() from CSizeComputer.
Mon, Dec 2, 08:22
Fabien accepted D4602: Use BlockHash in BlockTransactionsRequest.
Mon, Dec 2, 08:06
Fabien accepted D4601: tx pool: Use class methods to hide raw map iterator impl details.
Mon, Dec 2, 08:06
Fabien accepted D4600: Update mempool and compact block logic to use TxHash.
Mon, Dec 2, 07:57
Fabien accepted D4599: Update mempool's mapDelta to use TxId.
Mon, Dec 2, 07:53
Fabien requested changes to D4597: Use TxId in setInventoryTxToSend.
Mon, Dec 2, 07:52
Fabien accepted D4596: validation: assert that pindexPrev is non-null when required.
Mon, Dec 2, 07:44
Fabien committed rABCc4345d49c203: [CMAKE] Avoid rebuilding sec256k1 (authored by Fabien).
[CMAKE] Avoid rebuilding sec256k1
Mon, Dec 2, 07:39
Fabien closed D4587: [CMAKE] Avoid rebuilding sec256k1.
Mon, Dec 2, 07:39
Fabien committed rABC3a12c8538e5b: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions (authored by Fabien).
[CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions
Mon, Dec 2, 07:38
Fabien closed D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.
Mon, Dec 2, 07:38
Fabien requested review of D4588: [tests] Add libFuzzer support..
Mon, Dec 2, 07:35

Sun, Dec 1

deadalnix requested changes to D4588: [tests] Add libFuzzer support..
Sun, Dec 1, 22:35
markblundeberg updated the task description for T704: sigChecks implementation.
Sun, Dec 1, 18:40
markblundeberg updated the task description for T704: sigChecks implementation.
Sun, Dec 1, 18:39
markblundeberg created T704: sigChecks implementation.
Sun, Dec 1, 18:33
teamcity added a comment to D4610: Make TxIndex::FindTx use BlockHash.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 16:04
teamcity added a comment to D4609: Update GetTransaction's parameters.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 15:54
teamcity added a comment to D4610: Make TxIndex::FindTx use BlockHash.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 15:46
deadalnix created D4610: Make TxIndex::FindTx use BlockHash.
Sun, Dec 1, 15:46
teamcity added a comment to D4609: Update GetTransaction's parameters.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 15:42
deadalnix created D4609: Update GetTransaction's parameters.
Sun, Dec 1, 15:42
teamcity added a comment to D4608: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 14:35
teamcity added a comment to D4608: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 14:25
deadalnix created D4608: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread.
Sun, Dec 1, 14:25
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 02:47
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 02:41
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 02:37
deadalnix updated the diff for D4607: [cmake] link test runners by default.

Use absolute path

Sun, Dec 1, 02:37
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 02:30
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 02:30
deadalnix updated the diff for D4607: [cmake] link test runners by default.

map the sanitization with cmake doc ( https://cmake.org/cmake/help/v3.10/policy/CMP0037.html ) and reduce verbosity.

Sun, Dec 1, 02:30
teamcity added a comment to D4607: [cmake] link test runners by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 02:19
deadalnix created D4607: [cmake] link test runners by default.
Sun, Dec 1, 02:19
teamcity added a comment to D4606: Drop minor GetSerializeSize template.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 02:02
teamcity added a comment to D4605: Avoid creating a temporary vector for size-prefixed elements.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 01:47
teamcity added a comment to D4606: Drop minor GetSerializeSize template.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 01:44
deadalnix created D4606: Drop minor GetSerializeSize template.
Sun, Dec 1, 01:44
teamcity added a comment to D4605: Avoid creating a temporary vector for size-prefixed elements.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 01:30
deadalnix created D4605: Avoid creating a temporary vector for size-prefixed elements.
Sun, Dec 1, 01:30
teamcity added a comment to D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 01:26
teamcity added a comment to D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 01:15
deadalnix created D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.
Sun, Dec 1, 01:15
teamcity added a comment to D4603: Drop unused GetType() from CSizeComputer.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Dec 1, 00:54
deadalnix updated the summary of D4603: Drop unused GetType() from CSizeComputer.
Sun, Dec 1, 00:38
teamcity added a comment to D4603: Drop unused GetType() from CSizeComputer.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Dec 1, 00:36
deadalnix created D4603: Drop unused GetType() from CSizeComputer.
Sun, Dec 1, 00:36

Sat, Nov 30

teamcity added a comment to D4602: Use BlockHash in BlockTransactionsRequest.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 22:50
teamcity added a comment to D4601: tx pool: Use class methods to hide raw map iterator impl details.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 22:48
teamcity added a comment to D4602: Use BlockHash in BlockTransactionsRequest.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 22:35
deadalnix created D4602: Use BlockHash in BlockTransactionsRequest.
Sat, Nov 30, 22:35
teamcity added a comment to D4601: tx pool: Use class methods to hide raw map iterator impl details.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 22:30
deadalnix created D4601: tx pool: Use class methods to hide raw map iterator impl details.
Sat, Nov 30, 22:30
teamcity added a comment to D4600: Update mempool and compact block logic to use TxHash.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 22:06
teamcity added a comment to D4600: Update mempool and compact block logic to use TxHash.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 21:49
deadalnix created D4600: Update mempool and compact block logic to use TxHash.
Sat, Nov 30, 21:49
teamcity added a comment to D4599: Update mempool's mapDelta to use TxId.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 21:37
teamcity added a comment to D4599: Update mempool's mapDelta to use TxId.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 21:22
deadalnix created D4599: Update mempool's mapDelta to use TxId.
Sat, Nov 30, 21:22
teamcity added a comment to D4598: Update mempool's mapTx to index from TxId..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 21:16
teamcity added a comment to D4598: Update mempool's mapTx to index from TxId..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 21:00
deadalnix created D4598: Update mempool's mapTx to index from TxId..
Sat, Nov 30, 21:00
teamcity added a comment to D4597: Use TxId in setInventoryTxToSend.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 20:46
teamcity added a comment to D4597: Use TxId in setInventoryTxToSend.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sat, Nov 30, 20:32
deadalnix created D4597: Use TxId in setInventoryTxToSend.
Sat, Nov 30, 20:32
teamcity added a comment to D4596: validation: assert that pindexPrev is non-null when required.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sat, Nov 30, 20:24