Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Dec 9 2019

deadalnix accepted D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Dec 9 2019, 00:42
deadalnix added inline comments to D4629: fuzz: Script validation flags.
Dec 9 2019, 00:40
deadalnix accepted D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 9 2019, 00:28

Dec 8 2019

deadalnix added a comment to D4665: partial revert of tx decode sanity check backport.

Adding tests would be good or you might find this reverting back to a behavior you don't like.

Dec 8 2019, 15:42
deadalnix accepted D4665: partial revert of tx decode sanity check backport.
Dec 8 2019, 15:42
markblundeberg added inline comments to D4665: partial revert of tx decode sanity check backport.
Dec 8 2019, 05:21
teamcity added a comment to D4665: partial revert of tx decode sanity check backport.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 8 2019, 05:11
markblundeberg updated the test plan for D4665: partial revert of tx decode sanity check backport.
Dec 8 2019, 05:04
markblundeberg updated the test plan for D4665: partial revert of tx decode sanity check backport.
Dec 8 2019, 05:01
teamcity added a comment to D4665: partial revert of tx decode sanity check backport.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 8 2019, 05:00
markblundeberg created D4665: partial revert of tx decode sanity check backport.
Dec 8 2019, 05:00
deadalnix requested changes to D4659: Replace integer literals in dnshandle() with an enum class.
Dec 8 2019, 01:57

Dec 7 2019

teamcity added a comment to D4664: Merge #13627: Free keystore.h from file scope level type aliases.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 7 2019, 01:56
teamcity added a comment to D4664: Merge #13627: Free keystore.h from file scope level type aliases.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 7 2019, 01:44
nakihito planned changes to D4664: Merge #13627: Free keystore.h from file scope level type aliases.
Dec 7 2019, 01:44
nakihito created D4664: Merge #13627: Free keystore.h from file scope level type aliases.
Dec 7 2019, 01:44
teamcity added a comment to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 7 2019, 00:32
teamcity added a comment to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 7 2019, 00:22
nakihito updated the diff for D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.

2018 -> 2019.

Dec 7 2019, 00:22

Dec 6 2019

nakihito retitled D4659: Replace integer literals in dnshandle() with an enum class from Replace integer literals in dnshandle() with constants to Replace integer literals in dnshandle() with an enum.
Dec 6 2019, 23:54
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum class.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 6 2019, 23:43
nakihito updated the summary of D4659: Replace integer literals in dnshandle() with an enum class.
Dec 6 2019, 23:32
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum class.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 6 2019, 23:32
nakihito updated the diff for D4659: Replace integer literals in dnshandle() with an enum class.

Changed constant ints to an enum.

Dec 6 2019, 23:32
jasonbcox committed rABCb6b37d8933eb: Fix unused variable warning when building with wallet disabled (authored by jasonbcox).
Fix unused variable warning when building with wallet disabled
Dec 6 2019, 23:06
jasonbcox closed D4661: Fix unused variable warning when building with wallet disabled.
Dec 6 2019, 23:06
jasonbcox committed rABCcf8a94851f12: Bump version to 0.20.9 (authored by jasonbcox).
Bump version to 0.20.9
Dec 6 2019, 23:05
jasonbcox closed D4660: Bump version to 0.20.9.
Dec 6 2019, 23:05
jasonbcox added inline comments to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 6 2019, 23:04
teamcity added a comment to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 6 2019, 22:59
nakihito requested review of D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 6 2019, 22:55
nakihito updated the summary of D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 6 2019, 22:49
teamcity added a comment to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 6 2019, 22:47
nakihito planned changes to D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 6 2019, 22:47
nakihito created D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Dec 6 2019, 22:47
Fabien accepted D4660: Bump version to 0.20.9.
Dec 6 2019, 21:07
Fabien accepted D4661: Fix unused variable warning when building with wallet disabled.
Dec 6 2019, 21:05
teamcity added a comment to D4661: Fix unused variable warning when building with wallet disabled.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 6 2019, 20:32
teamcity added a comment to D4661: Fix unused variable warning when building with wallet disabled.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 6 2019, 20:21
jasonbcox created D4661: Fix unused variable warning when building with wallet disabled.
Dec 6 2019, 20:21
markblundeberg added a comment to D4247: Decodehextx scripts sanity check.

This seems to just remove functionality and Core only did this because they have problems telling apart segwit txns from partially constructed non-segwit transactions (see discussion on PR). This isn't a crutch that we need to be copying.

Dec 6 2019, 19:38
teamcity added a comment to D4660: Bump version to 0.20.9.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 6 2019, 19:22
teamcity added a comment to D4660: Bump version to 0.20.9.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 6 2019, 19:08
jasonbcox created D4660: Bump version to 0.20.9.
Dec 6 2019, 19:08
nakihito requested review of D4659: Replace integer literals in dnshandle() with an enum class.
Dec 6 2019, 19:00
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum class.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 6 2019, 18:50
deadalnix changed the visibility for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Dec 6 2019, 18:38
teamcity added a comment to D4659: Replace integer literals in dnshandle() with an enum class.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 6 2019, 18:36
nakihito planned changes to D4659: Replace integer literals in dnshandle() with an enum class.
Dec 6 2019, 18:36
nakihito created D4659: Replace integer literals in dnshandle() with an enum class.
Dec 6 2019, 18:36
Fabien requested changes to D4619: Merge #14451: Allow building GUI without BIP70 support.

This is really large, and hard enough to figure out if something is missing. Can you try to split this ?

Dec 6 2019, 15:37
deadalnix requested changes to D4627: qa: Add test/fuzz/test_runner.py.
Dec 6 2019, 11:54
deadalnix requested changes to D4653: Abstract EraseBlockData out of RewindBlockIndex.
Dec 6 2019, 11:41
deadalnix accepted D4615: test: Build fuzz targets into seperate executables.
Dec 6 2019, 11:15
deadalnix accepted D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.
Dec 6 2019, 11:08
deadalnix requested changes to D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Back on your queue. It looks like this broke the rpc_bind test.

Dec 6 2019, 11:08
deadalnix requested changes to D4642: Cleanup graviton activation.

It would be preferable to remove the tests along side the code that they do test. Doing this as this simply reduce test coverage.

Dec 6 2019, 11:06
Fabien updated the summary of D4642: Cleanup graviton activation.
Dec 6 2019, 06:54

Dec 5 2019

Harbormaster failed remote builds in B8439: Diff 14668 for D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly!
Dec 5 2019, 22:57
teamcity added a comment to D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Dec 5 2019, 22:57
jasonbcox committed rABC91689edf6526: Update seeds (authored by jasonbcox).
Update seeds
Dec 5 2019, 22:53
jasonbcox closed D4652: Update seeds.
Dec 5 2019, 22:52
jasonbcox closed D4649: Update manpages for 0.20.8 release.
Dec 5 2019, 22:52
jasonbcox committed rABC770bceebc841: Update manpages for 0.20.8 release (authored by jasonbcox).
Update manpages for 0.20.8 release
Dec 5 2019, 22:52
jasonbcox committed rABC7ca65067e498: Update chainparams (authored by jasonbcox).
Update chainparams
Dec 5 2019, 22:51
jasonbcox closed D4648: Update chainparams.
Dec 5 2019, 22:51
jasonbcox committed rABC8776750dc21b: Remove errant --testnet argument in chainparams README (authored by jasonbcox).
Remove errant --testnet argument in chainparams README
Dec 5 2019, 22:50
jasonbcox closed D4650: Remove errant --testnet argument in chainparams README.
Dec 5 2019, 22:50
jasonbcox abandoned D4651: Add some more release notes.
Dec 5 2019, 22:49
teamcity added a comment to D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 5 2019, 22:46
ProtocolCash created D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.
Dec 5 2019, 22:45
Fabien accepted D4650: Remove errant --testnet argument in chainparams README.
Dec 5 2019, 22:12
Fabien added inline comments to D4651: Add some more release notes.
Dec 5 2019, 22:10
deadalnix requested changes to D4637: Remove gotos in seeder/dns.cpp.
Dec 5 2019, 21:59
deadalnix added a comment to D4637: Remove gotos in seeder/dns.cpp.

Using goto to not litter otherwise good code with error handling is a fairly common practice. Surely, if this makes this code bad in some way, the specifics can be pointed at rather than blanket statement about goto being harmful.

Dec 5 2019, 21:57
Fabien committed rABC3e0aed9fe2ee: Fix apptest build failure on Xenial (authored by Fabien).
Fix apptest build failure on Xenial
Dec 5 2019, 21:54
Fabien closed D4654: Fix apptest build failure on Xenial.
Dec 5 2019, 21:54
Fabien accepted D4649: Update manpages for 0.20.8 release.
Dec 5 2019, 21:53
Fabien accepted D4648: Update chainparams.
Dec 5 2019, 21:52
teamcity added a comment to D4654: Fix apptest build failure on Xenial.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 5 2019, 21:50
Fabien accepted D4652: Update seeds.
Dec 5 2019, 21:49
ProtocolCash committed rABC883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required (authored by ProtocolCash).
Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required
Dec 5 2019, 21:45
ProtocolCash closed D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.
Dec 5 2019, 21:45
ProtocolCash committed rABC5f22db900a80: Small fix in backporting.md - remove unneeded trailing . for git remote add… (authored by ProtocolCash).
Small fix in backporting.md - remove unneeded trailing . for git remote add…
Dec 5 2019, 21:44
ProtocolCash closed D4633: Small fix in backporting.md - remove unneeded trailing . for git remote add command.
Dec 5 2019, 21:44
jasonbcox accepted D4654: Fix apptest build failure on Xenial.

Thanks for pinning this down.

Dec 5 2019, 21:40
teamcity added a comment to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 5 2019, 21:39
Fabien added a comment to D4654: Fix apptest build failure on Xenial.

Note to reviewers: I tested reversing the ordering on core and they exhibit the same issue.

Dec 5 2019, 21:38
teamcity added a comment to D4654: Fix apptest build failure on Xenial.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 5 2019, 21:37
Fabien created D4654: Fix apptest build failure on Xenial.
Dec 5 2019, 21:37
teamcity added a comment to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 5 2019, 21:23
Fabien committed rABC93fc377fac4e: Fix missing blockhash cast in wallet_tests.cpp (authored by Fabien).
Fix missing blockhash cast in wallet_tests.cpp
Dec 5 2019, 20:56
Fabien closed D4646: Fix missing blockhash cast in wallet_tests.cpp.
Dec 5 2019, 20:56
teamcity added a comment to D4637: Remove gotos in seeder/dns.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 5 2019, 20:38
teamcity added a comment to D4637: Remove gotos in seeder/dns.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 5 2019, 20:28
nakihito planned changes to D4637: Remove gotos in seeder/dns.cpp.
Dec 5 2019, 20:27
nakihito updated the diff for D4637: Remove gotos in seeder/dns.cpp.

Removed unnecessary error variables and streamlined returns.

Dec 5 2019, 20:27
teamcity added a comment to D4620: Merge #15101: gui: Add WalletController.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 5 2019, 20:18
teamcity added a comment to D4620: Merge #15101: gui: Add WalletController.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 5 2019, 20:10
teamcity added a comment to D4620: Merge #15101: gui: Add WalletController.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 5 2019, 20:08
First
Prev
Next