Page MenuHomePhabricator
Feed All Stories

Tue, Jan 14

Fabien updated the diff for D4928: [CI] Increase the coverage for the build-diff and build-master configs.

Rebase.

Tue, Jan 14, 10:20
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC76e36aa9079b: add a flag that restricts sigChecks per-input (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
add a flag that restricts sigChecks per-input
Tue, Jan 14, 10:15
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4617: add a flag that restricts sigChecks per-input.
Tue, Jan 14, 10:15
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 10:02
Fabien requested changes to D4921: [wallet] Support creating a blank wallet.

Clearing my queue, waiting for other comments to be addressed.

Tue, Jan 14, 10:01
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 09:58
Fabien updated the diff for D4927: [CI] Use ninja targets instead of calling binaries.

Still create the build dir.

Tue, Jan 14, 09:58
Harbormaster failed remote builds in B8923: Diff 15438 for D4927: [CI] Use ninja targets instead of calling binaries!
Tue, Jan 14, 09:52
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.
Tue, Jan 14, 09:52
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 09:51
Fabien updated the diff for D4927: [CI] Use ninja targets instead of calling binaries.

Address feedback by rebasing on top of D4938 and D4939.
This avoids overriding the defaults in the build system, but instead
rely on better defaults.

Tue, Jan 14, 09:51
teamcity added a comment to D4939: Move the functional test temporary directory under the build directory.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 09:51
markblundeberg added a revision to T704: sigChecks implementation: D4920: save ScriptExecutionMetrics during CScriptCheck.
Tue, Jan 14, 09:50
markblundeberg added a task to D4920: save ScriptExecutionMetrics during CScriptCheck: T704: sigChecks implementation.
Tue, Jan 14, 09:50
Fabien updated the summary of D4927: [CI] Use ninja targets instead of calling binaries.
Tue, Jan 14, 09:49
teamcity added a comment to D4939: Move the functional test temporary directory under the build directory.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 09:46
Fabien created D4939: Move the functional test temporary directory under the build directory.
Tue, Jan 14, 09:45
teamcity added a comment to D4938: Move the JUnit file to the temporary directory.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 09:22
Fabien updated the test plan for D4938: Move the JUnit file to the temporary directory.
Tue, Jan 14, 09:09
teamcity added a comment to D4938: Move the JUnit file to the temporary directory.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 09:08
Fabien created D4938: Move the JUnit file to the temporary directory.
Tue, Jan 14, 09:08
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC8bbb45003d06: save ScriptExecutionMetrics during CScriptCheck (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
save ScriptExecutionMetrics during CScriptCheck
Tue, Jan 14, 09:03
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4920: save ScriptExecutionMetrics during CScriptCheck.
Tue, Jan 14, 09:03
teamcity added a comment to D4937: tweak auto-unparking message.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 08:58
teamcity added a comment to D4937: tweak auto-unparking message.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 08:53
markblundeberg created D4937: tweak auto-unparking message.
Tue, Jan 14, 08:53
teamcity added a comment to D4834: add sigChecks value to script cache.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 08:40
teamcity added a comment to D4834: add sigChecks value to script cache.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 08:34
markblundeberg updated the diff for D4834: add sigChecks value to script cache.

big overhaul to use ScriptExecutionMetrics

Tue, Jan 14, 08:34
teamcity added a comment to D4935: [validation.cpp] parking-related comment tweaks.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 04:57
teamcity added a comment to D4935: [validation.cpp] parking-related comment tweaks.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 04:47
teamcity added a comment to D4935: [validation.cpp] parking-related comment tweaks.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 04:41
markblundeberg updated the diff for D4935: [validation.cpp] parking-related comment tweaks.

add another comment

Tue, Jan 14, 04:41
teamcity added a comment to D4935: [validation.cpp] parking-related comment tweaks.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 04:40
markblundeberg created D4935: [validation.cpp] parking-related comment tweaks.
Tue, Jan 14, 04:40
teamcity added a comment to D4934: [secp256k1] scratch: add stack frame support.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 01:39
deadalnix requested changes to D4933: Merge #13429: Return the script type from Solver.

The change in src/rpc/rawtransaction.cpp is missing.

Tue, Jan 14, 01:24
nakihito requested review of D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 01:21
deadalnix added a comment to D4934: [secp256k1] scratch: add stack frame support.

https://github.com/bitcoin-core/secp256k1/pull/523/files

Tue, Jan 14, 01:21
teamcity added a comment to D4934: [secp256k1] scratch: add stack frame support.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 01:20
deadalnix created D4934: [secp256k1] scratch: add stack frame support.
Tue, Jan 14, 01:20
deadalnix requested changes to D4927: [CI] Use ninja targets instead of calling binaries.

This patch make things worse because it changes the expectations one migh have that running ninja check-functional does the same thing as running ./functional/test_runner.py which it doesn't anymore, and this is bad UX.

Tue, Jan 14, 01:19
deadalnix committed rABC95fb86547648: parameterize ecmult_const over input size (authored by deadalnix).
parameterize ecmult_const over input size
Tue, Jan 14, 01:14
deadalnix accepted D4928: [CI] Increase the coverage for the build-diff and build-master configs.
Tue, Jan 14, 01:14
deadalnix closed D4900: parameterize ecmult_const over input size.
Tue, Jan 14, 01:14
teamcity added a comment to D4933: Merge #13429: Return the script type from Solver.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Jan 14, 00:36
markblundeberg added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

The new code is related to @markblundeberg and your comments in D4758: InvalidateBlock now requires that cs_main be unlocked.
Also: abc-finalize-block is broken here if I don't make the changes. (Not broken in previous Diffs).
I could move the related code to D4758 (I didn't do it because it had already been approved) or to a new Diff.

Tue, Jan 14, 00:32
teamcity added a comment to D4933: Merge #13429: Return the script type from Solver.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Jan 14, 00:17
nakihito created D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 00:16
nakihito planned changes to D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 00:16
nakihito committed rABC24d55d31a9ff: Merge #12559: Avoid locking cs_main in some wallet RPC (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12559: Avoid locking cs_main in some wallet RPC
Tue, Jan 14, 00:02
nakihito closed D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Tue, Jan 14, 00:02

Mon, Jan 13

nakihito committed rABC9f7d434f32ab: Add some braces to policy/policy.cpp (authored by nakihito).
Add some braces to policy/policy.cpp
Mon, Jan 13, 23:57
nakihito closed D4931: Add some braces to policy/policy.cpp.
Mon, Jan 13, 23:56
markblundeberg accepted D4900: parameterize ecmult_const over input size.

Never mind, I was wrong -- Core does have these changes.

Mon, Jan 13, 23:16
deadalnix accepted D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 23:06
deadalnix accepted D4931: Add some braces to policy/policy.cpp.
Mon, Jan 13, 22:53
nakihito requested review of D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 22:24
teamcity added a comment to D4931: Add some braces to policy/policy.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 13, 22:01
teamcity added a comment to D4931: Add some braces to policy/policy.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 21:56
nakihito created D4931: Add some braces to policy/policy.cpp.
Mon, Jan 13, 21:56
teamcity added a comment to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 13, 21:11
teamcity added a comment to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 21:04
nakihito planned changes to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 21:04
nakihito updated the diff for D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.

Rebased.

Mon, Jan 13, 21:04
nakihito planned changes to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 21:03
Harbormaster failed remote builds in B8908: Diff 15416 for D4930: Merge #12559: Avoid locking cs_main in some wallet RPC!
Mon, Jan 13, 20:52
teamcity added a comment to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 20:52
teamcity added a comment to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 20:52
nakihito created D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 20:51
nakihito requested review of D4418: Add unit tests for parse_name().
Mon, Jan 13, 19:43
Fabien committed rABCdb2962bac16c: [CI] Add a configuration to build and run the benchmarks (authored by Fabien).
[CI] Add a configuration to build and run the benchmarks
Mon, Jan 13, 19:17
Fabien closed D4924: [CI] Add a configuration to build and run the benchmarks.
Mon, Jan 13, 19:17
Fabien committed rABCc1993c7ac85d: [CI] Split build-default into build-diff and build-master (authored by Fabien).
[CI] Split build-default into build-diff and build-master
Mon, Jan 13, 19:16
Fabien closed D4925: [CI] Split build-default into build-diff and build-master.
Mon, Jan 13, 19:16
Fabien committed rABC189c6951892c: [CMAKE] Add a check-upgrade-activated-extended target (authored by Fabien).
[CMAKE] Add a check-upgrade-activated-extended target
Mon, Jan 13, 19:12
Fabien closed D4922: [CMAKE] Add a check-upgrade-activated-extended target.
Mon, Jan 13, 19:12
nakihito committed rABC5262a13f0300: Merge #13988: Add checks for settxfee reasonableness (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13988: Add checks for settxfee reasonableness
Mon, Jan 13, 18:30
nakihito closed D4894: Merge #13988: Add checks for settxfee reasonableness.
Mon, Jan 13, 18:30
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Mon, Jan 13, 18:17
Harbormaster failed remote builds in B8907: Diff 15411 for D4804: Optimization: don't add txn back to mempool after 10 invalidates!
Mon, Jan 13, 18:17
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 18:17
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

braces

Mon, Jan 13, 18:16
fpelliccioni requested review of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:15
fpelliccioni added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

Mon, Jan 13, 18:13
jasonbcox accepted D4924: [CI] Add a configuration to build and run the benchmarks.
Mon, Jan 13, 18:13
teamcity added a comment to D4925: [CI] Split build-default into build-diff and build-master.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 13, 18:12
jasonbcox added a comment to D4925: [CI] Split build-default into build-diff and build-master.

This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.

I think the most important part is that in addition to easier to maintain and follow, it's easier to test locally. Although testing is part of maintenance, I think this is clearly the most important part of this change.

Mon, Jan 13, 18:09
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 13, 18:09
teamcity added a comment to D4925: [CI] Split build-default into build-diff and build-master.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 18:07
jasonbcox accepted D4925: [CI] Split build-default into build-diff and build-master.

This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.

Mon, Jan 13, 18:06
fpelliccioni retitled D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted from Granular invalidateblock and RewindBlockIndex to Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:04
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:02
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 18:01
fpelliccioni created D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:01
jasonbcox updated the test plan for D4807: Add instructions for verifying download integrity against release signer keys.
Mon, Jan 13, 17:58
teamcity added a comment to D4807: Add instructions for verifying download integrity against release signer keys.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Jan 13, 17:58
teamcity added a comment to D4807: Add instructions for verifying download integrity against release signer keys.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Jan 13, 17:52
jasonbcox updated the diff for D4807: Add instructions for verifying download integrity against release signer keys.
  • Use versioned keys.txt file from bitcoinabc.org or github.com depending on availability by version.
  • Fixed a bug where the script would break on multiple signature files.
Mon, Jan 13, 17:52
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.
Mon, Jan 13, 17:16