Rebase.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 14 2020
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Clearing my queue, waiting for other comments to be addressed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Still create the build dir.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
big overhaul to use ScriptExecutionMetrics
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
add another comment
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
The change in src/rpc/rawtransaction.cpp is missing.
Build Bitcoin-ABC / Diffs / Diff Testing started.
This patch make things worse because it changes the expectations one migh have that running ninja check-functional does the same thing as running ./functional/test_runner.py which it doesn't anymore, and this is bad UX.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
In D4803#119052, @fpelliccioni wrote:In D4803#118361, @deadalnix wrote:This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?
The new code is related to @markblundeberg and your comments in D4758: InvalidateBlock now requires that cs_main be unlocked.
Also: abc-finalize-block is broken here if I don't make the changes. (Not broken in previous Diffs).
I could move the related code to D4758 (I didn't do it because it had already been approved) or to a new Diff.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Jan 13 2020
Never mind, I was wrong -- Core does have these changes.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
braces
In D4803#118361, @deadalnix wrote:This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
In D4925#119040, @jasonbcox wrote:This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.
I think the most important part is that in addition to easier to maintain and follow, it's easier to test locally. Although testing is part of maintenance, I think this is clearly the most important part of this change.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
- Use versioned keys.txt file from bitcoinabc.org or github.com depending on availability by version.
- Fixed a bug where the script would break on multiple signature files.