Page MenuHomePhabricator
Feed All Stories

Feb 12 2020

teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 04:15
markblundeberg updated the diff for D5029: deactivate sigops limits in phonon upgrade.

simple rebase

Feb 12 2020, 04:15
teamcity added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 04:08
teamcity added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 03:58
markblundeberg updated the diff for D5253: Bump automatic replay protection to Nov 2020 upgrade.

putting in a name : axion

Feb 12 2020, 03:58
markblundeberg added a comment to D5130: OP_REVERSEBYTES activation logic.

Good!

Feb 12 2020, 03:28
deadalnix accepted D5130: OP_REVERSEBYTES activation logic.
Feb 12 2020, 03:10
markblundeberg added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Best runner so far: Axion

Feb 12 2020, 02:55
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 02:22
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 02:12
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Removed excess includes and changed function name.

Feb 12 2020, 02:11
jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Looking much better. Please review the includes, because I don't want to dig into all of them.

Feb 12 2020, 01:43
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCae6e769b671c: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex
Feb 12 2020, 01:21
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Feb 12 2020, 01:21
nakihito committed rABCddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14310: [wallet] Ensure wallet is unlocked before signing
Feb 12 2020, 01:21
nakihito closed D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Feb 12 2020, 01:21
teamcity added a comment to D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 01:10
jasonbcox accepted D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Feb 12 2020, 01:04
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 01:03
markblundeberg added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

I think I am going to leave off the virtualsize tests to a separate Diff, to keep this focussed on consensus behaviour. (It's not like we're introducing any new virtualsize behaviours, just changing what count is used)

Feb 12 2020, 01:02
markblundeberg retitled D5179: [consensus rule] limit sigchecks in a block after phonon upgrade from [WIP] [consensus rule] limit sigchecks in a block after phonon upgrade to [consensus rule] limit sigchecks in a block after phonon upgrade.
Feb 12 2020, 01:01
teamcity added a comment to D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Feb 12 2020, 01:01
teamcity added a comment to D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 01:01
teamcity updated the summary of D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Feb 12 2020, 01:01
nakihito created D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Feb 12 2020, 01:00
teamcity added a comment to D5270: Make all automated commits run smoke tests prior to pushing.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 00:55
teamcity added a comment to D5269: Add --commit to automated-commits to make local testing easier.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 12 2020, 00:51
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 00:46
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Functional style casting.

Feb 12 2020, 00:46
jasonbcox requested changes to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Feb 12 2020, 00:44
jasonbcox updated the test plan for D5269: Add --commit to automated-commits to make local testing easier.
Feb 12 2020, 00:39
teamcity added a comment to D5270: Make all automated commits run smoke tests prior to pushing.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 00:38
jasonbcox created D5270: Make all automated commits run smoke tests prior to pushing.
Feb 12 2020, 00:38
teamcity added a comment to D5269: Add --commit to automated-commits to make local testing easier.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 12 2020, 00:34
jasonbcox created D5269: Add --commit to automated-commits to make local testing easier.
Feb 12 2020, 00:34

Feb 11 2020

nakihito committed rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
Feb 11 2020, 23:26
nakihito closed D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Feb 11 2020, 23:26
nakihito added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

The code looks correct, but the test plan is inadequate.

Feb 11 2020, 23:13
nakihito updated the test plan for D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Feb 11 2020, 23:11
deadalnix added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

The code looks correct, but the test plan is inadequate.

Feb 11 2020, 23:08
deadalnix accepted D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Feb 11 2020, 23:08
jasonbcox requested review of D5268: Fix a race condition with rpc ports in check-seeds.
Feb 11 2020, 22:35
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 22:32
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 22:31
jasonbcox requested changes to D5244: Enable new ancestor/descendants chains limit at fork.

Needs an update in doc/release-notes.md

Feb 11 2020, 22:30
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 22:29
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 22:29
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 22:27
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 22:27
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 22:27
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 22:26
jasonbcox added inline comments to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 11 2020, 22:25
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 22:22
teamcity added a comment to D5268: Fix a race condition with rpc ports in check-seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 22:13
jasonbcox planned changes to D5268: Fix a race condition with rpc ports in check-seeds.
Feb 11 2020, 22:13
jasonbcox created D5268: Fix a race condition with rpc ports in check-seeds.
Feb 11 2020, 22:13
jasonbcox accepted D5243: Add new post-fork ancestor and descendants limit..
Feb 11 2020, 22:09
teamcity added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 21:49
teamcity added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Feb 11 2020, 21:40
teamcity updated the summary of D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Feb 11 2020, 21:40
teamcity added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 21:40
nakihito created D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Feb 11 2020, 21:40
jasonbcox committed rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds (authored by jasonbcox).
Use a temporary datadir and non-default RPC port when testing seeds
Feb 11 2020, 19:37
jasonbcox closed D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Feb 11 2020, 19:37
jasonbcox committed rABC0e76b141405d: Remove updating chainparams from release process (authored by jasonbcox).
Remove updating chainparams from release process
Feb 11 2020, 19:36
jasonbcox closed D5250: Remove updating chainparams from release process.
Feb 11 2020, 19:36
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 17:01
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 16:51
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Rebased.

Feb 11 2020, 16:51
deadalnix requested changes to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Feb 11 2020, 16:42
deadalnix accepted D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Feb 11 2020, 16:37
teamcity added a comment to D5263: Prevent arc land from failing if there is nothing to lint.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 15:07
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCc28550b1c65c: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.
Feb 11 2020, 15:04
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..
Feb 11 2020, 15:04
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC41fde531cfe5: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi… (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi…
Feb 11 2020, 15:01
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..
Feb 11 2020, 15:00
teamcity added a comment to D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 14:55
teamcity added a comment to D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 14:55
teamcity added a comment to D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 14:46
teamcity added a comment to D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 14:46
teamcity added a comment to D5263: Prevent arc land from failing if there is nothing to lint.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 14:43
Fabien accepted D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..
Feb 11 2020, 14:36
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC305f4597d941: rm cruft: contrib/rpm (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
rm cruft: contrib/rpm
Feb 11 2020, 14:34
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5258: rm cruft: contrib/rpm.
Feb 11 2020, 14:33
Fabien committed rABCb9d391453dfa: Prevent arc land from failing if there is nothing to lint (authored by Fabien).
Prevent arc land from failing if there is nothing to lint
Feb 11 2020, 14:33
Fabien closed D5263: Prevent arc land from failing if there is nothing to lint.
Feb 11 2020, 14:33
markblundeberg accepted D5263: Prevent arc land from failing if there is nothing to lint.
Feb 11 2020, 14:32
markblundeberg updated the diff for D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..

fixed parent

Feb 11 2020, 14:26
Fabien created D5263: Prevent arc land from failing if there is nothing to lint.
Feb 11 2020, 14:24
markblundeberg updated the diff for D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..

minor text fix (will not change result after child)

Feb 11 2020, 14:24
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC487c1b6d5348: Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default
Feb 11 2020, 14:21
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5260: Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default.
Feb 11 2020, 14:21
markblundeberg added inline comments to D5257: RPCHelpMan fixups.
Feb 11 2020, 14:08
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC43da31c7d549: RPCHelpMan fixups (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
RPCHelpMan fixups
Feb 11 2020, 14:03
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5257: RPCHelpMan fixups.
Feb 11 2020, 14:03
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC7a59e0987888: Merge #14530: Use RPCHelpMan to generate RPC doc strings (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14530: Use RPCHelpMan to generate RPC doc strings
Feb 11 2020, 14:01
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.
Feb 11 2020, 14:01
teamcity added a comment to D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 13:54
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC0e497712ab6f: rm cruft: travis-ci doc (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
rm cruft: travis-ci doc
Feb 11 2020, 13:51
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5259: rm cruft: travis-ci doc.
Feb 11 2020, 13:51