Page MenuHomePhabricator
Feed All Stories

Thu, Feb 13

dagurval added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.

Thu, Feb 13, 08:38
Fabien requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Looking at the test cases exhibits a common and repetitive initialization pattern.
You might want to create a test fixture to avoid this boilerplate.

Thu, Feb 13, 08:21
Fabien committed rABC2177ccfbe208: [CI] Run the functional tests when wallet is disable (authored by Fabien).
[CI] Run the functional tests when wallet is disable
Thu, Feb 13, 07:30
Fabien closed D5279: [CI] Run the functional tests when wallet is disable.
Thu, Feb 13, 07:30
dagurval committed rABC20ecb768b0d6: Add new post-fork ancestor and descendants limit. (authored by dagurval).
Add new post-fork ancestor and descendants limit.
Thu, Feb 13, 06:57
dagurval closed D5243: Add new post-fork ancestor and descendants limit..
Thu, Feb 13, 06:57
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 06:07
markblundeberg updated the task description for T704: sigChecks implementation.
Thu, Feb 13, 05:47
markblundeberg updated the task description for T704: sigChecks implementation.
Thu, Feb 13, 05:46
markblundeberg updated the summary of D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Thu, Feb 13, 05:45
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 05:45
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

just rebase

Thu, Feb 13, 05:44
tobias_ruck committed rABC9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Thu, Feb 13, 05:34
tobias_ruck closed D5283: OP_REVERSEBYTES activation logic.
Thu, Feb 13, 05:34
markblundeberg added a comment to D5282: Implement miner funding features.

Where is the spec for this? If there isn't any yet, one can be put under doc/abc/ . It's not clear what is the intended behaviour in simple language -- how does activation work, when does rule take effect, when does rule stop taking effect, etc etc.

Thu, Feb 13, 05:18
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 03:56
markblundeberg added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.

Thu, Feb 13, 03:51
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 03:50
markblundeberg updated the test plan for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Thu, Feb 13, 03:46
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 03:46
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

update test to work with nowallet build

Thu, Feb 13, 03:46
teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 03:43
markblundeberg updated the test plan for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Thu, Feb 13, 03:40
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 03:40
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

update func test to work with nowallet build

Thu, Feb 13, 03:40
markblundeberg updated the test plan for D5029: deactivate sigops limits in phonon upgrade.
Thu, Feb 13, 03:36
markblundeberg accepted D5283: OP_REVERSEBYTES activation logic.
Thu, Feb 13, 03:33
teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 03:33
markblundeberg updated the diff for D5029: deactivate sigops limits in phonon upgrade.

update functional test to work with nowallet build

Thu, Feb 13, 03:33
teamcity added a comment to D5283: OP_REVERSEBYTES activation logic.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 03:26
markblundeberg added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

Thu, Feb 13, 03:17
teamcity added a comment to D5283: OP_REVERSEBYTES activation logic.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 03:05
tobias_ruck created D5283: OP_REVERSEBYTES activation logic.
Thu, Feb 13, 03:05
markblundeberg requested changes to D5282: Implement miner funding features.

fix the build fail

Thu, Feb 13, 02:32
markblundeberg added a comment to D5282: Implement miner funding features.

Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) --

Thu, Feb 13, 02:16
deadalnix changed the visibility for D5282: Implement miner funding features.
Thu, Feb 13, 01:58
teamcity added a comment to D5282: Implement miner funding features.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 01:58
deadalnix created D5282: Implement miner funding features.
Thu, Feb 13, 01:57
teamcity added a comment to D5281: Merge #14720: rpc: Correctly name arguments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Thu, Feb 13, 01:45
deadalnix requested changes to D5244: Enable new ancestor/descendants chains limit at fork.
Thu, Feb 13, 01:42
deadalnix requested changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.
Thu, Feb 13, 01:38
deadalnix accepted D5243: Add new post-fork ancestor and descendants limit..
Thu, Feb 13, 01:36
teamcity added a comment to D5281: Merge #14720: rpc: Correctly name arguments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Thu, Feb 13, 01:36
teamcity updated the summary of D5281: Merge #14720: rpc: Correctly name arguments.
Thu, Feb 13, 01:36
teamcity added a comment to D5281: Merge #14720: rpc: Correctly name arguments.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Thu, Feb 13, 01:36
nakihito created D5281: Merge #14720: rpc: Correctly name arguments.
Thu, Feb 13, 01:36

Wed, Feb 12

teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 23:34
teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 23:24
teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Wed, Feb 12, 23:24
teamcity updated the summary of D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Wed, Feb 12, 23:24
nakihito created D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Wed, Feb 12, 23:24
nakihito accepted D5279: [CI] Run the functional tests when wallet is disable.
Wed, Feb 12, 23:18
deadalnix accepted D5279: [CI] Run the functional tests when wallet is disable.
Wed, Feb 12, 23:04
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
deadalnix committed rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic" (authored by deadalnix).
Revert "OP_REVERSEBYTES activation logic"
Wed, Feb 12, 22:52
deadalnix closed D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
teamcity added a comment to D5279: [CI] Run the functional tests when wallet is disable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 22:52
Fabien accepted D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:49
teamcity added a comment to D5279: [CI] Run the functional tests when wallet is disable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 22:43
Fabien created D5279: [CI] Run the functional tests when wallet is disable.
Wed, Feb 12, 22:43
teamcity added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 22:33
teamcity added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 22:24
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
deadalnix created D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
teamcity added a comment to D5277: Merge #14460: tests: Improve 'CAmount' tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 21:54
teamcity added a comment to D5277: Merge #14460: tests: Improve 'CAmount' tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 21:45
teamcity added a comment to D5277: Merge #14460: tests: Improve 'CAmount' tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Wed, Feb 12, 21:45
teamcity updated the summary of D5277: Merge #14460: tests: Improve 'CAmount' tests.
Wed, Feb 12, 21:45
nakihito created D5277: Merge #14460: tests: Improve 'CAmount' tests.
Wed, Feb 12, 21:45
Fabien added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.

Wed, Feb 12, 20:53
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Wed, Feb 12, 20:40
nakihito committed rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13152: [rpc] Add getnodeaddresses RPC command
Wed, Feb 12, 18:56
nakihito closed D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Wed, Feb 12, 18:56
jasonbcox accepted D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Wed, Feb 12, 17:27
jasonbcox accepted D4436: Add unit tests for CSeederNode::ProcessMessage().
Wed, Feb 12, 17:23
Mengerian accepted D5253: Bump automatic replay protection to Nov 2020 upgrade.

Looks good to me.

Wed, Feb 12, 15:56
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Wed, Feb 12, 15:41
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 15:24
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Wed, Feb 12, 15:17
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Wed, Feb 12, 15:15
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 15:14
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.

Wed, Feb 12, 15:14
deadalnix accepted D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Wed, Feb 12, 15:04
deadalnix accepted D5253: Bump automatic replay protection to Nov 2020 upgrade.
Wed, Feb 12, 15:03
teamcity added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 07:59
teamcity added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 07:48
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.
  • Replace fork with ponon-upgrade in parameter description.
  • Move maxorphantx to common_params
  • Add a comment on why minimumAmount was added
  • Add release notes
Wed, Feb 12, 07:48
dagurval planned changes to D5244: Enable new ancestor/descendants chains limit at fork.
Wed, Feb 12, 07:13
tobias_ruck committed rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Wed, Feb 12, 07:11
tobias_ruck closed D5130: OP_REVERSEBYTES activation logic.
Wed, Feb 12, 07:11
teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Wed, Feb 12, 04:58
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Wed, Feb 12, 04:50
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 04:28
teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Wed, Feb 12, 04:28
teamcity added a comment to D5029: deactivate sigops limits in phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Feb 12, 04:27
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Wed, Feb 12, 04:27
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Feb 12, 04:16
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

simple rebase

Wed, Feb 12, 04:16