In D5244#127423, @Fabien wrote:Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 13 2020
Feb 13 2020
Looking at the test cases exhibits a common and repetitive initialization pattern.
You might want to create a test fixture to avoid this boilerplate.
Fabien committed rABC2177ccfbe208: [CI] Run the functional tests when wallet is disable (authored by Fabien).
[CI] Run the functional tests when wallet is disable
dagurval committed rABC20ecb768b0d6: Add new post-fork ancestor and descendants limit. (authored by dagurval).
Add new post-fork ancestor and descendants limit.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
markblundeberg updated the summary of D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
just rebase
OP_REVERSEBYTES activation logic
Where is the spec for this? If there isn't any yet, one can be put under doc/abc/ . It's not clear what is the intended behaviour in simple language -- how does activation work, when does rule take effect, when does rule stop taking effect, etc etc.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
markblundeberg updated the test plan for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
update test to work with nowallet build
Build Bitcoin-ABC / Diffs / Diff Testing passed.
markblundeberg updated the test plan for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
update func test to work with nowallet build
Build Bitcoin-ABC / Diffs / Diff Testing started.
update functional test to work with nowallet build
Build Bitcoin-ABC / Diffs / Diff Testing passed.
I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI
Build Bitcoin-ABC / Diffs / Diff Testing started.
fix the build fail
Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
Feb 12 2020
Feb 12 2020
teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
teamcity updated the summary of D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
deadalnix committed rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic" (authored by deadalnix).
Revert "OP_REVERSEBYTES activation logic"
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
nakihito committed rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13152: [rpc] Add getnodeaddresses RPC command
Looks good to me.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
teamcity added a comment to D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
- Replace fork with ponon-upgrade in parameter description.
- Move maxorphantx to common_params
- Add a comment on why minimumAmount was added
- Add release notes
OP_REVERSEBYTES activation logic
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
simple rebase