Build Bitcoin-ABC / Diffs / Diff Testing started.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 27 2020
Feb 27 2020
nakihito retitled D5344: Remove GotVersion() from Rename GotVersion() to RequestAddrs() to Remove GotVersion().
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Improve the regex to match any number > 0 of spaces and tabs.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
nakihito committed rABCed4ca8ee11f0: Add unit tests for CSeederNode::ProcessMessage() (authored by nakihito).
Add unit tests for CSeederNode::ProcessMessage()
teamcity added a comment to D5340: [CMAKE] Make the test python scripts depend on targets and not on files.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5340: [CMAKE] Make the test python scripts depend on targets and not on files.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fix copyright years and put the separators on a sigle line.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Discussed with Jason offline, changed enum to better reflect the return value's purpose.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
AddrCapacity -> AddrAdditionRate, NotFull -> Unlimited, Full -> Limited.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added a sanity check after finding out that my local box wouldn't even generate all of the timings.
jasonbcox committed rABC9224e2c142c5: Add update-manpages to automated-commits (authored by jasonbcox).
Add update-manpages to automated-commits
Update seeds
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien committed rABC6f7a7256394f: build: update RapidCheck Makefile (authored by Jon Atack <jon@atack.com>).
build: update RapidCheck Makefile
Fabien committed rABCd4cf781adab0: build: dont compile rapidcheck with -Wall (authored by fanquake <fanquake@gmail.com>).
build: dont compile rapidcheck with -Wall
Fabien committed rABC33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS (authored by fanquake <fanquake@gmail.com>).
depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
Fabien committed rABCf9d5b98ef544: Integration of property based testing into Bitcoin ABC (authored by Chris Stewart <stewart.chris1234@gmail.com>).
Integration of property based testing into Bitcoin ABC
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
[Automated] Update chainparams
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Feb 26 2020
Feb 26 2020
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Adjusted ADDR_SOFT_CAP comments, refined addr message test with advice from Fabien, removed smurf naming of AddrCapacity enum values.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito retitled D5329: Enforce maximum name length for parse_name() and add unit tests from Add maximum name length unit test for parse_name() to Enforce maximum name length for parse_name() and add unit tests.
In D5329#129147, @Mengerian wrote:Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?
Maybe a better name would be "Add maximum name length for parse_name()", or something similar.
Mengerian added a comment to D5329: Enforce maximum name length for parse_name() and add unit tests.
Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.