Page MenuHomePhabricator
Feed All Stories

Jun 5 2020

deadalnix closed D6383: Use a single wallet batch for UpgradeKeyMetadata.
Jun 5 2020, 15:34
deadalnix committed rABC849a00758477: Add facility to generate RPC docs (authored by deadalnix).
Add facility to generate RPC docs
Jun 5 2020, 15:31
deadalnix closed D6382: Add facility to generate RPC docs.
Jun 5 2020, 15:31
majcosta accepted D6383: Use a single wallet batch for UpgradeKeyMetadata.
Jun 5 2020, 15:18
teamcity added a comment to D6383: Use a single wallet batch for UpgradeKeyMetadata.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 5 2020, 14:44
teamcity updated the summary of D6383: Use a single wallet batch for UpgradeKeyMetadata.
Jun 5 2020, 14:44
deadalnix requested review of D6383: Use a single wallet batch for UpgradeKeyMetadata.
Jun 5 2020, 14:44
Fabien accepted D6382: Add facility to generate RPC docs.
Jun 5 2020, 13:55
deadalnix updated the diff for D6382: Add facility to generate RPC docs.

Change erroneous comment

Jun 5 2020, 13:51
Fabien requested changes to D6382: Add facility to generate RPC docs.
Jun 5 2020, 13:48
deadalnix requested review of D6382: Add facility to generate RPC docs.
Jun 5 2020, 10:01
deadalnix accepted D6379: [devtools] Use -daemon instead of backgrounding bitcoind.
Jun 5 2020, 08:24
deadalnix committed rABC71905e7247f9: Improve handling of INVALID in IsMine (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Improve handling of INVALID in IsMine
Jun 5 2020, 08:16
deadalnix closed D6381: Improve handling of INVALID in IsMine.
Jun 5 2020, 08:16
Fabien requested changes to D6380: Add remaining linter dependencies to CI base image.

You'll better install all the missing linters at once

Jun 5 2020, 07:46
teamcity triaged T919: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Unbreak Now! priority.
Jun 5 2020, 03:00
majcosta accepted D6381: Improve handling of INVALID in IsMine.
Jun 5 2020, 01:51
teamcity updated the summary of D6381: Improve handling of INVALID in IsMine.
Jun 5 2020, 01:07
teamcity added a comment to D6381: Improve handling of INVALID in IsMine.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 5 2020, 01:07
deadalnix requested review of D6381: Improve handling of INVALID in IsMine.
Jun 5 2020, 01:07

Jun 4 2020

jasonbcox committed rABCda311f5ed8fe: Fix UniValue .write() changes for C++98 (authored by jasonbcox).
Fix UniValue .write() changes for C++98
Jun 4 2020, 23:32
jasonbcox closed D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 23:32
jasonbcox requested review of D6380: Add remaining linter dependencies to CI base image.
Jun 4 2020, 23:15
jasonbcox committed rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process (authored by jasonbcox).
[devtools] Use a trap to cleanup bitcoind instead of a background process
Jun 4 2020, 23:10
jasonbcox closed D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.
Jun 4 2020, 23:10
deadalnix committed rABC4c00f172dd60: util: Add Join helper to join a list of strings (authored by MarcoFalke <falke.marco@gmail.com>).
util: Add Join helper to join a list of strings
Jun 4 2020, 23:10
deadalnix closed D6377: util: Add Join helper to join a list of strings.
Jun 4 2020, 23:10
deadalnix committed rABCfeb9dc577c7e: util: refactor upper/lowercase functions (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
util: refactor upper/lowercase functions
Jun 4 2020, 23:10
deadalnix closed D6376: util: refactor upper/lowercase functions.
Jun 4 2020, 23:10
jasonbcox requested changes to D6375: [backport#16898] test: Remove connect_nodes_bi.

Figure out what's up with the build-without-wallet failure

Jun 4 2020, 23:08
jasonbcox accepted D6377: util: Add Join helper to join a list of strings.
Jun 4 2020, 23:05
jasonbcox accepted D6376: util: refactor upper/lowercase functions.
Jun 4 2020, 23:02
jasonbcox requested review of D6379: [devtools] Use -daemon instead of backgrounding bitcoind.
Jun 4 2020, 22:53
deadalnix accepted D6370: [backport#13756] wallet: avoid reuse flags.
Jun 4 2020, 22:40
deadalnix accepted D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.
Jun 4 2020, 22:39
deadalnix requested changes to D6375: [backport#16898] test: Remove connect_nodes_bi.

Ok, the main problem here is that this completely unreviewable. You have a set of manual changes that are swamped into a shotgun automated refactoring. You need to decouple the manual changes and the automated ones. It'll also make it more evident why some of the changes to abc tests are necessary, because they seems to be at best fishy from where I'm at.

Jun 4 2020, 22:38
nakihito planned changes to D6357: Dedup net message writing code in the seeder.
Jun 4 2020, 22:37
jasonbcox requested review of D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.
Jun 4 2020, 22:28
teamcity closed T918: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Windows 64-bit is broken. as Resolved.
Jun 4 2020, 22:04
teamcity added a comment to D6377: util: Add Join helper to join a list of strings.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 4 2020, 21:44
teamcity updated the summary of D6377: util: Add Join helper to join a list of strings.
Jun 4 2020, 21:44
deadalnix requested review of D6377: util: Add Join helper to join a list of strings.
Jun 4 2020, 21:44
majcosta planned changes to D6375: [backport#16898] test: Remove connect_nodes_bi.
Jun 4 2020, 21:40
teamcity added a comment to D6376: util: refactor upper/lowercase functions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 4 2020, 21:35
teamcity updated the summary of D6376: util: refactor upper/lowercase functions.
Jun 4 2020, 21:35
deadalnix requested review of D6376: util: refactor upper/lowercase functions.
Jun 4 2020, 21:34
Fabien committed rABC639f4ac34735: [CI] Disable jemalloc for running the tests with wine (authored by Fabien).
[CI] Disable jemalloc for running the tests with wine
Jun 4 2020, 21:34
Fabien closed D6374: [CI] Disable jemalloc for running the tests with wine.
Jun 4 2020, 21:34
jasonbcox accepted D6374: [CI] Disable jemalloc for running the tests with wine.
Jun 4 2020, 21:33
teamcity added a comment to D6375: [backport#16898] test: Remove connect_nodes_bi.
Jun 4 2020, 21:27
teamcity updated the summary of D6375: [backport#16898] test: Remove connect_nodes_bi.
Jun 4 2020, 21:21
teamcity added a comment to D6375: [backport#16898] test: Remove connect_nodes_bi.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 4 2020, 21:21
majcosta requested review of D6375: [backport#16898] test: Remove connect_nodes_bi.
Jun 4 2020, 21:20
Fabien committed rABCfd8f51fe7767: [CI] Let build_cmake.sh take a list of targets and use it (authored by Fabien).
[CI] Let build_cmake.sh take a list of targets and use it
Jun 4 2020, 21:17
Fabien closed D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 21:17
jasonbcox accepted D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 21:15
teamcity added a comment to D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 21:13
Fabien requested review of D6374: [CI] Disable jemalloc for running the tests with wine.
Jun 4 2020, 20:55
Fabien updated the diff for D6373: [CI] Let build_cmake.sh take a list of targets and use it.

Use ninja -t targets all for older ninja versions.

Jun 4 2020, 20:51
majcosta updated the diff for D6370: [backport#13756] wallet: avoid reuse flags.

good job Clang. this was a test. and you passed.

Jun 4 2020, 20:24
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

size_t

Jun 4 2020, 20:13
jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 20:12
majcosta committed rABCfe7e6dcdc4c8: [backport#13756] wallet: make IsWalletFlagSet() const (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet: make IsWalletFlagSet() const
Jun 4 2020, 19:49
majcosta closed D6369: [backport#13756] wallet: make IsWalletFlagSet() const.
Jun 4 2020, 19:49
majcosta committed rABCd8fefbbec6a1: [backport#13756] wallet: rename g_known_wallet_flags constant to… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet: rename g_known_wallet_flags constant to…
Jun 4 2020, 19:48
majcosta closed D6368: [backport#13756] wallet: rename g_known_wallet_flags constant to KNOWN_WALLET_FLAGS.
Jun 4 2020, 19:48
majcosta committed rABC7d44fb717d3c: [refactor] add const CCoinControl& param to SendMoney (authored by majcosta).
[refactor] add const CCoinControl& param to SendMoney
Jun 4 2020, 19:46
majcosta closed D6367: [refactor] add const CCoinControl& param to SendMoney.
Jun 4 2020, 19:45
majcosta committed rABC8a2ed5f2d0de: [backport#15777] [docs] Add doxygen comment for CKeyPool (authored by John Newbery <john@johnnewbery.com>).
[backport#15777] [docs] Add doxygen comment for CKeyPool
Jun 4 2020, 19:45
majcosta closed D6350: [backport#15777] [docs] Add doxygen comment for CKeyPool.
Jun 4 2020, 19:44
Fabien added inline comments to D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 19:10
teamcity closed T916: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master Benchmarking is broken. as Resolved.
Jun 4 2020, 18:39
teamcity assigned T918: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Windows 64-bit is broken. to Fabien.
Jun 4 2020, 18:31
teamcity triaged T918: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
Jun 4 2020, 18:31
jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 18:30
jasonbcox added inline comments to D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 18:21
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Use swap to emulate std::move for C++98

Jun 4 2020, 18:13
jasonbcox accepted D6350: [backport#15777] [docs] Add doxygen comment for CKeyPool.
Jun 4 2020, 18:04
deadalnix accepted D6368: [backport#13756] wallet: rename g_known_wallet_flags constant to KNOWN_WALLET_FLAGS.
Jun 4 2020, 17:58
deadalnix accepted D6369: [backport#13756] wallet: make IsWalletFlagSet() const.
Jun 4 2020, 17:57
deadalnix requested changes to D6370: [backport#13756] wallet: avoid reuse flags.

Looks like clang is not happy.

Jun 4 2020, 17:57
deadalnix accepted D6367: [refactor] add const CCoinControl& param to SendMoney.
Jun 4 2020, 17:56
teamcity closed T915: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Secp256k1 is broken. as Resolved.
Jun 4 2020, 17:56
deadalnix accepted D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 17:53
deadalnix committed rABCe54d9beb6347: Import watch only pubkeys to the keypool if private keys are disabled (authored by Andrew Chow <achow101-github@achow101.com>).
Import watch only pubkeys to the keypool if private keys are disabled
Jun 4 2020, 17:47
deadalnix closed D6366: Import watch only pubkeys to the keypool if private keys are disabled.
Jun 4 2020, 17:47
Fabien added inline comments to D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 17:44
Fabien updated the diff for D6373: [CI] Let build_cmake.sh take a list of targets and use it.

Remove debug comment

Jun 4 2020, 17:43
deadalnix committed rABC85617361eb2f: blockfilter: Update BIP 158 test vectors. (authored by jimpo).
blockfilter: Update BIP 158 test vectors.
Jun 4 2020, 17:42
deadalnix closed D6351: blockfilter: Update BIP 158 test vectors..
Jun 4 2020, 17:41
deadalnix committed rABCf79742f8f978: rpc: Add getblockfilter RPC method. (authored by jimpo).
rpc: Add getblockfilter RPC method.
Jun 4 2020, 17:37
deadalnix closed D6349: rpc: Add getblockfilter RPC method..
Jun 4 2020, 17:37
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Introduce preprocessor directive to allow compilation with std::move. This change differs from
the upstream PR for now, as a strategy for C++11 in UniValue will take more time.

Jun 4 2020, 17:35
deadalnix committed rABC5e92cdede2ce: Update multiset hash benchmark to use get_iters (authored by deadalnix).
Update multiset hash benchmark to use get_iters
Jun 4 2020, 17:33
deadalnix closed D6372: Update multiset hash benchmark to use get_iters.
Jun 4 2020, 17:32
deadalnix committed rABCd5f585b407c4: init: Add CLI option to enable block filter index. (authored by jimpo).
init: Add CLI option to enable block filter index.
Jun 4 2020, 17:32
deadalnix closed D6346: init: Add CLI option to enable block filter index..
Jun 4 2020, 17:32
teamcity closed T917: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jun 4 2020, 17:31
jasonbcox committed rABC91184c7616fc: Merge #13047: [trivial] Tidy blocktools.py (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13047: [trivial] Tidy blocktools.py
Jun 4 2020, 17:14
jasonbcox closed D6354: Merge #13047: [trivial] Tidy blocktools.py.
Jun 4 2020, 17:14