Page MenuHomePhabricator
Feed All Stories

Mon, Jun 29

teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Mon, Jun 29, 11:35
teamcity updated the summary of D6764: refactor: Make scheduler methods type safe.
Mon, Jun 29, 11:35
Fabien requested review of D6764: refactor: Make scheduler methods type safe.
Mon, Jun 29, 11:34
deadalnix committed rABC7efd78f59e4e: [seeder] Use testutil library in seeder tests (authored by deadalnix).
[seeder] Use testutil library in seeder tests
Mon, Jun 29, 11:21
deadalnix closed D6760: [seeder] Use testutil library in seeder tests.
Mon, Jun 29, 11:20
Fabien accepted D6760: [seeder] Use testutil library in seeder tests.
Mon, Jun 29, 11:20
deadalnix updated the diff for D6760: [seeder] Use testutil library in seeder tests.

Also rename variosu instances of test_bitcoin-seeder

Mon, Jun 29, 11:18
deadalnix accepted D6763: [CI] Run the check target instead of a list of subtargets.
Mon, Jun 29, 11:11
deadalnix updated the diff for D6760: [seeder] Use testutil library in seeder tests.

Update test suite name in various places

Mon, Jun 29, 11:08
deadalnix committed rABCa6b7add55026: Move avalanche in its own folder (authored by deadalnix).
Move avalanche in its own folder
Mon, Jun 29, 11:04
deadalnix closed D6761: Move avalanche in its own folder.
Mon, Jun 29, 11:04
deadalnix committed rABC673825f098de: Move minimum boost version to 1.59 (authored by deadalnix).
Move minimum boost version to 1.59
Mon, Jun 29, 10:56
deadalnix closed D6762: Move minimum boost version to 1.59.
Mon, Jun 29, 10:56
Unknown Object (User) added a comment to Image Macro "sashagreykiss".
Mon, Jun 29, 08:43
Fabien added a comment to D6760: [seeder] Use testutil library in seeder tests.

If you rebase on top of D6763 you only have a single occurrence of the seeder target remaining in contrib/teamcity/builds/build-osx.sh

Mon, Jun 29, 07:31
Fabien requested review of D6763: [CI] Run the check target instead of a list of subtargets.
Mon, Jun 29, 07:28
Unknown Object (User) added a comment to T77: Consider removing prevector and switching back to good 'ol vector (with possible .reserve calls).
Mon, Jun 29, 07:18 ยท Bootcamp, Restricted Project
Fabien accepted D6762: Move minimum boost version to 1.59.
Mon, Jun 29, 06:53
Fabien accepted D6761: Move avalanche in its own folder.
Mon, Jun 29, 06:48
Fabien requested changes to D6760: [seeder] Use testutil library in seeder tests.

Please keep the targets renaming for another diff as there are some places where this needs to be updated as well.

Mon, Jun 29, 06:39
Fabien accepted D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.
Mon, Jun 29, 06:30
deadalnix requested changes to D6710: [backport#15492] [rpc] remove deprecated generate method.
Mon, Jun 29, 00:28
deadalnix requested review of D6762: Move minimum boost version to 1.59.
Mon, Jun 29, 00:20

Sun, Jun 28

deadalnix committed rABCc4788eec7895: build: Create test utility library from src/test/util/ (authored by Harris <brakmic@gmail.com>).
build: Create test utility library from src/test/util/
Sun, Jun 28, 22:48
deadalnix closed D6759: build: Create test utility library from src/test/util/.
Sun, Jun 28, 22:48
majcosta accepted D6759: build: Create test utility library from src/test/util/.
Sun, Jun 28, 22:11
majcosta retitled D6714: [backport#15492 2/2] [cleanup] Remove unused CReserveKey from [backport#15492 2/2] [cleanup] Remove unused CReserveKey [v0.22 ONLY] to [backport#15492 2/2] [cleanup] Remove unused CReserveKey.
Sun, Jun 28, 21:50
majcosta retitled D6712: [backport#15492 1/2] [rpc] simplify generate RPC from [backport#15492 1/2] [rpc] simplify generate RPC [v0.22 ONLY] to [backport#15492 1/2] [rpc] simplify generate RPC.
Sun, Jun 28, 21:50
majcosta requested review of D6710: [backport#15492] [rpc] remove deprecated generate method.
Sun, Jun 28, 21:50
majcosta retitled D6710: [backport#15492] [rpc] remove deprecated generate method from [backport#15492] [rpc] remove deprecated generate method [v0.22 ONLY] to [backport#15492] [rpc] remove deprecated generate method.
Sun, Jun 28, 21:47
deadalnix updated the test plan for D6759: build: Create test utility library from src/test/util/.
Sun, Jun 28, 21:37
deadalnix requested review of D6759: build: Create test utility library from src/test/util/.

Clearly, the autotool build isn't missing.

Sun, Jun 28, 21:34
majcosta requested changes to D6759: build: Create test utility library from src/test/util/.

autotools build missing, also test plan doesn't test bench or fuzzer

Sun, Jun 28, 20:40
deadalnix updated the diff for D6761: Move avalanche in its own folder.

Fix stuff

Sun, Jun 28, 19:55
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 19:54
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 19:50
deadalnix updated the diff for D6760: [seeder] Use testutil library in seeder tests.

Add fixture for the test suite name

Sun, Jun 28, 19:48
deadalnix updated the summary of D6761: Move avalanche in its own folder.
Sun, Jun 28, 19:39
deadalnix planned changes to D6761: Move avalanche in its own folder.

This is a WIP

Sun, Jun 28, 19:38
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 19:37
deadalnix requested review of D6761: Move avalanche in its own folder.
Sun, Jun 28, 19:37
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 19:34
deadalnix updated the diff for D6760: [seeder] Use testutil library in seeder tests.

Remove seeder tests from the autotool build.

Sun, Jun 28, 19:32
deadalnix updated the diff for D6759: build: Create test utility library from src/test/util/.

Also do fuzzer

Sun, Jun 28, 18:47
deadalnix updated the diff for D6759: build: Create test utility library from src/test/util/.

Also do bitcoin-qt

Sun, Jun 28, 18:41
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 18:30
teamcity added a comment to D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 18:29
deadalnix requested review of D6760: [seeder] Use testutil library in seeder tests.
Sun, Jun 28, 18:19
teamcity added a comment to D6759: build: Create test utility library from src/test/util/.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Sun, Jun 28, 17:39
teamcity updated the summary of D6759: build: Create test utility library from src/test/util/.
Sun, Jun 28, 17:39
deadalnix requested review of D6759: build: Create test utility library from src/test/util/.
Sun, Jun 28, 17:38
deadalnix requested changes to D6692: [land-bot] Preserve committer name and email.
Sun, Jun 28, 15:11
teamcity closed T985: Build Bitcoin-ABC / Resource Intensive Builds / Initial Block Download w/o Checkpoints is broken. as Resolved.
Sun, Jun 28, 07:18

Sat, Jun 27

deadalnix committed rABCedbca26ce4c2: Remove dead checkpoint test (authored by deadalnix).
Remove dead checkpoint test
Sat, Jun 27, 16:18
deadalnix closed D6758: Remove dead checkpoint test.
Sat, Jun 27, 16:18
Fabien accepted D6758: Remove dead checkpoint test.
Sat, Jun 27, 16:14
teamcity closed T984: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Secp256k1 is broken. as Resolved.
Sat, Jun 27, 15:34
deadalnix requested review of D6758: Remove dead checkpoint test.
Sat, Jun 27, 15:26
jasonbcox committed rABC768822a9ef8b: Bump version to 0.21.11 (authored by jasonbcox).
Bump version to 0.21.11
Sat, Jun 27, 15:19
jasonbcox closed D6752: Bump version to 0.21.11.
Sat, Jun 27, 15:19
jasonbcox committed rABCc87b967f347e: [CI] Increase stream buffer limit for build subprocess (authored by jasonbcox).
[CI] Increase stream buffer limit for build subprocess
Sat, Jun 27, 15:19
jasonbcox closed D6753: [CI] Increase stream buffer limit for build subprocess.
Sat, Jun 27, 15:18
Fabien committed rABC99069046cb0c: [CI] Fix wrong configuration when there is no template (authored by Fabien).
[CI] Fix wrong configuration when there is no template
Sat, Jun 27, 12:42
Fabien closed D6757: [CI] Fix wrong configuration when there is no template.
Sat, Jun 27, 12:42
deadalnix accepted D6757: [CI] Fix wrong configuration when there is no template.
Sat, Jun 27, 12:37
deadalnix requested changes to D6751: [CMAKE] Run the leveldb tests serially.

The difference is very relevent because this adds to the serial path for no good reasons.

Sat, Jun 27, 12:37
deadalnix committed rABC0662e0785d44: Add missing fi in secp256k1's travis script (authored by deadalnix).
Add missing fi in secp256k1's travis script
Sat, Jun 27, 12:29
deadalnix closed D6754: Add missing fi in secp256k1's travis script.
Sat, Jun 27, 12:29
Fabien requested review of D6757: [CI] Fix wrong configuration when there is no template.
Sat, Jun 27, 07:20
Fabien accepted D6744: [linter] add exceptions to include guards and file name linters.

Only nits

Sat, Jun 27, 06:53
Fabien accepted D6753: [CI] Increase stream buffer limit for build subprocess.

More context: the bash traces are echoing a list of the valid targets, as it checks for validity when a list is passed to build_with_cmake. This list has no line break and causes the overflow.

Sat, Jun 27, 06:48
Fabien accepted D6752: Bump version to 0.21.11.
Sat, Jun 27, 06:43
teamcity triaged T985: Build Bitcoin-ABC / Resource Intensive Builds / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Sat, Jun 27, 04:05
majcosta accepted D6754: Add missing fi in secp256k1's travis script.
Sat, Jun 27, 01:04
deadalnix requested review of D6754: Add missing fi in secp256k1's travis script.
Sat, Jun 27, 00:21
jasonbcox requested review of D6753: [CI] Increase stream buffer limit for build subprocess.
Sat, Jun 27, 00:09
jasonbcox updated the test plan for D6753: [CI] Increase stream buffer limit for build subprocess.
Sat, Jun 27, 00:09

Fri, Jun 26

jasonbcox planned changes to D6753: [CI] Increase stream buffer limit for build subprocess.
Fri, Jun 26, 23:55
jasonbcox requested review of D6753: [CI] Increase stream buffer limit for build subprocess.
Fri, Jun 26, 23:55
jasonbcox requested review of D6752: Bump version to 0.21.11.
Fri, Jun 26, 23:51
teamcity closed T982: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master Coverage is broken. as Resolved.
Fri, Jun 26, 20:55
teamcity triaged T984: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Secp256k1 is broken. as Unbreak Now! priority.
Fri, Jun 26, 20:29
teamcity triaged T983: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Fri, Jun 26, 20:21
Fabien committed rABC2786c2432edf: [CI] Refactor the build by making it a class (authored by Fabien).
[CI] Refactor the build by making it a class
Fri, Jun 26, 20:01
Fabien closed D6750: [CI] Refactor the build by making it a class.
Fri, Jun 26, 20:01
Fabien committed rABC8b79d85a6f40: [CI] Make the build configuration a class (authored by Fabien).
[CI] Make the build configuration a class
Fri, Jun 26, 19:59
Fabien closed D6749: [CI] Make the build configuration a class.
Fri, Jun 26, 19:59
Fabien committed rABC0d2341bee658: [CI] Filter what is printed to the console and log it to files (authored by Fabien).
[CI] Filter what is printed to the console and log it to files
Fri, Jun 26, 19:58
Fabien closed D6748: [CI] Filter what is printed to the console and log it to files.
Fri, Jun 26, 19:58
Fabien committed rABCe23422471d46: [CI] Manage the build artifacts from the configuration (authored by Fabien).
[CI] Manage the build artifacts from the configuration
Fri, Jun 26, 19:58
Fabien closed D6735: [CI] Manage the build artifacts from the configuration.
Fri, Jun 26, 19:57
Fabien requested review of D6751: [CMAKE] Run the leveldb tests serially.

Setting the job pool for custom targets is only possible with cmake >= 3.15 and we enforce cmake >= 3.13 (debian 10 default): https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3308.
Note that due to the wrapper, USES_TERMINAL will not dump the test to the console unless there is a failure. It's still not equivalent to a dedicated pool but close enough.

Fri, Jun 26, 19:20
deadalnix added a comment to D6751: [CMAKE] Run the leveldb tests serially.

Also: https://reviews.llvm.org/D6304

Fri, Jun 26, 19:16
deadalnix requested changes to D6751: [CMAKE] Run the leveldb tests serially.

You can create a specific job pool for this and set the job count to 1 rather than simply use terminal.

Fri, Jun 26, 19:14
Fabien requested review of D6751: [CMAKE] Run the leveldb tests serially.
Fri, Jun 26, 19:10
deadalnix accepted D6750: [CI] Refactor the build by making it a class.
Fri, Jun 26, 18:48
deadalnix accepted D6749: [CI] Make the build configuration a class.
Fri, Jun 26, 18:47
majcosta updated the diff for D6649: [backport#16542 4/4] Additional tests for other failure cases.

rebase

Fri, Jun 26, 18:43
majcosta updated the diff for D6648: [backport#16542 3/4] Check error messages in descriptor tests.

rebase

Fri, Jun 26, 18:35
teamcity closed T981: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Fri, Jun 26, 18:00