Page MenuHomePhabricator
Feed All Stories

Jul 3 2020

teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:08
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Jul 3 2020, 21:06
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.
  • Actually write to the log BEFORE publishing the artifacts...
  • Override the build status message in case of a failure
Jul 3 2020, 21:06
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:55
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:54
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:53
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:46
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Jul 3 2020, 20:45
Fabien planned changes to D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 3 2020, 20:41
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

flash => flush

Jul 3 2020, 20:41
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Sync to make sure the build logs are complete before aborting

Jul 3 2020, 20:40
Fabien planned changes to D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 3 2020, 20:37
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:35
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:27
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:27
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 20:26
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase on top of D6817 to see failure messages

Jul 3 2020, 20:26
Fabien requested review of D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 3 2020, 20:11
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 19:25
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jul 3 2020, 19:24
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jul 3 2020, 18:49
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 18:47
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Make it fail

Jul 3 2020, 18:46
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

@bot build-tsan

Jul 3 2020, 18:29
Fabien planned changes to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Talked to @jasonbcox and the server will be upgraded to more memory

Jul 3 2020, 17:55
deadalnix committed rABC4aa90b187df7: [avalanche] Bail when selecting a peer fails too many times (authored by deadalnix).
[avalanche] Bail when selecting a peer fails too many times
Jul 3 2020, 10:56
deadalnix closed D6810: [avalanche] Bail when selecting a peer fails too many times.
Jul 3 2020, 10:55
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

The stress test is still running full capacity on all other tests, and when running with TSAN we are especially looking for deadlocks rather than performance issues.
The point still stands, this patch was a solution I can leverage by myself to work around the issue now but I will look at if/how we can increase the machines capacity.

Jul 3 2020, 07:43
Fabien updated the diff for D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Pass by reference

Jul 3 2020, 07:35
Fabien accepted D6810: [avalanche] Bail when selecting a peer fails too many times.
Jul 3 2020, 07:22
Fabien requested changes to D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 3 2020, 07:19
rudragavara edited a custom field on rudragavara.
Jul 3 2020, 06:56
deadalnix committed rABC9d4f237eedca: [avalanche] Implement compaction for the PeerManager (authored by deadalnix).
[avalanche] Implement compaction for the PeerManager
Jul 3 2020, 00:19
deadalnix closed D6809: [avalanche] Implement compaction for the PeerManager.
Jul 3 2020, 00:19
deadalnix requested review of D6810: [avalanche] Bail when selecting a peer fails too many times.
Jul 3 2020, 00:18

Jul 2 2020

jasonbcox abandoned D6692: [land-bot] Preserve committer name and email.

Abandoned in favor of D6799

Jul 2 2020, 22:40
jasonbcox accepted D6809: [avalanche] Implement compaction for the PeerManager.
Jul 2 2020, 22:39
Mengerian committed rABCWEB2f627f616a41: [website] Add ericreid91 as sponsor (authored by George Donnelly <me@georgedonnelly.com>).
[website] Add ericreid91 as sponsor
Jul 2 2020, 16:11
Mengerian closed D6807: [website] Add ericreid91 as sponsor.
Jul 2 2020, 16:11
Mengerian committed rABCWEB41ca95879607: [website] Add upgrade instructions (authored by Mengerian).
[website] Add upgrade instructions
Jul 2 2020, 16:10
Mengerian closed D6808: [website] Add upgrade instructions.
Jul 2 2020, 16:10
jasonbcox closed D6805: Cleanup leftover phononactivationtime option.
Jul 2 2020, 15:43
jasonbcox committed rABCc931b3d676ed: Cleanup leftover phononactivationtime option (authored by jasonbcox).
Cleanup leftover phononactivationtime option
Jul 2 2020, 15:43
majcosta committed rABCd3670a9f5b31: [backport#16415] Get rid of PendingWalletTx class. (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#16415] Get rid of PendingWalletTx class.
Jul 2 2020, 14:22
majcosta closed D6804: [backport#16415] Get rid of PendingWalletTx class..
Jul 2 2020, 14:22
majcosta committed rABCe942ee183dcb: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet… (authored by Gregory Sanders <gsanders87@gmail.com>).
[backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet…
Jul 2 2020, 14:22
majcosta closed D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.
Jul 2 2020, 14:21
majcosta committed rABCc5263dffd160: [backport#16208 1/2] CreateTransaction calls KeepDestination on… (authored by Gregory Sanders <gsanders87@gmail.com>).
[backport#16208 1/2] CreateTransaction calls KeepDestination on…
Jul 2 2020, 14:21
majcosta closed D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.
Jul 2 2020, 14:21
deadalnix requested review of D6809: [avalanche] Implement compaction for the PeerManager.
Jul 2 2020, 13:44
deadalnix requested changes to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Now this patch looks much better, but I'd like to loop back on the motivation. This is a stress test, and the purpose of a stress test is to stress the system.

Jul 2 2020, 12:52
deadalnix accepted D6807: [website] Add ericreid91 as sponsor.
Jul 2 2020, 12:35
navyasri updated navyasri.
Jul 2 2020, 12:09
nevastech edited a custom field on nevastech.
Jul 2 2020, 11:09
Fabien updated the diff for D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

Move the test argument decalaration where it belongs

Jul 2 2020, 10:01
rudragavara updated rudragavara.
Jul 2 2020, 09:57
Fabien accepted D6808: [website] Add upgrade instructions.
Jul 2 2020, 08:54
Fabien accepted D6805: Cleanup leftover phononactivationtime option.
Jul 2 2020, 08:50
Fabien accepted D6804: [backport#16415] Get rid of PendingWalletTx class..
Jul 2 2020, 08:49
Fabien accepted D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.
Jul 2 2020, 08:45
Fabien accepted D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.
Jul 2 2020, 08:42
Mengerian added a comment to D6808: [website] Add upgrade instructions.

For reference, same article is posted at

Jul 2 2020, 04:47
Mengerian requested review of D6808: [website] Add upgrade instructions.
Jul 2 2020, 04:40
abc-bot committed rABC37ecea7c0f7e: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jul 2 2020, 03:19
Mengerian requested review of D6807: [website] Add ericreid91 as sponsor.
Jul 2 2020, 03:04
teamcity triaged T992: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jul 2 2020, 02:29
abc-bot committed rABC1a04a05251ed: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jul 2 2020, 02:13
abc-bot committed rABCc144a346dbcc: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jul 2 2020, 02:09

Jul 1 2020

jasonbcox requested review of D6805: Cleanup leftover phononactivationtime option.
Jul 1 2020, 23:34
teamcity added a comment to D6804: [backport#16415] Get rid of PendingWalletTx class..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 1 2020, 21:24
teamcity updated the summary of D6804: [backport#16415] Get rid of PendingWalletTx class..
Jul 1 2020, 21:24
majcosta requested review of D6804: [backport#16415] Get rid of PendingWalletTx class..
Jul 1 2020, 21:24
jasonbcox abandoned D6783: Fix out-of-bounds index in Avalanche PeerManager.
Jul 1 2020, 21:21
teamcity updated the summary of D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.
Jul 1 2020, 20:47
teamcity added a comment to D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 1 2020, 20:47
majcosta requested review of D6802: [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction.
Jul 1 2020, 20:47
teamcity updated the summary of D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.
Jul 1 2020, 20:39
teamcity added a comment to D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 1 2020, 20:39
majcosta requested review of D6800: [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success.
Jul 1 2020, 20:38
teamcity closed T991: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jul 1 2020, 19:58
majcosta committed rABCa9f8187d8939: [backport#17009] tests: Add EvalScript(...) fuzzing harness (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17009] tests: Add EvalScript(...) fuzzing harness
Jul 1 2020, 19:43
majcosta closed D6745: [backport#17009] tests: Add EvalScript(...) fuzzing harness.
Jul 1 2020, 19:43
majcosta updated the diff for D6745: [backport#17009] tests: Add EvalScript(...) fuzzing harness.

rebase

Jul 1 2020, 19:32
teamcity triaged T991: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jul 1 2020, 18:38
majcosta committed rABC4d8a91846647: [linter] add exceptions to include guards and file name linters (authored by majcosta).
[linter] add exceptions to include guards and file name linters
Jul 1 2020, 18:34
majcosta closed D6744: [linter] add exceptions to include guards and file name linters.
Jul 1 2020, 18:34
majcosta updated the diff for D6744: [linter] add exceptions to include guards and file name linters.

addressed comments

Jul 1 2020, 18:32
teamcity closed T990: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jul 1 2020, 18:26
majcosta committed rABC9e0128d08619: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...)… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17076] tests: Add fuzzing harness for CheckTransaction(...)…
Jul 1 2020, 18:21
majcosta closed D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.
Jul 1 2020, 18:21
jasonbcox requested review of D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 1 2020, 18:10
jasonbcox committed rABCae150fdf9d0b: Cleanup unused --with-phononactivation from test_framework (authored by jasonbcox).
Cleanup unused --with-phononactivation from test_framework
Jul 1 2020, 18:09
jasonbcox closed D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 18:09
majcosta updated the diff for D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.

fixed linker error after rebase

Jul 1 2020, 18:01
teamcity triaged T990: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jul 1 2020, 17:47
jasonbcox committed rABC9bbe4cd78d8c: Cleanup phonon activation in functional tests (authored by jasonbcox).
Cleanup phonon activation in functional tests
Jul 1 2020, 17:36
jasonbcox closed D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 17:36
teamcity closed T989: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jul 1 2020, 16:40
majcosta committed rABCac5ff19dd46a: [backport#16237 3/3] Add GetNewChangeDestination for getting new change… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16237 3/3] Add GetNewChangeDestination for getting new change…
Jul 1 2020, 16:18
majcosta closed D6721: [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations.
Jul 1 2020, 16:18