Page MenuHomePhabricator
Feed All Stories

Jul 29 2020

majcosta requested review of D7081: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default.
Jul 29 2020, 17:31
majcosta requested review of D7080: [backport#14519] tests: add utility to easily profile node performance with perf.
Jul 29 2020, 17:17
jasonbcox requested review of D7079: Fixup comment regarding finalized block.
Jul 29 2020, 16:56
jasonbcox requested review of D7078: Fix RPC example for finalizeblock.
Jul 29 2020, 16:54
teamcity added a comment to D7077: [backport#14465] tests: Stop node before removing the notification file.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 29 2020, 16:45
teamcity updated the summary of D7077: [backport#14465] tests: Stop node before removing the notification file.
Jul 29 2020, 16:45
majcosta requested review of D7077: [backport#14465] tests: Stop node before removing the notification file.
Jul 29 2020, 16:45
jasonbcox added a comment to D7071: Do not generate RPC doc index files multiple times.

Note that you still need to build an index per group (so within the loop), despite this is not what is done here.

Jul 29 2020, 16:34
jasonbcox accepted D7076: [CI] Prevent copying undesired test/tmp content to the artifacts.
Jul 29 2020, 16:32
jasonbcox requested changes to D7075: [DOC] Improve instructions for setting up shellcheck.

This doesn't strike me as something that belongs in CONTRIBUTING and brings up lots of questions:

  • Why do we expect new devs to have multiple shellcheck versions installed?
  • Why do we expect shellcheck to not be in PATH correctly?
  • What makes shellcheck install special such that we need to tell devs to check the version, but we do not do this for other tools?
Jul 29 2020, 16:28
jasonbcox accepted D7072: [GITIAN] Build with cmake 3.16 from the backport repository.

Expanding our ownership to gitian-builder makes me uncomfortable, but this change is small and the benefits far outweigh the cost of maintaining this change.

Jul 29 2020, 16:25
jasonbcox requested changes to D7073: [CMAKE] Bump minimum cmake to 3.16.

Version bump is missing from contrib/debian/control. Please add this to the test plan also.

Jul 29 2020, 16:21
majcosta accepted D7074: [DOC] clang-*-8 tools are now in the backport repository for Debian 10.
Jul 29 2020, 16:19
Fabien requested review of D7076: [CI] Prevent copying undesired test/tmp content to the artifacts.
Jul 29 2020, 13:54
Fabien requested review of D7075: [DOC] Improve instructions for setting up shellcheck.
Jul 29 2020, 13:31
Fabien requested review of D7074: [DOC] clang-*-8 tools are now in the backport repository for Debian 10.
Jul 29 2020, 13:22
Fabien updated the summary of D6751: [CMAKE] Run the leveldb tests serially.
Jul 29 2020, 13:06
Fabien updated the diff for D6751: [CMAKE] Run the leveldb tests serially.

Use a JOB_POOL mechanism to limit the number of concurrent jobs.

Jul 29 2020, 13:06
Fabien requested review of D7073: [CMAKE] Bump minimum cmake to 3.16.
Jul 29 2020, 12:50
Fabien requested review of D7072: [GITIAN] Build with cmake 3.16 from the backport repository.
Jul 29 2020, 12:09
teamcity closed T1006: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Resolved.
Jul 29 2020, 10:44
teamcity closed T1007: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jul 29 2020, 10:26
teamcity triaged T1007: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jul 29 2020, 10:25
Fabien committed rABCf03faa468ce0: Don't generate junit report for functional test unless being asked to (authored by Fabien).
Don't generate junit report for functional test unless being asked to
Jul 29 2020, 10:08
Fabien closed D7058: Don't generate junit report for functional test unless being asked to.
Jul 29 2020, 10:08
Munna123 added a comment to D5199: [python linting] enforce E265: Block comment should start with '# '.
Jul 29 2020, 10:00
teamcity triaged T1006: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Jul 29 2020, 09:28
Fabien committed rABC4523a0ff1785: [CI] Enable Junit reporting via the build system and use it in scripts (authored by Fabien).
[CI] Enable Junit reporting via the build system and use it in scripts
Jul 29 2020, 09:07
Fabien closed D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 29 2020, 09:07
Fabien requested changes to D7065: Remove language sub-route from RPC doc permalinks.

I don't see the value of this diff. IMO a shorter URL (3 chars !) is not a strong case and this:

  • Makes the url inconsistent with the file system scheme,
  • Will make it more complicated to add translations, if someone is willing to do so.
Jul 29 2020, 08:55
Fabien accepted D7071: Do not generate RPC doc index files multiple times.

Note that you still need to build an index per group (so within the loop), despite this is not what is done here.

Jul 29 2020, 08:51
abbs edited a custom field on abbs.
Jul 29 2020, 05:00

Jul 28 2020

jasonbcox added a parent task for T1004: Backport Core PR18417: Unknown Object (Maniphest Task).
Jul 28 2020, 23:41 · Restricted Project
jasonbcox triaged T1004: Backport Core PR18417 as Normal priority.
Jul 28 2020, 23:38 · Restricted Project
jasonbcox closed T580: Backport Core PR 13930 as Resolved.
Jul 28 2020, 23:35 · Restricted Project
jasonbcox closed T702: Backport 15210 as Resolved.
Jul 28 2020, 23:35
jasonbcox closed T692: Fix apptests as Resolved.
Jul 28 2020, 23:35
jasonbcox closed T693: Backport 15195, a subtask of T692: Fix apptests, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T693: Backport 15195 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T694: Backport 15153, a subtask of T692: Fix apptests, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T694: Backport 15153 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T695: Backport 15226, a subtask of T694: Backport 15153, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T695: Backport 15226 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T696: Backport 15280, a subtask of T694: Backport 15153, as Resolved.
Jul 28 2020, 23:33
jasonbcox closed T696: Backport 15280 as Resolved.
Jul 28 2020, 23:33
jasonbcox closed T688: Backport Core PR13235, a subtask of T537: Backport Core PR14670, as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T688: Backport Core PR13235 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T689: Backport of Core PR13131, a subtask of T688: Backport Core PR13235, as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T689: Backport of Core PR13131 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T537: Backport Core PR14670 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T644: Backport Core PR 13163 as Resolved.
Jul 28 2020, 23:31
jasonbcox requested review of D7071: Do not generate RPC doc index files multiple times.
Jul 28 2020, 23:25
Fabien committed rABC9265d04e9717: Disable Jemalloc for the debian package builds (authored by Fabien).
Disable Jemalloc for the debian package builds
Jul 28 2020, 22:27
Fabien closed D7069: Disable Jemalloc for the debian package builds.
Jul 28 2020, 22:27
Fabien requested review of D7070: [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI.
Jul 28 2020, 22:25
jasonbcox accepted D7069: Disable Jemalloc for the debian package builds.
Jul 28 2020, 21:20
Fabien requested review of D7069: Disable Jemalloc for the debian package builds.
Jul 28 2020, 21:18
jasonbcox accepted D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 21:12
jasonbcox retitled D7065: Remove language sub-route from RPC doc permalinks from Remove langage sub-route from RPC doc permalinks to Remove language sub-route from RPC doc permalinks.
Jul 28 2020, 20:35
jasonbcox committed rABCWEB0cf7c443f98e: Link to new /doc/dev route (authored by jasonbcox).
Link to new /doc/dev route
Jul 28 2020, 20:35
jasonbcox closed D7066: Link to new /doc/dev route.
Jul 28 2020, 20:35
Fabien requested review of D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

The path is finally what Teamcity expects. You can see the result here.

Jul 28 2020, 19:56
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 19:33
Fabien updated the diff for D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

Use version from the artifact dir.

Jul 28 2020, 19:33
deadalnix accepted D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 19:25
deadalnix accepted D7066: Link to new /doc/dev route.
Jul 28 2020, 19:24
deadalnix accepted D7068: Add a link to RPC docs.
Jul 28 2020, 19:24
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 19:02
Fabien updated the diff for D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

Make the path relative to the checkout directory

Jul 28 2020, 19:01
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 18:00
jasonbcox requested review of D7068: Add a link to RPC docs.
Jul 28 2020, 17:56
Fabien updated the diff for D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

Try to send the message before copying the result file, as Teamcity doc says it monitors for the files to appear

Jul 28 2020, 17:54
jasonbcox updated the summary of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:50
jasonbcox updated the summary of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:49
jasonbcox requested review of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:47
jasonbcox requested review of D7066: Link to new /doc/dev route.
Jul 28 2020, 17:32
jasonbcox requested review of D7065: Remove language sub-route from RPC doc permalinks.
Jul 28 2020, 17:30
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 16:49
Fabien updated the diff for D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

Duplicated junit/ in path

Jul 28 2020, 16:49
jhoenicke added a comment to D6981: Implement Grasberg DAA.

Comment about the new approximation for exponential:

Jul 28 2020, 16:31
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 16:30
Fabien updated the diff for D7064: [CI] Enable Junit reporting via the build system and use it in scripts.

Update importdata message.
Since the doc contradicts itself some more iterations are expected...

Jul 28 2020, 16:29
Fabien planned changes to D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 16:21
jasonbcox committed rABCWEBb059f4bf972f: Add autoindexing for /doc route (authored by jasonbcox).
Add autoindexing for /doc route
Jul 28 2020, 15:56
jasonbcox closed D7057: Add autoindexing for /doc route.
Jul 28 2020, 15:56
Fabien requested review of D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 15:48
jasonbcox added a comment to D7057: Add autoindexing for /doc route.

I don't quite get it, since D7052 updated the generated extension there is no html anymore in the RPC docs ?

Jul 28 2020, 15:35
deadalnix requested changes to D7061: [backport#16402] Remove wallet settings from chainparams.

There is a clearly some previous backports that are missing.

Jul 28 2020, 12:12
deadalnix accepted D7062: [backport#16524] Wallet: Disable -fallbackfee by default.
Jul 28 2020, 12:11
deadalnix accepted D7058: Don't generate junit report for functional test unless being asked to.
Jul 28 2020, 12:09
deadalnix accepted D7057: Add autoindexing for /doc route.
Jul 28 2020, 12:09
deadalnix updated the diff for D6981: Implement Grasberg DAA.

Update comments

Jul 28 2020, 12:09
deadalnix updated the diff for D6981: Implement Grasberg DAA.

Simplify target computation by dropping one bit out of the exp2 compuation. That bit is not significant anyways, so we are good.

Jul 28 2020, 12:04
teamcity triaged T1003: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Jul 28 2020, 11:35
teamcity triaged T1002: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jul 28 2020, 11:21
majcosta committed rABCa78b85c81e7c: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet…
Jul 28 2020, 11:07
majcosta closed D7060: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...).
Jul 28 2020, 11:06
majcosta committed rABC16ad4587e457: [backport#14103] docs: Fix broken Doxygen comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14103] docs: Fix broken Doxygen comments
Jul 28 2020, 11:06
majcosta closed D7059: [backport#14103] docs: Fix broken Doxygen comments.
Jul 28 2020, 11:06
majcosta closed D7051: [backport#16624 4/4] Add a test wallet_reorgsrestore.
Jul 28 2020, 11:05