Page MenuHomePhabricator
Feed All Stories

Thu, Jul 30

teamcity updated the summary of D7090: [backport#17138 1/2][wallet] Remove package limit config access from wallet.
Thu, Jul 30, 18:23
majcosta requested review of D7090: [backport#17138 1/2][wallet] Remove package limit config access from wallet.
Thu, Jul 30, 18:23
majcosta requested review of D7061: [backport#16402] Remove wallet settings from chainparams.

indeed we're missing this https://github.com/bitcoin/bitcoin/pull/11882/files, but I'm not sure we even want anything out of it since this fallback_fee thing is an RBF relic and isn't really used. in fact the only line I'm including in this diff is to be removed in the next D7062.

Thu, Jul 30, 17:32
jasonbcox accepted D7089: [GITIAN] Stop distributing the *-unsigned.tar.gz archive.
Thu, Jul 30, 17:09
jasonbcox added a comment to D7065: Remove language sub-route from RPC doc permalinks.

I don't see the value of this diff. IMO a shorter URL (3 chars !) is not a strong case and this:

  • Makes the url inconsistent with the file system scheme,
  • Will make it more complicated to add translations, if someone is willing to do so.
Thu, Jul 30, 17:06
teamcity added a comment to D7089: [GITIAN] Stop distributing the *-unsigned.tar.gz archive.
Thu, Jul 30, 15:02
Fabien requested review of D7089: [GITIAN] Stop distributing the *-unsigned.tar.gz archive.
Thu, Jul 30, 14:37
teamcity closed T1002: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Thu, Jul 30, 12:48
Fabien committed rABCf7b92034f258: Fix wallet_reorgsrestore functional test flakiness (authored by Fabien).
Fix wallet_reorgsrestore functional test flakiness
Thu, Jul 30, 12:34
Fabien closed D7088: Fix wallet_reorgsrestore functional test flakiness.
Thu, Jul 30, 12:34
Fabien updated the diff for D6751: [CMAKE] Run the leveldb tests serially.

PARAM => ARG

Thu, Jul 30, 12:28
deadalnix accepted D7088: Fix wallet_reorgsrestore functional test flakiness.
Thu, Jul 30, 12:22
deadalnix accepted D6751: [CMAKE] Run the leveldb tests serially.
Thu, Jul 30, 12:22
deadalnix added a comment to D7087: Add index page for /en/doc/<version>/rpc.

I think you are going the completely wrong road here. Jeckyl seems to be perfectly able to generate all the crap that is necessary for indices and all. This is completely breaking the SRP. The goal of that script is to extract infos from the node. The goal of the jeckyl machinery to to put it in proper form.

Thu, Jul 30, 12:13
deadalnix requested changes to D7087: Add index page for /en/doc/<version>/rpc.
Thu, Jul 30, 12:11
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Thu, Jul 30, 11:41
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase, don't fail

Thu, Jul 30, 11:41
Fabien updated the diff for D6751: [CMAKE] Run the leveldb tests serially.

Pick a better name for BELONG_TO_POOL

Thu, Jul 30, 09:41
Fabien added a comment to D7088: Fix wallet_reorgsrestore functional test flakiness.

@bot build-asan build-ubsan

Thu, Jul 30, 09:26
Fabien requested review of D7088: Fix wallet_reorgsrestore functional test flakiness.
Thu, Jul 30, 09:26
Fabien committed rABC82e154c27969: [GITIAN] Build with cmake 3.16 from the backport repository (authored by Fabien).
[GITIAN] Build with cmake 3.16 from the backport repository
Thu, Jul 30, 08:59
Fabien closed D7072: [GITIAN] Build with cmake 3.16 from the backport repository.
Thu, Jul 30, 08:59
Fabien accepted D7087: Add index page for /en/doc/<version>/rpc.
Thu, Jul 30, 08:49
Fabien committed rABCa02d9fce3d58: [DOC] Improve instructions for setting up shellcheck (authored by Fabien).
[DOC] Improve instructions for setting up shellcheck
Thu, Jul 30, 08:47
Fabien closed D7075: [DOC] Improve instructions for setting up shellcheck.
Thu, Jul 30, 08:46
abbssm updated abbssm.
Thu, Jul 30, 08:14
abc-bot committed rABC59ecba9ccf46: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Jul 30, 03:21
abc-bot committed rABCf79b54c72926: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Jul 30, 02:13
abc-bot committed rABCa1abf2a3ec1f: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Jul 30, 02:06
teamcity closed T1003: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Thu, Jul 30, 00:44
majcosta committed rABCc529d0493122: [backports#18561#18633] test: Properly raise FailedToStartError when rpc… (authored by MarcoFalke <falke.marco@gmail.com>).
[backports#18561#18633] test: Properly raise FailedToStartError when rpc…
Thu, Jul 30, 00:37
majcosta closed D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.
Thu, Jul 30, 00:36
majcosta committed rABC86af2d500565: [backport#17633] tests: Add option --valgrind to run the functional tests under… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17633] tests: Add option --valgrind to run the functional tests under…
Thu, Jul 30, 00:35
majcosta closed D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.
Thu, Jul 30, 00:35
majcosta committed rABC524cc44787b0: [backport#15963] [tests] Make random seed logged and settable (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15963] [tests] Make random seed logged and settable
Thu, Jul 30, 00:34
majcosta closed D7083: [backport#15963] [tests] Make random seed logged and settable.
Thu, Jul 30, 00:34
majcosta committed rABC05960024a55d: [backport#15927] [tests] log thread names by default in functional tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15927] [tests] log thread names by default in functional tests
Thu, Jul 30, 00:34
majcosta closed D7082: [backport#15927] [tests] log thread names by default in functional tests.
Thu, Jul 30, 00:33
majcosta committed rABC8c7b2b836e9e: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15415] [test] functional: allow custom cwd, use tmpdir as default
Thu, Jul 30, 00:32
majcosta closed D7081: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default.
Thu, Jul 30, 00:32
deadalnix requested changes to D6751: [CMAKE] Run the leveldb tests serially.
Thu, Jul 30, 00:30
majcosta committed rABC0d7f8ccb11b4: [backport#14519] tests: add utility to easily profile node performance with perf (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14519] tests: add utility to easily profile node performance with perf
Thu, Jul 30, 00:25
majcosta closed D7080: [backport#14519] tests: add utility to easily profile node performance with perf.
Thu, Jul 30, 00:25
jasonbcox requested review of D7087: Add index page for /en/doc/<version>/rpc.
Thu, Jul 30, 00:20
majcosta committed rABC0d733b66aa9c: [backport#14465] tests: Stop node before removing the notification file (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#14465] tests: Stop node before removing the notification file
Thu, Jul 30, 00:12
majcosta closed D7077: [backport#14465] tests: Stop node before removing the notification file.
Thu, Jul 30, 00:12

Wed, Jul 29

jasonbcox committed rABC97fe5d3a8660: Do not generate RPC doc index files multiple times (authored by jasonbcox).
Do not generate RPC doc index files multiple times
Wed, Jul 29, 23:55
jasonbcox closed D7071: Do not generate RPC doc index files multiple times.
Wed, Jul 29, 23:55
teamcity added a comment to D7071: Do not generate RPC doc index files multiple times.
Wed, Jul 29, 23:23
jasonbcox updated the summary of D7071: Do not generate RPC doc index files multiple times.
Wed, Jul 29, 23:17
jasonbcox updated the diff for D7071: Do not generate RPC doc index files multiple times.

Rebase (doesn't really depend on D7065)

Wed, Jul 29, 23:17
jasonbcox committed rABCe5a948d2d98e: Fix RPC example for finalizeblock (authored by jasonbcox).
Fix RPC example for finalizeblock
Wed, Jul 29, 22:30
jasonbcox closed D7078: Fix RPC example for finalizeblock.
Wed, Jul 29, 22:30
jasonbcox accepted D7073: [CMAKE] Bump minimum cmake to 3.16.
Wed, Jul 29, 22:25
jasonbcox accepted D7075: [DOC] Improve instructions for setting up shellcheck.
Wed, Jul 29, 22:24
jasonbcox committed rABCf1195918a674: Fixup comment regarding finalized block (authored by jasonbcox).
Fixup comment regarding finalized block
Wed, Jul 29, 22:21
jasonbcox closed D7079: Fixup comment regarding finalized block.
Wed, Jul 29, 22:21
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 21:43
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 21:43
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 21:43
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 21:42
Fabien accepted D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.
Wed, Jul 29, 21:26
Fabien accepted D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.
Wed, Jul 29, 21:18
Fabien accepted D7083: [backport#15963] [tests] Make random seed logged and settable.
Wed, Jul 29, 21:16
Fabien accepted D7082: [backport#15927] [tests] log thread names by default in functional tests.
Wed, Jul 29, 21:07
Fabien accepted D7081: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default.
Wed, Jul 29, 21:04
Fabien accepted D7080: [backport#14519] tests: add utility to easily profile node performance with perf.
Wed, Jul 29, 20:58
Fabien committed rABCab767461f0a6: [CI] Prevent copying undesired test/tmp content to the artifacts (authored by Fabien).
[CI] Prevent copying undesired test/tmp content to the artifacts
Wed, Jul 29, 20:39
Fabien closed D7076: [CI] Prevent copying undesired test/tmp content to the artifacts.
Wed, Jul 29, 20:39
Fabien committed rABC86b027998638: [DOC] clang-*-8 tools are now in the backport repository for Debian 10 (authored by Fabien).
[DOC] clang-*-8 tools are now in the backport repository for Debian 10
Wed, Jul 29, 20:33
Fabien closed D7074: [DOC] clang-*-8 tools are now in the backport repository for Debian 10.
Wed, Jul 29, 20:33
Fabien accepted D7077: [backport#14465] tests: Stop node before removing the notification file.
Wed, Jul 29, 20:30
Fabien updated the diff for D7075: [DOC] Improve instructions for setting up shellcheck.

Make it appear as a note and deduplicate version check

Wed, Jul 29, 20:25
Fabien planned changes to D7075: [DOC] Improve instructions for setting up shellcheck.

This is expected to give a hint on why arcanist could fail to use a recent shellcheck version freshly downloaded.
Talked offline, this will be simplified a bit to not require more steps for the user.

Wed, Jul 29, 20:21
Fabien added a comment to D7073: [CMAKE] Bump minimum cmake to 3.16.

Updating the test plan is not really necessary as the PPA build already uses cmake 3.17.

Wed, Jul 29, 20:17
Fabien updated the diff for D7073: [CMAKE] Bump minimum cmake to 3.16.

Update debian control file

Wed, Jul 29, 20:15
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 19:34
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 19:22
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 19:22
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 19:22
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Wed, Jul 29, 19:19
jasonbcox accepted D7074: [DOC] clang-*-8 tools are now in the backport repository for Debian 10.
Wed, Jul 29, 19:15
majcosta updated the summary of D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.
Wed, Jul 29, 19:02
teamcity added a comment to D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Wed, Jul 29, 18:49
teamcity updated the summary of D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.
Wed, Jul 29, 18:49
majcosta requested review of D7085: [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished.
Wed, Jul 29, 18:49
teamcity added a comment to D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Wed, Jul 29, 18:08
teamcity updated the summary of D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.
Wed, Jul 29, 18:08
majcosta requested review of D7084: [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind.
Wed, Jul 29, 18:08
majcosta accepted D7078: Fix RPC example for finalizeblock.
Wed, Jul 29, 17:57
majcosta accepted D7079: Fixup comment regarding finalized block.
Wed, Jul 29, 17:56
teamcity added a comment to D7083: [backport#15963] [tests] Make random seed logged and settable.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Wed, Jul 29, 17:40
teamcity updated the summary of D7083: [backport#15963] [tests] Make random seed logged and settable.
Wed, Jul 29, 17:40
majcosta requested review of D7083: [backport#15963] [tests] Make random seed logged and settable.
Wed, Jul 29, 17:40
teamcity added a comment to D7082: [backport#15927] [tests] log thread names by default in functional tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Wed, Jul 29, 17:34
teamcity updated the summary of D7082: [backport#15927] [tests] log thread names by default in functional tests.
Wed, Jul 29, 17:33
majcosta requested review of D7082: [backport#15927] [tests] log thread names by default in functional tests.
Wed, Jul 29, 17:33
teamcity added a comment to D7081: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Wed, Jul 29, 17:32
majcosta updated the summary of D7080: [backport#14519] tests: add utility to easily profile node performance with perf.
Wed, Jul 29, 17:32
teamcity updated the summary of D7081: [backport#15415] [test] functional: allow custom cwd, use tmpdir as default.
Wed, Jul 29, 17:32