Page MenuHomePhabricator
Feed All Stories

Oct 1 2020

deadalnix closed D7707: wallet: Report full error message in wallettool.
Oct 1 2020, 14:18
deadalnix committed rABCf5b557323fc6: wallet: Report full error message in wallettool (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Report full error message in wallettool
Oct 1 2020, 14:17
teamcity added a comment to D7709: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 14:17
teamcity updated the summary of D7709: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.
Oct 1 2020, 14:17
majcosta requested review of D7709: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.
Oct 1 2020, 14:17
deadalnix closed D7706: test: tool wallet test coverage for unexpected writes to wallet.
Oct 1 2020, 14:16
deadalnix committed rABC2030c4ba6508: test: tool wallet test coverage for unexpected writes to wallet (authored by Jon Atack <jon@atack.com>).
test: tool wallet test coverage for unexpected writes to wallet
Oct 1 2020, 14:16
deadalnix closed D7703: wallet: Avoid translating RPC errors when creating txs.
Oct 1 2020, 14:15
deadalnix committed rABCfd902a90a6a2: wallet: Avoid translating RPC errors when creating txs (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Avoid translating RPC errors when creating txs
Oct 1 2020, 14:15
deadalnix accepted D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
Oct 1 2020, 14:14
teamcity added a comment to D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 14:13
teamcity added a comment to D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 14:13
teamcity added a comment to D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 14:13
teamcity added a comment to D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 14:12
deadalnix accepted D7704: Fix assertion in CKey::SignCompact.
Oct 1 2020, 14:11
deadalnix accepted D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 14:10
teamcity added a comment to D7708: wallet: Remove trailing whitespace from potential translation strings.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 14:09
teamcity updated the summary of D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 14:09
deadalnix requested review of D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 14:08
PiRK updated the diff for D7704: Fix assertion in CKey::SignCompact.

fix PR number (15299)

Oct 1 2020, 14:06
Fabien accepted D7707: wallet: Report full error message in wallettool.
Oct 1 2020, 13:50
Fabien accepted D7706: test: tool wallet test coverage for unexpected writes to wallet.
Oct 1 2020, 13:48
majcosta updated the diff for D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.

prepended _ to CWallet argument name to prevent shadowing

Oct 1 2020, 13:46
teamcity added a comment to D7707: wallet: Report full error message in wallettool.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 13:43
teamcity updated the summary of D7707: wallet: Report full error message in wallettool.
Oct 1 2020, 13:43
deadalnix requested review of D7707: wallet: Report full error message in wallettool.
Oct 1 2020, 13:42
Fabien requested changes to D7704: Fix assertion in CKey::SignCompact.

This is not a PR

Oct 1 2020, 13:42
Fabien accepted D7703: wallet: Avoid translating RPC errors when creating txs.
Oct 1 2020, 13:41
teamcity added a comment to D7706: test: tool wallet test coverage for unexpected writes to wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 13:40
teamcity updated the summary of D7706: test: tool wallet test coverage for unexpected writes to wallet.
Oct 1 2020, 13:40
deadalnix requested review of D7706: test: tool wallet test coverage for unexpected writes to wallet.
Oct 1 2020, 13:39
Fabien requested review of D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 13:34
majcosta closed D7697: [backport#17373] wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet.
Oct 1 2020, 13:32
majcosta committed rABC0aad192a0690: [backport#17373] wallet: Various fixes and cleanup to keypool handling in… (authored by fanquake <fanquake@gmail.com>).
[backport#17373] wallet: Various fixes and cleanup to keypool handling in…
Oct 1 2020, 13:32
majcosta closed D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
Oct 1 2020, 13:31
majcosta committed rABC61d4ae5b7551: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination
Oct 1 2020, 13:31
teamcity added a comment to D7704: Fix assertion in CKey::SignCompact.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 13:31
teamcity updated the summary of D7704: Fix assertion in CKey::SignCompact.
Oct 1 2020, 13:31
PiRK requested review of D7704: Fix assertion in CKey::SignCompact.
Oct 1 2020, 13:30
teamcity added a comment to D7703: wallet: Avoid translating RPC errors when creating txs.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 13:30
teamcity updated the summary of D7703: wallet: Avoid translating RPC errors when creating txs.
Oct 1 2020, 13:30
deadalnix requested review of D7703: wallet: Avoid translating RPC errors when creating txs.
Oct 1 2020, 13:29
deadalnix closed D7701: wallet: Avoid translating RPC errors when loading wallets.
Oct 1 2020, 13:21
deadalnix committed rABCcfbeff3426c9: wallet: Avoid translating RPC errors when loading wallets (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Avoid translating RPC errors when loading wallets
Oct 1 2020, 13:21
Fabien closed D7700: Remove unused OpenSSL includes to make it more clear where OpenSSL is used.
Oct 1 2020, 13:05
Fabien committed rABCce95722d9781: Remove unused OpenSSL includes to make it more clear where OpenSSL is used (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove unused OpenSSL includes to make it more clear where OpenSSL is used
Oct 1 2020, 13:05
Fabien accepted D7701: wallet: Avoid translating RPC errors when loading wallets.

Note for the future backports: this PR has some non functional dependencies that will need care when backporting:

  • PR15761
  • PR16923
  • PR18727
Oct 1 2020, 13:04
PiRK closed D7702: doc: correct logging rpc return type and example.
Oct 1 2020, 12:51
PiRK committed rABC34344f26585a: doc: correct logging rpc return type and example (authored by fanquake <fanquake@gmail.com>).
doc: correct logging rpc return type and example
Oct 1 2020, 12:51
PiRK abandoned D7604: remove walletmodel header in guiutil.cpp.

This diff was merged into D7602

Oct 1 2020, 12:50
PiRK closed D7605: refactor: remove walletmodeltransaction circular dep.
Oct 1 2020, 12:49
PiRK committed rABC4ff5a135d031: refactor: remove walletmodeltransaction circular dep (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: remove walletmodeltransaction circular dep
Oct 1 2020, 12:49
PiRK closed D7603: refactor: Cleanup headers from walletmodel.h.
Oct 1 2020, 12:48
PiRK committed rABC8f8f44c4564f: refactor: Cleanup headers from walletmodel.h (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Cleanup headers from walletmodel.h
Oct 1 2020, 12:48
deadalnix closed D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 12:46
deadalnix committed rABCbc81b0e205af: wallet: Fix unique_ptr usage in boost::signals2 (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Fix unique_ptr usage in boost::signals2
Oct 1 2020, 12:46
PiRK closed D7602: remove walletmodel circular dependency.
Oct 1 2020, 12:45
PiRK committed rABCd75704e2fa7e: remove walletmodel circular dependency (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
remove walletmodel circular dependency
Oct 1 2020, 12:45
deadalnix accepted D7702: doc: correct logging rpc return type and example.
Oct 1 2020, 12:44
PiRK closed D7572: refactor: Move SendCoinsRecipient in own header.
Oct 1 2020, 12:43
PiRK committed rABC185ad49febbd: refactor: Move SendCoinsRecipient in own header (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Move SendCoinsRecipient in own header
Oct 1 2020, 12:43
teamcity added a comment to D7702: doc: correct logging rpc return type and example.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 12:40
teamcity updated the summary of D7702: doc: correct logging rpc return type and example.
Oct 1 2020, 12:40
PiRK requested review of D7702: doc: correct logging rpc return type and example.
Oct 1 2020, 12:40
deadalnix updated the diff for D7701: wallet: Avoid translating RPC errors when loading wallets.

Remove commented include

Oct 1 2020, 12:33
Fabien accepted D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 12:33
deadalnix accepted D7700: Remove unused OpenSSL includes to make it more clear where OpenSSL is used.
Oct 1 2020, 12:31
deadalnix updated the summary of D7701: wallet: Avoid translating RPC errors when loading wallets.
Oct 1 2020, 12:29
deadalnix updated the diff for D7701: wallet: Avoid translating RPC errors when loading wallets.

rebase

Oct 1 2020, 12:29
teamcity added a comment to D7701: wallet: Avoid translating RPC errors when loading wallets.
Oct 1 2020, 12:28
deadalnix updated the diff for D7699: wallet: Fix unique_ptr usage in boost::signals2.

braces

Oct 1 2020, 12:27
teamcity added a comment to D7701: wallet: Avoid translating RPC errors when loading wallets.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 12:26
teamcity updated the summary of D7701: wallet: Avoid translating RPC errors when loading wallets.
Oct 1 2020, 12:26
deadalnix requested review of D7701: wallet: Avoid translating RPC errors when loading wallets.
Oct 1 2020, 12:26
masonlava updated masonlava.
Oct 1 2020, 12:23
teamcity added a comment to D7700: Remove unused OpenSSL includes to make it more clear where OpenSSL is used.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 12:19
teamcity updated the summary of D7700: Remove unused OpenSSL includes to make it more clear where OpenSSL is used.
Oct 1 2020, 12:19
Fabien requested review of D7700: Remove unused OpenSSL includes to make it more clear where OpenSSL is used.
Oct 1 2020, 12:19
Fabien accepted D7602: remove walletmodel circular dependency.
Oct 1 2020, 11:58
rockbottom edited a custom field on rockbottom.
Oct 1 2020, 11:57
deadalnix accepted D7602: remove walletmodel circular dependency.
Oct 1 2020, 11:45
PiRK updated the summary of D7605: refactor: remove walletmodeltransaction circular dep.
Oct 1 2020, 11:31
PiRK updated the summary of D7603: refactor: Cleanup headers from walletmodel.h.
Oct 1 2020, 11:29
PiRK updated the summary of D7572: refactor: Move SendCoinsRecipient in own header.
Oct 1 2020, 11:28
PiRK added a comment to D7602: remove walletmodel circular dependency.

Please update the summary accordingly

Oct 1 2020, 11:26
PiRK retitled D7602: remove walletmodel circular dependency from refactor headers to remove walletmodel circular dependency.
Oct 1 2020, 11:26
digitalraisers edited a custom field on digitalraisers.
Oct 1 2020, 11:20
Fabien requested changes to D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 11:05
Fabien added a comment to D7602: remove walletmodel circular dependency.

Please update the summary accordingly

Oct 1 2020, 11:04
teamcity added a comment to D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 11:02
PiRK updated the diff for D7602: remove walletmodel circular dependency.

fix newly introduced circular dependencies (this makes D7604 a no-op)

Oct 1 2020, 10:50
deadalnix requested changes to D7602: remove walletmodel circular dependency.

Then squash them together. No need to introduce regression without any good reason to do so.

Oct 1 2020, 10:45
deadalnix accepted D7604: remove walletmodel header in guiutil.cpp.
Oct 1 2020, 10:43
deadalnix added a comment to D7604: remove walletmodel header in guiutil.cpp.

Please link to the specific commit you are backporting when you are not porting the whole PR at once.

Oct 1 2020, 10:43
teamcity added a comment to D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 10:42
teamcity added a comment to D7699: wallet: Fix unique_ptr usage in boost::signals2.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 10:38
teamcity updated the summary of D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 10:38
deadalnix requested review of D7699: wallet: Fix unique_ptr usage in boost::signals2.
Oct 1 2020, 10:38
PiRK added a comment to D7602: remove walletmodel circular dependency.

This commit seems to now introduce 3 new circular dependencies, but they will all be removed in D7604. Should I amend these 2 diffs to temporarily add them to lint-circukar-dependencies.sh in D7602 and remove them again in D7604?

Oct 1 2020, 10:15
PiRK requested review of D7604: remove walletmodel header in guiutil.cpp.
Oct 1 2020, 09:58