Page MenuHomePhabricator
Feed All Stories

Oct 15 2020

deadalnix accepted D7930: GUI: Remove unused menu items for Windows and Linux.
Oct 15 2020, 21:54
deadalnix accepted D7933: log: harmonize bitcoind server logging.
Oct 15 2020, 21:53
deadalnix requested changes to D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Oct 15 2020, 21:53
deadalnix requested changes to D7943: Fix a potential use after move.
Oct 15 2020, 21:52
deadalnix updated the diff for D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.

rebase

Oct 15 2020, 21:50
deadalnix requested review of D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Oct 15 2020, 21:50
Fabien updated the diff for D7943: Fix a potential use after move.

Remove the useless else

Oct 15 2020, 21:49
deadalnix updated the diff for D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.

rebase and fix merge conflicts

Oct 15 2020, 21:47
deadalnix requested changes to D7943: Fix a potential use after move.
Oct 15 2020, 21:45
deadalnix accepted D7943: Fix a potential use after move.
Oct 15 2020, 21:34
deadalnix closed D7936: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.
Oct 15 2020, 21:28
deadalnix committed rABC890765dfd7ee: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>).
[wallet] Move getBlockHash from Chain::Lock interface to simple Chain
Oct 15 2020, 21:28
deadalnix closed D7935: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 21:20
deadalnix committed rABC87c5aec9b3ee: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>).
[wallet] Move getBlockHeight from Chain::Lock interface to simple Chain
Oct 15 2020, 21:20
deadalnix closed D7934: [wallet] Move getHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 21:14
deadalnix committed rABCf9f575bb0118: [wallet] Move getHeight from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>).
[wallet] Move getHeight from Chain::Lock interface to simple Chain
Oct 15 2020, 21:14
jasonbcox closed D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 19:29
jasonbcox committed rABC2c98a843a474: [build-bot] Fix character escapes in ignore list (authored by jasonbcox).
[build-bot] Fix character escapes in ignore list
Oct 15 2020, 19:29
Fabien requested review of D7943: Fix a potential use after move.
Oct 15 2020, 19:19
jasonbcox closed D7942: Use new roadmap link.
Oct 15 2020, 19:00
jasonbcox committed rABCWEBbac85b76fb06: Use new roadmap link (authored by jasonbcox).
Use new roadmap link
Oct 15 2020, 19:00
PiRK updated the diff for D7930: GUI: Remove unused menu items for Windows and Linux.

rebase

Oct 15 2020, 18:50
jasonbcox closed D7725: [CI] Do not wait too long for build logs to flush.
Oct 15 2020, 18:49
jasonbcox committed rABCc1ff352e013c: [CI] Do not wait too long for build logs to flush (authored by jasonbcox).
[CI] Do not wait too long for build logs to flush
Oct 15 2020, 18:49
PiRK updated the diff for D7932: Don't show addresses of P2PK in decoderawtransaction.

rebase

Oct 15 2020, 18:48
PiRK updated the diff for D7933: log: harmonize bitcoind server logging.

add blank line accidentaly deleted

Oct 15 2020, 18:46
Fabien accepted D7942: Use new roadmap link.
Oct 15 2020, 18:33
Fabien accepted D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 18:31
majcosta updated the diff for D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.

named the new translation unit to something more appropriate going forward

Oct 15 2020, 18:19
majcosta closed T1093: Backport script and key management improvements (PR17261), a subtask of T1092: Unrevert coin selection changes, as Resolved.
Oct 15 2020, 18:00 · Restricted Project
majcosta closed T1093: Backport script and key management improvements (PR17261) as Resolved.

this has been landed in D7863 et al

Oct 15 2020, 18:00 · Restricted Project
PiRK abandoned D7941: refactor: pcoinsTip -> CChainState::CoinsTip().

Abandoned because Marco worked on it already: D7580

Oct 15 2020, 17:42
jasonbcox requested review of D7942: Use new roadmap link.
Oct 15 2020, 17:29
majcosta closed D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 17:29
majcosta committed rABCfa57b76ebd76: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17579] [refactor] Merge getreceivedby tally into GetReceived function
Oct 15 2020, 17:29
majcosta requested changes to D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Oct 15 2020, 17:27
PiRK updated the summary of D7941: refactor: pcoinsTip -> CChainState::CoinsTip().
Oct 15 2020, 17:14
PiRK updated subscribers of D7941: refactor: pcoinsTip -> CChainState::CoinsTip().
Oct 15 2020, 17:13
teamcity updated the summary of D7941: refactor: pcoinsTip -> CChainState::CoinsTip().
Oct 15 2020, 17:11
PiRK requested review of D7941: refactor: pcoinsTip -> CChainState::CoinsTip().
Oct 15 2020, 17:10
teamcity closed T1114: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Resolved.
Oct 15 2020, 17:02
teamcity added a comment to D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 17:01
jasonbcox updated the diff for D7725: [CI] Do not wait too long for build logs to flush.

Rebase

Oct 15 2020, 16:46
jasonbcox accepted D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 16:38
jasonbcox closed D7920: [land-bot] Queue the HEAD revision by default.
Oct 15 2020, 16:38
jasonbcox committed rABCa6b0545ead7a: [land-bot] Queue the HEAD revision by default (authored by jasonbcox).
[land-bot] Queue the HEAD revision by default
Oct 15 2020, 16:38
jasonbcox requested review of D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 16:29
Fabien accepted D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.
Oct 15 2020, 16:18
majcosta accepted D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.
Oct 15 2020, 16:16
Fabien accepted D7920: [land-bot] Queue the HEAD revision by default.
Oct 15 2020, 16:12
teamcity updated the summary of D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 16:10
majcosta requested review of D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 16:10
majcosta accepted D7936: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.
Oct 15 2020, 15:29
majcosta accepted D7935: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 15:16
majcosta accepted D7934: [wallet] Move getHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 15:13
deadalnix requested changes to D7933: log: harmonize bitcoind server logging.
Oct 15 2020, 14:55
teamcity updated the summary of D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Oct 15 2020, 14:54
deadalnix requested changes to D7932: Don't show addresses of P2PK in decoderawtransaction.
In D7932#186446, @PiRK wrote:

I'm unable to repoduce the build failure. I tried cmake .. -GNinja -DBUILD_BITCOIN_WALLET=OFF && ninja && test/functional/test_runner.py p2p_timeouts.py

Oct 15 2020, 14:54
deadalnix requested review of D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Oct 15 2020, 14:54
teamcity updated the summary of D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:52
deadalnix requested review of D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:51
teamcity updated the summary of D7936: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:49
deadalnix requested review of D7936: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:49
teamcity updated the summary of D7935: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:47
deadalnix requested review of D7935: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:47
teamcity updated the summary of D7934: [wallet] Move getHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:40
deadalnix requested review of D7934: [wallet] Move getHeight from Chain::Lock interface to simple Chain.
Oct 15 2020, 14:40
PiRK updated the summary of D7933: log: harmonize bitcoind server logging.
Oct 15 2020, 14:35
PiRK requested review of D7933: log: harmonize bitcoind server logging.
Oct 15 2020, 14:26
teamcity triaged T1114: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
Oct 15 2020, 14:08
PiRK added a comment to D7930: GUI: Remove unused menu items for Windows and Linux.

I'm unable to reproduce the failure locally.

Oct 15 2020, 13:34
PiRK added a comment to D7932: Don't show addresses of P2PK in decoderawtransaction.

I'm unable to repoduce the build failure. I tried cmake .. -GNinja -DBUILD_BITCOIN_WALLET=OFF && ninja && test/functional/test_runner.py p2p_timeouts.py

Oct 15 2020, 13:23
PiRK closed D7931: HTML escape the wallet name in dialogs and notifications.
Oct 15 2020, 12:37
PiRK committed rABC5d4729852ad9: HTML escape the wallet name in dialogs and notifications (authored by Andrew Chow <achow101-github@achow101.com>).
HTML escape the wallet name in dialogs and notifications
Oct 15 2020, 12:37
PiRK closed D7929: [backport#14862]Declare BlockValidity:HEADER reserved.
Oct 15 2020, 12:30
PiRK committed rABCeba575e95d47: [backport#14862]Declare BlockValidity:HEADER reserved (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14862]Declare BlockValidity:HEADER reserved
Oct 15 2020, 12:30
teamcity added a comment to D7932: Don't show addresses of P2PK in decoderawtransaction.
Oct 15 2020, 12:21
PiRK updated the summary of D7932: Don't show addresses of P2PK in decoderawtransaction.
Oct 15 2020, 12:21
teamcity updated the summary of D7932: Don't show addresses of P2PK in decoderawtransaction.
Oct 15 2020, 12:17
PiRK requested review of D7932: Don't show addresses of P2PK in decoderawtransaction.
Oct 15 2020, 12:16
deadalnix accepted D7931: HTML escape the wallet name in dialogs and notifications.
Oct 15 2020, 11:48
deadalnix requested changes to D7930: GUI: Remove unused menu items for Windows and Linux.

The test suite seems to be broken.

Oct 15 2020, 11:47
deadalnix closed D7927: Remove -upgradewallet startup option.
Oct 15 2020, 11:46
deadalnix committed rABC0ce1779c0ef9: Remove -upgradewallet startup option (authored by Andrew Chow <achow101-github@achow101.com>).
Remove -upgradewallet startup option
Oct 15 2020, 11:46
deadalnix updated the diff for D7927: Remove -upgradewallet startup option.

rebase

Oct 15 2020, 11:45
teamcity closed T1112: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
Oct 15 2020, 11:45
deadalnix closed D7926: Add upgradewallet RPC.
Oct 15 2020, 11:43
deadalnix committed rABC9c390150444e: Add upgradewallet RPC (authored by Andrew Chow <achow101-github@achow101.com>).
Add upgradewallet RPC
Oct 15 2020, 11:42
deadalnix updated the diff for D7926: Add upgradewallet RPC.

Update as per comments

Oct 15 2020, 11:41
deadalnix accepted D7929: [backport#14862]Declare BlockValidity:HEADER reserved.
Oct 15 2020, 11:39
deadalnix closed D7925: Make UpgradeWallet a member function of CWallet.
Oct 15 2020, 11:38
deadalnix committed rABCdaeced2a2978: Make UpgradeWallet a member function of CWallet (authored by Andrew Chow <achow101-github@achow101.com>).
Make UpgradeWallet a member function of CWallet
Oct 15 2020, 11:38
deadalnix closed D7924: Have UpgradeWallet take the version to upgrade to and an error message out parameter.
Oct 15 2020, 11:36
deadalnix committed rABCddb1c65648de: Have UpgradeWallet take the version to upgrade to and an error message out… (authored by Andrew Chow <achow101-github@achow101.com>).
Have UpgradeWallet take the version to upgrade to and an error message out…
Oct 15 2020, 11:36
deadalnix closed D7923: Only run UpgradeWallet if the wallet needs to be upgraded.
Oct 15 2020, 11:34
deadalnix committed rABC1a996fb25ce6: Only run UpgradeWallet if the wallet needs to be upgraded (authored by Andrew Chow <achow101-github@achow101.com>).
Only run UpgradeWallet if the wallet needs to be upgraded
Oct 15 2020, 11:34
deadalnix closed D7922: Move wallet upgrading to its own function.
Oct 15 2020, 11:32
deadalnix committed rABC2a5a2056cb19: Move wallet upgrading to its own function (authored by Andrew Chow <achow101-github@achow101.com>).
Move wallet upgrading to its own function
Oct 15 2020, 11:32
PiRK updated the summary of D7931: HTML escape the wallet name in dialogs and notifications.
Oct 15 2020, 10:12
PiRK requested review of D7931: HTML escape the wallet name in dialogs and notifications.
Oct 15 2020, 10:11