Page MenuHomePhabricator
Feed All Stories

Nov 19 2020

jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 22:38
jasonbcox updated the diff for D8471: [buildbot] Introduce selecting diff builds based on filename regex.

Changes according to feedback, and rebased on D8473

Nov 19 2020, 22:38
jasonbcox requested review of D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Nov 19 2020, 21:04
bytesofman abandoned D8452: Adding cashtab in web folder.

Abandoning, will split into 2 diffs.

Nov 19 2020, 20:44
deadalnix closed D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 20:40
deadalnix committed rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type (authored by Andrew Chow <achow101-github@achow101.com>).
Return error when no ScriptPubKeyMan is available for specified type
Nov 19 2020, 20:40
deadalnix closed D8468: Correctly check for default wallet.
Nov 19 2020, 20:23
deadalnix committed rABCa58b36f37fc1: Correctly check for default wallet (authored by Andrew Chow <achow101-github@achow101.com>).
Correctly check for default wallet
Nov 19 2020, 20:22
deadalnix closed D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 20:16
deadalnix committed rABC8b377d31cd2a: Implement CWallet::IsSpentKey for non-LegacySPKMans (authored by Andrew Chow <achow101-github@achow101.com>).
Implement CWallet::IsSpentKey for non-LegacySPKMans
Nov 19 2020, 20:16
deadalnix accepted D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 19 2020, 20:02
bytesofman updated the diff for D8452: Adding cashtab in web folder.

Better tools and code org

Nov 19 2020, 19:44
Fabien requested changes to D8471: [buildbot] Introduce selecting diff builds based on filename regex.

I suggest you wrap the differential.getcommitpaths call to a phabricator_wrapper method. This allows for unit testing it, makes it easier to mock and easier to factorize in the future if needed.
Also general style nit, python tends to prefer snake_case.

Nov 19 2020, 18:54
Fabien closed D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 18:39
Fabien committed rABCa33c9303703c: refactor: replace CNode pointers by references within net_processing.{h,cpp} (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: replace CNode pointers by references within net_processing.{h,cpp}
Nov 19 2020, 18:39
jasonbcox requested review of D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 19 2020, 18:19
jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 18:08
jasonbcox accepted D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 18:04
jasonbcox requested review of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 18:03
Fabien updated the diff for D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.

Rebase and address feedback

Nov 19 2020, 18:00
jasonbcox requested changes to D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 17:23
Fabien closed D8469: net processing: Add support for getcfilters.
Nov 19 2020, 17:06
Fabien committed rABCeb6fae51773f: net processing: Add support for getcfilters (authored by John Newbery <john@johnnewbery.com>).
net processing: Add support for getcfilters
Nov 19 2020, 17:06
Fabien closed D8465: net processing: Add support for getcfheaders.
Nov 19 2020, 17:05
Fabien committed rABCa2ee2a50584a: net processing: Add support for getcfheaders (authored by John Newbery <john@johnnewbery.com>).
net processing: Add support for getcfheaders
Nov 19 2020, 17:05
Fabien closed D8464: indexes: Add compact block filter headers cache.
Nov 19 2020, 17:05
Fabien committed rABCa4c5ff8ec7a2: indexes: Add compact block filter headers cache (authored by John Newbery <john@johnnewbery.com>).
indexes: Add compact block filter headers cache
Nov 19 2020, 17:04
Fabien closed D8463: Serve cfcheckpt requests.
Nov 19 2020, 17:04
Fabien committed rABC3ca37803e05b: Serve cfcheckpt requests (authored by jimpo).
Serve cfcheckpt requests
Nov 19 2020, 17:04
Fabien closed D8462: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg.
Nov 19 2020, 17:03
Fabien committed rABC0b1e6312a7c0: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg
Nov 19 2020, 17:03
Fabien closed D8461: scripted-diff: test: replace command with msgtype (naming).
Nov 19 2020, 17:02
Fabien committed rABCce3237e107e7: scripted-diff: test: replace command with msgtype (naming) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
scripted-diff: test: replace command with msgtype (naming)
Nov 19 2020, 17:02
Fabien closed D8460: scripted-diff: Replace strCommand with msg_type.
Nov 19 2020, 17:01
Fabien committed rABC8d54f58d4ffa: scripted-diff: Replace strCommand with msg_type (authored by MarcoFalke <falke.marco@gmail.com>).
scripted-diff: Replace strCommand with msg_type
Nov 19 2020, 17:01
jasonbcox closed D8459: [buildbot] Add revision ID as arg to /buildDiff.
Nov 19 2020, 17:00
jasonbcox committed rABCc21047603fd7: [buildbot] Add revision ID as arg to /buildDiff (authored by jasonbcox).
[buildbot] Add revision ID as arg to /buildDiff
Nov 19 2020, 17:00
teamcity updated the summary of D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 16:55
Fabien requested review of D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 16:55
jasonbcox accepted D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 16:36
jasonbcox accepted D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 16:34
jasonbcox accepted D8468: Correctly check for default wallet.
Nov 19 2020, 16:28
deadalnix accepted D8464: indexes: Add compact block filter headers cache.
Nov 19 2020, 16:02
deadalnix accepted D8463: Serve cfcheckpt requests.
Nov 19 2020, 16:01
deadalnix accepted D8462: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg.
Nov 19 2020, 15:58
deadalnix accepted D8469: net processing: Add support for getcfilters.
Nov 19 2020, 15:57
deadalnix accepted D8465: net processing: Add support for getcfheaders.
Nov 19 2020, 15:54
teamcity updated the summary of D8469: net processing: Add support for getcfilters.
Nov 19 2020, 15:52
Fabien requested review of D8469: net processing: Add support for getcfilters.
Nov 19 2020, 15:52
teamcity updated the summary of D8468: Correctly check for default wallet.
Nov 19 2020, 15:31
deadalnix requested review of D8468: Correctly check for default wallet.
Nov 19 2020, 15:31
teamcity updated the summary of D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 15:22
deadalnix requested review of D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 15:22
teamcity updated the summary of D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 15:15
deadalnix requested review of D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 15:15
teamcity updated the summary of D8465: net processing: Add support for getcfheaders.
Nov 19 2020, 15:14
Fabien requested review of D8465: net processing: Add support for getcfheaders.
Nov 19 2020, 15:13
teamcity updated the summary of D8464: indexes: Add compact block filter headers cache.
Nov 19 2020, 14:39
Fabien requested review of D8464: indexes: Add compact block filter headers cache.
Nov 19 2020, 14:38
teamcity updated the summary of D8463: Serve cfcheckpt requests.
Nov 19 2020, 14:22
Fabien requested review of D8463: Serve cfcheckpt requests.
Nov 19 2020, 14:22
teamcity updated the summary of D8462: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg.
Nov 19 2020, 14:15
Fabien requested review of D8462: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg.
Nov 19 2020, 14:15
deadalnix accepted D8461: scripted-diff: test: replace command with msgtype (naming).
Nov 19 2020, 14:07
teamcity updated the summary of D8461: scripted-diff: test: replace command with msgtype (naming).
Nov 19 2020, 14:05
Fabien requested review of D8461: scripted-diff: test: replace command with msgtype (naming).
Nov 19 2020, 14:05
jasminedisouza created T1207: Bigpond Contact Number 1-800-383-368 Australia- For Technical Support.
Nov 19 2020, 14:01
deadalnix closed D8458: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly.
Nov 19 2020, 14:00
deadalnix committed rABC36c78200690b: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly (authored by Andrew Chow <achow101-github@achow101.com>).
Add IsLegacy to CWallet so that the GUI knows whether to show watchonly
Nov 19 2020, 14:00
deadalnix accepted D8460: scripted-diff: Replace strCommand with msg_type.
Nov 19 2020, 13:55
teamcity closed T1206: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Nov 19 2020, 13:54
teamcity updated the summary of D8460: scripted-diff: Replace strCommand with msg_type.
Nov 19 2020, 13:54
Fabien requested review of D8460: scripted-diff: Replace strCommand with msg_type.
Nov 19 2020, 13:54
deadalnix closed D8457: Generate new descriptors when encrypting.
Nov 19 2020, 13:53
deadalnix committed rABC73cf12785f48: Generate new descriptors when encrypting (authored by Andrew Chow <achow101-github@achow101.com>).
Generate new descriptors when encrypting
Nov 19 2020, 13:53
deadalnix closed D8455: Be able to create new wallets with DescriptorScriptPubKeyMans as backing.
Nov 19 2020, 13:46
deadalnix committed rABC2ab0aaff663c: Be able to create new wallets with DescriptorScriptPubKeyMans as backing (authored by Andrew Chow <achow101-github@achow101.com>).
Be able to create new wallets with DescriptorScriptPubKeyMans as backing
Nov 19 2020, 13:46
deadalnix closed D8454: Implement GetMetadata in DescriptorScriptPubKeyMan.
Nov 19 2020, 13:41
deadalnix committed rABC0fcd2b0ffae7: Implement GetMetadata in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetMetadata in DescriptorScriptPubKeyMan
Nov 19 2020, 13:41
deadalnix closed D8453: Change GetMetadata to use unique_ptr<CKeyMetadata>.
Nov 19 2020, 13:37
deadalnix committed rABCf18cf5b36037: Change GetMetadata to use unique_ptr<CKeyMetadata> (authored by Andrew Chow <achow101-github@achow101.com>).
Change GetMetadata to use unique_ptr<CKeyMetadata>
Nov 19 2020, 13:37
teamcity triaged T1206: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Nov 19 2020, 13:37
deadalnix closed D8451: Implement FillPSBT in DescriptorScriptPubKeyMan.
Nov 19 2020, 13:27
deadalnix committed rABC69c82b89f1e5: Implement FillPSBT in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement FillPSBT in DescriptorScriptPubKeyMan
Nov 19 2020, 13:27
deadalnix requested changes to D8452: Adding cashtab in web folder.

First create a web folder.
Then you can fan out. Add the tools for the web folder, such as prettier & al and in parallel, add the tab project.

Nov 19 2020, 13:24
tbdtgolmart created T1204: tbdtgolmart.
Nov 19 2020, 10:08
tbdtgolmart created T1203: tbdtgolmart.
Nov 19 2020, 10:06
tbdtgolmart created T1202: tbdtgolmart.
Nov 19 2020, 10:04
davedaveee renamed T1201: Đổi đời nhờ tấm vé xổ số miền nam ế from Doi doi nho tam ve xo so mien nam e to Đổi đời nhờ tấm vé xổ số miền nam ế.
Nov 19 2020, 09:55
davedaveee created T1201: Đổi đời nhờ tấm vé xổ số miền nam ế.
Nov 19 2020, 09:55
lucyzara created T1199: End Your Assignment Help Searches - we are here to help you.
Nov 19 2020, 09:07
lucyzara updated lucyzara.
Nov 19 2020, 09:06
majcosta accepted D8453: Change GetMetadata to use unique_ptr<CKeyMetadata>.
Nov 19 2020, 08:43
Fabien accepted D8458: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly.
Nov 19 2020, 08:42
Fabien accepted D8457: Generate new descriptors when encrypting.
Nov 19 2020, 08:38
Fabien accepted D8455: Be able to create new wallets with DescriptorScriptPubKeyMans as backing.
Nov 19 2020, 08:38
Fabien accepted D8454: Implement GetMetadata in DescriptorScriptPubKeyMan.
Nov 19 2020, 08:34
Fabien accepted D8453: Change GetMetadata to use unique_ptr<CKeyMetadata>.
Nov 19 2020, 08:33
majcosta accepted D8451: Implement FillPSBT in DescriptorScriptPubKeyMan.
Nov 19 2020, 08:30
abc-bot committed rABCc480b040c554: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Nov 19 2020, 04:18