Page MenuHomePhabricator
Feed All Stories

Nov 20 2020

jasonbcox accepted D8484: Moving bcha page CSS to main.css.
Nov 20 2020, 21:25
johnkuney updated the diff for D8484: Moving bcha page CSS to main.css.

Remove overide.css from bcha.html

Nov 20 2020, 21:24
jasonbcox requested changes to D8484: Moving bcha page CSS to main.css.

Please remove the reference to overrides.css from the bcha page too

Nov 20 2020, 21:21
johnkuney requested review of D8484: Moving bcha page CSS to main.css.
Nov 20 2020, 21:17
johnkuney closed D8476: Adding a landing page for BCHA information.
Nov 20 2020, 20:30
johnkuney committed rABCWEB016b151c8208: Adding a landing page for BCHA information (authored by johnkuney).
Adding a landing page for BCHA information
Nov 20 2020, 20:30
deadalnix accepted D8476: Adding a landing page for BCHA information.
Nov 20 2020, 20:22
deadalnix requested changes to D8476: Adding a landing page for BCHA information.
Nov 20 2020, 20:21
jasonbcox requested review of D8483: Only run node-related builds on diffs where the node software has changed.
Nov 20 2020, 20:02
jasonbcox closed D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 20 2020, 19:57
jasonbcox committed rABC72637855dccc: [buildbot] Support a list of regex when matching builds to changed files (authored by jasonbcox).
[buildbot] Support a list of regex when matching builds to changed files
Nov 20 2020, 19:57
deadalnix updated the diff for D8475: add importdescriptors RPC and tests for native descriptor wallets.

Fix flackyness

Nov 20 2020, 19:37
Mengerian accepted D8476: Adding a landing page for BCHA information.

OK, I think this is good as an initial MVP.

Nov 20 2020, 19:21
teamcity closed T1235: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Nov 20 2020, 19:15
johnkuney updated the diff for D8476: Adding a landing page for BCHA information.

Remove incorrect wallet link

Nov 20 2020, 19:15
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase to fix another issue. See D8482

Nov 20 2020, 19:12
Mengerian added inline comments to D8476: Adding a landing page for BCHA information.
Nov 20 2020, 19:09
jasonbcox closed D8482: [buildbot] Fix getcommitpaths result type.
Nov 20 2020, 19:07
jasonbcox committed rABCf6664ddd8ad6: [buildbot] Fix getcommitpaths result type (authored by jasonbcox).
[buildbot] Fix getcommitpaths result type
Nov 20 2020, 19:07
Fabien accepted D8482: [buildbot] Fix getcommitpaths result type.
Nov 20 2020, 19:04
johnkuney updated the diff for D8476: Adding a landing page for BCHA information.

Adding Content updates based on Chrsitabels copy

Nov 20 2020, 19:02
jasonbcox requested review of D8482: [buildbot] Fix getcommitpaths result type.
Nov 20 2020, 18:56
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase with D8481 to fix CI

Nov 20 2020, 18:38
jasonbcox closed D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Nov 20 2020, 18:35
jasonbcox committed rABC33babbf34deb: [buildbot] Fix missing revision_id that is expected to be strictly an integer (authored by jasonbcox).
[buildbot] Fix missing revision_id that is expected to be strictly an integer
Nov 20 2020, 18:34
PiRK accepted D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Nov 20 2020, 18:21
Fabien accepted D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Nov 20 2020, 18:21
teamcity triaged T1235: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Nov 20 2020, 17:35
bytesofman abandoned D8474: adding parent dir web/ for web apps.

Abandoning in favor of https://reviews.bitcoinabc.org/D8477, which I think offers a better approach.

Nov 20 2020, 17:04
jasonbcox requested review of D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Nov 20 2020, 16:41
Mengerian requested changes to D8476: Adding a landing page for BCHA information.

Could you put a link in the banner, so that people can navigate to it from the main site?

Nov 20 2020, 16:36
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebasing again since buildbot did not finish re-deploying

Nov 20 2020, 16:30
teamcity added a comment to D8480: refactor: replace CConnman pointers by references in net_processing.cpp.
Nov 20 2020, 16:13
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase to kick off new buildbot tests on the diff

Nov 20 2020, 16:13
jasonbcox closed D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 20 2020, 16:12
jasonbcox committed rABC96022ff9077a: [buildbot] Introduce selecting diff builds based on filename regex (authored by jasonbcox).
[buildbot] Introduce selecting diff builds based on filename regex
Nov 20 2020, 16:12
abc-bot committed rABC3dea2e01ed67: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Nov 20 2020, 16:10
teamcity updated the summary of D8480: refactor: replace CConnman pointers by references in net_processing.cpp.
Nov 20 2020, 16:06
Fabien requested review of D8480: refactor: replace CConnman pointers by references in net_processing.cpp.
Nov 20 2020, 16:06
teamcity updated the summary of D8479: net: Make addr relay mockable, add test.
Nov 20 2020, 16:02
Fabien requested review of D8479: net: Make addr relay mockable, add test.
Nov 20 2020, 16:02
Fabien closed D8478: refactor: replace pointers by references within tx_verify.{h,cpp}.
Nov 20 2020, 15:25
Fabien committed rABCb2effc38822e: refactor: replace pointers by references within tx_verify.{h,cpp} (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: replace pointers by references within tx_verify.{h,cpp}
Nov 20 2020, 15:25
deadalnix requested changes to D8476: Adding a landing page for BCHA information.
Nov 20 2020, 14:40
deadalnix accepted D8478: refactor: replace pointers by references within tx_verify.{h,cpp}.
Nov 20 2020, 14:39
deadalnix added inline comments to D8474: adding parent dir web/ for web apps.
Nov 20 2020, 14:37
deadalnix requested changes to D8477: Add a prettier linter for the web tools.
Nov 20 2020, 14:36
Fabien accepted D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 20 2020, 14:35
teamcity updated the summary of D8478: refactor: replace pointers by references within tx_verify.{h,cpp}.
Nov 20 2020, 14:34
Fabien requested review of D8478: refactor: replace pointers by references within tx_verify.{h,cpp}.
Nov 20 2020, 14:34
nicolassmith edited a custom field on nicolassmith.
Nov 20 2020, 13:49
nicolassmith updated nicolassmith.
Nov 20 2020, 13:49
Fabien requested review of D8477: Add a prettier linter for the web tools.
Nov 20 2020, 10:05
numbersupport triaged T1233: Spam as High priority.
Nov 20 2020, 08:01
numbersupport triaged T1232: How do you access account if Sbcglobal email not working? as Wishlist priority.
Nov 20 2020, 08:00
numbersupport triaged T1231: How may you unlock Cash app account? as High priority.
Nov 20 2020, 07:58
numbersupport updated the task description for T1230: Can't move from Apple Pay to Cash App considering net trouble? Call help gathering..
Nov 20 2020, 07:57
numbersupport triaged T1230: Can't move from Apple Pay to Cash App considering net trouble? Call help gathering. as High priority.
Nov 20 2020, 07:56
numbersupport created T1229: Can't move from Paypal to Cash App in view of net difficulty? Call help group..
Nov 20 2020, 07:53
numbersupport created T1228: How to get to account if ATT email not working?.
Nov 20 2020, 07:52
numbersupport triaged T1227: Glitch in send button explanation behind Paypal to Cash App thwarted expectation? Dial helpline to discover uphold. as High priority.
Nov 20 2020, 07:47
avalee5020 updated avalee5020.
Nov 20 2020, 07:46
adamfoster009 updated adamfoster009.
Nov 20 2020, 06:49
johnkuney requested review of D8476: Adding a landing page for BCHA information.
Nov 20 2020, 06:18
melwilson updated melwilson.
Nov 20 2020, 05:48
jasonbcox committed rABCad746f3c3989: Split chainparams by network (authored by jasonbcox).
Split chainparams by network
Nov 20 2020, 00:44
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase

Nov 20 2020, 00:24
jasonbcox closed D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Nov 20 2020, 00:20
jasonbcox committed rABCcd684dad5ea7: [buildbot] Add a facility for fetching the files changed in a given revision (authored by jasonbcox).
[buildbot] Add a facility for fetching the files changed in a given revision
Nov 20 2020, 00:20
teamcity added a comment to D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 20 2020, 00:03
bytesofman updated the diff for D8474: adding parent dir web/ for web apps.

Test plan

Nov 20 2020, 00:02

Nov 19 2020

deadalnix planned changes to D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 19 2020, 23:55
teamcity updated the summary of D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 19 2020, 23:54
deadalnix requested review of D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 19 2020, 23:54
deadalnix accepted D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Nov 19 2020, 23:47
jasonbcox added inline comments to D8474: adding parent dir web/ for web apps.
Nov 19 2020, 23:16
bytesofman requested review of D8474: adding parent dir web/ for web apps.
Nov 19 2020, 22:52
teamcity added a comment to D8471: [buildbot] Introduce selecting diff builds based on filename regex.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 19 2020, 22:45
jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 22:38
jasonbcox updated the diff for D8471: [buildbot] Introduce selecting diff builds based on filename regex.

Changes according to feedback, and rebased on D8473

Nov 19 2020, 22:38
jasonbcox requested review of D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Nov 19 2020, 21:04
bytesofman abandoned D8452: Adding cashtab in web folder.

Abandoning, will split into 2 diffs.

Nov 19 2020, 20:44
deadalnix closed D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 20:40
deadalnix committed rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type (authored by Andrew Chow <achow101-github@achow101.com>).
Return error when no ScriptPubKeyMan is available for specified type
Nov 19 2020, 20:40
deadalnix closed D8468: Correctly check for default wallet.
Nov 19 2020, 20:23
deadalnix committed rABCa58b36f37fc1: Correctly check for default wallet (authored by Andrew Chow <achow101-github@achow101.com>).
Correctly check for default wallet
Nov 19 2020, 20:22
deadalnix closed D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 20:16
deadalnix committed rABC8b377d31cd2a: Implement CWallet::IsSpentKey for non-LegacySPKMans (authored by Andrew Chow <achow101-github@achow101.com>).
Implement CWallet::IsSpentKey for non-LegacySPKMans
Nov 19 2020, 20:16
deadalnix accepted D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 19 2020, 20:02
bytesofman updated the diff for D8452: Adding cashtab in web folder.

Better tools and code org

Nov 19 2020, 19:44
Fabien requested changes to D8471: [buildbot] Introduce selecting diff builds based on filename regex.

I suggest you wrap the differential.getcommitpaths call to a phabricator_wrapper method. This allows for unit testing it, makes it easier to mock and easier to factorize in the future if needed.
Also general style nit, python tends to prefer snake_case.

Nov 19 2020, 18:54
Fabien closed D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 18:39
Fabien committed rABCa33c9303703c: refactor: replace CNode pointers by references within net_processing.{h,cpp} (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: replace CNode pointers by references within net_processing.{h,cpp}
Nov 19 2020, 18:39
jasonbcox requested review of D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 19 2020, 18:19
jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 18:08
jasonbcox accepted D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 18:04
jasonbcox requested review of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Nov 19 2020, 18:03
Fabien updated the diff for D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.

Rebase and address feedback

Nov 19 2020, 18:00
jasonbcox requested changes to D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Nov 19 2020, 17:23
Fabien closed D8469: net processing: Add support for getcfilters.
Nov 19 2020, 17:06