Page MenuHomePhabricator
Feed All Stories

Feb 18 2021

PiRK updated the diff for D9240: cli: use GetWalletBalances() functionality for -getinfo.

remove maybe_unused annotation

Feb 18 2021, 07:48
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:46
PiRK added inline comments to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 18 2021, 07:44
PiRK updated the diff for D9239: cli: create GetWalletBalances() to fetch multiwallet balances.

annotate unused function

Feb 18 2021, 07:44
teamcity added a comment to D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:43
PiRK updated the test plan for D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:36
teamcity updated the summary of D9248: Remove old serialization primitives.
Feb 18 2021, 07:32
PiRK requested review of D9248: Remove old serialization primitives.
Feb 18 2021, 07:31
PiRK requested review of D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:29
teamcity updated the summary of D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:26
PiRK requested review of D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:26
PiRK updated the summary of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:25
teamcity updated the summary of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:23
PiRK requested review of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:23
teamcity updated the summary of D9244: Convert Qt to new serialization.
Feb 18 2021, 07:23
PiRK requested review of D9244: Convert Qt to new serialization.
Feb 18 2021, 07:22
PiRK retitled D9236: wallet: descriptor wallet cleanups from wallet: descriptor wallet release notes and cleanups to wallet: descriptor wallet cleanups.
Feb 18 2021, 07:05
abc-bot committed rABCa0f63989f10e: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Feb 18 2021, 04:18
abc-bot committed rABC0dbb1d38cd78: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Feb 18 2021, 03:17
abc-bot committed rABC591819828eef: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Feb 18 2021, 03:08

Feb 17 2021

bytesofman requested review of D9243: [Cashtab] fix css issue with long wallet display names.
Feb 17 2021, 21:08
Joey King <joseph.roy.king@gmail.com> closed D9233: [Cashtab] show active wallet on home.
Feb 17 2021, 19:28
Joey King <joseph.roy.king@gmail.com> committed rABC5a0f74cdd8b5: [Cashtab] show active wallet on home (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] show active wallet on home
Feb 17 2021, 19:28
majcosta accepted D9242: test: add -getinfo multiwallet functional tests.
Feb 17 2021, 19:21
majcosta accepted D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Feb 17 2021, 19:18
Fabien accepted D9233: [Cashtab] show active wallet on home.
Feb 17 2021, 19:17
majcosta accepted D9240: cli: use GetWalletBalances() functionality for -getinfo.
Feb 17 2021, 19:14
majcosta requested changes to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 19:13
majcosta accepted D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 17 2021, 18:32
majcosta accepted D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Feb 17 2021, 18:09
Joey King <joseph.roy.king@gmail.com> closed D9235: [cashtab-components] More unit tests for helper functions.
Feb 17 2021, 17:55
Joey King <joseph.roy.king@gmail.com> committed rABC93882ee43eb2: [cashtab-components] More unit tests for helper functions (authored by Joey King <joseph.roy.king@gmail.com>).
[cashtab-components] More unit tests for helper functions
Feb 17 2021, 17:55
bytesofman updated the diff for D9233: [Cashtab] show active wallet on home.

Bold, bump font size, remove margin bottom, remove unnecessary !important flag

Feb 17 2021, 17:55
teamcity added a comment to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:53
teamcity added a comment to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:53
teamcity added a comment to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:50
teamcity added a comment to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:47
teamcity updated the summary of D9242: test: add -getinfo multiwallet functional tests.
Feb 17 2021, 14:46
teamcity updated the summary of D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Feb 17 2021, 14:45
PiRK requested review of D9242: test: add -getinfo multiwallet functional tests.
Feb 17 2021, 14:44
PiRK requested review of D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Feb 17 2021, 14:43
teamcity updated the summary of D9240: cli: use GetWalletBalances() functionality for -getinfo.
Feb 17 2021, 14:43
PiRK requested review of D9240: cli: use GetWalletBalances() functionality for -getinfo.
Feb 17 2021, 14:42
teamcity updated the summary of D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:41
PiRK requested review of D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 14:41
PiRK updated the summary of D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 17 2021, 14:37
teamcity updated the summary of D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 17 2021, 14:37
PiRK requested review of D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 17 2021, 14:37
teamcity updated the summary of D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Feb 17 2021, 14:35
PiRK requested review of D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Feb 17 2021, 14:35
teamcity updated the summary of D9236: wallet: descriptor wallet cleanups.
Feb 17 2021, 11:45
PiRK requested review of D9236: wallet: descriptor wallet cleanups.
Feb 17 2021, 11:45
Fabien accepted D9235: [cashtab-components] More unit tests for helper functions.
Feb 17 2021, 09:23
Fabien requested changes to D9233: [Cashtab] show active wallet on home.

Please update the summary to reflect the current diff content

Feb 17 2021, 09:21
PiRK closed D9230: Avoid crash when g_thread_http was never started.
Feb 17 2021, 07:39
PiRK committed rABCeb6a052baa17: Avoid crash when g_thread_http was never started (authored by MarcoFalke <falke.marco@gmail.com>).
Avoid crash when g_thread_http was never started
Feb 17 2021, 07:38

Feb 16 2021

bytesofman requested review of D9235: [cashtab-components] More unit tests for helper functions.
Feb 16 2021, 21:16
Mengerian closed D9234: [website] Add MXC.com to list of exchanges on BCHA page.
Feb 16 2021, 20:46
Mengerian committed rABCWEBa2d61ffcba1d: [website] Add MXC.com to list of exchanges on BCHA page (authored by Mengerian).
[website] Add MXC.com to list of exchanges on BCHA page
Feb 16 2021, 20:46
bytesofman accepted D9234: [website] Add MXC.com to list of exchanges on BCHA page.
Feb 16 2021, 20:38
Mengerian requested review of D9234: [website] Add MXC.com to list of exchanges on BCHA page.
Feb 16 2021, 20:35
bytesofman updated the diff for D9233: [Cashtab] show active wallet on home.

Apply active wallet label in standardized way to all screens

Feb 16 2021, 19:12
Unknown Object (User) added a comment to D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Feb 16 2021, 18:58
PiRK closed D9232: test: Fix intermittent ETIMEDOUT on FreeBSD.
Feb 16 2021, 16:30
PiRK committed rABC79cf316a9560: test: Fix intermittent ETIMEDOUT on FreeBSD (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix intermittent ETIMEDOUT on FreeBSD
Feb 16 2021, 16:30
PiRK updated the diff for D9230: Avoid crash when g_thread_http was never started.

rebase

Feb 16 2021, 16:26
bytesofman added a comment to D9233: [Cashtab] show active wallet on home.

Here's what it looks like

Feb 16 2021, 14:21
bytesofman requested review of D9233: [Cashtab] show active wallet on home.
Feb 16 2021, 14:20
Fabien closed D9231: [CI] Run cashtab components tests on CI.
Feb 16 2021, 14:17
Fabien committed rABC50b0392e1158: [CI] Run cashtab components tests on CI (authored by Fabien).
[CI] Run cashtab components tests on CI
Feb 16 2021, 14:17
bytesofman accepted D9231: [CI] Run cashtab components tests on CI.
Feb 16 2021, 14:13
Fabien accepted D9232: test: Fix intermittent ETIMEDOUT on FreeBSD.
Feb 16 2021, 13:17
PiRK added a comment to D9230: Avoid crash when g_thread_http was never started.

I wasn't able to reproduce the latest build-clang-tidy failure on my machine.

Feb 16 2021, 12:28
teamcity updated the summary of D9232: test: Fix intermittent ETIMEDOUT on FreeBSD.
Feb 16 2021, 10:49
PiRK requested review of D9232: test: Fix intermittent ETIMEDOUT on FreeBSD.
Feb 16 2021, 10:48
Fabien accepted D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 10:05
Fabien requested review of D9231: [CI] Run cashtab components tests on CI.
Feb 16 2021, 09:59
teamcity added a comment to D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 09:34
PiRK updated the diff for D9230: Avoid crash when g_thread_http was never started.

address review

Feb 16 2021, 09:25
PiRK added inline comments to D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 09:25
Fabien requested changes to D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 07:51
teamcity added a comment to D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 07:44
teamcity updated the summary of D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 07:39
PiRK requested review of D9230: Avoid crash when g_thread_http was never started.
Feb 16 2021, 07:39

Feb 15 2021

Mengerian accepted D9225: Move replay protection activation to Nov. 15, 2021.

I double-checked the unix time stamp, looks good.

Feb 15 2021, 21:16
Fabien closed D9229: [CI] Rename teamcity messages testMeta to testMetadata.
Feb 15 2021, 15:49
Fabien committed rABC7320560e958f: [CI] Rename teamcity messages testMeta to testMetadata (authored by Fabien).
[CI] Rename teamcity messages testMeta to testMetadata
Feb 15 2021, 15:49
Fabien closed D9228: [CI] Split secp256k1 benchmarks from the node benchmarks.
Feb 15 2021, 15:48
Fabien committed rABC5d8fde6b5af9: [CI] Split secp256k1 benchmarks from the node benchmarks (authored by Fabien).
[CI] Split secp256k1 benchmarks from the node benchmarks
Feb 15 2021, 15:48
majcosta accepted D9225: Move replay protection activation to Nov. 15, 2021.
Feb 15 2021, 15:44
PiRK accepted D9229: [CI] Rename teamcity messages testMeta to testMetadata.
Feb 15 2021, 14:50
PiRK accepted D9228: [CI] Split secp256k1 benchmarks from the node benchmarks.
Feb 15 2021, 14:49
Fabien requested review of D9229: [CI] Rename teamcity messages testMeta to testMetadata.
Feb 15 2021, 13:48
Fabien requested review of D9228: [CI] Split secp256k1 benchmarks from the node benchmarks.
Feb 15 2021, 13:08
Fabien closed D9227: [CI] Integrate nanobench with Teamcity.
Feb 15 2021, 13:08
Fabien committed rABCc3ac2ec43dd3: [CI] Integrate nanobench with Teamcity (authored by Fabien).
[CI] Integrate nanobench with Teamcity
Feb 15 2021, 13:08
Fabien closed D9226: Replace current benchmarking framework with nanobench.
Feb 15 2021, 13:07
Fabien committed rABCf95373f2340a: Replace current benchmarking framework with nanobench (authored by Martin Ankerl <martin.ankerl@gmail.com>).
Replace current benchmarking framework with nanobench
Feb 15 2021, 13:07
PiRK accepted D9227: [CI] Integrate nanobench with Teamcity.
Feb 15 2021, 10:05
PiRK accepted D9226: Replace current benchmarking framework with nanobench.

Note: i did not review src/bench/nanobench.h

Feb 15 2021, 10:00