- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 22 2021
Good stuff.
remove accidentaly duplicated line
remove "// serialization support" comments and mark getters as const
Feb 21 2021
couldn't reproduce with for i in {1..100}; do ninja check-bitcoin-coinselector_tests; done, rebasing
Feb 20 2021
Feb 19 2021
nvm last comment, was an old uncommited one
Feb 18 2021
rebase after changing D9247 to suppress compiler warning
remove maybe_unused which does not work for GCC with attributes, define two getters instead
replace a SER_READ with SER_WRITE (seeder/db.h l234)
Rebase after fixing -Wunused-private-field warning in D9247
annotate two private attributes in avalanche/protocol.h with [[maybe_unused]] to suppress a compiler warning
Tested locally and it works.
Please update the test plan, afaik there is no test coverage for this.
getters are required to silence a compiler warning
-Wunused-private-field
@bot build-without-bip70
and also write the store request when serializing
in case BIP70 is disabled, still store the deserialized payment request in the object's sPaymentRequest attribute
rebase (probably unrelated coinselector_tests failure in build-clang-tidy)
remove maybe_unused annotation
annotate unused function