Page MenuHomePhabricator
Feed All Stories

Feb 22 2021

teamcity updated the summary of D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Feb 22 2021, 14:53
PiRK requested review of D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Feb 22 2021, 14:53
teamcity updated the summary of D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 22 2021, 14:47
PiRK requested review of D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 22 2021, 14:47
teamcity updated the summary of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 14:44
PiRK requested review of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 14:44
PiRK accepted D9252: [CI] Use a new datadir when running the windows native tests.
Feb 22 2021, 14:34
Fabien requested review of D9252: [CI] Use a new datadir when running the windows native tests.
Feb 22 2021, 13:07
PiRK closed D9248: Remove old serialization primitives.
Feb 22 2021, 10:52
PiRK committed rABCc044e9dcf18e: Remove old serialization primitives (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Remove old serialization primitives
Feb 22 2021, 10:52
PiRK closed D9247: convert all remaining serializations to new style.
Feb 22 2021, 10:51
PiRK committed rABCf77a8a4d352e: convert all remaining serializations to new style (authored by PiRK).
convert all remaining serializations to new style
Feb 22 2021, 10:51
PiRK closed D9246: Convert LimitedString to formatter.
Feb 22 2021, 10:50
PiRK committed rABC632bf808135f: Convert LimitedString to formatter (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Convert LimitedString to formatter
Feb 22 2021, 10:50
PiRK closed D9245: Convert wallet to new serialization.
Feb 22 2021, 10:50
PiRK committed rABC7f8be210948b: Convert wallet to new serialization (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Convert wallet to new serialization
Feb 22 2021, 10:49
PiRK closed D9244: Convert Qt to new serialization.
Feb 22 2021, 10:44
PiRK committed rABC6b64f26d1420: Convert Qt to new serialization (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Convert Qt to new serialization
Feb 22 2021, 10:43
Fabien accepted D9247: convert all remaining serializations to new style.
Feb 22 2021, 08:47
PiRK accepted D9251: [refactor] add alias for Schnorr signatures and remove size magic number.

Good stuff.

Feb 22 2021, 07:38
PiRK updated the diff for D9236: wallet: descriptor wallet cleanups.

remove accidentaly duplicated line

Feb 22 2021, 07:29
PiRK updated the diff for D9247: convert all remaining serializations to new style.

remove "// serialization support" comments and mark getters as const

Feb 22 2021, 07:22

Feb 21 2021

majcosta updated the diff for D9251: [refactor] add alias for Schnorr signatures and remove size magic number.

couldn't reproduce with for i in {1..100}; do ninja check-bitcoin-coinselector_tests; done, rebasing

Feb 21 2021, 11:05
majcosta planned changes to D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 21 2021, 10:49
teamcity added a comment to D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 21 2021, 10:19
majcosta requested review of D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 21 2021, 10:13

Feb 20 2021

bytesofman requested review of D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 20 2021, 22:07
teamcity triaged T1523: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Feb 20 2021, 15:07

Feb 19 2021

Fabien accepted D9248: Remove old serialization primitives.
Feb 19 2021, 19:52
Fabien added a comment to D9247: convert all remaining serializations to new style.

nvm last comment, was an old uncommited one

Feb 19 2021, 19:51
Fabien requested changes to D9247: convert all remaining serializations to new style.
Feb 19 2021, 19:50
majcosta requested changes to D9236: wallet: descriptor wallet cleanups.
Feb 19 2021, 17:30
Fabien closed D9249: Update version to 0.22.14.
Feb 19 2021, 16:43
Fabien committed rABCe6f40506af6d: Update version to 0.22.14 (authored by Fabien).
Update version to 0.22.14
Feb 19 2021, 16:43
majcosta accepted D9249: Update version to 0.22.14.
Feb 19 2021, 16:36
Fabien requested review of D9249: Update version to 0.22.14.
Feb 19 2021, 16:28

Feb 18 2021

Joey King <joseph.roy.king@gmail.com> closed D9243: [Cashtab] fix css issue with long wallet display names.
Feb 18 2021, 14:28
Joey King <joseph.roy.king@gmail.com> committed rABC9e5d2722498a: [Cashtab] fix css issue with long wallet display names (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] fix css issue with long wallet display names
Feb 18 2021, 14:28
bytesofman updated the test plan for D9243: [Cashtab] fix css issue with long wallet display names.
Feb 18 2021, 14:27
teamcity closed T1519: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Feb 18 2021, 13:33
PiRK updated the diff for D9248: Remove old serialization primitives.

rebase after changing D9247 to suppress compiler warning

Feb 18 2021, 13:24
teamcity closed T1520: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Feb 18 2021, 13:23
PiRK updated the diff for D9247: convert all remaining serializations to new style.

remove maybe_unused which does not work for GCC with attributes, define two getters instead

Feb 18 2021, 13:23
teamcity triaged T1520: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Feb 18 2021, 13:14
teamcity triaged T1519: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Feb 18 2021, 13:13
PiRK closed D9242: test: add -getinfo multiwallet functional tests.
Feb 18 2021, 13:05
PiRK committed rABC08c813ab9661: test: add -getinfo multiwallet functional tests (authored by Jon Atack <jon@atack.com>).
test: add -getinfo multiwallet functional tests
Feb 18 2021, 13:05
PiRK closed D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Feb 18 2021, 13:02
PiRK committed rABCb5e256418683: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor (authored by Jon Atack <jon@atack.com>).
rpc: drop unused JSONRPCProcessBatchReply size arg, refactor
Feb 18 2021, 13:01
PiRK closed D9240: cli: use GetWalletBalances() functionality for -getinfo.
Feb 18 2021, 13:01
PiRK committed rABC984a96569bcf: cli: use GetWalletBalances() functionality for -getinfo (authored by Jon Atack <jon@atack.com>).
cli: use GetWalletBalances() functionality for -getinfo
Feb 18 2021, 13:00
PiRK closed D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 18 2021, 13:00
PiRK committed rABC01f2e8d87568: cli: create GetWalletBalances() to fetch multiwallet balances (authored by Jon Atack <jon@atack.com>).
cli: create GetWalletBalances() to fetch multiwallet balances
Feb 18 2021, 12:59
PiRK closed D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 18 2021, 12:59
PiRK committed rABC9aa48e14e245: cli: lift -rpcwallet logic up to CommandLineRPC() (authored by Jon Atack <jon@atack.com>).
cli: lift -rpcwallet logic up to CommandLineRPC()
Feb 18 2021, 12:59
PiRK closed D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Feb 18 2021, 12:58
PiRK committed rABC61bb2abbe050: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC() (authored by Jon Atack <jon@atack.com>).
cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC()
Feb 18 2021, 12:58
majcosta accepted D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 18 2021, 11:48
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:27
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:27
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:27
PiRK updated the diff for D9247: convert all remaining serializations to new style.

replace a SER_READ with SER_WRITE (seeder/db.h l234)

Feb 18 2021, 11:24
teamcity added a comment to D9248: Remove old serialization primitives.
Feb 18 2021, 11:05
teamcity added a comment to D9248: Remove old serialization primitives.
Feb 18 2021, 11:03
teamcity added a comment to D9248: Remove old serialization primitives.
Feb 18 2021, 11:02
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:00
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:00
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 11:00
PiRK updated the diff for D9248: Remove old serialization primitives.

Rebase after fixing -Wunused-private-field warning in D9247

Feb 18 2021, 10:58
PiRK updated the diff for D9247: convert all remaining serializations to new style.

annotate two private attributes in avalanche/protocol.h with [[maybe_unused]] to suppress a compiler warning

Feb 18 2021, 10:57
Fabien accepted D9243: [Cashtab] fix css issue with long wallet display names.

Tested locally and it works.
Please update the test plan, afaik there is no test coverage for this.

Feb 18 2021, 10:25
Fabien accepted D9246: Convert LimitedString to formatter.
Feb 18 2021, 10:19
Fabien accepted D9245: Convert wallet to new serialization.
Feb 18 2021, 10:16
Fabien accepted D9244: Convert Qt to new serialization.
Feb 18 2021, 10:06
PiRK planned changes to D9247: convert all remaining serializations to new style.

getters are required to silence a compiler warning

-Wunused-private-field
Feb 18 2021, 09:45
teamcity awarded D9244: Convert Qt to new serialization a Haypence token.
Feb 18 2021, 09:35
Fabien added a comment to D9244: Convert Qt to new serialization.

@bot build-without-bip70

Feb 18 2021, 09:34
PiRK updated the diff for D9244: Convert Qt to new serialization.

and also write the store request when serializing

Feb 18 2021, 09:30
PiRK updated the diff for D9244: Convert Qt to new serialization.

in case BIP70 is disabled, still store the deserialized payment request in the object's sPaymentRequest attribute

Feb 18 2021, 09:22
PiRK updated the diff for D9246: Convert LimitedString to formatter.

rebase (probably unrelated coinselector_tests failure in build-clang-tidy)

Feb 18 2021, 07:54
teamcity added a comment to D9248: Remove old serialization primitives.
Feb 18 2021, 07:54
PiRK updated the diff for D9240: cli: use GetWalletBalances() functionality for -getinfo.

remove maybe_unused annotation

Feb 18 2021, 07:48
teamcity added a comment to D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:46
PiRK added inline comments to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 18 2021, 07:44
PiRK updated the diff for D9239: cli: create GetWalletBalances() to fetch multiwallet balances.

annotate unused function

Feb 18 2021, 07:44
teamcity added a comment to D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:43
PiRK updated the test plan for D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:36
teamcity updated the summary of D9248: Remove old serialization primitives.
Feb 18 2021, 07:32
PiRK requested review of D9248: Remove old serialization primitives.
Feb 18 2021, 07:31
PiRK requested review of D9247: convert all remaining serializations to new style.
Feb 18 2021, 07:29
teamcity updated the summary of D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:26
PiRK requested review of D9246: Convert LimitedString to formatter.
Feb 18 2021, 07:26
PiRK updated the summary of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:25
teamcity updated the summary of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:23
PiRK requested review of D9245: Convert wallet to new serialization.
Feb 18 2021, 07:23
teamcity updated the summary of D9244: Convert Qt to new serialization.
Feb 18 2021, 07:23
PiRK requested review of D9244: Convert Qt to new serialization.
Feb 18 2021, 07:22
PiRK retitled D9236: wallet: descriptor wallet cleanups from wallet: descriptor wallet release notes and cleanups to wallet: descriptor wallet cleanups.
Feb 18 2021, 07:05
abc-bot committed rABCa0f63989f10e: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Feb 18 2021, 04:18
abc-bot committed rABC0dbb1d38cd78: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Feb 18 2021, 03:17