Thu, Apr 29
Remove commented out import
Update the error message
I conclude from the lack of answer that there is actually no reason to initialize the struct where it is.
I don't see any reason this patch should exists, and the description provides none.
Wed, Apr 28
We changed the convention recently, because now we have multiple repos to backport from (core, gui and secp256k1) : D9258
Can you use the common denomination for backports, so that this can be grepped for? I just realized that I greened several of these, I shouldn't have. This is making keeping track of things in git pretty much impossible.
improve the test that adds variables sized proofs to actually check that the number of proofs and number of stakes are exactly as expected.
Tue, Apr 27
Use Decimal in the functional test.
Use a more plausible stake of 10 million coins in the unit test. The test should still fail less than once every 2 or 3 years if we assume 100 runs per day.
I'm going to green this for the sake of progress and this is fairly contained, but I think there are still problems in the API.
corrected missing line between functions, made testPastActivation static
Rebase. The test failure is an unrelated failure in a leveldb unit test. It is a rare intermittent failure (see D6751).
Mon, Apr 26
The approach looks sensible, but there are no test for anything. It seems like this does too little to constitute a unit.
The test are not passing.
Why does this depends on D9365 . It seems to me that verifying that the delegation is correct isn't really something that depends on being able to supply it. If anything, it should be done no matter what.
Allow useEffect call to update savedWallets list in Configure.js; do not call it twice with the previous wallet