Page MenuHomePhabricator
Feed All Stories

Thu, Apr 29

Joey King <joseph.roy.king@gmail.com> committed rABC93d59c134415: [Cashtab] bug fix in utxo diff check (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] bug fix in utxo diff check
Thu, Apr 29, 15:00
josephroyking abandoned D9458: [Cashtab] Remove largest npm bundles and bug fix.
Thu, Apr 29, 15:00
majcosta accepted D9459: [Cashtab] bug fix in utxo diff check.
Thu, Apr 29, 14:55
josephroyking requested review of D9459: [Cashtab] bug fix in utxo diff check.
Thu, Apr 29, 14:48
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.
Thu, Apr 29, 14:20
josephroyking updated the diff for D9458: [Cashtab] Remove largest npm bundles and bug fix.

Remove commented out import

Thu, Apr 29, 13:23
josephroyking requested review of D9458: [Cashtab] Remove largest npm bundles and bug fix.
Thu, Apr 29, 13:19
Fabien updated the diff for D9365: [avalanche] Add an option to import a delegation.

Update the error message

Thu, Apr 29, 12:45
deadalnix requested changes to D9425: [avalanche] add an OrphanProofPool class.
Thu, Apr 29, 12:16
PiRK added inline comments to D9369: [avalanche] implement a proof relay struct.
Thu, Apr 29, 12:13
PiRK closed D9457: refactor: Drop ::HasWallets().
Thu, Apr 29, 11:58
PiRK committed rABCd66b0479d499: refactor: Drop ::HasWallets() (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
refactor: Drop ::HasWallets()
Thu, Apr 29, 11:57
deadalnix requested changes to D9369: [avalanche] implement a proof relay struct.

I conclude from the lack of answer that there is actually no reason to initialize the struct where it is.

Thu, Apr 29, 11:57
PiRK closed D9456: refactor: Remove unused request.fHelp.
Thu, Apr 29, 11:57
PiRK committed rABCb8f1ee76929b: refactor: Remove unused request.fHelp (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Remove unused request.fHelp
Thu, Apr 29, 11:57
deadalnix accepted D9453: Ensure Axion can be reactivated consistently in abc_mining_basic.
Thu, Apr 29, 11:56
deadalnix requested changes to D9454: [avalanche] Fail to delegate to self.

I don't see any reason this patch should exists, and the description provides none.

Thu, Apr 29, 11:56
PiRK closed D9455: wallet: Make RPC help compile-time static.
Thu, Apr 29, 11:55
PiRK committed rABC1a57c26881e3: wallet: Make RPC help compile-time static (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Make RPC help compile-time static
Thu, Apr 29, 11:55
PiRK closed D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.
Thu, Apr 29, 11:54
PiRK committed rABC51c94b782d08: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable… (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable…
Thu, Apr 29, 11:54
deadalnix accepted D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.
Thu, Apr 29, 11:49
Joey King <joseph.roy.king@gmail.com> closed D9451: [Cashtab] Use wallet.state for balance on Send screen.
Thu, Apr 29, 11:37
Joey King <joseph.roy.king@gmail.com> committed rABCc32043f396be: [Cashtab] Use wallet.state for balance on Send screen (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Use wallet.state for balance on Send screen
Thu, Apr 29, 11:37
Fabien accepted D9457: refactor: Drop ::HasWallets().
Thu, Apr 29, 07:45
Fabien accepted D9456: refactor: Remove unused request.fHelp.
Thu, Apr 29, 07:43
Fabien accepted D9455: wallet: Make RPC help compile-time static.
Thu, Apr 29, 07:37
Fabien accepted D9451: [Cashtab] Use wallet.state for balance on Send screen.
Thu, Apr 29, 07:19
abc-bot committed rABCe41dcedf767e: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Thu, Apr 29, 03:20
abc-bot committed rABC769b3cc423c2: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Thu, Apr 29, 02:13
abc-bot committed rABC52f2dd665bd5: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Thu, Apr 29, 02:06

Wed, Apr 28

teamcity updated the summary of D9457: refactor: Drop ::HasWallets().
Wed, Apr 28, 20:38
PiRK requested review of D9457: refactor: Drop ::HasWallets().
Wed, Apr 28, 20:37
teamcity updated the summary of D9456: refactor: Remove unused request.fHelp.
Wed, Apr 28, 20:36
PiRK requested review of D9456: refactor: Remove unused request.fHelp.
Wed, Apr 28, 20:36
teamcity updated the summary of D9455: wallet: Make RPC help compile-time static.
Wed, Apr 28, 20:33
PiRK requested review of D9455: wallet: Make RPC help compile-time static.
Wed, Apr 28, 20:33
Fabien requested review of D9454: [avalanche] Fail to delegate to self.
Wed, Apr 28, 19:37
PiRK requested review of D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.

We changed the convention recently, because now we have multiple repos to backport from (core, gui and secp256k1) : D9258

Wed, Apr 28, 18:57
jasonbcox updated the test plan for D9453: Ensure Axion can be reactivated consistently in abc_mining_basic.
Wed, Apr 28, 18:54
jasonbcox requested review of D9453: Ensure Axion can be reactivated consistently in abc_mining_basic.
Wed, Apr 28, 18:52
jasonbcox closed D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 28, 17:00
jasonbcox committed rABC4b89a7a531f9: Fix minerfund in GBT when cashaddr is disabled (authored by jasonbcox).
Fix minerfund in GBT when cashaddr is disabled
Wed, Apr 28, 16:59
deadalnix requested changes to D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.

Can you use the common denomination for backports, so that this can be grepped for? I just realized that I greened several of these, I shouldn't have. This is making keeping track of things in git pretty much impossible.

Wed, Apr 28, 15:55
teamcity updated the summary of D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.
Wed, Apr 28, 15:49
PiRK requested review of D9452: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions.
Wed, Apr 28, 15:49
PiRK updated the diff for D9425: [avalanche] add an OrphanProofPool class.

improve the test that adds variables sized proofs to actually check that the number of proofs and number of stakes are exactly as expected.

Wed, Apr 28, 13:36
sellmyhousealabama updated sellmyhousealabama.
Wed, Apr 28, 12:53
josephroyking requested review of D9451: [Cashtab] Use wallet.state for balance on Send screen.
Wed, Apr 28, 12:43
PiRK closed D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 28, 09:15
PiRK committed rABC6bcc0e609cb0: [avalanche] set a minimum amount for a proof (authored by PiRK).
[avalanche] set a minimum amount for a proof
Wed, Apr 28, 09:15
micalwilson updated micalwilson.
Wed, Apr 28, 06:14

Tue, Apr 27

deadalnix added inline comments to D9345: [avalanche] set a minimum amount for a proof.
Tue, Apr 27, 22:16
deadalnix accepted D9345: [avalanche] set a minimum amount for a proof.
Tue, Apr 27, 22:15
PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

Use Decimal in the functional test.
Use a more plausible stake of 10 million coins in the unit test. The test should still fail less than once every 2 or 3 years if we assume 100 runs per day.

Tue, Apr 27, 19:35
PiRK closed D9450: refactor: Use Mutex type for some mutexes in CNode class.
Tue, Apr 27, 17:38
PiRK committed rABC7ae0a8a18881: refactor: Use Mutex type for some mutexes in CNode class (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Use Mutex type for some mutexes in CNode class
Tue, Apr 27, 17:38
PiRK closed D9449: refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp.
Tue, Apr 27, 17:32
PiRK committed rABC19cb47be44e1: refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp
Tue, Apr 27, 17:31
PiRK closed D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Tue, Apr 27, 17:20
PiRK committed rABCcbf849a1c177: refactor: Use Mutex type for g_cs_recent_confirmed_transactions (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Use Mutex type for g_cs_recent_confirmed_transactions
Tue, Apr 27, 17:20
PiRK closed D9441: [avalanche] improve stake generation in functional test.
Tue, Apr 27, 17:11
PiRK committed rABC6aba8b30bd60: [avalanche] improve stake generation in functional test (authored by PiRK).
[avalanche] improve stake generation in functional test
Tue, Apr 27, 17:10
Joey King <joseph.roy.king@gmail.com> closed D9443: [Cashtab] load wallet from storage before calling API.
Tue, Apr 27, 15:40
Joey King <joseph.roy.king@gmail.com> committed rABCb612be7f9aec: [Cashtab] load wallet from storage before calling API (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] load wallet from storage before calling API
Tue, Apr 27, 15:39
Fabien accepted D9443: [Cashtab] load wallet from storage before calling API.
Tue, Apr 27, 15:30
majcosta closed D9444: [refactor] extract function for past activation tests.
Tue, Apr 27, 15:24
majcosta committed rABCd7f5657808e3: [refactor] extract function for past activation tests (authored by majcosta).
[refactor] extract function for past activation tests
Tue, Apr 27, 15:24
majcosta accepted D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Tue, Apr 27, 15:21
deadalnix accepted D9441: [avalanche] improve stake generation in functional test.

I'm going to green this for the sake of progress and this is fairly contained, but I think there are still problems in the API.

Tue, Apr 27, 15:20
deadalnix accepted D9449: refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp.
Tue, Apr 27, 15:19
deadalnix accepted D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Tue, Apr 27, 15:18
deadalnix accepted D9450: refactor: Use Mutex type for some mutexes in CNode class.
Tue, Apr 27, 15:17
deadalnix accepted D9444: [refactor] extract function for past activation tests.
Tue, Apr 27, 15:17
teamcity updated the summary of D9450: refactor: Use Mutex type for some mutexes in CNode class.
Tue, Apr 27, 14:06
PiRK requested review of D9450: refactor: Use Mutex type for some mutexes in CNode class.
Tue, Apr 27, 14:06
teamcity updated the summary of D9449: refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp.
Tue, Apr 27, 14:01
PiRK requested review of D9449: refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp.
Tue, Apr 27, 14:00
teamcity updated the summary of D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Tue, Apr 27, 13:33
PiRK requested review of D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Tue, Apr 27, 13:33
judithnoland915 updated judithnoland915.
Tue, Apr 27, 12:06
majcosta updated the diff for D9444: [refactor] extract function for past activation tests.

corrected missing line between functions, made testPastActivation static

Tue, Apr 27, 10:58
PiRK updated the diff for D9441: [avalanche] improve stake generation in functional test.

Rebase. The test failure is an unrelated failure in a leveldb unit test. It is a rare intermittent failure (see D6751).

Tue, Apr 27, 06:56

Mon, Apr 26

Mengerian closed D9446: [website] Remove link to splitbch.com coin splitting service..
Mon, Apr 26, 22:07
Mengerian committed rABCWEB3ab4cc5f11e7: [website] Remove link to splitbch.com coin splitting service. (authored by Mengerian).
[website] Remove link to splitbch.com coin splitting service.
Mon, Apr 26, 22:07
Mengerian updated the diff for D9446: [website] Remove link to splitbch.com coin splitting service..

Rebase

Mon, Apr 26, 22:05
Mengerian closed D9447: [website] Add warning about coin splitting scams.
Mon, Apr 26, 22:01
Mengerian committed rABCWEB39a6d3b0d7e2: [website] Add warning about coin splitting scams (authored by Mengerian).
[website] Add warning about coin splitting scams
Mon, Apr 26, 22:01
josephroyking accepted D9447: [website] Add warning about coin splitting scams.
Mon, Apr 26, 21:47
Mengerian requested review of D9447: [website] Add warning about coin splitting scams.
Mon, Apr 26, 21:41
deadalnix added a comment to D9369: [avalanche] implement a proof relay struct.

The approach looks sensible, but there are no test for anything. It seems like this does too little to constitute a unit.

Mon, Apr 26, 21:33
deadalnix accepted D9446: [website] Remove link to splitbch.com coin splitting service..
Mon, Apr 26, 21:28
deadalnix accepted D9414: Fix minerfund in GBT when cashaddr is disabled.
Mon, Apr 26, 21:28
deadalnix requested changes to D9441: [avalanche] improve stake generation in functional test.

The test are not passing.

Mon, Apr 26, 21:27
deadalnix requested changes to D9445: [avalanche] Check the delegation generated at startup is valid.

Why does this depends on D9365 . It seems to me that verifying that the delegation is correct isn't really something that depends on being able to supply it. If anything, it should be done no matter what.

Mon, Apr 26, 21:24
Mengerian requested review of D9446: [website] Remove link to splitbch.com coin splitting service..
Mon, Apr 26, 21:08
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Mon, Apr 26, 21:03
deadalnix requested changes to D9444: [refactor] extract function for past activation tests.
Mon, Apr 26, 20:57
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.
Mon, Apr 26, 20:56
josephroyking updated the diff for D9443: [Cashtab] load wallet from storage before calling API.

Allow useEffect call to update savedWallets list in Configure.js; do not call it twice with the previous wallet

Mon, Apr 26, 20:16