Page MenuHomePhabricator
Feed All Stories

Jun 6 2021

majcosta updated the summary of D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 19:14
tobias_ruck closed D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 17:16
tobias_ruck committed rABC27d01668269f: Add FormatSubVersionUserAgent. (authored by tobias_ruck).
Add FormatSubVersionUserAgent.
Jun 6 2021, 17:16
deadalnix requested changes to D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).
Jun 6 2021, 14:25
deadalnix added a comment to D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).

This honestly seems like a step backward. The thing throws JSONRPC errors, so that most certainly belong in the RPC stack.

Jun 6 2021, 14:25
deadalnix accepted D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 14:23
tobias_ruck requested review of D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 12:54
majcosta updated the diff for D9636: [testing] enable '-ecash' only on tests that use it.

rebase

Jun 6 2021, 10:15
majcosta updated the diff for D9636: [testing] enable '-ecash' only on tests that use it.

that flakiness in script_tests.cpp is unrelated, restarting build

Jun 6 2021, 09:35
teamcity added a comment to D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 09:31
majcosta updated the diff for D9636: [testing] enable '-ecash' only on tests that use it.

fixed feature_notifications.py without wallet

Jun 6 2021, 09:27
teamcity added a comment to D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 09:14
majcosta updated the summary of D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 09:07
majcosta updated the diff for D9636: [testing] enable '-ecash' only on tests that use it.

Depends on D9635

Jun 6 2021, 09:07
teamcity added a comment to D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 09:01
majcosta requested review of D9636: [testing] enable '-ecash' only on tests that use it.
Jun 6 2021, 08:53
majcosta requested review of D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).
Jun 6 2021, 06:01

Jun 5 2021

Fabien closed D9634: [avalanche] Fix threading issue in processor_tests.cpp.
Jun 5 2021, 07:00
Fabien committed rABC13e9dcd14d5a: [avalanche] Fix threading issue in processor_tests.cpp (authored by Fabien).
[avalanche] Fix threading issue in processor_tests.cpp
Jun 5 2021, 07:00

Jun 4 2021

deadalnix abandoned D9633: Fix threading issue in processor_tests.cpp.

Abandoning in favor of D9634

Jun 4 2021, 20:46
deadalnix accepted D9634: [avalanche] Fix threading issue in processor_tests.cpp.
Jun 4 2021, 20:46
teamcity closed T1640: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jun 4 2021, 20:13
Fabien added a comment to D9633: Fix threading issue in processor_tests.cpp.

Please consider D9634 for an alternative solution

Jun 4 2021, 20:03
Fabien planned changes to D9365: [avalanche] Add an option to import a delegation.
Jun 4 2021, 20:02
Fabien planned changes to D9445: [avalanche] Check the delegation generated at startup is valid.
Jun 4 2021, 20:01
Fabien abandoned D9454: [avalanche] Fail to delegate to self.
Jun 4 2021, 20:01
Fabien planned changes to D9471: [avalanche] Improve proof checking at startup.
Jun 4 2021, 20:00
Fabien abandoned D9499: [avalanche] Reverse cs_main and cs_peerManager lock order.

Hopefully this won't be needed anymore

Jun 4 2021, 19:59
Fabien planned changes to D9489: [avalanche] Annouce our proofs to our peers.
Jun 4 2021, 19:59
Fabien planned changes to D9492: [avalanche] Add a sendavalancheproof RPC shell.
Jun 4 2021, 19:58
Fabien planned changes to D9493: [avalanche] Prevent sending proof invs multiple times to the same peer.
Jun 4 2021, 19:57
Fabien abandoned D9498: [avalanche] Reply to proof invs with getdata requests.

superseded by D9582

Jun 4 2021, 19:56
Fabien abandoned D9517: Use state pointer in SendMessages.
Jun 4 2021, 19:54
Fabien abandoned D9518: Lock cs_main in SendMessages where it's needed.
Jun 4 2021, 19:54
Fabien closed D9627: [avalanche] Download the proof from our peers that send avahello.
Jun 4 2021, 19:51
Fabien committed rABC359045064944: [avalanche] Download the proof from our peers that send avahello (authored by Fabien).
[avalanche] Download the proof from our peers that send avahello
Jun 4 2021, 19:51
Fabien closed D9625: [avalanche] Add a facility to check if a peer is preferred for DL.
Jun 4 2021, 19:48
Fabien committed rABC9f241cc79d56: [avalanche] Add a facility to check if a peer is preferred for DL (authored by Fabien).
[avalanche] Add a facility to check if a peer is preferred for DL
Jun 4 2021, 19:48
Fabien closed D9600: [avalanche] Reset the proof tracking state on peer disconnection.
Jun 4 2021, 19:40
Fabien committed rABCd596bf6c8e22: [avalanche] Reset the proof tracking state on peer disconnection (authored by Fabien).
[avalanche] Reset the proof tracking state on peer disconnection
Jun 4 2021, 19:40
Fabien closed D9599: [avalanche] Manage the notfound messages from a proof request.
Jun 4 2021, 19:36
Fabien committed rABCd86ccb5a2564: [avalanche] Manage the notfound messages from a proof request (authored by Fabien).
[avalanche] Manage the notfound messages from a proof request
Jun 4 2021, 19:36
Fabien closed D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 4 2021, 19:34
Fabien committed rABCcef8cbca39d8: [avalanche] Answer proof invs with getdata proof requests (authored by Fabien).
[avalanche] Answer proof invs with getdata proof requests
Jun 4 2021, 19:34
teamcity awarded D9634: [avalanche] Fix threading issue in processor_tests.cpp a Haypence token.
Jun 4 2021, 19:33
Fabien added a task to D9634: [avalanche] Fix threading issue in processor_tests.cpp: Unknown Object (Maniphest Task).
Jun 4 2021, 19:32
Fabien added a comment to D9634: [avalanche] Fix threading issue in processor_tests.cpp.

@bot build-tsan

Jun 4 2021, 19:32
Fabien requested review of D9634: [avalanche] Fix threading issue in processor_tests.cpp.
Jun 4 2021, 19:32
majcosta accepted D9632: Split SetWalletFlags into Add/LoadWalletFlags.
Jun 4 2021, 19:29
majcosta accepted D9631: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan.
Jun 4 2021, 19:20
majcosta accepted D9630: Split SetHDChain into AddHDChain and LoadHDChain.
Jun 4 2021, 19:09
Mengerian added a task to D9600: [avalanche] Reset the proof tracking state on peer disconnection: Unknown Object (Maniphest Task).
Jun 4 2021, 17:23
Mengerian added a task to D9599: [avalanche] Manage the notfound messages from a proof request: Unknown Object (Maniphest Task).
Jun 4 2021, 17:22
teamcity added a comment to D9633: Fix threading issue in processor_tests.cpp.
Jun 4 2021, 17:02
teamcity added a comment to D9633: Fix threading issue in processor_tests.cpp.
Jun 4 2021, 16:54
deadalnix accepted D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 4 2021, 16:50
deadalnix updated the diff for D9633: Fix threading issue in processor_tests.cpp.

rebase

Jun 4 2021, 16:49
deadalnix requested review of D9633: Fix threading issue in processor_tests.cpp.
Jun 4 2021, 16:43
PiRK closed D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 4 2021, 15:57
PiRK committed rABC97ecb320bde4: [avalanche] make delegateavalancheproof take a limited id rather than a whole… (authored by PiRK).
[avalanche] make delegateavalancheproof take a limited id rather than a whole…
Jun 4 2021, 15:57
teamcity updated the summary of D9632: Split SetWalletFlags into Add/LoadWalletFlags.
Jun 4 2021, 15:56
PiRK requested review of D9632: Split SetWalletFlags into Add/LoadWalletFlags.
Jun 4 2021, 15:55
teamcity updated the summary of D9631: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan.
Jun 4 2021, 15:52
PiRK requested review of D9631: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan.
Jun 4 2021, 15:52
teamcity updated the summary of D9630: Split SetHDChain into AddHDChain and LoadHDChain.
Jun 4 2021, 15:49
PiRK requested review of D9630: Split SetHDChain into AddHDChain and LoadHDChain.
Jun 4 2021, 15:48
teamcity triaged T1640: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jun 4 2021, 15:26
tobias_ruck added a comment to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

So what should I do instead

Jun 4 2021, 15:12
deadalnix closed D9476: [avalanche] use the OrphanProofPool.
Jun 4 2021, 15:07
deadalnix committed rABCc565a795866a: [avalanche] use the OrphanProofPool (authored by PiRK).
[avalanche] use the OrphanProofPool
Jun 4 2021, 15:07
deadalnix closed D9629: Use smart pointer in the orphan proof pool.
Jun 4 2021, 14:53
deadalnix committed rABCa53677be459f: Use smart pointer in the orphan proof pool (authored by deadalnix).
Use smart pointer in the orphan proof pool
Jun 4 2021, 14:53
Fabien accepted D9629: Use smart pointer in the orphan proof pool.
Jun 4 2021, 14:50
deadalnix updated the diff for D9476: [avalanche] use the OrphanProofPool.

Rebase on top of D9629

Jun 4 2021, 14:50
deadalnix requested review of D9629: Use smart pointer in the orphan proof pool.
Jun 4 2021, 14:39
deadalnix accepted D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 4 2021, 14:29
Fabien accepted D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 4 2021, 12:08
Fabien closed D9608: [avalanche] Add an avaproof network permission for bypassing the inv tracking limit.
Jun 4 2021, 11:57
Fabien committed rABC38e511b2b8ea: [avalanche] Add an avaproof network permission for bypassing the inv tracking… (authored by Fabien).
[avalanche] Add an avaproof network permission for bypassing the inv tracking…
Jun 4 2021, 11:57
Fabien requested review of D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 4 2021, 11:54
Fabien accepted D9476: [avalanche] use the OrphanProofPool.

OK let's move on with this. Since the orphan proof is always accessed through the peer manager (tests excepted) if this become an issue it should be cheap enough to refactor.

Jun 4 2021, 11:49
PiRK updated the diff for D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.

use std::make_unique

Jun 4 2021, 11:06
deadalnix requested changes to D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 4 2021, 10:12
deadalnix accepted D9608: [avalanche] Add an avaproof network permission for bypassing the inv tracking limit.
Jun 4 2021, 10:02
deadalnix requested changes to D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 4 2021, 10:01
deadalnix requested changes to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

This breaks the -uacomment flag.

Jun 4 2021, 09:59
deadalnix added inline comments to D9476: [avalanche] use the OrphanProofPool.
Jun 4 2021, 09:57
PiRK updated the diff for D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.

factor the initialization using constructor delegation with a private constructor.

Jun 4 2021, 08:38
tobias_ruck requested review of D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 4 2021, 02:37

Jun 3 2021

Mengerian added a task to D9627: [avalanche] Download the proof from our peers that send avahello: Unknown Object (Maniphest Task).
Jun 3 2021, 18:24
Mengerian added a task to D9625: [avalanche] Add a facility to check if a peer is preferred for DL: Unknown Object (Maniphest Task).
Jun 3 2021, 18:23
Mengerian added a task to D9608: [avalanche] Add an avaproof network permission for bypassing the inv tracking limit: Unknown Object (Maniphest Task).
Jun 3 2021, 18:23
Mengerian added a task to D9598: Extract inv saturation check and data request time computation: Unknown Object (Maniphest Task).
Jun 3 2021, 18:23
PiRK abandoned D9571: Don't penalize peers for unsollicited avalanche messages, just ignore them.
Jun 3 2021, 16:44
teamcity closed T1639: Build Bitcoin-ABC / Master / Benchmarking is broken. as Resolved.
Jun 3 2021, 16:31
Fabien requested changes to D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 3 2021, 16:16
Fabien committed rABC2d558c27cda8: Update the unspendable address in the wallet test lib (authored by Fabien).
Update the unspendable address in the wallet test lib
Jun 3 2021, 15:56
Fabien closed D9623: Remove wallet related constant from the mining util test lib.
Jun 3 2021, 15:55
Fabien committed rABCb7bb766e5316: Remove wallet related constant from the mining util test lib (authored by Fabien).
Remove wallet related constant from the mining util test lib
Jun 3 2021, 15:55
Fabien added inline comments to D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 3 2021, 15:51