Page MenuHomePhabricator
Feed All Stories

Wed, Jun 9

Fabien closed D9643: [avalanche] Keep track of the peer creation time.
Wed, Jun 9, 07:35
Fabien committed rABC963d2d852a3a: [avalanche] Keep track of the peer creation time (authored by Fabien).
[avalanche] Keep track of the peer creation time
Wed, Jun 9, 07:35
Fabien closed D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Wed, Jun 9, 07:34
Fabien committed rABC8ee560a6dec6: [avalanche] Keep a rolling bloom filter of our recently announced proofs (authored by Fabien).
[avalanche] Keep a rolling bloom filter of our recently announced proofs
Wed, Jun 9, 07:34

Tue, Jun 8

majcosta abandoned D9636: [testing] enable '-ecash' only on tests that use it.

you're right, this is not good

Tue, Jun 8, 21:01
deadalnix accepted D9492: [avalanche] Add a sendavalancheproof RPC shell.
Tue, Jun 8, 15:29
deadalnix requested changes to D9628: Add -uaclient config option to set the client name and version of the user agent in the version message..
Tue, Jun 8, 15:29
Fabien added a comment to D9650: [avalanche] Send proof inventories.

Note to reviewers:
This supersedes D9489 and D9493. I deliberately chose to not split apart the filtering of the peer's known proof (was D9493) because in the end I don't think it makes the review easier, but quite the opposite. By keeping it together with the inv message sending it makes it easier to compare with what is done for the proofs invs.
The broadcasting feature detailed in D9489 will be added in another diff.

Tue, Jun 8, 15:22
Fabien requested review of D9650: [avalanche] Send proof inventories.
Tue, Jun 8, 15:19
PiRK accepted D9646: [avalanche] Extract a proof verification facility from the RPC.
Tue, Jun 8, 15:19
PiRK accepted D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Tue, Jun 8, 15:17
PiRK accepted D9648: [avalanche] Add a facility to check if avalanche is enabled.
Tue, Jun 8, 15:15
PiRK accepted D9647: [avalanche] Move the global definitions into their own header.
Tue, Jun 8, 15:14
Fabien updated the diff for D9492: [avalanche] Add a sendavalancheproof RPC shell.

Rebase on top of D9648, make it an empty shell for now

Tue, Jun 8, 15:07
Fabien retitled D9492: [avalanche] Add a sendavalancheproof RPC shell from [avalanche] Add a sendavalancheproof RPC to broadcast a proof to [avalanche] Add a sendavalancheproof RPC shell.
Tue, Jun 8, 15:04
Fabien added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.

Unrelated failure, I am out of luck today

Tue, Jun 8, 14:21
teamcity added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Tue, Jun 8, 14:17
Fabien updated the diff for D9646: [avalanche] Extract a proof verification facility from the RPC.

Rebase on D9649 to get more factorized code

Tue, Jun 8, 14:15
Fabien updated the summary of D9646: [avalanche] Extract a proof verification facility from the RPC.
Tue, Jun 8, 14:14
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.

Confused with another diff

Tue, Jun 8, 14:14
Fabien requested review of D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Tue, Jun 8, 14:10
Fabien planned changes to D9648: [avalanche] Add a facility to check if avalanche is enabled.
Tue, Jun 8, 13:59
Fabien added a comment to D9647: [avalanche] Move the global definitions into their own header.

Unrelated spurious processor_tests failure. I managed to reproduce by chance on my machine and I have a core dump to debug on now

Tue, Jun 8, 13:33
Fabien added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.

Unrelated failure

Tue, Jun 8, 13:32
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.
Tue, Jun 8, 13:32
teamcity added a comment to D9647: [avalanche] Move the global definitions into their own header.
Tue, Jun 8, 13:14
Fabien requested review of D9647: [avalanche] Move the global definitions into their own header.
Tue, Jun 8, 13:11
PiRK accepted D9644: [avalanche] Send avalanche proofs upon request.
Tue, Jun 8, 12:55
teamcity added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.
Tue, Jun 8, 12:47
Fabien requested review of D9646: [avalanche] Extract a proof verification facility from the RPC.
Tue, Jun 8, 12:40
PiRK accepted D9643: [avalanche] Keep track of the peer creation time.
Tue, Jun 8, 12:38
Fabien closed D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.
Tue, Jun 8, 11:43
Fabien committed rABCa1601abf3f0e: [CMAKE] Hint to user to the option flags when an optional dependency is not… (authored by Fabien).
[CMAKE] Hint to user to the option flags when an optional dependency is not…
Tue, Jun 8, 11:43
deadalnix accepted D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.

likestamp

Tue, Jun 8, 10:26
Fabien requested review of D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.
Tue, Jun 8, 09:32
PiRK accepted D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Tue, Jun 8, 08:09
PiRK closed D9079: walletdb: Remove unused static functions from walletdb.h.
Tue, Jun 8, 08:07
PiRK committed rABC1d26b7dbb65d: walletdb: Remove unused static functions from walletdb.h (authored by Andrew Chow <achow101-github@achow101.com>).
walletdb: Remove unused static functions from walletdb.h
Tue, Jun 8, 08:07
PiRK closed D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Tue, Jun 8, 08:06
PiRK committed rABCd37ccaecae8f: wallettool: Have RecoverDatabaseFile return errors and warnings (authored by Andrew Chow <achow101-github@achow101.com>).
wallettool: Have RecoverDatabaseFile return errors and warnings
Tue, Jun 8, 08:06
PiRK closed D9640: walletdb: Don't remove database transaction logs and instead error.
Tue, Jun 8, 08:05
PiRK committed rABC7e286043e41a: walletdb: Don't remove database transaction logs and instead error (authored by Andrew Chow <achow101-github@achow101.com>).
walletdb: Don't remove database transaction logs and instead error
Tue, Jun 8, 08:05
PiRK closed D9639: Call RecoverDatabaseFile directly from wallettool.
Tue, Jun 8, 08:00
PiRK committed rABC11d97206b17a: Call RecoverDatabaseFile directly from wallettool (authored by Andrew Chow <achow101-github@achow101.com>).
Call RecoverDatabaseFile directly from wallettool
Tue, Jun 8, 08:00

Mon, Jun 7

Fabien requested review of D9644: [avalanche] Send avalanche proofs upon request.
Mon, Jun 7, 21:17
Fabien updated the diff for D9643: [avalanche] Keep track of the peer creation time.

Use the right clock for the job

Mon, Jun 7, 20:49
Mengerian added a comment to D9628: Add -uaclient config option to set the client name and version of the user agent in the version message..

Why not have two flags that can be set, -uaclientname, and -uaclientversion ?

Mon, Jun 7, 20:35
tobias_ruck updated the diff for D9628: Add -uaclient config option to set the client name and version of the user agent in the version message..

Changed FormatSubVersion to FormatUserAgent and solely use FormatSubVersionUserAgent now

Mon, Jun 7, 19:56
Fabien planned changes to D9643: [avalanche] Keep track of the peer creation time.
Mon, Jun 7, 19:50
majcosta closed D9638: [refactor] deduplicate AmountFromValue.
Mon, Jun 7, 18:11
majcosta committed rABC8a9f470950c1: [refactor] deduplicate AmountFromValue (authored by majcosta).
[refactor] deduplicate AmountFromValue
Mon, Jun 7, 18:11
Fabien added inline comments to D9643: [avalanche] Keep track of the peer creation time.
Mon, Jun 7, 16:37
Fabien accepted D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 16:36
Fabien accepted D9640: walletdb: Don't remove database transaction logs and instead error.
Mon, Jun 7, 16:34
Fabien accepted D9639: Call RecoverDatabaseFile directly from wallettool.
Mon, Jun 7, 16:31
Fabien accepted D9079: walletdb: Remove unused static functions from walletdb.h.
Mon, Jun 7, 16:30
Fabien requested review of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.

I don't know what caused the failure, I couldn't reproduce in a 100 loop on a similar debian, nor did it reproduce on CI.

Mon, Jun 7, 15:07
Fabien added a comment to D9643: [avalanche] Keep track of the peer creation time.

Added the rational in the diff summary

Mon, Jun 7, 15:07
Fabien updated the summary of D9643: [avalanche] Keep track of the peer creation time.
Mon, Jun 7, 15:06
Fabien updated the summary of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Mon, Jun 7, 15:03
deadalnix added a comment to D9643: [avalanche] Keep track of the peer creation time.

Why?

Mon, Jun 7, 14:51
Fabien planned changes to D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.

Investigating the build failure

Mon, Jun 7, 14:45
teamcity added a comment to D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Mon, Jun 7, 14:43
Fabien requested review of D9643: [avalanche] Keep track of the peer creation time.
Mon, Jun 7, 14:43
Fabien requested review of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Mon, Jun 7, 14:40
deadalnix requested changes to D9628: Add -uaclient config option to set the client name and version of the user agent in the version message..
Mon, Jun 7, 09:50
teamcity added a comment to D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 08:25
PiRK updated the diff for D9639: Call RecoverDatabaseFile directly from wallettool.

rebase (unrelated failure)

Mon, Jun 7, 08:21
PiRK updated the diff for D9079: walletdb: Remove unused static functions from walletdb.h.

rebase to fix clang failure

Mon, Jun 7, 08:20
PiRK updated the diff for D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.

fix clang warning

Mon, Jun 7, 08:18
teamcity added a comment to D9079: walletdb: Remove unused static functions from walletdb.h.
Mon, Jun 7, 08:12
teamcity added a comment to D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 08:04
teamcity added a comment to D9639: Call RecoverDatabaseFile directly from wallettool.
Mon, Jun 7, 07:58
iberiaflightcancellation updated iberiaflightcancellation.
Mon, Jun 7, 07:58
PiRK updated the diff for D9079: walletdb: Remove unused static functions from walletdb.h.

rebase onto D9639, D9640 and D9641 to finally finish this.

Mon, Jun 7, 07:57
PiRK updated the summary of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 07:53
teamcity updated the summary of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 07:53
PiRK requested review of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Mon, Jun 7, 07:53
teamcity updated the summary of D9640: walletdb: Don't remove database transaction logs and instead error.
Mon, Jun 7, 07:52
PiRK requested review of D9640: walletdb: Don't remove database transaction logs and instead error.
Mon, Jun 7, 07:51
teamcity updated the summary of D9639: Call RecoverDatabaseFile directly from wallettool.
Mon, Jun 7, 07:50
PiRK requested review of D9639: Call RecoverDatabaseFile directly from wallettool.
Mon, Jun 7, 07:49
PiRK updated the summary of D9079: walletdb: Remove unused static functions from walletdb.h.
Mon, Jun 7, 07:48
PiRK closed D9632: Split SetWalletFlags into Add/LoadWalletFlags.
Mon, Jun 7, 06:58
PiRK committed rABC4b6a468d3eb8: Split SetWalletFlags into Add/LoadWalletFlags (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetWalletFlags into Add/LoadWalletFlags
Mon, Jun 7, 06:58
PiRK closed D9631: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan.
Mon, Jun 7, 06:57
PiRK committed rABCfee8cf69cb67: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan
Mon, Jun 7, 06:57
PiRK closed D9630: Split SetHDChain into AddHDChain and LoadHDChain.
Mon, Jun 7, 06:53
PiRK committed rABC1147f7663bec: Split SetHDChain into AddHDChain and LoadHDChain (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetHDChain into AddHDChain and LoadHDChain
Mon, Jun 7, 06:53
Fabien accepted D9638: [refactor] deduplicate AmountFromValue.
Mon, Jun 7, 06:36
Fabien requested changes to D9636: [testing] enable '-ecash' only on tests that use it.

Can you expand a bit of what the problem is from setting the flag globally ? Without more details it's hard to see how having the option repeated in and here in every test is better than setting it once for all.
Also if it increases the test coverage then the tests are wrong, because these tests are not testing the -ecash flag.

Mon, Jun 7, 06:31
rhodesross updated rhodesross.
Mon, Jun 7, 06:00
rhodesross updated rhodesross.
Mon, Jun 7, 05:59

Sun, Jun 6

tobias_ruck retitled D9628: Add -uaclient config option to set the client name and version of the user agent in the version message. from Add -useragent config option to explicitly set the User Agent in the version message. to Add -uaclient config option to set the client name and version of the user agent in the version message..
Sun, Jun 6, 22:03
tobias_ruck updated the diff for D9628: Add -uaclient config option to set the client name and version of the user agent in the version message..

Changed to -uaclient, which sets the client name and version of the user agent, staying compatible with -uacomment

Sun, Jun 6, 22:02
majcosta updated the diff for D9638: [refactor] deduplicate AmountFromValue.

couldn't reproduce this failure. rebasing on latest master.

Sun, Jun 6, 21:06
teamcity added a comment to D9638: [refactor] deduplicate AmountFromValue.
Sun, Jun 6, 20:51
majcosta abandoned D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).

bummer. alright, how about D9638, then?

Sun, Jun 6, 20:44
majcosta requested review of D9638: [refactor] deduplicate AmountFromValue.
Sun, Jun 6, 20:44
majcosta updated the diff for D9636: [testing] enable '-ecash' only on tests that use it.

rebase on master

Sun, Jun 6, 19:15