Feed All Stories
Jun 9 2021
Jun 9 2021
Fabien committed rABC963d2d852a3a: [avalanche] Keep track of the peer creation time (authored by Fabien).
[avalanche] Keep track of the peer creation time
Fabien committed rABC8ee560a6dec6: [avalanche] Keep a rolling bloom filter of our recently announced proofs (authored by Fabien).
[avalanche] Keep a rolling bloom filter of our recently announced proofs
Jun 8 2021
Jun 8 2021
you're right, this is not good
Fabien added a comment to D9650: [avalanche] Send proof inventories.
Note to reviewers:
This supersedes D9489 and D9493. I deliberately chose to not split apart the filtering of the peer's known proof (was D9493) because in the end I don't think it makes the review easier, but quite the opposite. By keeping it together with the inv message sending it makes it easier to compare with what is done for the proofs invs.
The broadcasting feature detailed in D9489 will be added in another diff.
Fabien requested review of D9650: [avalanche] Send proof inventories.
Fabien updated the diff for D9492: [avalanche] Add a sendavalancheproof RPC shell.
Rebase on top of D9648, make it an empty shell for now
Fabien retitled D9492: [avalanche] Add a sendavalancheproof RPC shell from [avalanche] Add a sendavalancheproof RPC to broadcast a proof to [avalanche] Add a sendavalancheproof RPC shell.
Fabien added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Unrelated failure, I am out of luck today
teamcity added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Fabien updated the diff for D9646: [avalanche] Extract a proof verification facility from the RPC.
Rebase on D9649 to get more factorized code
Fabien updated the summary of D9646: [avalanche] Extract a proof verification facility from the RPC.
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.
Confused with another diff
Fabien requested review of D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Fabien planned changes to D9648: [avalanche] Add a facility to check if avalanche is enabled.
Fabien added a comment to D9647: [avalanche] Move the global definitions into their own header.
Unrelated spurious processor_tests failure. I managed to reproduce by chance on my machine and I have a core dump to debug on now
Fabien added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.
Unrelated failure
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.
teamcity added a comment to D9647: [avalanche] Move the global definitions into their own header.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Fabien requested review of D9647: [avalanche] Move the global definitions into their own header.
teamcity added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien requested review of D9646: [avalanche] Extract a proof verification facility from the RPC.
Fabien committed rABCa1601abf3f0e: [CMAKE] Hint to user to the option flags when an optional dependency is not… (authored by Fabien).
[CMAKE] Hint to user to the option flags when an optional dependency is not…
deadalnix accepted D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.
PiRK committed rABC1d26b7dbb65d: walletdb: Remove unused static functions from walletdb.h (authored by Andrew Chow <achow101-github@achow101.com>).
walletdb: Remove unused static functions from walletdb.h
PiRK committed rABCd37ccaecae8f: wallettool: Have RecoverDatabaseFile return errors and warnings (authored by Andrew Chow <achow101-github@achow101.com>).
wallettool: Have RecoverDatabaseFile return errors and warnings
PiRK committed rABC7e286043e41a: walletdb: Don't remove database transaction logs and instead error (authored by Andrew Chow <achow101-github@achow101.com>).
walletdb: Don't remove database transaction logs and instead error
PiRK committed rABC11d97206b17a: Call RecoverDatabaseFile directly from wallettool (authored by Andrew Chow <achow101-github@achow101.com>).
Call RecoverDatabaseFile directly from wallettool
Jun 7 2021
Jun 7 2021
Fabien requested review of D9644: [avalanche] Send avalanche proofs upon request.
Fabien updated the diff for D9643: [avalanche] Keep track of the peer creation time.
Use the right clock for the job
Mengerian added a comment to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Why not have two flags that can be set, -uaclientname, and -uaclientversion ?
tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Changed FormatSubVersion to FormatUserAgent and solely use FormatSubVersionUserAgent now
Fabien planned changes to D9643: [avalanche] Keep track of the peer creation time.
[refactor] deduplicate AmountFromValue
Fabien added inline comments to D9643: [avalanche] Keep track of the peer creation time.
Fabien requested review of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
I don't know what caused the failure, I couldn't reproduce in a 100 loop on a similar debian, nor did it reproduce on CI.
Fabien added a comment to D9643: [avalanche] Keep track of the peer creation time.
Added the rational in the diff summary
Fabien updated the summary of D9643: [avalanche] Keep track of the peer creation time.
Fabien updated the summary of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
deadalnix added a comment to D9643: [avalanche] Keep track of the peer creation time.
Why?
Fabien planned changes to D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Investigating the build failure
teamcity added a comment to D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Fabien requested review of D9643: [avalanche] Keep track of the peer creation time.
Fabien requested review of D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
teamcity added a comment to D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
PiRK updated the diff for D9639: Call RecoverDatabaseFile directly from wallettool.
rebase (unrelated failure)
PiRK updated the diff for D9079: walletdb: Remove unused static functions from walletdb.h.
rebase to fix clang failure
PiRK updated the diff for D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
fix clang warning
teamcity added a comment to D9079: walletdb: Remove unused static functions from walletdb.h.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
teamcity added a comment to D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
teamcity added a comment to D9639: Call RecoverDatabaseFile directly from wallettool.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
PiRK updated the diff for D9079: walletdb: Remove unused static functions from walletdb.h.
PiRK updated the summary of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
teamcity updated the summary of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
PiRK requested review of D9641: wallettool: Have RecoverDatabaseFile return errors and warnings.
teamcity updated the summary of D9640: walletdb: Don't remove database transaction logs and instead error.
PiRK requested review of D9640: walletdb: Don't remove database transaction logs and instead error.
teamcity updated the summary of D9639: Call RecoverDatabaseFile directly from wallettool.
PiRK requested review of D9639: Call RecoverDatabaseFile directly from wallettool.
PiRK updated the summary of D9079: walletdb: Remove unused static functions from walletdb.h.
teamcity triaged T1642: Build Bitcoin-ABC / CashTab / CashTab Components Unit Tests is broken. as Unbreak Now! priority.
teamcity triaged T1641: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
PiRK committed rABC4b6a468d3eb8: Split SetWalletFlags into Add/LoadWalletFlags (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetWalletFlags into Add/LoadWalletFlags
PiRK committed rABCfee8cf69cb67: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan
PiRK committed rABC1147f7663bec: Split SetHDChain into AddHDChain and LoadHDChain (authored by Andrew Chow <achow101-github@achow101.com>).
Split SetHDChain into AddHDChain and LoadHDChain
Fabien requested changes to D9636: [testing] enable '-ecash' only on tests that use it.
Can you expand a bit of what the problem is from setting the flag globally ? Without more details it's hard to see how having the option repeated in and here in every test is better than setting it once for all.
Also if it increases the test coverage then the tests are wrong, because these tests are not testing the -ecash flag.
Jun 6 2021
Jun 6 2021
tobias_ruck retitled D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message. from Add -useragent config option to explicitly set the User Agent in the version message. to Add -uaclient config option to set the client name and version of the user agent in the version message..
tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Changed to -uaclient, which sets the client name and version of the user agent, staying compatible with -uacomment
majcosta updated the diff for D9638: [refactor] deduplicate AmountFromValue.
couldn't reproduce this failure. rebasing on latest master.