Page MenuHomePhabricator
Feed All Stories

Jun 10 2021

Fabien committed rABC6ad142f004a9: [avalanche] Improve proof verification test coverage (authored by Fabien).
[avalanche] Improve proof verification test coverage
Jun 10 2021, 13:16
Fabien closed D9650: [avalanche] Send proof inventories.
Jun 10 2021, 13:16
Fabien committed rABC5794e8338bb8: [avalanche] Send proof inventories (authored by Fabien).
[avalanche] Send proof inventories
Jun 10 2021, 13:16
Fabien closed D9654: Extract out the next inventory send time computation.
Jun 10 2021, 13:15
Fabien committed rABC1aa72ef2ae5d: Extract out the next inventory send time computation (authored by Fabien).
Extract out the next inventory send time computation
Jun 10 2021, 13:15
Fabien requested review of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 12:50
PiRK accepted D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 12:17
PiRK accepted D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 12:15
Fabien requested review of D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 12:09
Fabien requested review of D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 12:05
teamcity triaged T1646: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Jun 10 2021, 10:09
PiRK planned changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 10 2021, 09:52
PiRK updated the diff for D9478: [avalanche] make avalanche peer discovery in a simple case.

rebase on current master
Now this review does not need to implement GetData for proofs any longer. The proof needs to be verified by a local node before it can be requested. There is now a Processor::addProof method, so we can use in in the code handling NetMsgType::AVAPROOF messages to store proofs even if they don't belong to the node sending it (for now we are not looking for the owner to add it, in such a case).

Jun 10 2021, 09:51
majcosta closed D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 09:47
majcosta committed rABC23dc845e6077: [refactor] encapsulate a unit's denomination in a class (authored by majcosta).
[refactor] encapsulate a unit's denomination in a class
Jun 10 2021, 09:47
Fabien accepted D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 09:24
majcosta updated the diff for D9656: [refactor] encapsulate a unit's denomination in a class.

POD'ified Currency, renamed 'unit' to 'baseunit' for clarity

Jun 10 2021, 09:12
majcosta closed D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 09:09
majcosta committed rABCb48da90d1e72: [refactor] set the -ecash CLI argument earlier in startup (authored by majcosta).
[refactor] set the -ecash CLI argument earlier in startup
Jun 10 2021, 09:08
Fabien accepted D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 09:05
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

addressed feedback

Jun 10 2021, 08:56
Fabien requested changes to D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 08:31
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

missing newline at end of file

Jun 10 2021, 07:49
Ichessuinc updated Ichessuinc.
Jun 10 2021, 07:41
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

do not set the parameter in an inappropriate function, create a compilation unit for currency unit related code

Jun 10 2021, 07:20
Fabien requested changes to D9656: [refactor] encapsulate a unit's denomination in a class.

You need to add some unit tests for this new Currency object

Jun 10 2021, 07:15
Fabien requested changes to D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 06:56
teamcity closed T1645: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Jun 10 2021, 03:41
majcosta updated the diff for D9656: [refactor] encapsulate a unit's denomination in a class.

ValueFromAmount function still had the decimal places magical number code

Jun 10 2021, 03:21
abc-bot committed rABC3cc7c730e397: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 10 2021, 03:20
teamcity triaged T1645: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Jun 10 2021, 02:46
abc-bot committed rABC12d3cae43646: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 10 2021, 02:16
abc-bot committed rABC253e2dbe8709: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 10 2021, 02:08
majcosta requested review of D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 01:12

Jun 9 2021

majcosta requested review of D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 9 2021, 20:09
Mengerian added a task to D9654: Extract out the next inventory send time computation: Unknown Object (Maniphest Task).
Jun 9 2021, 18:49
PiRK accepted D9650: [avalanche] Send proof inventories.
Jun 9 2021, 17:28
teamcity closed T1643: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Jun 9 2021, 14:07
PiRK accepted D9654: Extract out the next inventory send time computation.
Jun 9 2021, 14:01
Fabien updated the diff for D9650: [avalanche] Send proof inventories.

Rebase on top of D9654.

Jun 9 2021, 14:01
Fabien updated the summary of D9650: [avalanche] Send proof inventories.
Jun 9 2021, 14:00
Fabien requested review of D9654: Extract out the next inventory send time computation.
Jun 9 2021, 13:58
teamcity closed T1644: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jun 9 2021, 13:51
Fabien closed D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:42
Fabien committed rABC2467b6cfa6a6: [avalanche] Fix the avalanche test on slow machines (authored by Fabien).
[avalanche] Fix the avalanche test on slow machines
Jun 9 2021, 13:42
Fabien updated the summary of D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:38
PiRK accepted D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:29
teamcity awarded D9653: [avalanche] Fix the avalanche test on slow machines a Haypence token.
Jun 9 2021, 13:07
Fabien added a comment to D9653: [avalanche] Fix the avalanche test on slow machines.

@bot build-linux-arm build-linux-aarch64

Jun 9 2021, 13:07
Fabien requested review of D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:06
Fabien planned changes to D9650: [avalanche] Send proof inventories.

I should probably manage the loop delay first before enabling all this, will update/rebase once done

Jun 9 2021, 10:05
PiRK added inline comments to D9650: [avalanche] Send proof inventories.
Jun 9 2021, 10:01
PiRK added inline comments to D9650: [avalanche] Send proof inventories.
Jun 9 2021, 09:49
teamcity triaged T1644: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jun 9 2021, 08:34
teamcity triaged T1643: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Jun 9 2021, 08:33
Fabien updated the diff for D9650: [avalanche] Send proof inventories.

Rebase

Jun 9 2021, 07:56
Fabien closed D9492: [avalanche] Add a sendavalancheproof RPC shell.
Jun 9 2021, 07:53
Fabien committed rABC2e4bc27105b7: [avalanche] Add a sendavalancheproof RPC shell (authored by Fabien).
[avalanche] Add a sendavalancheproof RPC shell
Jun 9 2021, 07:53
Fabien closed D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 9 2021, 07:52
Fabien committed rABC10b624ffb4f5: [avalanche] Extract a proof verification facility from the RPC (authored by Fabien).
[avalanche] Extract a proof verification facility from the RPC
Jun 9 2021, 07:52
Fabien closed D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Jun 9 2021, 07:51
Fabien committed rABC350aba92a742: [avalanche] Make the deserialization error code consistent between RPCs (authored by Fabien).
[avalanche] Make the deserialization error code consistent between RPCs
Jun 9 2021, 07:50
Fabien closed D9648: [avalanche] Add a facility to check if avalanche is enabled.
Jun 9 2021, 07:50
Fabien committed rABCe9fc5f21799a: [avalanche] Add a facility to check if avalanche is enabled (authored by Fabien).
[avalanche] Add a facility to check if avalanche is enabled
Jun 9 2021, 07:49
Fabien closed D9647: [avalanche] Move the global definitions into their own header.
Jun 9 2021, 07:49
Fabien committed rABC478f68235d39: [avalanche] Move the global definitions into their own header (authored by Fabien).
[avalanche] Move the global definitions into their own header
Jun 9 2021, 07:48
Fabien closed D9644: [avalanche] Send avalanche proofs upon request.
Jun 9 2021, 07:47
Fabien committed rABCf5468cdd8454: [avalanche] Send avalanche proofs upon request (authored by Fabien).
[avalanche] Send avalanche proofs upon request
Jun 9 2021, 07:47
Fabien closed D9643: [avalanche] Keep track of the peer creation time.
Jun 9 2021, 07:35
Fabien committed rABC963d2d852a3a: [avalanche] Keep track of the peer creation time (authored by Fabien).
[avalanche] Keep track of the peer creation time
Jun 9 2021, 07:35
Fabien closed D9642: [avalanche] Keep a rolling bloom filter of our recently announced proofs.
Jun 9 2021, 07:34
Fabien committed rABC8ee560a6dec6: [avalanche] Keep a rolling bloom filter of our recently announced proofs (authored by Fabien).
[avalanche] Keep a rolling bloom filter of our recently announced proofs
Jun 9 2021, 07:34

Jun 8 2021

majcosta abandoned D9636: [testing] enable '-ecash' only on tests that use it.

you're right, this is not good

Jun 8 2021, 21:01
deadalnix accepted D9492: [avalanche] Add a sendavalancheproof RPC shell.
Jun 8 2021, 15:29
deadalnix requested changes to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 8 2021, 15:29
Fabien added a comment to D9650: [avalanche] Send proof inventories.

Note to reviewers:
This supersedes D9489 and D9493. I deliberately chose to not split apart the filtering of the peer's known proof (was D9493) because in the end I don't think it makes the review easier, but quite the opposite. By keeping it together with the inv message sending it makes it easier to compare with what is done for the proofs invs.
The broadcasting feature detailed in D9489 will be added in another diff.

Jun 8 2021, 15:22
Fabien requested review of D9650: [avalanche] Send proof inventories.
Jun 8 2021, 15:19
PiRK accepted D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 8 2021, 15:19
PiRK accepted D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Jun 8 2021, 15:17
PiRK accepted D9648: [avalanche] Add a facility to check if avalanche is enabled.
Jun 8 2021, 15:15
PiRK accepted D9647: [avalanche] Move the global definitions into their own header.
Jun 8 2021, 15:14
Fabien updated the diff for D9492: [avalanche] Add a sendavalancheproof RPC shell.

Rebase on top of D9648, make it an empty shell for now

Jun 8 2021, 15:07
Fabien retitled D9492: [avalanche] Add a sendavalancheproof RPC shell from [avalanche] Add a sendavalancheproof RPC to broadcast a proof to [avalanche] Add a sendavalancheproof RPC shell.
Jun 8 2021, 15:04
Fabien added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.

Unrelated failure, I am out of luck today

Jun 8 2021, 14:21
teamcity added a comment to D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Jun 8 2021, 14:17
Fabien updated the diff for D9646: [avalanche] Extract a proof verification facility from the RPC.

Rebase on D9649 to get more factorized code

Jun 8 2021, 14:15
Fabien updated the summary of D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 8 2021, 14:14
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.

Confused with another diff

Jun 8 2021, 14:14
Fabien requested review of D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Jun 8 2021, 14:10
Fabien planned changes to D9648: [avalanche] Add a facility to check if avalanche is enabled.
Jun 8 2021, 13:59
Fabien added a comment to D9647: [avalanche] Move the global definitions into their own header.

Unrelated spurious processor_tests failure. I managed to reproduce by chance on my machine and I have a core dump to debug on now

Jun 8 2021, 13:33
Fabien added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.

Unrelated failure

Jun 8 2021, 13:32
Fabien requested review of D9648: [avalanche] Add a facility to check if avalanche is enabled.
Jun 8 2021, 13:32
teamcity added a comment to D9647: [avalanche] Move the global definitions into their own header.
Jun 8 2021, 13:14
Fabien requested review of D9647: [avalanche] Move the global definitions into their own header.
Jun 8 2021, 13:11
PiRK accepted D9644: [avalanche] Send avalanche proofs upon request.
Jun 8 2021, 12:55
teamcity added a comment to D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 8 2021, 12:47
Fabien requested review of D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 8 2021, 12:40
PiRK accepted D9643: [avalanche] Keep track of the peer creation time.
Jun 8 2021, 12:38
Fabien closed D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.
Jun 8 2021, 11:43