- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 10 2021
rebase on current master
Now this review does not need to implement GetData for proofs any longer. The proof needs to be verified by a local node before it can be requested. There is now a Processor::addProof method, so we can use in in the code handling NetMsgType::AVAPROOF messages to store proofs even if they don't belong to the node sending it (for now we are not looking for the owner to add it, in such a case).
POD'ified Currency, renamed 'unit' to 'baseunit' for clarity
addressed feedback
missing newline at end of file
do not set the parameter in an inappropriate function, create a compilation unit for currency unit related code
You need to add some unit tests for this new Currency object
ValueFromAmount function still had the decimal places magical number code
Jun 9 2021
Rebase on top of D9654.
@bot build-linux-arm build-linux-aarch64
I should probably manage the loop delay first before enabling all this, will update/rebase once done
Jun 8 2021
you're right, this is not good
Note to reviewers:
This supersedes D9489 and D9493. I deliberately chose to not split apart the filtering of the peer's known proof (was D9493) because in the end I don't think it makes the review easier, but quite the opposite. By keeping it together with the inv message sending it makes it easier to compare with what is done for the proofs invs.
The broadcasting feature detailed in D9489 will be added in another diff.
Rebase on top of D9648, make it an empty shell for now
Unrelated failure, I am out of luck today
Rebase on D9649 to get more factorized code
Confused with another diff
Unrelated spurious processor_tests failure. I managed to reproduce by chance on my machine and I have a core dump to debug on now
Unrelated failure