Page MenuHomePhabricator
Feed All Stories

Tue, Sep 14

teamcity added a comment to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 12:36
PiRK planned changes to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 12:27
PiRK updated the diff for D8671: Add a --descriptors option to various tests.

Again, the issue is caused by --descriptors causing a different fee calculation, so the balance on node0 is not exactly the same.

Tue, Sep 14, 12:27
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 11:59
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 11:56
PiRK planned changes to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 11:46
PiRK updated the diff for D8671: Add a --descriptors option to various tests.

partial fix for wallet_keypool, add some comments when our codebase diverges for a known reason.

Tue, Sep 14, 11:45
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 09:18
Fabien accepted D10106: Cleanup Bitcoin Cash user agents in seeder tests.
Tue, Sep 14, 09:17
Fabien accepted D10105: Set seeder user agent in a similar way to the node.
Tue, Sep 14, 09:16
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Tue, Sep 14, 09:12
Fabien accepted D10094: -maxapsfee: follow-up fixes.
Tue, Sep 14, 09:08
PiRK planned changes to D8671: Add a --descriptors option to various tests.

3 more tests to fix: wallet_keypool (with and without --descriptors), wallet_basic (with --descriptors) and rpc_psbt (with and without --descriptors)

Tue, Sep 14, 09:08
Fabien accepted D10091: rpc generate: print useful help and error message.
Tue, Sep 14, 09:03
Fabien added a comment to D10090: Fix a compiler warning: unused GetDevURandom().

Ok I actually read the comments. If there is a rationale for the previous approach then let's stick with that, I don't know if there is a plan to remove that function in the future.

Tue, Sep 14, 09:01
PiRK updated the diff for D8671: Add a --descriptors option to various tests.

rebase onto master.

Tue, Sep 14, 09:00
PiRK commandeered D8671: Add a --descriptors option to various tests.

Try to get this fixed. This is now blocking a couple of backports.

Tue, Sep 14, 08:57
Fabien added inline comments to rABC278b300a0620: [avalanche] Sort the stakes inside a proof.
Tue, Sep 14, 08:40
Fabien closed D10103: [avalanche] Fix extended tests that use buildavalancheproof.
Tue, Sep 14, 08:38
Fabien committed rABCd9fc523b345c: [avalanche] Fix extended tests that use buildavalancheproof (authored by Fabien).
[avalanche] Fix extended tests that use buildavalancheproof
Tue, Sep 14, 08:38
PiRK updated the diff for D10090: Fix a compiler warning: unused GetDevURandom().

use [[maybe_unused]] when defining the function instead of planting dummy references to the function

Tue, Sep 14, 08:22
PiRK updated the diff for D10094: -maxapsfee: follow-up fixes.

update the description to add a note about how the tx fees are computed, and add a comment next to -maxapsfee=2.93 to explain the threshold.

Tue, Sep 14, 08:11
PiRK added a comment to D10091: rpc generate: print useful help and error message.

Is that a backport ?

Tue, Sep 14, 06:41
PiRK updated the summary of D10091: rpc generate: print useful help and error message.
Tue, Sep 14, 06:40
PiRK added a comment to D10090: Fix a compiler warning: unused GetDevURandom().

What about [[maybe_unused]] ? That would be more elegant.

Tue, Sep 14, 06:37
PiRK closed D10100: wallet: Avoid recursive lock in IsTrusted.
Tue, Sep 14, 06:28
PiRK committed rABCaca02ec56a40: wallet: Avoid recursive lock in IsTrusted (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Avoid recursive lock in IsTrusted
Tue, Sep 14, 06:28
PiRK closed D10099: wallet, refactor: Immutable CWalletTx::pwallet.
Tue, Sep 14, 06:27
PiRK committed rABC819580a50c41: wallet, refactor: Immutable CWalletTx::pwallet (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet, refactor: Immutable CWalletTx::pwallet
Tue, Sep 14, 06:27
PiRK closed D10097: wallet: IsChange requires cs_wallet lock.
Tue, Sep 14, 06:27
PiRK committed rABCc0a3007e5e02: wallet: IsChange requires cs_wallet lock (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: IsChange requires cs_wallet lock
Tue, Sep 14, 06:26
PiRK closed D10096: wallet: IsMine overloads require cs_wallet lock.
Tue, Sep 14, 06:26
PiRK committed rABC96bb65f2028b: wallet: IsMine overloads require cs_wallet lock (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: IsMine overloads require cs_wallet lock
Tue, Sep 14, 06:26
PiRK closed D10095: wallet: GetWalletTx requires cs_wallet lock.
Tue, Sep 14, 06:24
PiRK closed D10098: wallet, refactor: Remove duplicate map lookups in GetAddressBalances.
Tue, Sep 14, 06:24
PiRK committed rABC9712e1445364: wallet: GetWalletTx requires cs_wallet lock (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: GetWalletTx requires cs_wallet lock
Tue, Sep 14, 06:24
PiRK committed rABC9f6318190b26: wallet, refactor: Remove duplicate map lookups in GetAddressBalances (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet, refactor: Remove duplicate map lookups in GetAddressBalances
Tue, Sep 14, 06:24
PiRK updated the test plan for D10100: wallet: Avoid recursive lock in IsTrusted.
Tue, Sep 14, 06:23
PiRK updated the summary of D10096: wallet: IsMine overloads require cs_wallet lock.
Tue, Sep 14, 06:21
PiRK accepted D10103: [avalanche] Fix extended tests that use buildavalancheproof.
Tue, Sep 14, 06:18
Klakurka added inline comments to rABC278b300a0620: [avalanche] Sort the stakes inside a proof.
Tue, Sep 14, 04:02

Mon, Sep 13

Mengerian accepted D10104: Rebrand seeder to eCash.
Mon, Sep 13, 23:54
thonkle requested review of D10106: Cleanup Bitcoin Cash user agents in seeder tests.
Mon, Sep 13, 22:09
thonkle requested review of D10105: Set seeder user agent in a similar way to the node.
Mon, Sep 13, 21:54
thonkle requested review of D10104: Rebrand seeder to eCash.
Mon, Sep 13, 21:36
Fabien requested review of D10103: [avalanche] Fix extended tests that use buildavalancheproof.
Mon, Sep 13, 19:53
PiRK planned changes to D10094: -maxapsfee: follow-up fixes.

I will try to figure out exactly why the second set of values, the computed fees for the transactions created in the test, are different.

Mon, Sep 13, 19:17
Fabien closed D10101: [avalanche] Improve invalid-signature error message accuracy.
Mon, Sep 13, 19:17
Fabien committed rABCf82652601c8c: [avalanche] Improve invalid-signature error message accuracy (authored by Fabien).
[avalanche] Improve invalid-signature error message accuracy
Mon, Sep 13, 19:17
Fabien closed D10092: [avalanche] Pass a CKey to the proof builder.
Mon, Sep 13, 19:14
Fabien committed rABC42ac1f7dae78: [avalanche] Pass a CKey to the proof builder (authored by Fabien).
[avalanche] Pass a CKey to the proof builder
Mon, Sep 13, 19:14
Fabien closed D10086: [avalanche] Add an error message for duplicated stakes in buildavalancheproof.
Mon, Sep 13, 19:10
Fabien committed rABC0258b059fbfa: [avalanche] Add an error message for duplicated stakes in buildavalancheproof (authored by Fabien).
[avalanche] Add an error message for duplicated stakes in buildavalancheproof
Mon, Sep 13, 19:10
Fabien closed D10079: [avalanche] Consistently check ProofBuilder::addUTXO return value.
Mon, Sep 13, 19:09
Fabien committed rABC9744008395cb: [avalanche] Consistently check ProofBuilder::addUTXO return value (authored by Fabien).
[avalanche] Consistently check ProofBuilder::addUTXO return value
Mon, Sep 13, 19:09
Fabien closed D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Mon, Sep 13, 19:05
Fabien committed rABC5b58bdb0f7a1: [avalanche] Use an ordered container for stakes in the proof builder (authored by Fabien).
[avalanche] Use an ordered container for stakes in the proof builder
Mon, Sep 13, 19:05
Fabien closed D10076: [avalanche] Sort the stakes inside a proof.
Mon, Sep 13, 19:04
Fabien committed rABC278b300a0620: [avalanche] Sort the stakes inside a proof (authored by Fabien).
[avalanche] Sort the stakes inside a proof
Mon, Sep 13, 19:04
Fabien accepted D10096: wallet: IsMine overloads require cs_wallet lock.
Mon, Sep 13, 19:00
Fabien accepted D10100: wallet: Avoid recursive lock in IsTrusted.
Mon, Sep 13, 19:00
Fabien accepted D10099: wallet, refactor: Immutable CWalletTx::pwallet.
Mon, Sep 13, 18:54
Fabien accepted D10098: wallet, refactor: Remove duplicate map lookups in GetAddressBalances.

TIL

Mon, Sep 13, 18:53
Fabien accepted D10097: wallet: IsChange requires cs_wallet lock.

Please take care to use the appropriate test plan. This one was not good (I edited), but luckily the CI did the job.

Mon, Sep 13, 18:49
Fabien updated the test plan for D10097: wallet: IsChange requires cs_wallet lock.
Mon, Sep 13, 18:48
Fabien updated the summary of D10097: wallet: IsChange requires cs_wallet lock.
Mon, Sep 13, 18:47
teamcity awarded D10096: wallet: IsMine overloads require cs_wallet lock a Haypence token.
Mon, Sep 13, 18:39
Fabien added a comment to D10096: wallet: IsMine overloads require cs_wallet lock.

@bot build-tsan

Mon, Sep 13, 18:39
Fabien accepted D10095: wallet: GetWalletTx requires cs_wallet lock.
Mon, Sep 13, 18:38
Fabien requested changes to D10094: -maxapsfee: follow-up fixes.
Mon, Sep 13, 18:37
deadalnix accepted D10092: [avalanche] Pass a CKey to the proof builder.
Mon, Sep 13, 16:26
Fabien added a comment to D10091: rpc generate: print useful help and error message.

Is that a backport ?

Mon, Sep 13, 16:24
Fabien added a comment to D10090: Fix a compiler warning: unused GetDevURandom().

What about [[maybe_unused]] ? That would be more elegant.

Mon, Sep 13, 16:23
Fabien added a comment to D10101: [avalanche] Improve invalid-signature error message accuracy.

Unrelated failure

Mon, Sep 13, 16:19
Joey King <joseph.roy.king@gmail.com> closed D10102: [Cashtab] correct error in parsing tx history for op ret txs.
Mon, Sep 13, 16:18
Joey King <joseph.roy.king@gmail.com> committed rABCbbfe3dc1abd8: [Cashtab] correct error in parsing tx history for op ret txs (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] correct error in parsing tx history for op ret txs
Mon, Sep 13, 16:18
Fabien accepted D10102: [Cashtab] correct error in parsing tx history for op ret txs.
Mon, Sep 13, 16:16
bytesofman requested review of D10102: [Cashtab] correct error in parsing tx history for op ret txs.
Mon, Sep 13, 15:48
teamcity added a comment to D10101: [avalanche] Improve invalid-signature error message accuracy.
Mon, Sep 13, 15:41
PiRK closed D10075: remove argName nBlocks from estimatefee RPC command registration.
Mon, Sep 13, 15:38
PiRK committed rABC4a106b29a689: remove argName nBlocks from estimatefee RPC command registration (authored by PiRK).
remove argName nBlocks from estimatefee RPC command registration
Mon, Sep 13, 15:38
deadalnix accepted D10101: [avalanche] Improve invalid-signature error message accuracy.
Mon, Sep 13, 15:35
Fabien updated the diff for D10092: [avalanche] Pass a CKey to the proof builder.

Improve RPC help

Mon, Sep 13, 15:33
Fabien requested review of D10101: [avalanche] Improve invalid-signature error message accuracy.
Mon, Sep 13, 15:29
teamcity updated the summary of D10100: wallet: Avoid recursive lock in IsTrusted.
Mon, Sep 13, 15:11
PiRK requested review of D10100: wallet: Avoid recursive lock in IsTrusted.
Mon, Sep 13, 15:11
teamcity updated the summary of D10099: wallet, refactor: Immutable CWalletTx::pwallet.
Mon, Sep 13, 15:09
PiRK requested review of D10099: wallet, refactor: Immutable CWalletTx::pwallet.
Mon, Sep 13, 15:09
teamcity updated the summary of D10098: wallet, refactor: Remove duplicate map lookups in GetAddressBalances.
Mon, Sep 13, 14:46
PiRK requested review of D10098: wallet, refactor: Remove duplicate map lookups in GetAddressBalances.
Mon, Sep 13, 14:46
PiRK updated the summary of D10094: -maxapsfee: follow-up fixes.
Mon, Sep 13, 14:44
PiRK updated the summary of D10097: wallet: IsChange requires cs_wallet lock.
Mon, Sep 13, 14:38
teamcity updated the summary of D10097: wallet: IsChange requires cs_wallet lock.
Mon, Sep 13, 14:38
PiRK requested review of D10097: wallet: IsChange requires cs_wallet lock.
Mon, Sep 13, 14:37
PiRK updated the summary of D10096: wallet: IsMine overloads require cs_wallet lock.
Mon, Sep 13, 14:36
teamcity updated the summary of D10096: wallet: IsMine overloads require cs_wallet lock.
Mon, Sep 13, 14:35
PiRK requested review of D10096: wallet: IsMine overloads require cs_wallet lock.
Mon, Sep 13, 14:35
teamcity updated the summary of D10095: wallet: GetWalletTx requires cs_wallet lock.
Mon, Sep 13, 14:33
PiRK requested review of D10095: wallet: GetWalletTx requires cs_wallet lock.
Mon, Sep 13, 14:33
teamcity updated the summary of D10094: -maxapsfee: follow-up fixes.
Mon, Sep 13, 14:23