Page MenuHomePhabricator
Feed All Stories

Wed, Nov 6

bytesofman closed D17078: [Cashtab] Convert CashtabCache to ts.
Wed, Nov 6, 03:19
bytesofman committed rABCfccf4f50904d: [Cashtab] Convert CashtabCache to ts (authored by bytesofman).
[Cashtab] Convert CashtabCache to ts
Wed, Nov 6, 03:19
emack accepted D17079: [Cashtab] Migrate CashtabSettings to ts.
Wed, Nov 6, 03:10
emack accepted D17078: [Cashtab] Convert CashtabCache to ts.
Wed, Nov 6, 03:06
bytesofman published D17084: [Cashtab] Add a jest setup file to avoid repeating global mocks for review.
Wed, Nov 6, 01:24
bytesofman published D17083: [Cashtab] Add canvas mock to prevent annoying jest debug logs for review.
Wed, Nov 6, 01:03

Tue, Nov 5

PiRK accepted D17082: Parallel compact block downloads, take 3.
Tue, Nov 5, 23:00
teamcity updated the summary of D17082: Parallel compact block downloads, take 3.
Tue, Nov 5, 21:21
Fabien requested review of D17082: Parallel compact block downloads, take 3.
Tue, Nov 5, 21:21
bytesofman requested changes to D17077: [cashtab] Agora order book UI adjustments.

awesome this is much better than the current component

Tue, Nov 5, 21:18
johnkuney published D17077: [cashtab] Agora order book UI adjustments for review.
Tue, Nov 5, 20:31
bytesofman published D17081: [Cashtab] Add fn and test cases for agora oneshot fuel inputs for review.
Tue, Nov 5, 19:35
Fabien closed D17071: [avalanche] Cleanup the logs.
Tue, Nov 5, 19:23
Fabien committed rABC00ed23b33c12: [avalanche] Cleanup the logs (authored by Fabien).
[avalanche] Cleanup the logs
Tue, Nov 5, 19:23
bytesofman published D17080: [Cashtab] Wallet methods to ts for review.
Tue, Nov 5, 18:50
bytesofman published D17079: [Cashtab] Migrate CashtabSettings to ts for review.
Tue, Nov 5, 18:32
bytesofman published D17078: [Cashtab] Convert CashtabCache to ts for review.
Tue, Nov 5, 18:21
bytesofman closed D17072: [ecash-agora] Update linter settings for monorepo consistency.
Tue, Nov 5, 17:45
bytesofman committed rABC753bbb9ff679: [ecash-agora] Update linter settings for monorepo consistency (authored by bytesofman).
[ecash-agora] Update linter settings for monorepo consistency
Tue, Nov 5, 17:45
roqqit accepted D17071: [avalanche] Cleanup the logs.
Tue, Nov 5, 16:42
Fabien closed D17076: [avalanche] Fix the getavaaddr functional test.
Tue, Nov 5, 15:23
Fabien committed rABC7a0c2cf9ec4a: [avalanche] Fix the getavaaddr functional test (authored by Fabien).
[avalanche] Fix the getavaaddr functional test
Tue, Nov 5, 15:22
Fabien updated the summary of D17037: [chronik] index scripts by scripthashes in the mempool.
Tue, Nov 5, 13:26
PiRK planned changes to D17037: [chronik] index scripts by scripthashes in the mempool.

still working on more tests

Tue, Nov 5, 13:16
PiRK updated the diff for D17037: [chronik] index scripts by scripthashes in the mempool.

rebase

Tue, Nov 5, 13:16
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Tue, Nov 5, 10:01
PiRK accepted D17076: [avalanche] Fix the getavaaddr functional test.
Tue, Nov 5, 09:57
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Tue, Nov 5, 09:24
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Tue, Nov 5, 08:58
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Make sure the spam is processed after sending, otherwise it can be processed after the mocktime is increased and cause the getavaaddr test to fail.

Tue, Nov 5, 08:30
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Tue, Nov 5, 08:16
emack accepted D17072: [ecash-agora] Update linter settings for monorepo consistency.
Tue, Nov 5, 06:24
bytesofman updated the diff for D17072: [ecash-agora] Update linter settings for monorepo consistency.

fix lingering eslint error

Tue, Nov 5, 04:38
emack requested changes to D17072: [ecash-agora] Update linter settings for monorepo consistency.
Tue, Nov 5, 04:18
roqqit closed D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Tue, Nov 5, 00:05
roqqit committed rABCa66b32711df2: [avalanche] Only allow contender cache cleanup up to the height of the last… (authored by roqqit).
[avalanche] Only allow contender cache cleanup up to the height of the last…
Tue, Nov 5, 00:05

Mon, Nov 4

roqqit updated the diff for D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.

Fix style nit

Mon, Nov 4, 21:47
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 21:34
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 21:30
Fabien accepted D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Mon, Nov 4, 21:26
Fabien updated the summary of D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 21:15
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Rebase on top of D17076 to fix the test

Mon, Nov 4, 21:15
Fabien updated the diff for D17076: [avalanche] Fix the getavaaddr functional test.

Uncomment tests

Mon, Nov 4, 21:11
Fabien planned changes to D17076: [avalanche] Fix the getavaaddr functional test.
Mon, Nov 4, 21:09
Fabien requested review of D17076: [avalanche] Fix the getavaaddr functional test.
Mon, Nov 4, 21:08
roqqit requested review of D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Mon, Nov 4, 20:35
Fabien added a comment to D17071: [avalanche] Cleanup the logs.

I will split out the test fix

Mon, Nov 4, 19:28
Fabien closed D17068: [avalanche] Always print the finalization messages.
Mon, Nov 4, 19:26
Fabien committed rABC5e91e0989f8b: [avalanche] Always print the finalization messages (authored by Fabien).
[avalanche] Always print the finalization messages
Mon, Nov 4, 19:26
bytesofman published D17072: [ecash-agora] Update linter settings for monorepo consistency for review.
Mon, Nov 4, 19:01
roqqit accepted D17068: [avalanche] Always print the finalization messages.
Mon, Nov 4, 17:41
bytesofman closed D17063: [Cashtab] Patch bug in manage agora offers.
Mon, Nov 4, 17:24
bytesofman committed rABC5b9ca8ccad18: [Cashtab] Patch bug in manage agora offers (authored by bytesofman).
[Cashtab] Patch bug in manage agora offers
Mon, Nov 4, 17:24
roqqit requested changes to D17071: [avalanche] Cleanup the logs.

Back to you for the test failure

Mon, Nov 4, 17:21
roqqit accepted D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 17:20
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 17:14
Fabien requested review of D17071: [avalanche] Cleanup the logs.
Mon, Nov 4, 16:35
bytesofman closed D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Mon, Nov 4, 16:30
bytesofman committed rABCba63229e2b34: [ecash-herald + token-server] Update typescript and docker build settings (authored by bytesofman).
[ecash-herald + token-server] Update typescript and docker build settings
Mon, Nov 4, 16:30
Fabien closed D17070: [CI] Fix the wasm build in the container.
Mon, Nov 4, 15:33
Fabien committed rABC600fa4f562d8: [CI] Fix the wasm build in the container (authored by Fabien).
[CI] Fix the wasm build in the container
Mon, Nov 4, 15:33
bytesofman accepted D17070: [CI] Fix the wasm build in the container.
Mon, Nov 4, 15:32
Fabien requested review of D17070: [CI] Fix the wasm build in the container.
Mon, Nov 4, 15:14
Fabien requested review of D17068: [avalanche] Always print the finalization messages.
Mon, Nov 4, 14:06
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Mon, Nov 4, 12:45
PiRK added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Mon, Nov 4, 11:34
Fabien closed D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 10:06
Fabien committed rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC (authored by Fabien).
Deprecate the address_type field of the getnewaddress RPC
Mon, Nov 4, 10:06
Fabien closed D17066: Bump version to 0.30.4.
Mon, Nov 4, 10:06
Fabien committed rABC486094e3a645: Bump version to 0.30.4 (authored by Fabien).
Bump version to 0.30.4
Mon, Nov 4, 10:06
PiRK accepted D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 09:47
PiRK accepted D17066: Bump version to 0.30.4.
Mon, Nov 4, 09:46
Fabien updated the summary of D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 09:40
Fabien requested review of D17067: Deprecate the address_type field of the getnewaddress RPC.
Mon, Nov 4, 09:30
Fabien requested review of D17066: Bump version to 0.30.4.
Mon, Nov 4, 08:58
emack accepted D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Mon, Nov 4, 00:51
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.
Mon, Nov 4, 00:43

Sun, Nov 3

abc-bot committed rABC5e8317de7248: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Nov 3, 22:21
abc-bot committed rABC4c23df8830e8: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Nov 3, 22:10
abc-bot committed rABCfc88d7f529f6: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Nov 3, 21:42
bytesofman closed D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Sun, Nov 3, 12:58
bytesofman committed rABCbd14420258ca: [Cashtab] Add OrderBook (with no icon) to token info page (authored by bytesofman).
[Cashtab] Add OrderBook (with no icon) to token info page
Sun, Nov 3, 12:58
bytesofman published D17065: [ecash-herald + token-server] Update typescript and docker build settings for review.
Sun, Nov 3, 12:53
bytesofman requested review of D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
Sun, Nov 3, 12:52
teamcity closed T3673: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Sun, Nov 3, 12:22
bytesofman closed D17060: [ecash-herald] Implement typescript.
Sun, Nov 3, 12:08
bytesofman committed rABC5bdba03f6cbc: [ecash-herald] Implement typescript (authored by bytesofman).
[ecash-herald] Implement typescript
Sun, Nov 3, 12:08
teamcity triaged T3673: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Sun, Nov 3, 12:07
bytesofman closed D17062: [token-server] Improve organization of test files.
Sun, Nov 3, 11:52
bytesofman committed rABC1fed704a0a8d: [token-server] Improve organization of test files (authored by bytesofman).
[token-server] Improve organization of test files
Sun, Nov 3, 11:52
emack accepted D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Sun, Nov 3, 11:52
emack requested changes to D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
  • the orderbook in manage listings become a "Buy token", which makes sense since you no longer have any offers left, but shouldn't it not be displayed at all?
Sun, Nov 3, 11:24
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.

Have verified the merging of orderbooks for the same token offer, though I wasn't getting a duplicate key error in the first place on master (v2.49.1).

Sun, Nov 3, 11:18
emack accepted D17060: [ecash-herald] Implement typescript.
Sun, Nov 3, 11:03
emack accepted D17062: [token-server] Improve organization of test files.
Sun, Nov 3, 10:53
bytesofman updated the diff for D17064: [Cashtab] Add OrderBook (with no icon) to token info page.

patch unintended css shift (make sure offers stay 100% width on Agora page and landing page)

Sun, Nov 3, 04:54
bytesofman published D17064: [Cashtab] Add OrderBook (with no icon) to token info page for review.
Sun, Nov 3, 04:24
bytesofman abandoned D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

superseded by D17064

Sun, Nov 3, 04:15

Sat, Nov 2

PiRK committed rABCbf00137a339a: [chronik] add scripthash option to the various script endpoints (authored by PiRK).
[chronik] add scripthash option to the various script endpoints
Sat, Nov 2, 22:43
PiRK closed D16937: [chronik] add scripthash option to the various script endpoints.
Sat, Nov 2, 22:43