Page MenuHomePhabricator
Feed All Stories

Thu, Nov 6

PiRK closed D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 11:56
PiRK committed rABC2c24045ddb98: test: Fix sanitizer suppresions in streams_tests (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix sanitizer suppresions in streams_tests
Thu, Nov 6, 11:56
Fabien accepted D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 11:11
teamcity triaged T3914: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Thu, Nov 6, 10:51
teamcity updated the summary of D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 10:38
PiRK requested review of D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 10:38
Fabien accepted D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 10:38
teamcity awarded D18891: test: Fix sanitizer suppresions in streams_tests a Haypence token.
Thu, Nov 6, 10:27
PiRK added a comment to D18891: test: Fix sanitizer suppresions in streams_tests.

@bot build-ubsan

Thu, Nov 6, 10:27
teamcity updated the summary of D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 10:27
PiRK requested review of D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 10:27
Fabien committed rABCa056c0d2ddd6: Add release notes for v0.32.2 (authored by Fabien).
Add release notes for v0.32.2
Thu, Nov 6, 10:01
Fabien closed D18887: test: don't throw from the destructor of DebugLogHelper.
Thu, Nov 6, 09:47
Fabien committed rABCf6f59226778d: test: don't throw from the destructor of DebugLogHelper (authored by Vasil Dimov <vd@FreeBSD.org>).
test: don't throw from the destructor of DebugLogHelper
Thu, Nov 6, 09:47
Fabien closed D18886: log: rate limiting followups.
Thu, Nov 6, 09:45
Fabien committed rABCf1f3f1b879cc: log: rate limiting followups (authored by Eugene Siegel <elzeigel@gmail.com>).
log: rate limiting followups
Thu, Nov 6, 09:45
PiRK accepted D18886: log: rate limiting followups.
Thu, Nov 6, 09:21
Fabien accepted D18889: [metachronik] Patch CI by upgrading dep.
Thu, Nov 6, 08:29
teamcity closed T3913: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Thu, Nov 6, 08:23
Fabien updated the diff for D18886: log: rate limiting followups.

Add back unintentionally removed line

Thu, Nov 6, 08:09
Fabien closed D18885: refactor: use Span for SipHash::Write.
Thu, Nov 6, 08:07
Fabien committed rABC9c275618c64c: refactor: use Span for SipHash::Write (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: use Span for SipHash::Write
Thu, Nov 6, 08:07
Fabien committed rABCefcca6b16a3b: [CI] Bump ASAN timeout (authored by Fabien).
[CI] Bump ASAN timeout
Thu, Nov 6, 08:07
Fabien closed D18888: [CI] Bump ASAN timeout.
Thu, Nov 6, 08:07
PiRK accepted D18888: [CI] Bump ASAN timeout.
Thu, Nov 6, 07:49
PiRK accepted D18887: test: don't throw from the destructor of DebugLogHelper.
Thu, Nov 6, 07:48
PiRK added inline comments to D18886: log: rate limiting followups.
Thu, Nov 6, 07:44
PiRK accepted D18885: refactor: use Span for SipHash::Write.
Thu, Nov 6, 07:27

Wed, Nov 5

bytesofman updated the diff for D18889: [metachronik] Patch CI by upgrading dep.

update lockfile

Wed, Nov 5, 23:17
teamcity added a comment to D18889: [metachronik] Patch CI by upgrading dep.
Wed, Nov 5, 23:07
bytesofman published D18889: [metachronik] Patch CI by upgrading dep for review.
Wed, Nov 5, 23:06
teamcity triaged T3913: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Wed, Nov 5, 22:35
teamcity closed T3912: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Wed, Nov 5, 22:27
Fabien requested review of D18888: [CI] Bump ASAN timeout.
Wed, Nov 5, 22:16
teamcity updated the summary of D18887: test: don't throw from the destructor of DebugLogHelper.
Wed, Nov 5, 22:13
Fabien requested review of D18887: test: don't throw from the destructor of DebugLogHelper.
Wed, Nov 5, 22:13
bytesofman closed D18882: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume.
Wed, Nov 5, 22:10
bytesofman committed rABCe8c6af084008: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume (authored by bytesofman).
[metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume
Wed, Nov 5, 22:10
teamcity updated the summary of D18886: log: rate limiting followups.
Wed, Nov 5, 22:04
Fabien requested review of D18886: log: rate limiting followups.
Wed, Nov 5, 22:04
Fabien accepted D18882: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume.
Wed, Nov 5, 22:04
teamcity triaged T3912: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Wed, Nov 5, 21:37
PiRK closed D18879: [validation] include all logged information in BlockValidationState.
Wed, Nov 5, 20:46
PiRK closed D18880: [validation] merge all ConnectBlock debug logging code paths.
Wed, Nov 5, 20:46
PiRK committed rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths (authored by PiRK).
[validation] merge all ConnectBlock debug logging code paths
Wed, Nov 5, 20:46
PiRK committed rABC0ffeacec23f8: [validation] include all logged information in BlockValidationState (authored by Pieter Wuille <pieter@wuille.net>).
[validation] include all logged information in BlockValidationState
Wed, Nov 5, 20:46
PiRK closed D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 20:46
PiRK closed D18878: [validation] Add detailed txin/txout information for script error messages.
Wed, Nov 5, 20:46
PiRK closed D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 20:46
PiRK committed rABC8eb86b00b55f: [validation] Add detailed txin/txout information for script error messages (authored by Pieter Wuille <pieter@wuille.net>).
[validation] Add detailed txin/txout information for script error messages
Wed, Nov 5, 20:46
PiRK committed rABCf844a8f41410: [checkqueue] support user-defined return type through std::optional (authored by Pieter Wuille <pieter@wuille.net>).
[checkqueue] support user-defined return type through std::optional
Wed, Nov 5, 20:46
PiRK committed rABCda83158d475d: [validation] Make script error messages uniform for parallel/single validation (authored by Pieter Wuille <pieter@wuille.net>).
[validation] Make script error messages uniform for parallel/single validation
Wed, Nov 5, 20:46
teamcity closed T3911: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Wed, Nov 5, 20:41
teamcity updated the summary of D18885: refactor: use Span for SipHash::Write.
Wed, Nov 5, 20:24
Fabien requested review of D18885: refactor: use Span for SipHash::Write.
Wed, Nov 5, 20:24
Fabien closed D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 19:49
Fabien committed rABCadb30b7ab03d: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo… (authored by Eugene Siegel <elzeigel@gmail.com>).
log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo…
Wed, Nov 5, 19:49
PiRK closed D18872: Add std::optional support to Boost's equality check.
Wed, Nov 5, 19:37
PiRK committed rABC3fb2ed2ceb27: Add std::optional support to Boost's equality check (authored by Lőrinc <pap.lorinc@gmail.com>).
Add std::optional support to Boost's equality check
Wed, Nov 5, 19:37
PiRK committed rABC8230e66ae88e: test: uint256 - Garbage suffixes and zero padding (authored by Hodlinator <172445034+hodlinator@users.noreply.github.com>).
test: uint256 - Garbage suffixes and zero padding
Wed, Nov 5, 19:37
PiRK closed D18871: test: uint256 - Garbage suffixes and zero padding.
Wed, Nov 5, 19:37
PiRK closed D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 19:37
PiRK committed rABC4d9fdc4a072d: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK() (authored by Hodlinator <172445034+hodlinator@users.noreply.github.com>).
refactor: Make uint256_tests no longer use deprecated BOOST_CHECK()
Wed, Nov 5, 19:37
bytesofman published D18882: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume for review.
Wed, Nov 5, 19:37
Fabien closed D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 19:34
Fabien committed rABC8c8f4cc97336: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp (authored by Fabien).
[chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp
Wed, Nov 5, 19:34
teamcity awarded D18880: [validation] merge all ConnectBlock debug logging code paths a Haypence token.
Wed, Nov 5, 19:33
PiRK added a comment to D18880: [validation] merge all ConnectBlock debug logging code paths.

@bot build-chronik chronik-client-integration-tests

Wed, Nov 5, 19:33
PiRK accepted D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 19:32
PiRK updated the diff for D18880: [validation] merge all ConnectBlock debug logging code paths.

rebase

Wed, Nov 5, 19:32
PiRK updated the diff for D18879: [validation] include all logged information in BlockValidationState.

rebase

Wed, Nov 5, 19:32
PiRK updated the diff for D18878: [validation] Add detailed txin/txout information for script error messages.

revert the hack introduced in D18876. This seems to be no longer needed after local_result = check() assigns a std::optional<std::pair<R, std::string>> rather than a std::optional<R> in CCheckQueue::Loop

Wed, Nov 5, 19:31
PiRK updated the diff for D18877: [validation] Make script error messages uniform for parallel/single validation.

newline

Wed, Nov 5, 19:13
PiRK accepted D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 19:07
Fabien accepted D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 19:00
Fabien accepted D18876: [checkqueue] support user-defined return type through std::optional.

OK it's ugly but has the same behavior and will be reverted to the clean solution anyway

Wed, Nov 5, 18:56
Fabien added inline comments to D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 18:51
Fabien accepted D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 18:51
Fabien requested review of D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 18:47
PiRK updated the diff for D18877: [validation] Make script error messages uniform for parallel/single validation.

rebase

Wed, Nov 5, 18:32
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

fix

Wed, Nov 5, 18:30
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:26
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:24
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:23
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:22
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:18
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

try replacing std::optional<R> local_result with a bool has_local_result; + R local_result; (remember that we converge back to Core's solution in D18878, so the hack is temporary)

Wed, Nov 5, 18:13
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:06
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:02
teamcity added a comment to D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 18:02
teamcity triaged T3911: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Wed, Nov 5, 17:59
PiRK requested review of D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 17:59
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

try decltype

Wed, Nov 5, 17:58
Fabien updated the diff for D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.

Rebase to get c++20 for chronik

Wed, Nov 5, 16:59
Fabien closed D18875: Early logging improvements.
Wed, Nov 5, 16:51
Fabien closed D18873: log: Use steady clock for bench logging.
Wed, Nov 5, 16:51
Fabien closed D18874: refactor: Replace GetTimeMicros by SystemClock.
Wed, Nov 5, 16:51
Fabien committed rABCa57a19a7b4a0: refactor: Replace GetTimeMicros by SystemClock (authored by Fabien).
refactor: Replace GetTimeMicros by SystemClock
Wed, Nov 5, 16:51
Fabien committed rABC311f263c08e8: log: Use steady clock for bench logging (authored by MacroFake <falke.marco@gmail.com>).
log: Use steady clock for bench logging
Wed, Nov 5, 16:51
Fabien committed rABC3f84968a29c7: Early logging improvements (authored by Anthony Towns <aj@erisian.com.au>).
Early logging improvements
Wed, Nov 5, 16:51