Page MenuHomePhabricator
Feed All Stories

Apr 15 2019

nakihito added a parent task for T603: Backport Core PR 10976: Refactor: separate wallet from node: T602: Backport Core PR 15288: Remove wallet -> node global function calls.
Apr 15 2019, 22:51 · Restricted Project, Backport
nakihito added a subtask for T602: Backport Core PR 15288: Remove wallet -> node global function calls: T603: Backport Core PR 10976: Refactor: separate wallet from node.
Apr 15 2019, 22:51 · Restricted Project, Backport
nakihito added a parent task for T600: Backport Core PR 14711: Refactor: Start to separate wallet from node: T603: Backport Core PR 10976: Refactor: separate wallet from node.
Apr 15 2019, 22:50 · Restricted Project, Backport
nakihito added a subtask for T603: Backport Core PR 10976: Refactor: separate wallet from node: T600: Backport Core PR 14711: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:50 · Restricted Project, Backport
nakihito triaged T603: Backport Core PR 10976: Refactor: separate wallet from node as High priority.
Apr 15 2019, 22:50 · Restricted Project, Backport
teamcity added a comment to D2805: GUI: Receive: Remove option to reuse a previous address.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 22:48
nakihito triaged T602: Backport Core PR 15288: Remove wallet -> node global function calls as High priority.
Apr 15 2019, 22:47 · Restricted Project, Backport
nakihito closed T599: Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address, a subtask of T417: Backport PR10244 from core, as Resolved.
Apr 15 2019, 22:45 · Backport
nakihito closed T599: Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address as Resolved.
Apr 15 2019, 22:45 · Restricted Project, Backport
Nico Guiton <nico@bitframe.org> committed rABC646720f32fdc: GUI: Receive: Remove option to reuse a previous address (authored by Luke Dashjr <luke-jr+git@utopios.org>).
GUI: Receive: Remove option to reuse a previous address
Apr 15 2019, 22:43
Diffusion closed D2805: GUI: Receive: Remove option to reuse a previous address.
Apr 15 2019, 22:42
teamcity added a comment to D2805: GUI: Receive: Remove option to reuse a previous address.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 22:42
nakihito updated the diff for D2805: GUI: Receive: Remove option to reuse a previous address.

rebased.

Apr 15 2019, 22:41
jasonbcox closed T560: Backport Core PR 11041, a subtask of T417: Backport PR10244 from core, as Resolved.
Apr 15 2019, 22:39 · Backport
jasonbcox closed T560: Backport Core PR 11041 as Resolved.
Apr 15 2019, 22:39 · Backport
jasonbcox committed rABC60d8a7a5a5ed: Merge #11041: Add LookupBlockIndex (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11041: Add LookupBlockIndex
Apr 15 2019, 22:38
jasonbcox closed D2793: Merge #11041: Add LookupBlockIndex.
Apr 15 2019, 22:38
teamcity added a comment to D2805: GUI: Receive: Remove option to reuse a previous address.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 22:34
teamcity added a comment to D2805: GUI: Receive: Remove option to reuse a previous address.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 22:34
nakihito updated the diff for D2805: GUI: Receive: Remove option to reuse a previous address.

Edited release notes to further clarify change in behavior.

Apr 15 2019, 22:34
jasonbcox accepted D2805: GUI: Receive: Remove option to reuse a previous address.
Apr 15 2019, 22:33
jasonbcox added inline comments to D2805: GUI: Receive: Remove option to reuse a previous address.
Apr 15 2019, 22:31
nakihito updated the summary of D2805: GUI: Receive: Remove option to reuse a previous address.
Apr 15 2019, 22:31
nakihito triaged T601: Backport Core PR 10973: Refactor: separate wallet from node as High priority.
Apr 15 2019, 22:28 · Restricted Project, Backport
nakihito removed a parent task for T592: Backport Core PR 14437: Refactor: Start to separate wallet from node: T600: Backport Core PR 14711: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:27 · Backport, Restricted Project
nakihito added a parent task for T596: Backport Core PR 14350: Add WalletLocation class: T600: Backport Core PR 14711: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:27 · Restricted Project, Backport
nakihito edited subtasks for T600: Backport Core PR 14711: Refactor: Start to separate wallet from node, added: T596: Backport Core PR 14350: Add WalletLocation class; removed: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:27 · Restricted Project, Backport
nakihito added a parent task for T592: Backport Core PR 14437: Refactor: Start to separate wallet from node: T600: Backport Core PR 14711: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:26 · Backport, Restricted Project
nakihito added a subtask for T600: Backport Core PR 14711: Refactor: Start to separate wallet from node: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
Apr 15 2019, 22:26 · Restricted Project, Backport
nakihito triaged T600: Backport Core PR 14711: Refactor: Start to separate wallet from node as High priority.
Apr 15 2019, 22:26 · Restricted Project, Backport
teamcity added a comment to D2805: GUI: Receive: Remove option to reuse a previous address.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 22:20
jasonbcox committed rABC76219fe2fda1: Update release notes for 0.19.3 to include instructions for re-enabling… (authored by jasonbcox).
Update release notes for 0.19.3 to include instructions for re-enabling…
Apr 15 2019, 22:20
Herald added a reviewer for D2805: GUI: Receive: Remove option to reuse a previous address: Restricted Project.
Apr 15 2019, 22:19
jasonbcox closed D2802: Update release notes for 0.19.3 to include instructions for re-enabling deprecated signrawtransaction.
Apr 15 2019, 22:19
nakihito triaged T599: Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address as High priority.
Apr 15 2019, 21:56 · Restricted Project, Backport
nakihito placed T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members up for grabs.
Apr 15 2019, 21:32 · Restricted Project, Backport
nakihito triaged T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members as Low priority.
Apr 15 2019, 21:32 · Restricted Project, Backport
nakihito renamed T597: Backport Core PR 15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled from Backport Core PR 16357: rpc: Don't ignore `-maxtxfee` when wallet is disabled to Backport Core PR 15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled .
Apr 15 2019, 20:21 · Restricted Project, Backport
nakihito triaged T597: Backport Core PR 15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled as Low priority.
Apr 15 2019, 20:20 · Restricted Project, Backport
nakihito updated the task description for T596: Backport Core PR 14350: Add WalletLocation class.
Apr 15 2019, 20:02 · Restricted Project, Backport
nakihito removed a parent task for T592: Backport Core PR 14437: Refactor: Start to separate wallet from node: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Apr 15 2019, 20:01 · Backport, Restricted Project
nakihito removed a subtask for T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
Apr 15 2019, 20:01 · Restricted Project, Backport
teamcity added a comment to D2755: [secp256k1] add schnorr sign jni binding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 18:49
floreslorca committed rABC60e30bca748a: [secp256k1] add schnorr sign jni binding (authored by floreslorca).
[secp256k1] add schnorr sign jni binding
Apr 15 2019, 18:35
teamcity added a comment to D2755: [secp256k1] add schnorr sign jni binding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 18:35
floreslorca closed D2755: [secp256k1] add schnorr sign jni binding.
Apr 15 2019, 18:35
floreslorca updated the diff for D2755: [secp256k1] add schnorr sign jni binding.

fix comment

Apr 15 2019, 18:34
nakihito added a parent task for T592: Backport Core PR 14437: Refactor: Start to separate wallet from node: T596: Backport Core PR 14350: Add WalletLocation class.
Apr 15 2019, 18:19 · Backport, Restricted Project
nakihito added a subtask for T596: Backport Core PR 14350: Add WalletLocation class: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
Apr 15 2019, 18:19 · Restricted Project, Backport
nakihito triaged T596: Backport Core PR 14350: Add WalletLocation class as High priority.
Apr 15 2019, 18:18 · Restricted Project, Backport
teamcity added a comment to D2755: [secp256k1] add schnorr sign jni binding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 18:15
nakihito removed a parent task for T417: Backport PR10244 from core: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Apr 15 2019, 18:12 · Backport
nakihito removed a subtask for T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency: T417: Backport PR10244 from core.
Apr 15 2019, 18:12 · Restricted Project, Backport
nakihito added a parent task for T592: Backport Core PR 14437: Refactor: Start to separate wallet from node: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Apr 15 2019, 18:12 · Backport, Restricted Project
nakihito added a subtask for T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
Apr 15 2019, 18:12 · Restricted Project, Backport
Fabien accepted D2755: [secp256k1] add schnorr sign jni binding.
Apr 15 2019, 18:11
nakihito added a parent task for T417: Backport PR10244 from core: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Apr 15 2019, 18:10 · Backport
nakihito added a subtask for T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency: T417: Backport PR10244 from core.
Apr 15 2019, 18:10 · Restricted Project, Backport
nakihito triaged T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency as Normal priority.
Apr 15 2019, 18:09 · Restricted Project, Backport
teamcity added a comment to D2755: [secp256k1] add schnorr sign jni binding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 18:01
floreslorca updated the diff for D2755: [secp256k1] add schnorr sign jni binding.

rebase

Apr 15 2019, 18:00
nakihito added a project to T581: Backport Core PR 14206: Backport.
Apr 15 2019, 16:59 · Backport, Bootcamp, Restricted Project
nakihito added a project to T582: Backport Core PR 13341: Backport.
Apr 15 2019, 16:59 · Backport, Bootcamp, Restricted Project
nakihito added a project to T554: Backport Core PR 11499: Backport.
Apr 15 2019, 16:59 · Backport, Bootcamp, Restricted Project
nakihito added a project to T583: Backport Core PR 13190: Backport.
Apr 15 2019, 16:59 · Backport, Bootcamp, Restricted Project
teamcity added a comment to D2766: Add Sent and Received information to the debug menu peer list.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 16:46
teamcity added a comment to D2766: Add Sent and Received information to the debug menu peer list.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 16:31
nakihito updated the diff for D2766: Add Sent and Received information to the debug menu peer list.

Added braces {} to if statements. Linter did not catch these for some reason?

Apr 15 2019, 16:31
deadalnix added a reverting change for rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist: rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 14:13
deadalnix committed rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist" (authored by deadalnix).
Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist"
Apr 15 2019, 14:13
deadalnix closed D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 14:13
Fabien accepted D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".

I will search for the cause of the performance issue and re-enable it when it gets fixed

Apr 15 2019, 14:02
teamcity added a comment to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 14:00
Fabien committed rABCdb99036786ac: [LINTER] Enforce custom coding standard for PHP files (authored by Fabien).
[LINTER] Enforce custom coding standard for PHP files
Apr 15 2019, 13:52
Fabien closed D2764: [LINTER] Enforce custom coding standard for PHP files.
Apr 15 2019, 13:52
teamcity added a comment to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 13:46
Fabien updated the diff for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Add double quotes

Apr 15 2019, 13:44
teamcity added a comment to D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 13:19
teamcity added a comment to D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 13:05
deadalnix added a reverting change for rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist: D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 13:04
Herald added a reviewer for D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist": Restricted Project.
Apr 15 2019, 13:04
deadalnix accepted D2800: Extract CSipHasher to it's own file in crypto/ directory..
Apr 15 2019, 11:54
deadalnix added inline comments to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 15 2019, 11:53
deadalnix accepted D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 15 2019, 11:53
deadalnix accepted D2764: [LINTER] Enforce custom coding standard for PHP files.
Apr 15 2019, 11:52
deadalnix requested changes to D2803: blockfilter: add GCSFilter class.
Apr 15 2019, 11:22
Fabien accepted D2793: Merge #11041: Add LookupBlockIndex.
Apr 15 2019, 07:48
teamcity added a comment to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 15 2019, 07:36
teamcity added a comment to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 15 2019, 07:21
Fabien updated the diff for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Add a comment and set the directory relative to the CMAKE_CURRENT_BINARY_DIR

Apr 15 2019, 07:20

Apr 14 2019

teamcity added a comment to D2800: Extract CSipHasher to it's own file in crypto/ directory..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 14 2019, 23:51
teamcity added a comment to D2803: blockfilter: add GCSFilter class.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 14 2019, 23:45
teamcity added a comment to D2800: Extract CSipHasher to it's own file in crypto/ directory..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 14 2019, 23:37
markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..

cstdint

Apr 14 2019, 23:36
teamcity added a comment to D2803: blockfilter: add GCSFilter class.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 14 2019, 23:31
markblundeberg updated the diff for D2803: blockfilter: add GCSFilter class.

char eradication and header normalization

Apr 14 2019, 23:30
schancel added inline comments to D1936: Move handling for `-maxtxfee` to the config object.
Apr 14 2019, 20:09
deadalnix added inline comments to D1936: Move handling for `-maxtxfee` to the config object.
Apr 14 2019, 19:56
deadalnix requested changes to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 14 2019, 19:51
deadalnix accepted D2802: Update release notes for 0.19.3 to include instructions for re-enabling deprecated signrawtransaction.
Apr 14 2019, 19:38