Page MenuHomePhabricator
Feed All Stories

May 15 2019

teamcity added a comment to D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 20:08
teamcity added a comment to D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 19:54
Fabien updated the diff for D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Comment on boost/thread use.

May 15 2019, 19:53
deadalnix accepted D3030: [CMAKE] Fix missing protobuf include directory.
May 15 2019, 18:43
jasonbcox accepted D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Nit: comment these as needed on Windows

May 15 2019, 17:16
teamcity added a comment to D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 16:06
teamcity added a comment to D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 15:52
Herald added a reviewer for D3054: Fix boost::thread::interruption_point causing build failure on Windows: deadalnix.
May 15 2019, 15:51
teamcity added a comment to D3053: Count checkdatasig for transaction entering the mempool.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 14:32
deadalnix committed rABCfd1e8051b429: Count checkdatasig for transaction entering the mempool (authored by deadalnix).
Count checkdatasig for transaction entering the mempool
May 15 2019, 14:24
deadalnix closed D3053: Count checkdatasig for transaction entering the mempool.
May 15 2019, 14:24
Fabien accepted D3053: Count checkdatasig for transaction entering the mempool.
May 15 2019, 14:24
teamcity added a comment to D3053: Count checkdatasig for transaction entering the mempool.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 14:18
jasonbcox accepted D3053: Count checkdatasig for transaction entering the mempool.
May 15 2019, 14:18
Herald added a reviewer for D3053: Count checkdatasig for transaction entering the mempool: Restricted Project.
May 15 2019, 14:17
teamcity added a comment to D3052: Update man pages for v0.19.6.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 12:54
teamcity added a comment to D3051: Update chainparams for 0.19.6 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 12:48
Fabien committed rABCf27da0752c0a: Update man pages for v0.19.6 (authored by Fabien).
Update man pages for v0.19.6
May 15 2019, 12:42
Fabien closed D3052: Update man pages for v0.19.6.
May 15 2019, 12:42
Fabien committed rABC965834d5e72a: Update chainparams for 0.19.6 release (authored by Fabien).
Update chainparams for 0.19.6 release
May 15 2019, 12:42
Fabien closed D3051: Update chainparams for 0.19.6 release.
May 15 2019, 12:42
deadalnix accepted D3052: Update man pages for v0.19.6.
May 15 2019, 12:41
jasonbcox accepted D3052: Update man pages for v0.19.6.
May 15 2019, 12:41
teamcity added a comment to D3052: Update man pages for v0.19.6.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 12:41
Herald added a reviewer for D3052: Update man pages for v0.19.6: deadalnix.
May 15 2019, 12:40
Mengerian accepted D3051: Update chainparams for 0.19.6 release.

Checked on my local node, parameters look good.

May 15 2019, 12:39
deadalnix accepted D3051: Update chainparams for 0.19.6 release.
May 15 2019, 12:39
jasonbcox accepted D3051: Update chainparams for 0.19.6 release.
May 15 2019, 12:35
teamcity added a comment to D3051: Update chainparams for 0.19.6 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 12:34
Herald added a reviewer for D3051: Update chainparams for 0.19.6 release: deadalnix.
May 15 2019, 12:34
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Rebase + added missing includes due to refactors over the last couple weeks

May 15 2019, 12:15
teamcity added a comment to D3050: Fix more init bugs..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 11:31
deadalnix accepted D3050: Fix more init bugs..
May 15 2019, 11:19
Fabien updated the test plan for D3050: Fix more init bugs..
May 15 2019, 11:16
teamcity added a comment to D3050: Fix more init bugs..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 11:16
Herald added a reviewer for D3050: Fix more init bugs.: deadalnix.
May 15 2019, 11:15
nakihito requested review of D3024: [tests] Remove unused variables.
May 15 2019, 01:00
teamcity added a comment to D3049: Merge #12333: Make CWallet::ListCoins atomic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 15 2019, 00:47
teamcity added a comment to D3049: Merge #12333: Make CWallet::ListCoins atomic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 15 2019, 00:33
Herald added a reviewer for D3049: Merge #12333: Make CWallet::ListCoins atomic: Restricted Project.
May 15 2019, 00:32

May 14 2019

Nico Guiton <nico@bitframe.org> committed rABC97b7b1b2388f: Merge #11385: Remove some unused functions and methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11385: Remove some unused functions and methods
May 14 2019, 23:10
Diffusion closed D3044: Merge #11385: Remove some unused functions and methods.
May 14 2019, 23:10
markblundeberg requested review of D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Please write a proper test plan.

May 14 2019, 23:08
markblundeberg updated the test plan for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
May 14 2019, 23:07
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 23:02
teamcity added a comment to D3047: Move RPC registration out of AppInitParameterInteraction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 23:01
deadalnix requested changes to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Please write a proper test plan.

May 14 2019, 22:57
teamcity added a comment to D3048: wallet: Refactor g_wallet_init_interface to const reference.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 22:54
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 22:49
teamcity added a comment to D3047: Move RPC registration out of AppInitParameterInteraction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 22:48
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

rebase for retest (same random rpc_listtransactions.py failure occured earlier in D2750)

May 14 2019, 22:47
deadalnix updated the diff for D3047: Move RPC registration out of AppInitParameterInteraction.

Fix initial diff broken due to DDoS

May 14 2019, 22:47
teamcity added a comment to D3039: Consensus: Minimal way to move dust out of consensus.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 22:46
deadalnix accepted D3044: Merge #11385: Remove some unused functions and methods.
May 14 2019, 22:42
deadalnix accepted D3041: [CMAKE] Allow to use sanitizers with cmake.
May 14 2019, 22:41
teamcity added a comment to D3048: wallet: Refactor g_wallet_init_interface to const reference.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 22:41
Herald added a reviewer for D3048: wallet: Refactor g_wallet_init_interface to const reference: Restricted Project.
May 14 2019, 22:40
Harbormaster failed remote builds in B5852: Diff 8664 for D3047: Move RPC registration out of AppInitParameterInteraction!
May 14 2019, 22:33
teamcity added a comment to D3047: Move RPC registration out of AppInitParameterInteraction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

May 14 2019, 22:33
teamcity added a comment to D3047: Move RPC registration out of AppInitParameterInteraction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 22:32
nakihito updated the diff for D3039: Consensus: Minimal way to move dust out of consensus.

Fixed comment formatting and removed references to segwit.

May 14 2019, 22:32
Herald added a reviewer for D3047: Move RPC registration out of AppInitParameterInteraction: Restricted Project.
May 14 2019, 22:32
teamcity added a comment to D3046: Fix D2181 by including DumpRPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 21:57
teamcity added a comment to D3046: Fix D2181 by including DumpRPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 21:43
Herald added a reviewer for D3046: Fix D2181 by including DumpRPC: Restricted Project.
May 14 2019, 21:42
teamcity added a comment to D3045: wallet: Make WalletInitInterface members const.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 21:30
deadalnix accepted D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
May 14 2019, 21:28
deadalnix updated the diff for D3045: wallet: Make WalletInitInterface members const.

Reup

May 14 2019, 21:15
deadalnix committed rABCf4cea37d423c: Remove useless include of boost thread (authored by deadalnix).
Remove useless include of boost thread
May 14 2019, 19:07
deadalnix closed D3042: Remove useless include of boost thread.
May 14 2019, 19:06
Herald added a reviewer for D3044: Merge #11385: Remove some unused functions and methods: Restricted Project.
May 14 2019, 18:24
Harbormaster failed remote builds in B5847: Diff 8658 for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`!
May 14 2019, 17:55
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

May 14 2019, 17:50
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
In D3040#71594, @Fabien wrote:

I get the warnings, which compiler do you use ?

May 14 2019, 17:49
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
In D3040#71594, @Fabien wrote:

I get the warnings, which compiler do you use ?

May 14 2019, 17:44
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

update per Fabien comments

May 14 2019, 17:37
markblundeberg added inline comments to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
May 14 2019, 17:35
markblundeberg requested review of D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 14 2019, 17:18
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9833: Trivial: fix comments referencing AppInit2
May 14 2019, 17:16
Diffusion closed D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
May 14 2019, 17:16
Herald added a reviewer for D3043: [docs] Reformat -help output for help2man: Restricted Project.
May 14 2019, 17:15
Nico Guiton <nico@bitframe.org> committed rABCa9cd88bfcd32: Merge #10280: [test] Unit test amount.h/amount.cpp (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10280: [test] Unit test amount.h/amount.cpp
May 14 2019, 16:56
Diffusion closed D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
May 14 2019, 16:56
jasonbcox committed rABC0ace84b6fe2e: Merge #9980: Fix mem access violation merkleblock (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #9980: Fix mem access violation merkleblock
May 14 2019, 16:53
jasonbcox closed D3009: Merge #9980: Fix mem access violation merkleblock.
May 14 2019, 16:53
jasonbcox committed rABC965b235866e3: Update disclosure policy standards (authored by jasonbcox).
Update disclosure policy standards
May 14 2019, 16:42
jasonbcox closed D2762: Update disclosure policy standards.
May 14 2019, 16:42
jasonbcox accepted D3042: Remove useless include of boost thread.

iirc there are backports that do similar things, but this is a good start regardless

May 14 2019, 16:39
teamcity added a comment to D3042: Remove useless include of boost thread.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 16:16
markblundeberg added inline comments to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 14 2019, 16:12
markblundeberg added inline comments to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 14 2019, 16:11
jasonbcox accepted D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
May 14 2019, 16:11
teamcity added a comment to D3042: Remove useless include of boost thread.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 16:02
Herald added a reviewer for D3042: Remove useless include of boost thread: Restricted Project.
May 14 2019, 16:01
jasonbcox requested changes to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 14 2019, 15:59
markblundeberg added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.
In D3026#71602, @Fabien wrote:

Clearing my queue, see D3035

May 14 2019, 15:02
markblundeberg abandoned D3026: Merge #10267: New -includeconf argument for including external configuration files.
May 14 2019, 15:01
teamcity added a comment to D3041: [CMAKE] Allow to use sanitizers with cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 14 2019, 14:27
teamcity added a comment to D3041: [CMAKE] Allow to use sanitizers with cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 14 2019, 14:14
Fabien updated the diff for D3041: [CMAKE] Allow to use sanitizers with cmake.

Hide ECM to the caller

May 14 2019, 14:13