Page MenuHomePhabricator
Feed All Stories

Jun 12 2019

teamcity added a comment to D3305: Fix comments in miner.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 20:47
deadalnix created D3305: Fix comments in miner.h.
Jun 12 2019, 20:46
deadalnix added a comment to D3283: Merge #10408, #13291, and partial #13163.

Why are all of these together ?

Jun 12 2019, 20:07
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 17:38
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 17:32
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

Fixed includes ordering.

Jun 12 2019, 17:32
D3253: Remove Schnorr activation now requires changes to proceed.

It is very hard to ensure this is correct.

Jun 12 2019, 17:18
D3254: Revert "add flags to VerifySignature and sigcache" is now accepted and ready to land.

This is correct as long as we "pretend" schnorr always was activated.

Jun 12 2019, 17:15
D3267: check negative CScriptNum.getint() and introduce new error code now requires changes to proceed.

Please don't add more assumptions into the code. Also please explain why this is needed for schnorr multisig.

Jun 12 2019, 17:12
D3299: [LINTER] Run selected linters last now requires changes to proceed.
Jun 12 2019, 17:03
D3300: [LINTER] Run some linter only once now requires changes to proceed.

You can call the linter n times, but only do the work once. You know a configuration is not what you are after because it makes no sense to run that linter multiple time. This is a property of the linter, not of the environment in which it runs so we clearly are facing a new type of linter, not a new workflow to be configured

Jun 12 2019, 17:01
teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 16:19
teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 16:12
deadalnix created D3304: Add a test to make sure that negative effective values are filtered.
Jun 12 2019, 16:12
teamcity added a comment to D3303: Benchmark BnB in the worst case where it exhausts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 15:59
teamcity added a comment to D3303: Benchmark BnB in the worst case where it exhausts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 15:52
deadalnix created D3303: Benchmark BnB in the worst case where it exhausts.
Jun 12 2019, 15:52
teamcity added a comment to D3302: Build wallet dependent benchmark using cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 15:48
teamcity added a comment to D3302: Build wallet dependent benchmark using cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 15:41
deadalnix created D3302: Build wallet dependent benchmark using cmake.
Jun 12 2019, 15:41
jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Missed Amaury's comment regarding testing. This is a good idea and should be included.

Jun 12 2019, 15:40
deadalnix committed rABCcd606f147cba: Use a struct for output eligibility (authored by Andrew Chow <achow101-github@achow101.com>).
Use a struct for output eligibility
Jun 12 2019, 15:18
deadalnix closed D3246: Use a struct for output eligibility.
Jun 12 2019, 15:18
markblundeberg requested review of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 12 2019, 14:52
teamcity added a comment to D3252: Add tests for the Branch and Bound algorithm.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:30
teamcity added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:27
teamcity added a comment to D3252: Add tests for the Branch and Bound algorithm.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:23
teamcity added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:23
Fabien added inline comments to D3252: Add tests for the Branch and Bound algorithm.
Jun 12 2019, 14:23
deadalnix added a comment to D3252: Add tests for the Branch and Bound algorithm.

Reorder includes

Jun 12 2019, 14:22
deadalnix added inline comments to D3252: Add tests for the Branch and Bound algorithm.
Jun 12 2019, 14:20
teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:19
teamcity added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:19
deadalnix added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

rebase

Jun 12 2019, 14:18
teamcity added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:16
deadalnix added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Reoder includes

Jun 12 2019, 14:15
teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 14:14
teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:11
deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

rebase

Jun 12 2019, 14:10
teamcity added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 14:07
deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Address comments

Jun 12 2019, 14:07
deadalnix committed rABC721d2df22e50: Store effective value, fee, and long term fee in CInputCoin (authored by Andrew Chow <achow101-github@achow101.com>).
Store effective value, fee, and long term fee in CInputCoin
Jun 12 2019, 14:00
deadalnix closed D3248: Store effective value, fee, and long term fee in CInputCoin.
Jun 12 2019, 14:00
deadalnix committed rABCa0f222f20b3e: Move output eligibility to a separate function (authored by Andrew Chow <achow101-github@achow101.com>).
Move output eligibility to a separate function
Jun 12 2019, 13:57
deadalnix closed D3245: Move output eligibility to a separate function.
Jun 12 2019, 13:57
deadalnix committed rABCf578ca9dd0fb: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee (authored by Andrew Chow <achow101-github@achow101.com>).
Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee
Jun 12 2019, 13:53
deadalnix closed D3251: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee.
Jun 12 2019, 13:53
deadalnix committed rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size (authored by Alex Morcos <morcos@chaincode.com>).
Fix rounding errors in calculation of minimum change size
Jun 12 2019, 13:51
deadalnix closed D3291: Fix rounding errors in calculation of minimum change size.
Jun 12 2019, 13:51
deadalnix committed rABCf4321052c578: Don't create change at the dust limit, even if it means paying more than… (authored by Alex Morcos <morcos@chaincode.com>).
Don't create change at the dust limit, even if it means paying more than…
Jun 12 2019, 13:49
deadalnix closed D3296: Don't create change at the dust limit, even if it means paying more than expected.
Jun 12 2019, 13:49
deadalnix committed rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients (authored by Alex Morcos <morcos@chaincode.com>).
Eliminate fee overpaying edge case when subtracting fee from recipients
Jun 12 2019, 13:47
deadalnix closed D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.
Jun 12 2019, 13:47
Fabien requested review of D3299: [LINTER] Run selected linters last.
Jun 12 2019, 13:14
Fabien added a comment to D3300: [LINTER] Run some linter only once.

Arcanist (and more specifically the ArcanistLintWorkFlow) calls each linter for every path that match the filter.
There is no feature to indicate to run it once, or you have to create another workflow from scratch rather than using a linter.
I evaluated this as well, but that would make a much more complicated solution with no real advantage.

Jun 12 2019, 13:08
D3265: add new encoding checker for Schnorr sigs now requires changes to proceed.
Jun 12 2019, 13:06
D3271: add SCRIPTSIGMINPUSHONLY flag and logic now requires changes to proceed.
Jun 12 2019, 13:02
D3299: [LINTER] Run selected linters last now requires changes to proceed.
Jun 12 2019, 13:00
D3291: Fix rounding errors in calculation of minimum change size is now accepted and ready to land.
Jun 12 2019, 12:57
D3292: Explicitly call out updating makeseeds.py after major releases now requires changes to proceed.
Jun 12 2019, 12:57
D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.
Jun 12 2019, 12:56
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 12:56
D3300: [LINTER] Run some linter only once now requires changes to proceed.

Why can't the linter un once to begin with, instead o having a linter that run multiple times and then build all kind of scafolding to have it run only once ?

Jun 12 2019, 12:55
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:50
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:50
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:49
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 12:48
deadalnix created D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:48
D3290: Move original knapsack solver tests to coinselector_tests.cpp is now accepted and ready to land.
Jun 12 2019, 12:34
D3289: Move current coin selection algorithm to coinselection.{cpp,h} is now accepted and ready to land.
Jun 12 2019, 12:26
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.

Please test running with TOR and add it to the test plan

Jun 12 2019, 11:23
teamcity added a comment to D3300: [LINTER] Run some linter only once.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 10:45
teamcity added a comment to D3299: [LINTER] Run selected linters last.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 10:44
teamcity added a comment to D3298: Introducing the new Bitcoin ABC lint engine.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 10:40
teamcity added a comment to D3300: [LINTER] Run some linter only once.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 10:37
Fabien created D3300: [LINTER] Run some linter only once.
Jun 12 2019, 10:37
teamcity added a comment to D3299: [LINTER] Run selected linters last.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 10:36
Fabien created D3299: [LINTER] Run selected linters last.
Jun 12 2019, 10:35
teamcity added a comment to D3298: Introducing the new Bitcoin ABC lint engine.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 10:34
Fabien created D3298: Introducing the new Bitcoin ABC lint engine.
Jun 12 2019, 10:34
Fabien committed rABC87fc03d54257: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory (authored by Fabien).
[LINTER] Move phpcs ruleset to a test/lint/phpcs directory
Jun 12 2019, 10:32
Fabien closed D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.
Jun 12 2019, 10:32
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 08:55
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 08:49
Fabien added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Rename the ruleset file phpcs_ruleset => bitcoinabc_ruleset

Jun 12 2019, 08:49
Fabien committed rABC70635fc8ac4b: [LINTER] Fix some PHP linter rules (authored by Fabien).
[LINTER] Fix some PHP linter rules
Jun 12 2019, 08:46
Fabien closed D3287: [LINTER] Fix some PHP linter rules.
Jun 12 2019, 08:46
Fabien committed rABC882b9d780536: Fix make distcheck (authored by fanquake <fanquake@gmail.com>).
Fix make distcheck
Jun 12 2019, 08:38
Fabien closed D3256: Fix make distcheck.
Jun 12 2019, 08:38
nakihito added a comment to D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.

Merged with D3283.

Jun 12 2019, 00:41
D3297: Eliminate fee overpaying edge case when subtracting fee from recipients is now accepted and ready to land.
Jun 12 2019, 00:38
D3296: Don't create change at the dust limit, even if it means paying more than expected is now accepted and ready to land.
Jun 12 2019, 00:34
nakihito retitled D3283: Merge #10408, #13291, and partial #13163 from Merge #10408: Net: Improvements to Tor control port parser to Merge #10408, #13291, and partial #13163.
Jun 12 2019, 00:31
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 00:29
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 12 2019, 00:23
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

Merged with PR13921 and the torcontrol_test.cpp parts of PR13163.

Jun 12 2019, 00:23
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.

There is already logic to check if a push is minimal or not, duplicating indicate the approach is wrong.

Jun 12 2019, 00:08
teamcity added a comment to D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 12 2019, 00:02

Jun 11 2019

teamcity added a comment to D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 11 2019, 23:56
deadalnix created D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.
Jun 11 2019, 23:56