Page MenuHomePhabricator
Feed All Stories

Sep 11 2019

teamcity added a comment to D4018: Do not construct out-of-bound pointers in SHA2 code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:09
teamcity added a comment to D4044: Fixes compilation of leveldb tests broken in D4004.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 19:52
fpelliccioni committed rABC4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
Sep 11 2019, 19:46
fpelliccioni closed D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).
Sep 11 2019, 19:46
fpelliccioni committed rABC29fec420b3e2: Pull leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Pull leveldb subtree
Sep 11 2019, 19:44
fpelliccioni closed D4016: Pull leveldb subtree.
Sep 11 2019, 19:44
fpelliccioni added a reviewer for D4044: Fixes compilation of leveldb tests broken in D4004: Fabien.
Sep 11 2019, 19:42
teamcity added a comment to D4044: Fixes compilation of leveldb tests broken in D4004.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 19:39
fpelliccioni created D4044: Fixes compilation of leveldb tests broken in D4004.
Sep 11 2019, 19:39
Fabien requested changes to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Sep 11 2019, 19:33
teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 19:21
Fabien committed rABC4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt (authored by Fabien).
[CMAKE] Move version to the top level CMakeLists.txt
Sep 11 2019, 19:16
Fabien closed D4028: [CMAKE] Move version to the top level CMakeLists.txt.
Sep 11 2019, 19:16
Fabien committed rABCe43e4bb9c56b: [CMAKE] Rename the top-level and `src/` cmake projects (authored by Fabien).
[CMAKE] Rename the top-level and `src/` cmake projects
Sep 11 2019, 19:16
Fabien closed D4027: [CMAKE] Rename the top-level and `src/` cmake projects.
Sep 11 2019, 19:15
teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 19:14
Fabien updated the diff for D4014: [CI] Make IBD a standard build configuration.

Rebase on top of D4003.

Sep 11 2019, 19:14
teamcity added a comment to D3750: Merge #12159: Use the character based overload for std::string::find..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 18:35
teamcity added a comment to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 18:28
teamcity added a comment to D3750: Merge #12159: Use the character based overload for std::string::find..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 18:27
nakihito updated the diff for D3750: Merge #12159: Use the character based overload for std::string::find..

Fixed remaining instance in wallet.h.

Sep 11 2019, 18:27
teamcity added a comment to D4042: Merge #11220: Check specific validation error in miner tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 18:17
teamcity added a comment to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 18:13
fpelliccioni created D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Sep 11 2019, 18:13
teamcity added a comment to D4042: Merge #11220: Check specific validation error in miner tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 18:10
nakihito updated the diff for D4042: Merge #11220: Check specific validation error in miner tests.

Fixed comment.

Sep 11 2019, 18:10
jasonbcox requested changes to D4042: Merge #11220: Check specific validation error in miner tests.
Sep 11 2019, 17:57
teamcity added a comment to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 17:56
jasonbcox added inline comments to D4040: Remove CheckBlockHeader's dependency on Config.
Sep 11 2019, 17:53
jasonbcox requested changes to D4041: Remove ContextualCheckBlock's dependency on Config.
Sep 11 2019, 17:52
jasonbcox requested changes to D4040: Remove CheckBlockHeader's dependency on Config.
Sep 11 2019, 17:50
nakihito requested review of D4042: Merge #11220: Check specific validation error in miner tests.
Sep 11 2019, 17:50
teamcity added a comment to D4042: Merge #11220: Check specific validation error in miner tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 17:44
teamcity added a comment to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 17:42
teamcity added a comment to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 17:40
jasonbcox added inline comments to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.
Sep 11 2019, 17:40
teamcity added a comment to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 17:39
jasonbcox updated the diff for D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Fixed get_wallet_rpc to be on par with getattr

Sep 11 2019, 17:39
nakihito updated the summary of D4042: Merge #11220: Check specific validation error in miner tests.
Sep 11 2019, 17:37
teamcity added a comment to D4042: Merge #11220: Check specific validation error in miner tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 17:37
nakihito planned changes to D4042: Merge #11220: Check specific validation error in miner tests.
Sep 11 2019, 17:36
nakihito created D4042: Merge #11220: Check specific validation error in miner tests.
Sep 11 2019, 17:36
teamcity added a comment to D4041: Remove ContextualCheckBlock's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 17:22
teamcity added a comment to D4041: Remove ContextualCheckBlock's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 17:13
deadalnix created D4041: Remove ContextualCheckBlock's dependency on Config.
Sep 11 2019, 17:13
jasonbcox requested changes to D4014: [CI] Make IBD a standard build configuration.

The changes to ibd.sh got incorporated into D4003. Please rebase and use BITCOIND (or rename it to BITCOIND_BINARY, which is fine too).

Sep 11 2019, 17:09
teamcity added a comment to D4040: Remove CheckBlockHeader's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 17:06
jasonbcox committed rABCe4747a18e925: Generalized ibd.sh to provide a logging tool for running similar types of tests (authored by jasonbcox).
Generalized ibd.sh to provide a logging tool for running similar types of tests
Sep 11 2019, 17:05
jasonbcox closed D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Sep 11 2019, 17:05
teamcity added a comment to D4040: Remove CheckBlockHeader's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 16:57
deadalnix created D4040: Remove CheckBlockHeader's dependency on Config.
Sep 11 2019, 16:57
jasonbcox accepted D4028: [CMAKE] Move version to the top level CMakeLists.txt.
Sep 11 2019, 16:46
Fabien requested review of D4038: [CMAKE] Fix Linux64 toolchain name.

Fixed a typo in the test plan and improved the instructions

Sep 11 2019, 16:35
Fabien updated the test plan for D4038: [CMAKE] Fix Linux64 toolchain name.
Sep 11 2019, 16:35
Fabien updated the test plan for D4038: [CMAKE] Fix Linux64 toolchain name.
Sep 11 2019, 16:34
deadalnix requested changes to D4038: [CMAKE] Fix Linux64 toolchain name.

The test plan is not appropriate.

Sep 11 2019, 16:02
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 15:53
deadalnix committed rABC0be377a50ccc: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config (authored by deadalnix).
Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config
Sep 11 2019, 15:50
deadalnix closed D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.
Sep 11 2019, 15:50
deadalnix committed rABC31fa4da44001: Remove ReadBlockFromDisk's dependency on Config (authored by deadalnix).
Remove ReadBlockFromDisk's dependency on Config
Sep 11 2019, 15:47
deadalnix closed D4033: Remove ReadBlockFromDisk's dependency on Config.
Sep 11 2019, 15:47
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 15:47
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 15:46
Fabien accepted D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Sep 11 2019, 15:44
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Disable verbose logging while printing the help message, otherwise it's impossible to read.

Sep 11 2019, 15:41
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 15:39
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Fix bad rebase

Sep 11 2019, 15:39
deadalnix committed rABCfd79071ecb95: Remove dependency on Config from the PoW code (authored by deadalnix).
Remove dependency on Config from the PoW code
Sep 11 2019, 15:39
deadalnix closed D4032: Remove dependency on Config from the PoW code.
Sep 11 2019, 15:39
deadalnix committed rABC8cd6262216c5: Use Consensus::Params in ContextualCheckTransaction and variations instead of… (authored by deadalnix).
Use Consensus::Params in ContextualCheckTransaction and variations instead of…
Sep 11 2019, 15:35
deadalnix closed D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.
Sep 11 2019, 15:35
teamcity added a comment to D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 15:27
teamcity added a comment to D4038: [CMAKE] Fix Linux64 toolchain name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 15:22
teamcity added a comment to D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 15:20
Fabien created D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.
Sep 11 2019, 15:20
teamcity added a comment to D4038: [CMAKE] Fix Linux64 toolchain name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 15:15
Fabien created D4038: [CMAKE] Fix Linux64 toolchain name.
Sep 11 2019, 15:15
deadalnix committed rABC35bb8e40f091: Activate consensus rule based on consensus params rather than config (authored by deadalnix).
Activate consensus rule based on consensus params rather than config
Sep 11 2019, 15:06
deadalnix closed D4030: Activate consensus rule based on consensus params rather than config.
Sep 11 2019, 15:05
Fabien accepted D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.
Sep 11 2019, 14:46
Fabien accepted D4033: Remove ReadBlockFromDisk's dependency on Config.
Sep 11 2019, 14:45
Fabien accepted D4032: Remove dependency on Config from the PoW code.
Sep 11 2019, 14:39
Fabien accepted D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.
Sep 11 2019, 14:34
Fabien accepted D4030: Activate consensus rule based on consensus params rather than config.
Sep 11 2019, 14:32
deadalnix committed rABC4b0c76696c1a: Add warning about redundant moves (authored by deadalnix).
Add warning about redundant moves
Sep 11 2019, 14:32
deadalnix closed D4036: Add warning about redundant moves.
Sep 11 2019, 14:32
deadalnix committed rABCfb99a574e0aa: Remove redundant call to std::move (authored by deadalnix).
Remove redundant call to std::move
Sep 11 2019, 14:32
deadalnix closed D4035: Remove redundant call to std::move.
Sep 11 2019, 14:32
Fabien accepted D4036: Add warning about redundant moves.
Sep 11 2019, 14:26
Fabien accepted D4035: Remove redundant call to std::move.
Sep 11 2019, 14:26
Fabien committed rABC4a2954fca490: Fix the build-osx target for the depends subsystem (authored by Fabien).
Fix the build-osx target for the depends subsystem
Sep 11 2019, 13:58
Fabien closed D4037: Fix the build-osx target for the depends subsystem.
Sep 11 2019, 13:58
teamcity added a comment to D4037: Fix the build-osx target for the depends subsystem.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 13:56
deadalnix accepted D4037: Fix the build-osx target for the depends subsystem.
Sep 11 2019, 13:52
teamcity added a comment to D4037: Fix the build-osx target for the depends subsystem.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 13:49
Fabien created D4037: Fix the build-osx target for the depends subsystem.
Sep 11 2019, 13:49
teamcity added a comment to D4036: Add warning about redundant moves.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 12:51
teamcity added a comment to D4036: Add warning about redundant moves.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 12:44
deadalnix created D4036: Add warning about redundant moves.
Sep 11 2019, 12:43
teamcity added a comment to D4035: Remove redundant call to std::move.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 12:40