rebase to master and tweak a few comments
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Dec 3 2019
Dec 3 2019
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC22a1d33378fb: fix undefined behaviour in seeder (select() aliasing) (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
fix undefined behaviour in seeder (select() aliasing)
markblundeberg added inline comments to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
teamcity added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
a number of updates
- added a couple of behaviours that are nonstandard to fund but the wallet will pick up, and will spend successfully.
- rename test, the general idea is to make sure wallet is not DoSable.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
seeder-net -> seeder-netprocessing.
jasonbcox accepted D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
I still do not agree that it makes any sense to consolidate the constructors. It makes the code quality worse. But hey, we don't own that code do we? Oh wait...
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
jasonbcox committed rABC254497ff6835: Update the github issue template to include disclosure policy (authored by jasonbcox).
Update the github issue template to include disclosure policy
Build Bitcoin-ABC / Diffs / Diff Testing started.
Dec 2 2019
Dec 2 2019
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
update ctor
The general direction is good, but there are a few problem with this patch.
Ah OK it is documented here at least https://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/select.h.html
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito retitled D4417: Add a separate executable for seeder tests from Add a separate executible for seeder tests to Add a separate executable for seeder tests.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Removed dependency.
markblundeberg added a revision to T704: sigChecks implementation: D4617: add a flag that restricts sigChecks per-input.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC5e4ac9377001: remove NULLDUMMY (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
remove NULLDUMMY
In D4453#107542, @jasonbcox wrote:I think it would be better to replace this with the next upgrade, even if it does nothing for now. Otherwise, we have to re-implement this later.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni committed rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Add and use HaveTxsDownloaded() where appropriate
Harbormaster failed remote builds in B8373: Diff 14572 for D4615: test: Build fuzz targets into seperate executables!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
jasonbcox committed rABC3c947e7b52d8: Added autopatch script for patching and rebasing phabricator diffs (authored by jasonbcox).
Added autopatch script for patching and rebasing phabricator diffs
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
rebase from master
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Make TxIndex::FindTx use BlockHash
Update GetTransaction's parameters
deadalnix committed rABCe37a511fd797: Update mempool and compact block logic to use TxHash (authored by deadalnix).
Update mempool and compact block logic to use TxHash
deadalnix committed rABCe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details (authored by MarcoFalke <falke.marco@gmail.com>).
tx pool: Use class methods to hide raw map iterator impl details
deadalnix retitled D4600: Update mempool and compact block logic to use TxHash from Update mempool and compact block logic to use TxHash . to Update mempool and compact block logic to use TxHash.
deadalnix committed rABC04a26c5bcd54: Update mempool's mapDelta to use TxId (authored by deadalnix).
Update mempool's mapDelta to use TxId
deadalnix committed rABC8a300d51d9c3: Update mempool's mapTx to index from TxId. (authored by deadalnix).
Update mempool's mapTx to index from TxId.
Verify cross compile build to make sure you did not fibared something, but LGTM