Page MenuHomePhabricator
Feed All Stories

Jan 14 2020

fpelliccioni committed rABCbaef60890b54: Call FinalizeBlockAndInvalidate without cs_main held (authored by fpelliccioni).
Call FinalizeBlockAndInvalidate without cs_main held
Jan 14 2020, 21:13
fpelliccioni closed D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 21:13
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

That fixed it. Thanks Mark!

Jan 14 2020, 21:12
jasonbcox accepted D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Sanitizer tests look ok to me.

Jan 14 2020, 20:48
teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:47
teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:39
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Rebased onto the changes from master.

Jan 14 2020, 20:39
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:35
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Jan 14 2020, 20:32
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:28
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:23
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:22
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Jan 14 2020, 20:22
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:22
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:19
markblundeberg added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Snippet of first build failure:

[17:32:02]W:	 [Step 1/1] + case "$ABC_BUILD_NAME" in
[17:32:02] :	 [Step 1/1] Error: Invalid build name 'build-diff'
[17:32:02]W:	 [Step 1/1] + echo 'Error: Invalid build name '\''build-diff'\'''
[17:32:02]W:	 [Step 1/1] + exit 2
[17:32:02]W:	 [Step 1/1] Process exited with code 2
[17:32:02]E:	 [Step 1/1] Process exited with code 2 (Step: Command Line)

This seems like a configuration error. Does someone know what‘s going on there?

Jan 14 2020, 20:17
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:09
teamcity added a comment to D4927: [CI] Use ninja targets instead of calling binaries.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:05
teamcity added a comment to D4939: Move the functional test temporary directory under the build directory.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 20:04
Fabien updated the diff for D4927: [CI] Use ninja targets instead of calling binaries.

Rebase

Jan 14 2020, 20:04
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:04
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

linting

Jan 14 2020, 20:03
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 20:03
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

lock frame reduced

Jan 14 2020, 20:02
teamcity added a comment to D4939: Move the functional test temporary directory under the build directory.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 19:58
Fabien updated the diff for D4939: Move the functional test temporary directory under the build directory.

Move to test/tmp

Jan 14 2020, 19:58
fpelliccioni added inline comments to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 19:49
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Snippet of first build failure:

[17:32:02]W:	 [Step 1/1] + case "$ABC_BUILD_NAME" in
[17:32:02] :	 [Step 1/1] Error: Invalid build name 'build-diff'
[17:32:02]W:	 [Step 1/1] + echo 'Error: Invalid build name '\''build-diff'\'''
[17:32:02]W:	 [Step 1/1] + exit 2
[17:32:02]W:	 [Step 1/1] Process exited with code 2
[17:32:02]E:	 [Step 1/1] Process exited with code 2 (Step: Command Line)

This seems like a configuration error. Does someone know what‘s going on there?

Jan 14 2020, 19:43
nakihito requested review of D4933: Merge #13429: Return the script type from Solver.

The change in src/rpc/rawtransaction.cpp is missing.

Jan 14 2020, 19:40
jasonbcox accepted D4938: Move the JUnit file to the temporary directory.

It's important to note that CI sets tmpdir to be within the build dir, so the CI can find these reports. Otherwise, reviewers may mistakenly believe the junit_reports will end up in /tmp/ on CI.

Jan 14 2020, 18:09
jasonbcox requested changes to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 17:43
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 14 2020, 17:33
deadalnix requested changes to D4939: Move the functional test temporary directory under the build directory.
Jan 14 2020, 17:32
teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 14 2020, 17:32
Harbormaster failed remote builds in B8938: Diff 15459 for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag!
Jan 14 2020, 17:32
teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 17:31
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed opcode to OP_REVERSEBYTES (which is the final name now), refactored & amended tests.

Jan 14 2020, 17:31
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 17:28
jasonbcox committed rABCb2c7043ba97e: Add a script to generate sha256sums from Gitian output (authored by jasonbcox).
Add a script to generate sha256sums from Gitian output
Jan 14 2020, 17:25
jasonbcox closed D4893: Add a script to generate sha256sums from Gitian output.
Jan 14 2020, 17:25
jasonbcox added a comment to D4893: Add a script to generate sha256sums from Gitian output.

While I don't have anything against that patch per se, it seems somewhat questionable that the signing process that core used was ditched in favor of something that clearly requires work.

Jan 14 2020, 17:24
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 17:22
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebased

Jan 14 2020, 17:22
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 17:19
Harbormaster failed remote builds in B8936: Diff 15456 for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex!
Jan 14 2020, 17:19
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 17:19
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

add whitespace

Jan 14 2020, 17:19
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 17:17
Harbormaster failed remote builds in B8935: Diff 15455 for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex!
Jan 14 2020, 17:17
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 17:17
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

revert not related with PR code

Jan 14 2020, 17:17
fpelliccioni updated the summary of D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 17:12
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 16:27
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 14 2020, 16:16
fpelliccioni planned changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 16:11
fpelliccioni added a reviewer for D4942: Call FinalizeBlockAndInvalidate without cs_main held: markblundeberg.
Jan 14 2020, 16:10
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 16:09
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

rebased from master

Jan 14 2020, 16:09
fpelliccioni committed rABC3fb45c049a4c: Release cs_main during InvalidateBlock iterations (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Release cs_main during InvalidateBlock iterations
Jan 14 2020, 16:05
fpelliccioni closed D4802: Release cs_main during InvalidateBlock iterations.
Jan 14 2020, 16:05
teamcity added a comment to D4802: Release cs_main during InvalidateBlock iterations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 16:01
teamcity added a comment to D4802: Release cs_main during InvalidateBlock iterations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 15:56
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

rebased from master

Jan 14 2020, 15:56
fpelliccioni planned changes to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 15:53
Harbormaster failed remote builds in B8931: Diff 15450 for D4942: Call FinalizeBlockAndInvalidate without cs_main held!
Jan 14 2020, 15:53
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 15:53
teamcity added a comment to D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 15:52
fpelliccioni created D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 15:52
fpelliccioni committed rABC9096e76f01e5: Call InvalidateBlock without cs_main held (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Call InvalidateBlock without cs_main held
Jan 14 2020, 15:28
fpelliccioni closed D4758: Call InvalidateBlock without cs_main held.
Jan 14 2020, 15:28
teamcity added a comment to D4758: Call InvalidateBlock without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 15:26
teamcity added a comment to D4758: Call InvalidateBlock without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 15:20
fpelliccioni updated the diff for D4758: Call InvalidateBlock without cs_main held.

rebase from master

Jan 14 2020, 15:20
fpelliccioni committed rABC7504e09fda75: Call RewindBlockIndex without cs_main held (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Call RewindBlockIndex without cs_main held
Jan 14 2020, 15:19
fpelliccioni closed D4757: Call RewindBlockIndex without cs_main held.
Jan 14 2020, 15:19
teamcity added a comment to D4757: Call RewindBlockIndex without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 15:18
teamcity added a comment to D4757: Call RewindBlockIndex without cs_main held.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 15:12
fpelliccioni updated the diff for D4757: Call RewindBlockIndex without cs_main held.

rebase from master

Jan 14 2020, 15:12
teamcity added a comment to D4941: track ScriptExecutionMetrics in CheckInputs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 15:12
teamcity added a comment to D4941: track ScriptExecutionMetrics in CheckInputs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 15:06
markblundeberg created D4941: track ScriptExecutionMetrics in CheckInputs.
Jan 14 2020, 15:05
markblundeberg added inline comments to D4937: tweak auto-unparking message.
Jan 14 2020, 13:36
deadalnix committed rABCbe651fb90eb6: [wallet] Support creating a blank wallet (authored by Andrew Chow <achow101-github@achow101.com>).
[wallet] Support creating a blank wallet
Jan 14 2020, 13:25
deadalnix closed D4921: [wallet] Support creating a blank wallet.
Jan 14 2020, 13:25
Fabien accepted D4921: [wallet] Support creating a blank wallet.
Jan 14 2020, 13:22
Fabien added inline comments to D4937: tweak auto-unparking message.
Jan 14 2020, 13:12
deadalnix added inline comments to D4921: [wallet] Support creating a blank wallet.
Jan 14 2020, 13:02
teamcity added a comment to D4921: [wallet] Support creating a blank wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 13:02
teamcity added a comment to D4921: [wallet] Support creating a blank wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 12:55
deadalnix updated the diff for D4921: [wallet] Support creating a blank wallet.

Address comments

Jan 14 2020, 12:55
teamcity added a comment to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 12:41
markblundeberg added a revision to T704: sigChecks implementation: D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.
Jan 14 2020, 12:35
markblundeberg added a task to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript: T704: sigChecks implementation.
Jan 14 2020, 12:35
teamcity added a comment to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 12:34
markblundeberg created D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.
Jan 14 2020, 12:34
Fabien accepted D4935: [validation.cpp] parking-related comment tweaks.
Jan 14 2020, 11:28
Fabien accepted D4893: Add a script to generate sha256sums from Gitian output.
Jan 14 2020, 11:22
Fabien requested changes to D4807: Add instructions for verifying download integrity against release signer keys.
Jan 14 2020, 11:10
teamcity added a comment to D4928: [CI] Increase the coverage for the build-diff and build-master configs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 14 2020, 10:40
teamcity added a comment to D4928: [CI] Increase the coverage for the build-diff and build-master configs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 14 2020, 10:20