Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 15 2020
Jan 15 2020
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Rebase on top of D4948.
Fabien updated the summary of D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the test plan for D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
So this is mostly in good shape, but ScriptExecutionMetrics has a bit of an identity crisis which causes a worst of both world situation. I would recommand giving up on trying to make it a POD, make its innards private, manipulate them via member function that ensure consistency and remove a bunch of error conditions down the road.
Fabien planned changes to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Need to investigate the failure
Harbormaster failed remote builds in B8957: Diff 15482 for D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS!
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4947: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix committed rABC6d8c162de5fb: [secp256k1] scratch: add stack frame support (authored by deadalnix).
[secp256k1] scratch: add stack frame support
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Update erroneous test case
Build Bitcoin-ABC / Diffs / Diff Testing passed.
deadalnix committed rABC6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held" (authored by deadalnix).
Revert "Call FinalizeBlockAndInvalidate without cs_main held"
This is still not correct as any number of reorg can occur in between the finalization and the invalidate..
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
After some tests, ready to review.
Fabien retitled D4943: Add an option to set the functional test suite name from [WIP] Make the test suite name unique in the JUnit result file to Make the test suite name unique in the JUnit result file.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
And now a string representing an int
Harbormaster failed remote builds in B8950: Diff 15473 for D4943: Add an option to set the functional test suite name!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Make id an int
Harbormaster failed remote builds in B8949: Diff 15472 for D4943: Add an option to set the functional test suite name!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Testing if the id attribute is managed by teamcity.
There is another side-effect here, which is that bumping GetMinFee can technically bring sigops (and virtualsize) into play for wallet estimation. To accurately capture this would really suck, since we would need to communicate two fee rates (one for min relay fee in sat/byte, and one for the mempool rolling fee floor in sat/vbyte).
Jan 14 2020
Jan 14 2020
Seems to be some sort of caching error on my machine.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Harbormaster failed remote builds in B8948: Diff 15470 for D4944: Remove redundant library links for seeder!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
markblundeberg added inline comments to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
fpelliccioni updated the summary of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.
rebased
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
rebase from master
markblundeberg added a comment to D4939: Move the functional test temporary directory under the build directory.
Seems OK I guess, we'll just have to remember to nuke test/tmp on our local builds occasionally as it fills up with test failures.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
rebase from master