Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 16 2020
Jan 16 2020
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4959: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex".
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4959: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex".
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien committed rABCbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only (authored by Fabien).
[CMAKE] Add compiler flags to some build configuration only
The reasoning behind not using the command line arguments is that I don't wanted to make the JUnit file a Teamcity only file. The name attribute is really designed to tell what the test suite being run is, and the arguments are more designed to fit a test suite property node imo.
Since the name needs to be unique, it seems to me that the temp dir is what better describes "what the test suite being run is", which is the closest to the initial name intent. You can read it as the name of "this instance of the bitcoin abc test suite".
Furthermore, it makes the name unique, which is not the case if you use the command line parameters.
Hmm weird that build failures happen with this patch, it smells like one of the prior diffs (which all got landed sort of at once) may actually be responsible. Safest option might be to revert all.
markblundeberg accepted D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Tiny quibble but otherwise good.
For some reason my name appears as the Author for the commit, any idea why that happened?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Various variable name changes and more comments for better clarity. Removed Excess constants and variables. CreateDNSQuestion() -> CreateDNSQuestionNameField() because parse_name() finishes onces it reaches the end of the name field. First three tests collapsed into a singular test. Added assert() to check that nameFieldEndIndex is correct.
Harbormaster failed remote builds in B8974: Diff 15513 for D4950: Fully revert D4803 due to TSAN test failures!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
fpelliccioni retitled D4950: Fully revert D4803 due to TSAN test failures from Partially revert D4803 due to TSAN test failures to Fully revert D4803 due to TSAN test failures.
Build Bitcoin-ABC / Diffs / Diff Testing started.
full revert
deadalnix committed rABCc3c34326f333: [secp256k1] fix tests.c in the count == 0 case (authored by deadalnix).
[secp256k1] fix tests.c in the count == 0 case
Jan 15 2020
Jan 15 2020
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
We had discussed offline about adding the commandline args to the junit name to make it obvious which test run it was. Any reason why you didn't include this? I think it drastically improves the usability of this fix.
I don't think this is wise to revert half of this patch. What is the problem to begin with?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito committed rABCbb2c97c5c396: Merge #13429: Return the script type from Solver (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13429: Return the script type from Solver
Fabien committed rABCc39e751d3053: [CI] Increase the coverage for the build-diff and build-master configs (authored by Fabien).
[CI] Increase the coverage for the build-diff and build-master configs
Harbormaster failed remote builds in B8962: Diff 15494 for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted!
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
fixes
fpelliccioni committed rABCe7fc0238127a: Optimization: don't add txn back to mempool after 10 invalidates (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Optimization: don't add txn back to mempool after 10 invalidates
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Fabien committed rABCa64accabc34c: [CI] Use ninja targets instead of calling binaries (authored by Fabien).
[CI] Use ninja targets instead of calling binaries
Fabien committed rABCb00deee65f23: Move the functional test temporary directory under the build directory (authored by Fabien).
Move the functional test temporary directory under the build directory
Fabien committed rABC41e63750ae78: Move the JUnit file to the temporary directory (authored by Fabien).
Move the JUnit file to the temporary directory
teamcity added a comment to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.
rebase from master
fpelliccioni committed rABCa9734a4e30ae: Prevent callback overruns in InvalidateBlock and RewindBlockIndex (authored by fpelliccioni).
Prevent callback overruns in InvalidateBlock and RewindBlockIndex
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien committed rABC7110ffe9d585: [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS (authored by Fabien).
[CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS
[CMAKE] Remove extra -fPIE flag
Hopefully make the problem more clear with the use of screenshots.
Also improved the test plan a bit.
deadalnix requested changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
I'm not 100% convinced we want this, but so be it. We can always remove it later.
Accepting, but consider doing the xor thing and that this may end up requiring changes due to changes requested in parents.
I don't understand the problem. The fact that the test plan is not reproducible doesn't help. I can look all day long if I don't know what I'm looking for.