Page MenuHomePhabricator
Feed All Stories

Aug 1 2020

teamcity updated the summary of D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 1 2020, 15:15
teamcity added a comment to D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 1 2020, 15:15
majcosta requested review of D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 1 2020, 15:15
teamcity added a comment to D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 1 2020, 15:13
teamcity updated the summary of D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().
Aug 1 2020, 15:13
majcosta requested review of D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().
Aug 1 2020, 15:13
teamcity added a comment to D7112: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 1 2020, 15:03
teamcity updated the summary of D7112: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().
Aug 1 2020, 15:03
majcosta requested review of D7112: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().
Aug 1 2020, 15:03
majcosta requested review of D7111: [backport#17070] wallet: Avoid showing GUI popups on RPC errors.
Aug 1 2020, 14:54
majcosta added inline comments to D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Aug 1 2020, 13:50
deadalnix added inline comments to D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Aug 1 2020, 08:52
majcosta committed rABCea1ca12b52ca: [backport#16394] Allow createwallet to take empty passwords to make unencrypted… (authored by MeshCollider <dobsonsa68@gmail.com>).
[backport#16394] Allow createwallet to take empty passwords to make unencrypted…
Aug 1 2020, 02:41
majcosta closed D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.
Aug 1 2020, 02:41
majcosta committed rABCbd83a3cadbe5: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME…
Aug 1 2020, 02:13
majcosta closed D7107: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core.
Aug 1 2020, 02:13

Jul 31 2020

deadalnix accepted D7070: [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI.
Jul 31 2020, 22:24
deadalnix requested changes to D7041: [refactor] remove const CChainParams& object from CWallet.

@majcosta While I don't have anything against this per se, packaging it with some code that actually uses this would be beneficial. I assume to is about removing the params member of CWallet because it is redundant with the chain member. Here is what I suggest you do:

Jul 31 2020, 20:31
jasonbcox accepted D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.
Jul 31 2020, 20:21
jasonbcox accepted D7107: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core.
Jul 31 2020, 20:13
majcosta committed rABCcbcbb33624c3: [backport#16524] Wallet: Disable -fallbackfee by default (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16524] Wallet: Disable -fallbackfee by default
Jul 31 2020, 18:04
majcosta closed D7062: [backport#16524] Wallet: Disable -fallbackfee by default.
Jul 31 2020, 18:04
majcosta committed rABCebb1c14da7c3: [backport#16402] Remove wallet settings from chainparams (authored by MeshCollider <dobsonsa68@gmail.com>).
[backport#16402] Remove wallet settings from chainparams
Jul 31 2020, 18:04
majcosta closed D7061: [backport#16402] Remove wallet settings from chainparams.
Jul 31 2020, 18:04
jasonbcox committed rABCWEB4bb9ced8befe: Add a link to RPC docs (authored by jasonbcox).
Add a link to RPC docs
Jul 31 2020, 17:22
jasonbcox closed D7068: Add a link to RPC docs.
Jul 31 2020, 17:22
jasonbcox committed rABCWEBac1ee0be3ed8: Add 0.21.12 RPC docs (authored by jasonbcox).
Add 0.21.12 RPC docs
Jul 31 2020, 17:21
jasonbcox closed D7067: Add 0.21.12 RPC docs.
Jul 31 2020, 17:21
Mengerian committed rABCWEB20612fc52ccb: [website] Add Gemini to sponsors (authored by Mengerian).
[website] Add Gemini to sponsors
Jul 31 2020, 16:29
Mengerian closed D7095: [website] Add Gemini to sponsors.
Jul 31 2020, 16:28
majcosta updated the diff for D7106: [backport#15450 5/5] Add Create Wallet menu action.

rebase on D7108

Jul 31 2020, 16:17
majcosta updated the diff for D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.

fixed DummyWallet for the nowallet build

Jul 31 2020, 16:16
teamcity added a comment to D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Jul 31 2020, 15:50
majcosta planned changes to D7106: [backport#15450 5/5] Add Create Wallet menu action.
Jul 31 2020, 15:37
majcosta planned changes to D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Jul 31 2020, 15:37
majcosta updated the diff for D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.

rebase on D7108

Jul 31 2020, 15:35
majcosta updated the diff for D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.

rebase on D7108

Jul 31 2020, 15:35
majcosta updated the diff for D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.

rebase on D7108

Jul 31 2020, 15:34
majcosta updated the summary of D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Jul 31 2020, 15:34
majcosta updated the diff for D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.

rebase on D7108

Jul 31 2020, 15:33
teamcity added a comment to D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 15:32
teamcity updated the summary of D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.
Jul 31 2020, 15:32
majcosta requested review of D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.
Jul 31 2020, 15:31
teamcity added a comment to D7107: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 15:16
teamcity updated the summary of D7107: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core.
Jul 31 2020, 15:16
majcosta requested review of D7107: [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core.
Jul 31 2020, 15:16
Fabien committed rABCc0d573a89b51: [CMAKE] Generate textual coverage report (authored by Fabien).
[CMAKE] Generate textual coverage report
Jul 31 2020, 13:39
Fabien closed D7094: [CMAKE] Generate textual coverage report.
Jul 31 2020, 13:39
teamcity added a comment to D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Jul 31 2020, 13:35
Fabien committed rABCb7212989f020: [TRAVIS] Install cmake version 3.16 (authored by Fabien).
[TRAVIS] Install cmake version 3.16
Jul 31 2020, 13:35
Fabien closed D7101: [TRAVIS] Install cmake version 3.16.
Jul 31 2020, 13:35
teamcity added a comment to D7106: [backport#15450 5/5] Add Create Wallet menu action.
Jul 31 2020, 13:31
deadalnix accepted D7094: [CMAKE] Generate textual coverage report.
Jul 31 2020, 13:20
deadalnix accepted D7061: [backport#16402] Remove wallet settings from chainparams.
Jul 31 2020, 13:19
deadalnix accepted D7101: [TRAVIS] Install cmake version 3.16.
Jul 31 2020, 13:19
deadalnix added inline comments to D6981: Implement Grasberg DAA.
Jul 31 2020, 13:18
teamcity added a comment to D7106: [backport#15450 5/5] Add Create Wallet menu action.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 13:10
teamcity updated the summary of D7106: [backport#15450 5/5] Add Create Wallet menu action.
Jul 31 2020, 13:10
majcosta requested review of D7106: [backport#15450 5/5] Add Create Wallet menu action.
Jul 31 2020, 13:10
teamcity added a comment to D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 13:09
teamcity updated the summary of D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Jul 31 2020, 13:09
majcosta requested review of D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Jul 31 2020, 13:09
teamcity added a comment to D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 13:09
teamcity updated the summary of D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.
Jul 31 2020, 13:09
majcosta requested review of D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.
Jul 31 2020, 13:08
teamcity added a comment to D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 13:08
teamcity updated the summary of D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.
Jul 31 2020, 13:08
majcosta requested review of D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.
Jul 31 2020, 13:08
teamcity added a comment to D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 31 2020, 12:49
teamcity updated the summary of D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Jul 31 2020, 12:49
majcosta requested review of D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Jul 31 2020, 12:49
Fabien committed rABCf0323812f55b: [CMAKE] Run the leveldb tests serially (authored by Fabien).
[CMAKE] Run the leveldb tests serially
Jul 31 2020, 09:18
Fabien closed D6751: [CMAKE] Run the leveldb tests serially.
Jul 31 2020, 09:18
Fabien committed rABC31b5e2792846: [GITIAN] Stop distributing the *-unsigned.tar.gz archive (authored by Fabien).
[GITIAN] Stop distributing the *-unsigned.tar.gz archive
Jul 31 2020, 08:57
Fabien closed D7089: [GITIAN] Stop distributing the *-unsigned.tar.gz archive.
Jul 31 2020, 08:57
Fabien added a comment to D7041: [refactor] remove const CChainParams& object from CWallet.

What's the use case ?

Jul 31 2020, 08:47
Fabien requested review of D7101: [TRAVIS] Install cmake version 3.16.
Jul 31 2020, 08:30
majcosta committed rABCbe118d0a5573: [backport#17203] wallet: Remove unused GetLabelName (authored by fanquake <fanquake@gmail.com>).
[backport#17203] wallet: Remove unused GetLabelName
Jul 31 2020, 01:01
majcosta closed D7093: [backport#17203] wallet: Remove unused GetLabelName.
Jul 31 2020, 01:01
majcosta committed rABC756dd8741559: [backport#17138 2/2][wallet] Remove pruning check for -rescan option (authored by John Newbery <john@johnnewbery.com>).
[backport#17138 2/2][wallet] Remove pruning check for -rescan option
Jul 31 2020, 00:58
majcosta closed D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.
Jul 31 2020, 00:58
majcosta committed rABCae229def7dba: [backport#17138 1/2][wallet] Remove package limit config access from wallet (authored by John Newbery <john@johnnewbery.com>).
[backport#17138 1/2][wallet] Remove package limit config access from wallet
Jul 31 2020, 00:57
majcosta closed D7090: [backport#17138 1/2][wallet] Remove package limit config access from wallet.
Jul 31 2020, 00:57
jasonbcox accepted D7090: [backport#17138 1/2][wallet] Remove package limit config access from wallet.
Jul 31 2020, 00:19
jasonbcox accepted D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.
Jul 31 2020, 00:18
jasonbcox accepted D7093: [backport#17203] wallet: Remove unused GetLabelName.
Jul 31 2020, 00:10
jasonbcox accepted D7095: [website] Add Gemini to sponsors.
Jul 31 2020, 00:02

Jul 30 2020

Fabien committed rABCc94fb65cf8be: [CMAKE] Bump minimum cmake to 3.16 (authored by Fabien).
[CMAKE] Bump minimum cmake to 3.16
Jul 30 2020, 22:24
Fabien closed D7073: [CMAKE] Bump minimum cmake to 3.16.
Jul 30 2020, 22:24
Mengerian requested review of D7095: [website] Add Gemini to sponsors.
Jul 30 2020, 20:18
Fabien added a comment to D7094: [CMAKE] Generate textual coverage report.

@bot build-coverage

Jul 30 2020, 20:11
majcosta requested review of D7041: [refactor] remove const CChainParams& object from CWallet.
Jul 30 2020, 20:02
Fabien requested review of D7094: [CMAKE] Generate textual coverage report.
Jul 30 2020, 19:43
teamcity added a comment to D7093: [backport#17203] wallet: Remove unused GetLabelName.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 30 2020, 18:52
teamcity updated the summary of D7093: [backport#17203] wallet: Remove unused GetLabelName.
Jul 30 2020, 18:52
majcosta requested review of D7093: [backport#17203] wallet: Remove unused GetLabelName.
Jul 30 2020, 18:52
teamcity added a comment to D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 30 2020, 18:35
teamcity updated the summary of D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.
Jul 30 2020, 18:35
majcosta requested review of D7091: [backport#17138 2/2][wallet] Remove pruning check for -rescan option.
Jul 30 2020, 18:35
teamcity added a comment to D7090: [backport#17138 1/2][wallet] Remove package limit config access from wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 30 2020, 18:23