Page MenuHomePhabricator
Feed All Stories

Oct 17 2020

deadalnix requested changes to D7973: [CI] Fail fast the builds that print error to stdout.
Oct 17 2020, 19:04
Fabien closed D7969: Add the python extension to the macdeployqtplus script.
Oct 17 2020, 18:31
Fabien committed rABCeaf75529e4f1: Add the python extension to the macdeployqtplus script (authored by Fabien).
Add the python extension to the macdeployqtplus script
Oct 17 2020, 18:30
Fabien closed D7968: build: Drop macports support.
Oct 17 2020, 18:29
Fabien committed rABCfa513530817b: build: Drop macports support (authored by Ben Woosley <ben.woosley@gmail.com>).
build: Drop macports support
Oct 17 2020, 18:29
Fabien closed D7967: [scripts] Minor improvements to `macdeployqtplus` script.
Oct 17 2020, 18:29
Fabien committed rABC2f142e5a3a60: [scripts] Minor improvements to `macdeployqtplus` script (authored by Chris Gavin <chris@chrisgavin.me>).
[scripts] Minor improvements to `macdeployqtplus` script
Oct 17 2020, 18:29
Fabien closed D7951: [CI] Add a configuration for running on native OSX agents.
Oct 17 2020, 18:28
Fabien committed rABC6fe4fd9b630a: [CI] Add a configuration for running on native OSX agents (authored by Fabien).
[CI] Add a configuration for running on native OSX agents
Oct 17 2020, 18:28
Fabien requested review of D7973: [CI] Fail fast the builds that print error to stdout.
Oct 17 2020, 18:27
deadalnix closed D7971: [secp256k1] Enable endomorphism by default.
Oct 17 2020, 18:17
deadalnix committed rABCc6dbc176ffa9: [secp256k1] Enable endomorphism by default (authored by deadalnix).
[secp256k1] Enable endomorphism by default
Oct 17 2020, 18:16
Fabien accepted D7971: [secp256k1] Enable endomorphism by default.
Oct 17 2020, 18:13
deadalnix accepted D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 16:04
deadalnix accepted D7972: rcp: update validateaddress RPCExamples to CashAddr.
Oct 17 2020, 16:02
PiRK added a comment to D7970: test: Seed test RNG context for each test case, print seed.

Make sure you look at the clang tidy build.

Oct 17 2020, 15:25
PiRK updated the diff for D7970: test: Seed test RNG context for each test case, print seed.

more braces

Oct 17 2020, 15:24
teamcity updated the summary of D7972: rcp: update validateaddress RPCExamples to CashAddr.
Oct 17 2020, 15:16
PiRK requested review of D7972: rcp: update validateaddress RPCExamples to CashAddr.
Oct 17 2020, 15:16
deadalnix requested changes to D7970: test: Seed test RNG context for each test case, print seed.

Make sure you look at the clang tidy build.

Oct 17 2020, 14:46
teamcity added a comment to D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 14:44
PiRK updated the diff for D7970: test: Seed test RNG context for each test case, print seed.

address feedback: missing braces

Oct 17 2020, 14:42
deadalnix updated the summary of D7971: [secp256k1] Enable endomorphism by default.
Oct 17 2020, 14:30
deadalnix accepted D7969: Add the python extension to the macdeployqtplus script.
Oct 17 2020, 14:24
deadalnix accepted D7967: [scripts] Minor improvements to `macdeployqtplus` script.
Oct 17 2020, 14:23
deadalnix accepted D7968: build: Drop macports support.
Oct 17 2020, 14:23
deadalnix requested review of D7971: [secp256k1] Enable endomorphism by default.
Oct 17 2020, 14:21
deadalnix accepted D7951: [CI] Add a configuration for running on native OSX agents.
Oct 17 2020, 14:19
deadalnix requested changes to D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 14:18
teamcity added a comment to D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 12:55
teamcity updated the summary of D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 12:53
PiRK requested review of D7970: test: Seed test RNG context for each test case, print seed.
Oct 17 2020, 12:52
Fabien requested review of D7951: [CI] Add a configuration for running on native OSX agents.

Example result:
https://build.bitcoinabc.org/viewLog.html?buildId=99539&buildTypeId=BitcoinABC_Master_NativeTests_TestNativeOsx&tab=buildResultsDiv&guest=1

Oct 17 2020, 12:21
teamcity added a comment to D7951: [CI] Add a configuration for running on native OSX agents.
Oct 17 2020, 09:45
Fabien planned changes to D7951: [CI] Add a configuration for running on native OSX agents.
Oct 17 2020, 09:16
Fabien updated the diff for D7951: [CI] Add a configuration for running on native OSX agents.

Don't generate the DMG, since our agent doesn't support it for some reason.

Oct 17 2020, 09:16
Fabien requested review of D7969: Add the python extension to the macdeployqtplus script.
Oct 17 2020, 09:10
teamcity updated the summary of D7968: build: Drop macports support.
Oct 17 2020, 08:54
Fabien requested review of D7968: build: Drop macports support.
Oct 17 2020, 08:54
teamcity updated the summary of D7967: [scripts] Minor improvements to `macdeployqtplus` script.
Oct 17 2020, 08:52
Fabien requested review of D7967: [scripts] Minor improvements to `macdeployqtplus` script.
Oct 17 2020, 08:51

Oct 16 2020

jasonbcox closed D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 23:39
jasonbcox committed rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17564: rpc: Use mempool from node context instead of global
Oct 16 2020, 23:39
deadalnix accepted D7966: Merge #17564: rpc: Use mempool from node context instead of global.

likestamp

Oct 16 2020, 23:27
jasonbcox closed D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 22:23
jasonbcox committed rABC3e158f2af481: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some… (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some…
Oct 16 2020, 22:23
jasonbcox updated the diff for D7966: Merge #17564: rpc: Use mempool from node context instead of global.
  • Removed an unnecessary include
  • Patched changes onto estimateSmartFee since our code diverges from Core
Oct 16 2020, 22:13
majcosta accepted D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 22:03
jasonbcox planned changes to D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 22:02
teamcity updated the summary of D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 21:53
jasonbcox requested review of D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 21:52
teamcity updated the summary of D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 21:07
jasonbcox requested review of D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 21:07
Fabien closed D7964: build: skip deploying plugins we dont use in macdeployqtplus.
Oct 16 2020, 20:47
Fabien committed rABC9ea4510324a5: build: skip deploying plugins we dont use in macdeployqtplus (authored by fanquake <fanquake@gmail.com>).
build: skip deploying plugins we dont use in macdeployqtplus
Oct 16 2020, 20:46
Fabien added a comment to D7964: build: skip deploying plugins we dont use in macdeployqtplus.

@deadalnix The script was skipped by the linter because it has no .py extension. I will add it in a follow up.

Oct 16 2020, 20:46
majcosta closed D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Oct 16 2020, 20:01
majcosta committed rABCf89036cf9d57: [backport#17999 2/2] refactor: Use psbt forward declaration (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#17999 2/2] refactor: Use psbt forward declaration
Oct 16 2020, 20:01
majcosta closed D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Oct 16 2020, 19:54
majcosta committed rABCd44cb2f96784: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState
Oct 16 2020, 19:54
deadalnix accepted D7964: build: skip deploying plugins we dont use in macdeployqtplus.

There is a linter for most of this, making sure it run over this would be a plus.

Oct 16 2020, 19:32
deadalnix accepted D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Oct 16 2020, 19:30
deadalnix accepted D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Oct 16 2020, 19:27
jasonbcox closed D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 19:19
jasonbcox committed rABC39fae5b8b23d: [land-bot] Give a reasonable error when a revision cannot be found (authored by jasonbcox).
[land-bot] Give a reasonable error when a revision cannot be found
Oct 16 2020, 19:19
jasonbcox closed D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 19:09
jasonbcox committed rABC9306dc3d8e81: [land-bot] Allow users to specify the branch/commit in order to determine the… (authored by jasonbcox).
[land-bot] Allow users to specify the branch/commit in order to determine the…
Oct 16 2020, 19:09
PiRK closed D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Oct 16 2020, 18:57
PiRK committed rABC74f32509bf67: bitcoin-wallet: Add a missing closing parenthesis in the help (authored by darosior <darosior@protonmail.com>).
bitcoin-wallet: Add a missing closing parenthesis in the help
Oct 16 2020, 18:56
Fabien planned changes to D7951: [CI] Add a configuration for running on native OSX agents.
Oct 16 2020, 18:31
Fabien updated the diff for D7951: [CI] Add a configuration for running on native OSX agents.

Rebase

Oct 16 2020, 18:31
teamcity updated the summary of D7964: build: skip deploying plugins we dont use in macdeployqtplus.
Oct 16 2020, 18:31
Fabien requested review of D7964: build: skip deploying plugins we dont use in macdeployqtplus.
Oct 16 2020, 18:30
majcosta accepted D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 18:22
majcosta accepted D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 18:22
jasonbcox requested review of D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 17:52
majcosta updated the summary of D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Oct 16 2020, 17:44
majcosta closed D6995: [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods.
Oct 16 2020, 17:41
majcosta committed rABCa4ab5f79f2d4: [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#17999 1/2] Add ChainClient setMockTime, getWallets methods
Oct 16 2020, 17:41
teamcity updated the summary of D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Oct 16 2020, 17:31
majcosta requested review of D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Oct 16 2020, 17:31
jasonbcox closed D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 16 2020, 17:27
jasonbcox committed rABC12d862c0dffa: [land-bot] Add a sanity rebase after running smoke tests (authored by jasonbcox).
[land-bot] Add a sanity rebase after running smoke tests
Oct 16 2020, 17:27
teamcity updated the summary of D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Oct 16 2020, 17:07
majcosta requested review of D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Oct 16 2020, 17:06
majcosta closed D7958: [backport#16757] doc: CChainState return values.
Oct 16 2020, 17:05
majcosta committed rABC3ee09fbcd837: [backport#16757] doc: CChainState return values (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16757] doc: CChainState return values
Oct 16 2020, 17:05
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:50
jasonbcox planned changes to D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
deadalnix accepted D7958: [backport#16757] doc: CChainState return values.
Oct 16 2020, 16:30
deadalnix accepted D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 16 2020, 16:29
PiRK closed D7956: [gui] intro: enable pruning by default unless disk is big.
Oct 16 2020, 16:25
PiRK committed rABC4f80bc7eb4fa: [gui] intro: enable pruning by default unless disk is big (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] intro: enable pruning by default unless disk is big
Oct 16 2020, 16:25
teamcity updated the summary of D7958: [backport#16757] doc: CChainState return values.
Oct 16 2020, 16:20
majcosta requested review of D7958: [backport#16757] doc: CChainState return values.
Oct 16 2020, 16:20
PiRK closed D7955: [gui] intro: add prune preference.
Oct 16 2020, 16:18
PiRK committed rABC18cc9093aad6: [gui] intro: add prune preference (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] intro: add prune preference
Oct 16 2020, 16:18
jasonbcox accepted D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Oct 16 2020, 15:58
PiRK closed D7954: [gui] intro: inform caller if intro was shown.
Oct 16 2020, 15:18