Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Nov 23 2020

deadalnix requested review of D8499: Fix a nit in wallet_keypool.py.
Nov 23 2020, 00:53

Nov 22 2020

Fabien accepted D8493: [cpp] move to C++17.
Nov 22 2020, 20:58
myintercitycab set Slack Username to myintercitycab on myintercitycab.
Nov 22 2020, 17:26
myintercitycab edited a custom field on myintercitycab.
Nov 22 2020, 17:26
teamcity updated the summary of D8498: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.
Nov 22 2020, 17:08
deadalnix requested review of D8498: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.
Nov 22 2020, 17:08
deadalnix requested changes to D8494: [refactoring] eliminate Boost::Optional for std::optional.

Small changes, but overall, LGTM.

Nov 22 2020, 17:04
deadalnix added inline comments to D8493: [cpp] move to C++17.
Nov 22 2020, 17:00
deadalnix accepted D8493: [cpp] move to C++17.
Nov 22 2020, 17:00
deadalnix requested review of D8497: [avalanche] Add facility to check proof against a view of the UTXO.
Nov 22 2020, 16:30
deadalnix requested review of D8496: Add primitive to generate random 160 bits numbers for tests.
Nov 22 2020, 14:39
davidjackson updated davidjackson.
Nov 22 2020, 10:34
teamcity triaged T1237: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Nov 22 2020, 03:06
majcosta closed D8495: [backport#18388] Make VerifyWitnessProgram use a Span stack.
Nov 22 2020, 02:53
majcosta committed rABC65d338095bad: [backport#18388] Make VerifyWitnessProgram use a Span stack (authored by fanquake <fanquake@gmail.com>).
[backport#18388] Make VerifyWitnessProgram use a Span stack
Nov 22 2020, 02:52

Nov 21 2020

deadalnix accepted D8495: [backport#18388] Make VerifyWitnessProgram use a Span stack.
Nov 21 2020, 22:38
majcosta updated the diff for D8494: [refactoring] eliminate Boost::Optional for std::optional.

make psbt.cpp std::optional use a bit more succint

Nov 21 2020, 18:35
teamcity awarded D8494: [refactoring] eliminate Boost::Optional for std::optional a Haypence token.
Nov 21 2020, 18:05
majcosta added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.

@bot build-diff

Nov 21 2020, 18:05
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Nov 21 2020, 17:29
majcosta updated the diff for D8494: [refactoring] eliminate Boost::Optional for std::optional.

missing #include <functional> on chain.h

Nov 21 2020, 17:13
deadalnix closed D8487: Functional tests for descriptor wallets.
Nov 21 2020, 16:38
deadalnix committed rABCc321c8ac8909: Functional tests for descriptor wallets (authored by Andrew Chow <achow101-github@achow101.com>).
Functional tests for descriptor wallets
Nov 21 2020, 16:38
deadalnix closed D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 21 2020, 16:25
deadalnix committed rABCecaa314bf7e7: add importdescriptors RPC and tests for native descriptor wallets (authored by Hugo Nguyen <hugh.hn@gmail.com>).
add importdescriptors RPC and tests for native descriptor wallets
Nov 21 2020, 16:25
majcosta updated the summary of D8493: [cpp] move to C++17.
Nov 21 2020, 15:30
majcosta updated the diff for D8493: [cpp] move to C++17.

squashed PR18591

Nov 21 2020, 15:29
teamcity updated the summary of D8495: [backport#18388] Make VerifyWitnessProgram use a Span stack.
Nov 21 2020, 15:03
majcosta requested review of D8495: [backport#18388] Make VerifyWitnessProgram use a Span stack.
Nov 21 2020, 15:03
majcosta accepted D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 21 2020, 15:01
majcosta added inline comments to D8493: [cpp] move to C++17.
Nov 21 2020, 14:51
deadalnix updated the diff for D8475: add importdescriptors RPC and tests for native descriptor wallets.

Update RPC doc
Restore use of 'sh(pkh(...))' in a test case.

Nov 21 2020, 13:35
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Nov 21 2020, 13:32
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Nov 21 2020, 13:30
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Nov 21 2020, 13:30
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Nov 21 2020, 13:29
majcosta planned changes to D8494: [refactoring] eliminate Boost::Optional for std::optional.

investigating failure

Nov 21 2020, 13:28
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Nov 21 2020, 13:27
majcosta updated the diff for D8494: [refactoring] eliminate Boost::Optional for std::optional.

fixed

Nov 21 2020, 13:23
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Nov 21 2020, 13:17
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Nov 21 2020, 13:17
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Nov 21 2020, 13:15
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Nov 21 2020, 13:15
teamcity added a comment to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Nov 21 2020, 13:15
deadalnix requested changes to D8477: Add a prettier linter for the web tools.

Back to your plate, this clearly hasn't been thought through.

Nov 21 2020, 13:14
deadalnix closed D8488: Change wallet_encryption.py to use signmessage instead of dumpprivkey.
Nov 21 2020, 13:10
deadalnix committed rABC2cfbab661db6: Change wallet_encryption.py to use signmessage instead of dumpprivkey (authored by Andrew Chow <achow101-github@achow101.com>).
Change wallet_encryption.py to use signmessage instead of dumpprivkey
Nov 21 2020, 13:10
majcosta planned changes to D8494: [refactoring] eliminate Boost::Optional for std::optional.

messed up my script, gonna fix those newlines in place of #include <optional.h>

Nov 21 2020, 13:09
deadalnix added inline comments to D8493: [cpp] move to C++17.
Nov 21 2020, 13:09
majcosta requested review of D8494: [refactoring] eliminate Boost::Optional for std::optional.
Nov 21 2020, 13:07
deadalnix closed D8491: Properly handle coinbase in proofbuilder.
Nov 21 2020, 13:01
deadalnix committed rABCa0cf931d0918: Properly handle coinbase in proofbuilder (authored by deadalnix).
Properly handle coinbase in proofbuilder
Nov 21 2020, 13:01
teamcity awarded D8493: [cpp] move to C++17 a Piece of Eight token.
Nov 21 2020, 12:15
Fabien added a comment to D8493: [cpp] move to C++17.

@bot gitian-linux gitian-osx gitian-win

Nov 21 2020, 12:14
Unknown Object (User) added a comment to T316: Split TxID and TxHash and use them properly across the codebase.
Nov 21 2020, 12:04 · Bootcamp
majcosta updated the diff for D8493: [cpp] move to C++17.

updated CppCheck, documentation, assumptions.h and added a small release note entry

Nov 21 2020, 11:49
teamcity awarded D8493: [cpp] move to C++17 a Haypence token.
Nov 21 2020, 10:11
Fabien accepted D8491: Properly handle coinbase in proofbuilder.
Nov 21 2020, 10:08
Fabien requested changes to D8493: [cpp] move to C++17.

You are missing the documentation update and maybe a release note.
Also what about clang ?

Nov 21 2020, 10:07
Fabien added a comment to D8493: [cpp] move to C++17.

@bot gitian-linux gitian-osx gitian-win

Nov 21 2020, 10:06
majcosta closed D8492: [qt] remove deprecated Qt:SystemLocale____Date.
Nov 21 2020, 09:59
majcosta committed rABC918700e98990: [qt] remove deprecated Qt:SystemLocale____Date (authored by majcosta).
[qt] remove deprecated Qt:SystemLocale____Date
Nov 21 2020, 09:59
Fabien accepted D8492: [qt] remove deprecated Qt:SystemLocale____Date.
Nov 21 2020, 09:52
teamcity awarded D8491: Properly handle coinbase in proofbuilder a Haypence token.
Nov 21 2020, 09:52
Fabien added a comment to D8491: Properly handle coinbase in proofbuilder.

@bot build-ubsan

Nov 21 2020, 09:52
Fabien requested changes to D8483: Only run node-related builds on diffs where the node software has changed.

Just make a template

node:
  runOnDiffRegex:
      - cmake/
      - src/
      - test/

and use it everywhere

Nov 21 2020, 09:45
majcosta requested review of D8493: [cpp] move to C++17.
Nov 21 2020, 09:01
Fabien closed D8480: refactor: replace CConnman pointers by references in net_processing.cpp.
Nov 21 2020, 07:52
Fabien committed rABC7ce32e64a0e3: refactor: replace CConnman pointers by references in net_processing.cpp (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: replace CConnman pointers by references in net_processing.cpp
Nov 21 2020, 07:52
Fabien closed D8479: net: Make addr relay mockable, add test.
Nov 21 2020, 07:51
Fabien committed rABCada27e66ecbc: net: Make addr relay mockable, add test (authored by MarcoFalke <falke.marco@gmail.com>).
net: Make addr relay mockable, add test
Nov 21 2020, 07:51
Fabien updated the diff for D8477: Add a prettier linter for the web tools.

Address feedback

Nov 21 2020, 07:48
johnkuney closed D8489: Add link to bcha page to main nav.
Nov 21 2020, 06:53
johnkuney committed rABCWEBa816f8750346: Add link to bcha page to main nav (authored by johnkuney).
Add link to bcha page to main nav
Nov 21 2020, 06:53
johnkuney closed D8490: Style improvements to bcha page.
Nov 21 2020, 06:52
johnkuney committed rABCWEBc2e61e0cc62a: Style improvements to bcha page (authored by johnkuney).
Style improvements to bcha page
Nov 21 2020, 06:52
majcosta requested review of D8492: [qt] remove deprecated Qt:SystemLocale____Date.
Nov 21 2020, 05:15
Mengerian accepted D8490: Style improvements to bcha page.

Yes, this is a big improvement.

Nov 21 2020, 04:17
Mengerian accepted D8489: Add link to bcha page to main nav.

Built it locally and had a look, looks good to me

Nov 21 2020, 04:11
deadalnix updated the diff for D8491: Properly handle coinbase in proofbuilder.

Also do it for Stake

Nov 21 2020, 03:56
deadalnix requested review of D8491: Properly handle coinbase in proofbuilder.
Nov 21 2020, 03:53
majcosta accepted D8488: Change wallet_encryption.py to use signmessage instead of dumpprivkey.
Nov 21 2020, 03:08
majcosta accepted D8487: Functional tests for descriptor wallets.
Nov 21 2020, 03:01
johnkuney requested review of D8490: Style improvements to bcha page.
Nov 21 2020, 02:55
majcosta requested changes to D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 21 2020, 02:48
johnkuney requested review of D8489: Add link to bcha page to main nav.
Nov 21 2020, 01:56
deadalnix accepted D8479: net: Make addr relay mockable, add test.
Nov 21 2020, 00:38
deadalnix accepted D8480: refactor: replace CConnman pointers by references in net_processing.cpp.
Nov 21 2020, 00:37
teamcity updated the summary of D8488: Change wallet_encryption.py to use signmessage instead of dumpprivkey.
Nov 21 2020, 00:26
deadalnix requested review of D8488: Change wallet_encryption.py to use signmessage instead of dumpprivkey.
Nov 21 2020, 00:25
teamcity updated the summary of D8487: Functional tests for descriptor wallets.
Nov 21 2020, 00:08
deadalnix requested review of D8487: Functional tests for descriptor wallets.
Nov 21 2020, 00:08

Nov 20 2020

jasonbcox planned changes to D8486: Temporarily disable caching for css and js files.
Nov 20 2020, 22:18
jasonbcox requested review of D8486: Temporarily disable caching for css and js files.
Nov 20 2020, 22:18
johnkuney closed D8485: Add version tag to main.css file.
Nov 20 2020, 22:18
johnkuney committed rABCWEB6d3ffdc676d8: Add version tag to main.css file (authored by johnkuney).
Add version tag to main.css file
Nov 20 2020, 22:18
jasonbcox accepted D8485: Add version tag to main.css file.

Let's try this. If this doesn't work well, we can disable caching all together.

Nov 20 2020, 22:16
johnkuney requested review of D8485: Add version tag to main.css file.
Nov 20 2020, 22:11
johnkuney closed D8484: Moving bcha page CSS to main.css.
Nov 20 2020, 21:26
johnkuney committed rABCWEB40597246b917: Moving bcha page CSS to main.css (authored by johnkuney).
Moving bcha page CSS to main.css
Nov 20 2020, 21:26
First
Prev
Next