- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 14 2021
@bot build-ubsan
mtx.vout.resize(2) must be before the first test using 2 outputs
@bot build-ubsan
Reverse the outputs for the int64 overflow test.
In D8899#204315, @PiRK wrote:I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.
Jan 13 2021
For clarity, here are the packages that were removed vs re-orged:
I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.
add tests for CTransaction::GetValueOut
Keep separate versioning for web-app, deal with this when you have app store versions. For now, web app is distinct from extension, should have own versioning.
Change CashTab to Cashtab, match version of extension to web app (webapp version is artifact)
If you are renaming from CashTab to Cashtab, please make it consistently everywhere.
Change "CashTab" to "Cashtab"
I know there isn't int he original code, but there should really be tests cases for this.
remove accidental blank line and fix 115->4086
squash with PR18464 and update default maximum number of connections to 4096 (D8605)
use ABC commit/revision ID in comment
This revision got accidentally squash-landed together with D8890
remove accidental copy past or conflict left-over
Please also backport and squash in https://github.com/bitcoin/bitcoin/pull/18464 which is a fix for this PR.