Page MenuHomePhabricator
Feed All Stories

Jan 14 2021

PiRK committed rABCf6e814392083: rpc: Make rpc documentation not depend on rpc args (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Make rpc documentation not depend on rpc args
Jan 14 2021, 09:09
Fabien requested changes to D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 14 2021, 08:33
teamcity awarded D8899: Check for overflow when calculating sum of outputs a Piece of Eight token.
Jan 14 2021, 08:07
PiRK added a comment to D8899: Check for overflow when calculating sum of outputs.

@bot build-ubsan

Jan 14 2021, 08:07
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

mtx.vout.resize(2) must be before the first test using 2 outputs

Jan 14 2021, 08:06
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:56
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:55
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:51
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:50
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:49
teamcity added a comment to D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:49
teamcity awarded D8899: Check for overflow when calculating sum of outputs a Haypence token.
Jan 14 2021, 07:45
PiRK added a comment to D8899: Check for overflow when calculating sum of outputs.

@bot build-ubsan

Jan 14 2021, 07:45
PiRK updated the summary of D8899: Check for overflow when calculating sum of outputs.
Jan 14 2021, 07:44
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

Reverse the outputs for the int64 overflow test.

Jan 14 2021, 07:42
abc-bot committed rABC149fa1daf2a2: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jan 14 2021, 04:16
majcosta requested changes to D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Jan 14 2021, 04:01
abc-bot committed rABC66cad2d29519: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jan 14 2021, 03:16
abc-bot committed rABCc132b4470fd3: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jan 14 2021, 03:11
deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
In D8899#204315, @PiRK wrote:

I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.

Jan 14 2021, 02:51

Jan 13 2021

Joey King <joseph.roy.king@gmail.com> closed D8904: [Cashtab] bump extension version to support new backend per D8885.
Jan 13 2021, 21:10
Joey King <joseph.roy.king@gmail.com> committed rABCbc7dca4a146a: [Cashtab] bump extension version to support new backend per D8885 (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] bump extension version to support new backend per D8885
Jan 13 2021, 21:10
bytesofman requested review of D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 13 2021, 21:01
Fabien accepted D8906: [Cashtab] hide scrollbar in extension.
Jan 13 2021, 20:16
Fabien accepted D8904: [Cashtab] bump extension version to support new backend per D8885.
Jan 13 2021, 20:13
bytesofman requested review of D8906: [Cashtab] hide scrollbar in extension.
Jan 13 2021, 18:40
bytesofman added a comment to D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.

For clarity, here are the packages that were removed vs re-orged:

Jan 13 2021, 18:28
bytesofman requested review of D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Jan 13 2021, 18:25
PiRK added a comment to D8899: Check for overflow when calculating sum of outputs.

I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.

Jan 13 2021, 17:21
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

add tests for CTransaction::GetValueOut

Jan 13 2021, 17:17
deadalnix closed D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 17:05
deadalnix committed rABCc17adeb89179: [CashTab] Update react-copy-to-clipboard (authored by deadalnix).
[CashTab] Update react-copy-to-clipboard
Jan 13 2021, 17:05
Mengerian closed D8888: Change Bitcoin Cash references to BCHA in README.
Jan 13 2021, 17:04
Mengerian committed rABC88b5c380aeac: Change Bitcoin Cash references to BCHA in README (authored by Mengerian).
Change Bitcoin Cash references to BCHA in README
Jan 13 2021, 17:04
bytesofman updated the diff for D8904: [Cashtab] bump extension version to support new backend per D8885.

Keep separate versioning for web-app, deal with this when you have app store versions. For now, web app is distinct from extension, should have own versioning.

Jan 13 2021, 16:41
bytesofman updated the diff for D8904: [Cashtab] bump extension version to support new backend per D8885.

Change CashTab to Cashtab, match version of extension to web app (webapp version is artifact)

Jan 13 2021, 16:39
Fabien requested changes to D8904: [Cashtab] bump extension version to support new backend per D8885.

If you are renaming from CashTab to Cashtab, please make it consistently everywhere.

Jan 13 2021, 16:08
majcosta accepted D8904: [Cashtab] bump extension version to support new backend per D8885.
Jan 13 2021, 16:06
bytesofman updated the diff for D8904: [Cashtab] bump extension version to support new backend per D8885.

Change "CashTab" to "Cashtab"

Jan 13 2021, 15:57
bytesofman requested review of D8904: [Cashtab] bump extension version to support new backend per D8885.
Jan 13 2021, 15:55
PiRK closed D8898: wallet: Handle duplicate fileid exception.
Jan 13 2021, 15:27
PiRK committed rABC3fcc6ed32b9d: wallet: Handle duplicate fileid exception (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Handle duplicate fileid exception
Jan 13 2021, 15:27
Joey King <joseph.roy.king@gmail.com> closed D8885: [Cashtab] Prepare for migration to psf bch-api with new utxo key.
Jan 13 2021, 15:23
Joey King <joseph.roy.king@gmail.com> committed rABCfdcd3a04fbf1: [Cashtab] Prepare for migration to psf bch-api with new utxo key (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Prepare for migration to psf bch-api with new utxo key
Jan 13 2021, 15:23
PiRK closed D8900: RPC: Fix more formatting nits.
Jan 13 2021, 15:20
PiRK committed rABC71ac2d99c49f: RPC: Fix more formatting nits (authored by Luke Dashjr <luke-jr+git@utopios.org>).
RPC: Fix more formatting nits
Jan 13 2021, 15:20
majcosta accepted D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 15:20
majcosta accepted D8902: rpc: Make rpc documentation not depend on rpc args.
Jan 13 2021, 15:08
teamcity updated the summary of D8902: rpc: Make rpc documentation not depend on rpc args.
Jan 13 2021, 15:06
PiRK requested review of D8902: rpc: Make rpc documentation not depend on rpc args.
Jan 13 2021, 15:05
teamcity added a comment to D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 15:05
deadalnix accepted D8900: RPC: Fix more formatting nits.
Jan 13 2021, 14:58
deadalnix requested review of D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 14:50
teamcity updated the summary of D8900: RPC: Fix more formatting nits.
Jan 13 2021, 14:48
PiRK requested review of D8900: RPC: Fix more formatting nits.
Jan 13 2021, 14:48
majcosta closed D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Jan 13 2021, 14:44
majcosta committed rABC925120cac2cb: [backport#16658] validation: Rename CheckInputs to CheckInputScripts (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16658] validation: Rename CheckInputs to CheckInputScripts
Jan 13 2021, 14:44
Fabien accepted D8885: [Cashtab] Prepare for migration to psf bch-api with new utxo key.
Jan 13 2021, 14:27
deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.

I know there isn't int he original code, but there should really be tests cases for this.

Jan 13 2021, 14:22
deadalnix accepted D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Jan 13 2021, 14:21
teamcity updated the summary of D8899: Check for overflow when calculating sum of outputs.
Jan 13 2021, 14:21
PiRK requested review of D8899: Check for overflow when calculating sum of outputs.
Jan 13 2021, 14:20
Fabien accepted D8898: wallet: Handle duplicate fileid exception.
Jan 13 2021, 14:17
Fabien accepted D8894: Update -blocksonly documentation.
Jan 13 2021, 14:10
majcosta requested review of D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.

it looks like D3878 and D3875 diverged from Core so that the tests don't rely on whether "CheckInputs" or "CheckInputScripts" gets printed to the debug log

Jan 13 2021, 13:58
PiRK closed D8895: test: listsinceblock block height checks.
Jan 13 2021, 13:57
PiRK committed rABC78de14facc83: test: listsinceblock block height checks (authored by Jon Atack <jon@atack.com>).
test: listsinceblock block height checks
Jan 13 2021, 13:57
PiRK updated the diff for D8894: Update -blocksonly documentation.

remove accidental blank line and fix 115->4086

Jan 13 2021, 13:48
teamcity updated the summary of D8898: wallet: Handle duplicate fileid exception.
Jan 13 2021, 13:42
PiRK requested review of D8898: wallet: Handle duplicate fileid exception.
Jan 13 2021, 13:42
PiRK closed D8896: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged.
Jan 13 2021, 13:03
PiRK committed rABC3ba6c6af6eb9: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged
Jan 13 2021, 13:03
Fabien requested changes to D8894: Update -blocksonly documentation.
Jan 13 2021, 13:02
Fabien updated the summary of D8894: Update -blocksonly documentation.
Jan 13 2021, 12:59
PiRK closed D8897: test: check that peer is connected when calling sync_*.
Jan 13 2021, 12:51
PiRK committed rABCa05e018b9578: test: check that peer is connected when calling sync_* (authored by MarcoFalke <falke.marco@gmail.com>).
test: check that peer is connected when calling sync_*
Jan 13 2021, 12:51
PiRK updated the diff for D8894: Update -blocksonly documentation.

squash with PR18464 and update default maximum number of connections to 4096 (D8605)

Jan 13 2021, 12:45
PiRK closed D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 12:41
PiRK committed rABCc077bd1fcf59: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
RPC: Remove final comma for last entry of fixed-size Arrays and Objects in…
Jan 13 2021, 12:41
PiRK closed D8893: rpc: remove unused getbalances() code.
Jan 13 2021, 12:36
PiRK committed rABC989ce5804783: rpc: remove unused getbalances() code (authored by Jon Atack <jon@atack.com>).
rpc: remove unused getbalances() code
Jan 13 2021, 12:36
PiRK updated the diff for D8895: test: listsinceblock block height checks.

use ABC commit/revision ID in comment

Jan 13 2021, 12:34
PiRK closed D8889: test: add coverage for script parse error in ParseScript.
Jan 13 2021, 12:28
PiRK committed rABC98cbc3bea4b3: test: add coverage for script parse error in ParseScript (authored by pierrenn <git@pnn.sh>).
test: add coverage for script parse error in ParseScript
Jan 13 2021, 12:28
PiRK retitled D8890: util: Remove unused itostr and replace i64tostr with ToString from util: Remove unused itostr to util: Remove unused itostr and replace i64tostr with ToString.
Jan 13 2021, 12:26
PiRK closed D8891: util: Replace i64tostr with ToString.

This revision got accidentally squash-landed together with D8890

Jan 13 2021, 12:25
PiRK closed D8890: util: Remove unused itostr and replace i64tostr with ToString.
Jan 13 2021, 12:22
PiRK committed rABCead7a4497d04: util: Remove unused itostr (authored by MarcoFalke <falke.marco@gmail.com>).
util: Remove unused itostr
Jan 13 2021, 12:22
bytesofman accepted D8888: Change Bitcoin Cash references to BCHA in README.
Jan 13 2021, 12:09
Fabien accepted D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 11:34
PiRK updated the diff for D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.

remove accidental copy past or conflict left-over

Jan 13 2021, 11:22
Fabien accepted D8897: test: check that peer is connected when calling sync_*.
Jan 13 2021, 11:16
Fabien accepted D8891: util: Replace i64tostr with ToString.
Jan 13 2021, 11:15
Fabien accepted D8890: util: Remove unused itostr and replace i64tostr with ToString.
Jan 13 2021, 11:15
Fabien accepted D8896: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged.
Jan 13 2021, 11:14
Fabien accepted D8895: test: listsinceblock block height checks.
Jan 13 2021, 11:11
PiRK added inline comments to D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 11:08
Fabien requested changes to D8894: Update -blocksonly documentation.

Please also backport and squash in https://github.com/bitcoin/bitcoin/pull/18464 which is a fix for this PR.

Jan 13 2021, 11:08
Fabien accepted D8893: rpc: remove unused getbalances() code.
Jan 13 2021, 10:59
Fabien requested changes to D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 10:58