Hide generated snapshot file

We'll reach out another time to offer help to the exchanges before landing this.

fix nit in comment (no code touched)

Improve the error message to be more meaningful and consistent with other parts of the codebase.
Don't print the exception to the log but add it to the init error message.

In D9469#214984, @deadalnix wrote:

2/ Do the check here and add a way to export the result, which this patch really doesn't achieve.

OK I will try to attack this from the other angle, starting from the network. I have a good idea of the general picture, but the tricky part for me it to split it into smaller units that make sense on their own.

Please address previous feedback.

Remove the brackets and "supplied" wording

remove all accounting, make the tests simpler and more explicit

Ok, so the problem that you want to solve is knowing if the proof is rejected or just orphaned. The solution can come in many forms. For instance:
1/ Separate validation that doesn't depend from the state (and is therefore def invalid) and validation that is state dependent, put the stateless check outside the peer manager and handle the result there. This doesn't require any changes here.
2/ Do the check here and add a way to export the result, which this patch really doesn't achieve.

In D9469#214959, @deadalnix wrote:

Why couldn't fetchOrCreatePeer put the proof in the orphan set based on validation? Why is a new API needed? I strongly suspect that as you actually solve problems that you haven you'll discover that this is not needed.

Why couldn't fetchOrCreatePeer put the proof in the orphan set based on validation? Why is a new API needed? I strongly suspect that as you actually solve problems that you haven you'll discover that this is not needed.

Remove dependency on D9468.
Update the summary to explain what getProof is supposed to be used for.

revert accidental change when trying to update D9469

In D9469#214913, @deadalnix wrote:

I completely fail to see what this patch achieve. The added code seems to be at best redundant with existing code, at worse introduce bugs (if not today, then later as redundancy gets out of sync).

I'm abandoning this for now, it is supposed to be an optimization and not strictly needed to make peer discovery work. No need for yet another blocking dependency.

I completely fail to see what this patch achieve. The added code seems to be at best redundant with existing code, at worse introduce bugs (if not today, then later as redundancy gets out of sync).

This change does not looks like it make sense to me, because you don't know if it is actually taking ownership or not.

rebase (unrelated CI failure)

Mark snapshot as generated

broke QR code scanning

revert the linter complaints and green the diff

rename the add_variable_size test, make sure it covers a case in which the pool is filled to maximum capacity.
Remove the test that add constant sized proofs. I do not think it adds anything in terms of behavior tested, compared with the variable sized proofs test. So better to get rid of it to avoid future maintenance work.

Back out antd upgrade in this diff, use same version of nodejs as last package.json change

Start working on unit tests review:

• remove unused variable script
• improve remove_proofs to add proofs of various sizes so that we can control which one is actually removed
• don't keep unneccessay copies of proofs in various tests, when only the ID (and in one intance the size) is needed
• add a fail_to_add_same_proof_twice test, remove that test from another test (which removes the need to store the proof)
• rename small_pool -> add_proof_larger_than_pool
• add a simple pool_starts_empty test