Page MenuHomePhabricator

D2054.diff
No OneTemporary

D2054.diff

diff --git a/src/qt/test/wallettests.cpp b/src/qt/test/wallettests.cpp
--- a/src/qt/test/wallettests.cpp
+++ b/src/qt/test/wallettests.cpp
@@ -85,6 +85,20 @@
// src/qt/test/test_bitcoin-qt -platform windows # Windows
// src/qt/test/test_bitcoin-qt -platform cocoa # macOS
void WalletTests::walletTests() {
+#ifdef Q_OS_MAC
+ if (QApplication::platformName() == "minimal") {
+ // Disable for mac on "minimal" platform to avoid crashes inside the Qt
+ // framework when it tries to look up unimplemented cocoa functions,
+ // and fails to handle returned nulls
+ // (https://bugreports.qt.io/browse/QTBUG-49686).
+ QWARN("Skipping WalletTests on mac build with 'minimal' platform set "
+ "due to Qt bugs. To run AppTests, invoke "
+ "with 'test_bitcoin-qt -platform cocoa' on mac, or else use a "
+ "linux or windows build.");
+ return;
+ }
+#endif
+
// Set up wallet and chain with 101 blocks (1 mature block for spending).
TestChain100Setup test;
test.CreateAndProcessBlock(

File Metadata

Mime Type
text/plain
Expires
Mon, May 12, 01:40 (3 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5777034
Default Alt Text
D2054.diff (1 KB)

Event Timeline