Page MenuHomePhabricator
Files F14864335

D4910.diff
No OneTemporary
Actions

D4910.diff
View Options

diff --git a/src/qt/forms/sendcoinsdialog.ui b/src/qt/forms/sendcoinsdialog.ui
--- a/src/qt/forms/sendcoinsdialog.ui
+++ b/src/qt/forms/sendcoinsdialog.ui
@@ -826,7 +826,7 @@
<item>
<widget class="QRadioButton" name="radioCustomPerKilobyte">
<property name="toolTip">
- <string>Specify a custom fee per kB (1,000 bytes) of the transaction's virtual size.
+ <string>Specify a custom fee per kB (1,000 bytes) of the transaction's size.
Note: Since the fee is calculated on a per-byte basis, a fee of "100 satoshis per kB" for a transaction size of 500 bytes (half of 1 kB) would ultimately yield a fee of only 50 satoshis.</string>
</property>
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
--- a/src/rpc/blockchain.cpp
+++ b/src/rpc/blockchain.cpp
@@ -421,13 +421,13 @@
"transaction entered pool\n"
" \"descendantcount\" : n, (numeric) number of in-mempool "
"descendant transactions (including this one)\n"
- " \"descendantsize\" : n, (numeric) virtual transaction size "
+ " \"descendantsize\" : n, (numeric) transaction size "
"of in-mempool descendants (including this one)\n"
" \"descendantfees\" : n, (numeric) modified fees (see above) "
"of in-mempool descendants (including this one) (DEPRECATED)\n"
" \"ancestorcount\" : n, (numeric) number of in-mempool "
"ancestor transactions (including this one)\n"
- " \"ancestorsize\" : n, (numeric) virtual transaction size "
+ " \"ancestorsize\" : n, (numeric) transaction size "
"of in-mempool ancestors (including this one)\n"
" \"ancestorfees\" : n, (numeric) modified fees (see above) "
"of in-mempool ancestors (including this one) (DEPRECATED)\n"
diff --git a/src/txmempool.h b/src/txmempool.h
--- a/src/txmempool.h
+++ b/src/txmempool.h
@@ -459,7 +459,7 @@
//!< Used by getblocktemplate to trigger CreateNewBlock() invocation
unsigned int nTransactionsUpdated;
- //!< sum of all mempool tx's virtual sizes.
+ //!< sum of all mempool tx's sizes.
uint64_t totalTxSize;
//!< sum of dynamic memory usage of all the map elements (NOT the maps
//! themselves)
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -3045,7 +3045,7 @@
nValueToSelect += nFeeRet;
}
- // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1
+ // Static size overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1
// input count, 1 output count
coin_selection_params.tx_noinputs_size = 10;
// vouts to the payees

File Metadata

Mime Type
text/plain
Expires
Tue, May 20, 18:51 (2 h, 57 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5865729
Default Alt Text
D4910.diff (2 KB)

Event Timeline