Page MenuHomePhabricator
Files F13711272

D12615.diff
No OneTemporary
Actions

D12615.diff
View Options

diff --git a/test/functional/feature_init.py b/test/functional/feature_init.py
--- a/test/functional/feature_init.py
+++ b/test/functional/feature_init.py
@@ -47,9 +47,6 @@
def check_clean_start():
"""Ensure that node restarts successfully after various interrupts."""
- # TODO: add -txindex=1 to fully test index initiatlization.
- # See https://github.com/bitcoin/bitcoin/pull/23289#discussion_r735159180 for
- # a discussion of the related bug.
node.start()
node.wait_for_rpc_connection()
assert_equal(200, node.getblockcount())
@@ -69,9 +66,10 @@
'net thread start',
'addcon thread start',
'loadblk thread start',
- # TODO: re-enable - see above TODO
- # 'txindex thread start',
+ 'txindex thread start',
'msghand thread start',
+ 'net thread start',
+ 'addcon thread start',
]
if self.is_wallet_compiled():
lines_to_terminate_after.append('Verifying wallet')
@@ -79,10 +77,7 @@
for terminate_line in lines_to_terminate_after:
self.log.info(
f"Starting node and will exit after line '{terminate_line}'")
- node.start(
- # TODO: add -txindex=1 to fully test index initiatlization.
- # extra_args=['-txindex=1'],
- )
+ node.start(extra_args=['-txindex=1'])
num_total_logs = node.wait_for_debug_log(
[terminate_line], ignore_case=True)
@@ -101,10 +96,7 @@
additional_lines = random.randint(1, num_total_logs)
self.log.debug(
f"Starting node and will exit after {additional_lines} lines")
- node.start(
- # TODO: add -txindex=1 to fully test index initiatlization.
- # extra_args=['-txindex=1'],
- )
+ node.start(extra_args=['-txindex=1'])
logfile = open(node.debug_log_path, 'r', encoding='utf8')
MAX_SECS_TO_WAIT = 10
@@ -158,8 +150,7 @@
# successfully?) so investigate doing this later.
node.assert_start_raises_init_error(
- # TODO: add -txindex=1 to fully test index initiatlization.
- # extra_args=['-txindex=1'],
+ extra_args=['-txindex=1'],
expected_msg=err_fragment,
match=ErrorMatch.PARTIAL_REGEX,
)

File Metadata

Mime Type
text/plain
Expires
Sat, Apr 26, 11:18 (11 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5573387
Default Alt Text
D12615.diff (2 KB)

Event Timeline