- User Since
- Jun 16 2017, 21:15 (114 w, 16 h)
Jul 3 2019
My beautiful code is gone! :'(
Jun 5 2019
Dec 23 2017
Sep 11 2017
Sep 10 2017
Added some comments and a question..
I dream of the day when we don't need Boost for anything. Except maybe the test framework. If that.
Sep 7 2017
Trivially correct. Accepting.
Sep 5 2017
Sep 4 2017
Excellent work, sickpig! I won't approve 100% just yet -- I'll wait for deadalnix to have one last look at it.
Sep 2 2017
Aug 31 2017
Oops -- QAPP_ORG_NAME "BitcoinCash" -> "BitcoinABC"
Updated all app bundle-related names to be bitoinabc.org and not bitcoincash.org
Bitcoincash is the protocol. The app org name is bitcoinabc.
Modified to use C++11 ranged for loop
Looks good to me. I'll approve as me, and give deadalnix a chance to reply/critique python usage (I am a python nub).
Bah. Arcanist! Why do you vex me?! Fixed with a rebase.
Fixed typo in comment
Aug 30 2017
Aw man thanks a lot!
Ok, I can do that at a later time (like later tonight or tomorrow morning) -- or freetrader -- if you're already set up mind doing it since.. well.. you're already set up?
Yeah agreed that can be a separate PR.. err... diff.
I strongly approve!!
A few comments. Otherwise looks good to me.
Aug 29 2017
This looks good. I like the code refactor -- slightly neater to not call self.start_nodes in each derived class and just move it to the base. All tests pass, as well.
OMFG did you test this?! SUCH A VITAL PIECE OF LOGIC ! It might break everything
Aug 28 2017
I love how you panic, Deadalnix, without bothering to understand what is happening. :)
Yay! Good job! Simple fix, lol..
Looks good to me.
Looks good. Approved.
Added some usability suggestions.
Aug 27 2017
Added freetrader's recommended changes
All fair points.. I'll implement your recommendations.
Good suggestions by deadalnix.
I can't apply this patch to test it.
Looks Good To Me. However I can't compile it as it complains about missing FastRandomContext::rand64().
Wrestling with arc
Refactored the two test-driver scripts into 1 script for simplicity.
Rebased to include all changes
Aug 26 2017
I like this diff. A lot.
Aug 24 2017
Aug 23 2017
Apparently you guys like holding locks for trivial checks rather than caching them
Abandoned because it turns out we throw away non-cash ADDR's anyway a few lines later. So it doesn't hurt to accept ADDRs from non-cash nodes in the off chance they are telliing us about a Cash peer.
Struggling with arcanist. This should do it.
Eh.. rebase to not pick up unwanted diffs
Use new flag from D479
Assert was in the wrong place.
Aug 22 2017
Aug 21 2017
Aug 20 2017
I was on clang-format-4.0.