Page MenuHomePhabricator

CCulianu (Calin Culianu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2017, 21:15 (114 w, 16 h)

Recent Activity

Jul 3 2019

CCulianu added a comment to D3537: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally".

My beautiful code is gone! :'(

Jul 3 2019, 09:26

Jun 5 2019

CCulianu added a project to T666: User-facing string in GUI from untrusted source: Restricted Project.
Jun 5 2019, 18:02 · Restricted Project
CCulianu created T666: User-facing string in GUI from untrusted source.
Jun 5 2019, 18:01 · Restricted Project

Dec 23 2017

rom894 awarded T89: Consider adding -maxoutconnections to command-line and config file (like BU has) a Pirate Logo token.
Dec 23 2017, 21:35 · Restricted Project

Sep 11 2017

CCulianu added inline comments to D529: Add Amount class and use it for CENT and COIN..
Sep 11 2017, 06:27
CCulianu added inline comments to D529: Add Amount class and use it for CENT and COIN..
Sep 11 2017, 05:54

Sep 10 2017

CCulianu added a comment to D529: Add Amount class and use it for CENT and COIN..

Added some comments and a question..

Sep 10 2017, 19:05
CCulianu accepted D536: boost::ref => std::ref.
Sep 10 2017, 19:01
CCulianu accepted D537: boost::shared_ptr => std::shared_ptr.

I dream of the day when we don't need Boost for anything. Except maybe the test framework. If that.

Sep 10 2017, 18:59

Sep 7 2017

CCulianu accepted D532: Use uint32_t in script flag test utility.

Trivially correct. Accepting.

Sep 7 2017, 09:43
CCulianu accepted D533: Update release notes for 0.15.0.

Looks good to me!

Sep 7 2017, 09:43

Sep 5 2017

CCulianu accepted D526: Make CheckInputs and FindFilesToPruneManual static.
Sep 5 2017, 21:33
CCulianu accepted D523: Use uint32_t as argument for Checkinputs.
Sep 5 2017, 21:32

Sep 4 2017

CCulianu added a comment to D485: Set default space reserved for hiprio txns to 5% of max generated block size.

Excellent work, sickpig! I won't approve 100% just yet -- I'll wait for deadalnix to have one last look at it.

Sep 4 2017, 00:10

Sep 2 2017

CCulianu accepted D485: Set default space reserved for hiprio txns to 5% of max generated block size.
Sep 2 2017, 21:11

Aug 31 2017

CCulianu committed rABC289835478b3e: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own… (authored by CCulianu).
Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own…
Aug 31 2017, 18:30
CCulianu closed D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file by committing rABC289835478b3e: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own….
Aug 31 2017, 18:30
CCulianu updated the diff for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.

Oops -- QAPP_ORG_NAME "BitcoinCash" -> "BitcoinABC"

Aug 31 2017, 18:20
CCulianu updated the diff for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.

Updated all app bundle-related names to be bitoinabc.org and not bitcoincash.org
Bitcoincash is the protocol. The app org name is bitcoinabc.

Aug 31 2017, 18:19
CCulianu added a comment to D514: Fix ZMQ test occasional hang and modernize it.

Yay!

Aug 31 2017, 18:12
CCulianu updated the diff for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.

Modified to use C++11 ranged for loop

Aug 31 2017, 18:10
CCulianu added inline comments to D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.
Aug 31 2017, 16:28
CCulianu accepted D514: Fix ZMQ test occasional hang and modernize it.

Looks good to me. I'll approve as me, and give deadalnix a chance to reply/critique python usage (I am a python nub).

Aug 31 2017, 14:35
CCulianu updated the diff for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.

Bah. Arcanist! Why do you vex me?! Fixed with a rebase.

Aug 31 2017, 08:19
CCulianu updated the diff for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file.

Fixed typo in comment

Aug 31 2017, 08:18
Herald added a reviewer for D513: Qt/GUI only: Migrate GUI settings from Bitcoin Core's settings file to our own file: Restricted Project.
Aug 31 2017, 08:14

Aug 30 2017

CCulianu committed rABCa8aab99234db: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change… (authored by CCulianu).
OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change…
Aug 30 2017, 21:16
CCulianu closed D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match. by committing rABCa8aab99234db: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change….
Aug 30 2017, 21:16
CCulianu accepted D511: Remove unused hasModifier flag.
Aug 30 2017, 20:42
CCulianu added a comment to D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match..

Aw man thanks a lot!

Aug 30 2017, 20:19
CCulianu added a comment to D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match..

Ok, I can do that at a later time (like later tonight or tomorrow morning) -- or freetrader -- if you're already set up mind doing it since.. well.. you're already set up?

Aug 30 2017, 17:30
Herald added a reviewer for D510: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change related OSX-specific handlers and Info.plist stuff to match.: Restricted Project.
Aug 30 2017, 15:41
CCulianu accepted D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.

Yeah agreed that can be a separate PR.. err... diff.

Aug 30 2017, 14:09
CCulianu accepted D509: Add note to Github repo for easier cloning of development source tree.

I strongly approve!!

Aug 30 2017, 13:37
CCulianu added a comment to D508: Update OSX MIME type for .bitcoinpaymentrequest files, rename identifiers.

A few comments. Otherwise looks good to me.

Aug 30 2017, 13:36

Aug 29 2017

CCulianu accepted D505: [tests] Remove is_network_split from funtional test cases.

This looks good. I like the code refactor -- slightly neater to not call self.start_nodes in each derived class and just move it to the base. All tests pass, as well.

Aug 29 2017, 22:55
CCulianu accepted D506: Use % style format in prunning.py.

OMFG did you test this?! SUCH A VITAL PIECE OF LOGIC ! It might break everything

Aug 29 2017, 11:09
CCulianu accepted D501: [net] Allow disconnectnode RPC to be called with node id.
Aug 29 2017, 11:08
CCulianu added inline comments to D501: [net] Allow disconnectnode RPC to be called with node id.
Aug 29 2017, 07:37

Aug 28 2017

CCulianu accepted D504: Fix proxy_test logging crash when no IPv6 available.
Aug 28 2017, 20:30
CCulianu accepted D504: Fix proxy_test logging crash when no IPv6 available.

I love how you panic, Deadalnix, without bothering to understand what is happening. :)

Aug 28 2017, 19:50
CCulianu accepted D504: Fix proxy_test logging crash when no IPv6 available.

Yay! Good job! Simple fix, lol..

Aug 28 2017, 18:43
CCulianu accepted D502: Fix and add test for empty chain and reorg consistency for gettxoutsetinfo..

Looks good to me.

Aug 28 2017, 17:51
CCulianu accepted D491: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a 32 bit one..

Looks good. Approved.

Aug 28 2017, 17:31
CCulianu accepted D493: Remove CCoinsModifier.

Ok, this looks good.

Aug 28 2017, 17:17
CCulianu accepted D471: Kill ModifyCoin.

.. and as Bitcoin ABC

Aug 28 2017, 17:16
CCulianu accepted D471: Kill ModifyCoin.

OK, well I'll accept as myself..

Aug 28 2017, 17:15
CCulianu added a comment to D501: [net] Allow disconnectnode RPC to be called with node id.

Added some usability suggestions.

Aug 28 2017, 17:08
CCulianu committed rABCa4a9a7c341ab: Workaround to Travis-CI Wine/Mingw build hanging occasionally (authored by CCulianu).
Workaround to Travis-CI Wine/Mingw build hanging occasionally
Aug 28 2017, 16:53
CCulianu closed D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally by committing rABCa4a9a7c341ab: Workaround to Travis-CI Wine/Mingw build hanging occasionally.
Aug 28 2017, 16:53

Aug 27 2017

CCulianu added a comment to D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Is the problem this is working around happening for core ? What are the next step here. This would be acceptable as a transitional solution, but doesn't seems like a good plan long term.

Aug 27 2017, 16:48
CCulianu updated the diff for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Added freetrader's recommended changes

Aug 27 2017, 13:02
CCulianu planned changes to D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

All fair points.. I'll implement your recommendations.

Aug 27 2017, 12:47
CCulianu requested changes to D494: Summary: Replace CAmount typdef with a struct..

Good suggestions by deadalnix.

Aug 27 2017, 11:01
CCulianu added a comment to D490: FastRandomContext improvements and switch to ChaCha20.

I can't apply this patch to test it.

Aug 27 2017, 10:15
CCulianu added a comment to D491: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a 32 bit one..

Looks Good To Me. However I can't compile it as it complains about missing FastRandomContext::rand64().

Aug 27 2017, 10:12
CCulianu accepted D496: autopep8 all tests.
Aug 27 2017, 10:05
CCulianu updated the diff for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Wrestling with arc

Aug 27 2017, 10:01
CCulianu updated the diff for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Refactored the two test-driver scripts into 1 script for simplicity.

Aug 27 2017, 09:59
CCulianu updated the diff for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Rebased to include all changes

Aug 27 2017, 03:11
CCulianu updated the diff for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally.

Ok

Aug 27 2017, 03:09
Herald added a reviewer for D497: Workaround to Travis-CI Wine/Mingw build hanging occasionally: Restricted Project.
Aug 27 2017, 03:06
CCulianu accepted D495: boost::function => std::function.

I very much approve.

Aug 27 2017, 02:16

Aug 26 2017

CCulianu committed rABC6719e4a97e10: Tweak to travis.yml to exit on error (authored by CCulianu).
Tweak to travis.yml to exit on error
Aug 26 2017, 20:27
CCulianu closed D492: Tweak to travis.yml to exit on error by committing rABC6719e4a97e10: Tweak to travis.yml to exit on error.
Aug 26 2017, 20:27
CCulianu accepted D483: Clang-format applied to some files.

LGTM

Aug 26 2017, 20:03
Herald added a reviewer for D492: Tweak to travis.yml to exit on error: Restricted Project.
Aug 26 2017, 19:43
CCulianu committed rABC333cd5b0cf4d: fixed travis build warning/error related to rename of package from bitcoin ->… (authored by CCulianu).
fixed travis build warning/error related to rename of package from bitcoin ->…
Aug 26 2017, 19:14
CCulianu closed D489: fixed travis build warning/error related to rename of package from bitcoin -> bitcoin-abc by committing rABC333cd5b0cf4d: fixed travis build warning/error related to rename of package from bitcoin ->….
Aug 26 2017, 19:14
CCulianu added a comment to D488: Specific GetOSRandom for Linux/FreeBSD/OpenBSD.

I like this diff. A lot.

Aug 26 2017, 19:07
Herald added a reviewer for D489: fixed travis build warning/error related to rename of package from bitcoin -> bitcoin-abc: Restricted Project.
Aug 26 2017, 18:56

Aug 24 2017

CCulianu committed rABC206f9daafe4a: Fixed sanitizers to compiled OK with Qt enabled (authored by CCulianu).
Fixed sanitizers to compiled OK with Qt enabled
Aug 24 2017, 13:36
CCulianu closed D481: Fixed sanitizers to compiled OK with Qt enabled by committing rABC206f9daafe4a: Fixed sanitizers to compiled OK with Qt enabled.
Aug 24 2017, 13:36
Herald added a reviewer for D481: Fixed sanitizers to compiled OK with Qt enabled: Restricted Project.
Aug 24 2017, 10:57

Aug 23 2017

CCulianu abandoned D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).

Apparently you guys like holding locks for trivial checks rather than caching them

Aug 23 2017, 18:28
CCulianu abandoned D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.

Abandoned because it turns out we throw away non-cash ADDR's anyway a few lines later. So it doesn't hurt to accept ADDRs from non-cash nodes in the off chance they are telliing us about a Cash peer.

Aug 23 2017, 18:27
CCulianu added a comment to D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.

For networking code, we will always be past UAHF fork. Unless we invent a time machine.

Aug 23 2017, 18:02
CCulianu added a comment to D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).

The flag should not really be necessary in my view, although I can live with it as an interim measure.

Aug 23 2017, 17:32
CCulianu added a comment to D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).
In D479#8388, @zander wrote:

In classic I needed a 3-state.

  1. not active
  2. active, waiting for > 1MB block
  3. active

If you follow that I think you can delete some more overhead elsewhere.

Aug 23 2017, 11:11
CCulianu updated the summary of D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).
Aug 23 2017, 11:10
CCulianu updated the diff for D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.

Struggling with arcanist. This should do it.

Aug 23 2017, 11:08
CCulianu updated the diff for D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.

Eh.. rebase to not pick up unwanted diffs

Aug 23 2017, 11:05
CCulianu updated the summary of D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.
Aug 23 2017, 11:02
CCulianu updated the diff for D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already.

Use new flag from D479

Aug 23 2017, 11:00
CCulianu updated the summary of D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).
Aug 23 2017, 10:44
Herald added a reviewer for D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff): Restricted Project.
Aug 23 2017, 10:41
CCulianu committed rABCda7242575063: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to… (authored by CCulianu).
Mark -uahfstarttime parameter as deprecated and issue a log warning if set to…
Aug 23 2017, 10:11
CCulianu closed D477: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to anything other than default by committing rABCda7242575063: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to….
Aug 23 2017, 10:11
CCulianu updated the test plan for D477: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to anything other than default.
Aug 23 2017, 10:04
Herald added a reviewer for D478: Ignore ADDR messages from non-Cash peers if on the Cash chain already: Restricted Project.
Aug 23 2017, 10:01
CCulianu updated the diff for D477: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to anything other than default.

Assert was in the wrong place.

Aug 23 2017, 09:23
Herald added a reviewer for D477: Mark -uahfstarttime parameter as deprecated and issue a log warning if set to anything other than default: Restricted Project.
Aug 23 2017, 09:18

Aug 22 2017

CCulianu abandoned D468: WIP - SafeMode warning fix: attempt to detect when the fork is behind a checkpoint.
In D468#8161, @zander wrote:

FYI; the CheckForkWarningConditions() and friends use hard-coded block-counts and show a warning of a nature that I'm not sure is of any value. As such this code has been removed in Classic.

Aug 22 2017, 21:23
CCulianu accepted D476: autopep8 rpc-tests.py.
Aug 22 2017, 21:21
CCulianu committed rABCeb04e1119ac2: TRIVIAL: Fix log file message for client name to match CLIENT_NAME (authored by CCulianu).
TRIVIAL: Fix log file message for client name to match CLIENT_NAME
Aug 22 2017, 21:20
CCulianu closed D475: TRIVIAL: Fix log file message for client name to match CLIENT_NAME by committing rABCeb04e1119ac2: TRIVIAL: Fix log file message for client name to match CLIENT_NAME.
Aug 22 2017, 21:20

Aug 21 2017

CCulianu accepted D311: Resolve FIXMEs in src/net.cpp (pass config through CConnman).
Aug 21 2017, 07:37

Aug 20 2017

CCulianu added a comment to D475: TRIVIAL: Fix log file message for client name to match CLIENT_NAME.

I was on clang-format-4.0.

Aug 20 2017, 23:26
CCulianu updated the diff for D475: TRIVIAL: Fix log file message for client name to match CLIENT_NAME.

Undid linter

Aug 20 2017, 23:26
CCulianu added inline comments to D311: Resolve FIXMEs in src/net.cpp (pass config through CConnman).
Aug 20 2017, 23:13