Page MenuHomePhabricator

awemany (awemany)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2017, 15:59 (264 w, 1 d)

Recent Activity

Aug 14 2018

awemany added a comment to D1653: Use a single round of SHA256 ont he CHECKDATASIG message..

As the author of the previous differential D1652, this looks good to me. Test vectors seem to be the same (I just did a diff of the diffs, it is empty regarding the test vectors) and the code as far as I can see is equivalent.

Aug 14 2018, 20:34
awemany updated the diff for D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.

Update formatting of comment after clang-format

Aug 14 2018, 17:16
awemany updated the diff for D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.

Forgot to squash commits - didn't use phabricator for a long time.

Aug 14 2018, 17:12
awemany created D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.
Aug 14 2018, 17:06

Jul 27 2017

awemany accepted D385: Do not increase the banscore of node forwarding transactions that are not valid yet..

make check runs successfully

Jul 27 2017, 13:05
awemany committed rABCd60dfef8c93b: Factor out getId() from Misbehaving(..) calls (authored by awemany).
Factor out getId() from Misbehaving(..) calls
Jul 27 2017, 12:20
awemany closed D384: Factor out getId() from Misbehaving(..) calls by committing rABCd60dfef8c93b: Factor out getId() from Misbehaving(..) calls.
Jul 27 2017, 12:20
awemany added inline comments to D384: Factor out getId() from Misbehaving(..) calls.
Jul 27 2017, 10:55
awemany updated the diff for D384: Factor out getId() from Misbehaving(..) calls.

Fix static

Jul 27 2017, 10:54
awemany updated the diff for D384: Factor out getId() from Misbehaving(..) calls.

Formatting with clang-format-3.8 again.

Jul 27 2017, 10:22
awemany accepted D362: Remove version from UTXO and undo datastructures..
Jul 27 2017, 09:47
awemany requested changes to D362: Remove version from UTXO and undo datastructures..
Jul 27 2017, 09:33
awemany closed T70: Remove boost unordered_map as Resolved.
Jul 27 2017, 09:24
awemany updated the diff for D384: Factor out getId() from Misbehaving(..) calls.

Add ref to D380.

Jul 27 2017, 09:18
Herald added a reviewer for D384: Factor out getId() from Misbehaving(..) calls: Restricted Project.
Jul 27 2017, 09:16
awemany accepted D380: Add error code when increasing DoS scores.

make check works, log message testing is too much as per dev slack.

Jul 27 2017, 09:13
awemany requested changes to D380: Add error code when increasing DoS scores.

Maybe I am at Nazi complaint level here, but any new feature should be tested, no?

Jul 27 2017, 08:56
awemany committed rABC3fc5f7c2f7e2: Replace boost::unordered_map and boost::unordered_set with std:: variant (authored by awemany).
Replace boost::unordered_map and boost::unordered_set with std:: variant
Jul 27 2017, 08:44
awemany closed D382: Replace boost::unordered_map and boost::unordered_set with std:: variant by committing rABC3fc5f7c2f7e2: Replace boost::unordered_map and boost::unordered_set with std:: variant.
Jul 27 2017, 08:44
Herald added a reviewer for D382: Replace boost::unordered_map and boost::unordered_set with std:: variant: Restricted Project.
Jul 27 2017, 08:28

Jun 22 2017

awemany added a comment to D232: Some simplification in the compact block code and tests.

See comments, make check passes.

Jun 22 2017, 15:30
awemany accepted D242: Pass config down to InitializeNode.

See message, looks good and make check passes.

Jun 22 2017, 15:16

Jun 20 2017

awemany added inline comments to D232: Some simplification in the compact block code and tests.
Jun 20 2017, 09:42
awemany added a comment to D224: Mark fall-through cases in our code clearly.

I didn't test this yet. But you wrote

Jun 20 2017, 09:39
awemany added inline comments to D222: Implement "EBx.y" indicator on subversion (user agent).
Jun 20 2017, 09:36
awemany added inline comments to D232: Some simplification in the compact block code and tests.
Jun 20 2017, 09:29
awemany added inline comments to D222: Implement "EBx.y" indicator on subversion (user agent).
Jun 20 2017, 09:16

Jun 14 2017

awemany added inline comments to D197: Test OP_RETURN anti replay feature.
Jun 14 2017, 21:12
awemany added a comment to D197: Test OP_RETURN anti replay feature.

Built and passed in 6s. But see also comments.

Jun 14 2017, 21:05
awemany accepted D198: Format various comments.

Looks good to me.

Jun 14 2017, 16:45
Herald added a reviewer for D199: Fix temporary file creation for validation_tests: Restricted Project.
Jun 14 2017, 10:34

Jun 13 2017

awemany committed rABC1d1ce9ab25e0: Fix for rebase/merge failure (authored by awemany).
Fix for rebase/merge failure
Jun 13 2017, 20:32
awemany closed D192: Fix for rebase/merge failure by committing rABC1d1ce9ab25e0: Fix for rebase/merge failure.
Jun 13 2017, 20:32
Herald added a reviewer for D192: Fix for rebase/merge failure: Restricted Project.
Jun 13 2017, 20:14
awemany added inline comments to D188: Format chain.h and chain.cpp.
Jun 13 2017, 20:02
awemany added inline comments to D187: Format mempool_tests.cpp.
Jun 13 2017, 20:00
awemany requested changes to D188: Format chain.h and chain.cpp.

See code comment.

Jun 13 2017, 19:56
awemany accepted D187: Format mempool_tests.cpp.

Except for above nit, looks good.

Jun 13 2017, 19:45
awemany committed rABC39fe309bab18: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE (authored by awemany).
Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE
Jun 13 2017, 18:48
awemany closed D189: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE by committing rABC39fe309bab18: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE.
Jun 13 2017, 18:48
awemany updated the diff for D189: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE.

Address review issues raised by deadalnix.

Jun 13 2017, 18:43
Herald added a reviewer for D189: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE: Restricted Project.
Jun 13 2017, 18:22
awemany committed rABCf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8 (authored by awemany).
Remove leftover short-circuit evaluation condition from bdb377d68ea8
Jun 13 2017, 14:37
awemany closed D185: Remove leftover short-circuit evaluation condition from bdb377d68ea8 by committing rABCf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8.
Jun 13 2017, 14:37
awemany updated the test plan for D185: Remove leftover short-circuit evaluation condition from bdb377d68ea8.
Jun 13 2017, 14:35
Herald added a reviewer for D185: Remove leftover short-circuit evaluation condition from bdb377d68ea8: Restricted Project.
Jun 13 2017, 14:34
awemany raised a concern with rABCbdb377d68ea8: Kill SegWit Step 11: Remove HasWitness.

Hi deadalnix,

Jun 13 2017, 12:08