- User Since
- Jun 11 2017, 15:59 (264 w, 1 d)
Aug 14 2018
As the author of the previous differential D1652, this looks good to me. Test vectors seem to be the same (I just did a diff of the diffs, it is empty regarding the test vectors) and the code as far as I can see is equivalent.
Update formatting of comment after clang-format
Forgot to squash commits - didn't use phabricator for a long time.
Jul 27 2017
make check runs successfully
Formatting with clang-format-3.8 again.
Add ref to D380.
make check works, log message testing is too much as per dev slack.
Maybe I am at Nazi complaint level here, but any new feature should be tested, no?
Jun 22 2017
See comments, make check passes.
See message, looks good and make check passes.
Jun 20 2017
I didn't test this yet. But you wrote
Jun 14 2017
Built and passed in 6s. But see also comments.
Jun 13 2017
Address review issues raised by deadalnix.