Page MenuHomePhabricator

danconnolly (Daniel Connolly)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 21 2018, 07:33 (118 w, 6 d)

Recent Activity

Sep 4 2018

danconnolly abandoned D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
Sep 4 2018, 09:29
danconnolly abandoned D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Sep 4 2018, 09:29
danconnolly abandoned D1598: OP_MUL implementation.
Sep 4 2018, 09:29
danconnolly abandoned D1606: OP_INVERT implementation.
Sep 4 2018, 09:28
danconnolly abandoned D1631: Enable the magnetic opcode changes in the opcode tests.
Sep 4 2018, 09:28
danconnolly abandoned D1638: OP_LSHIFT & OP_RSHIFT implementation.
Sep 4 2018, 09:28

Aug 9 2018

danconnolly added a reviewer for D1638: OP_LSHIFT & OP_RSHIFT implementation: Restricted Project.
Aug 9 2018, 19:37
danconnolly created D1638: OP_LSHIFT & OP_RSHIFT implementation.
Aug 9 2018, 19:35
danconnolly added a comment to D1606: OP_INVERT implementation.

There should be some additional testing in the magnetic anomaly activation test.

See here that there's already a test landed: https://reviews.bitcoinabc.org/rABC4714cd3622565b35d08fa71d932482ad760cc0ba

Aug 9 2018, 13:37
danconnolly updated the summary of D1606: OP_INVERT implementation.
Aug 9 2018, 07:59
danconnolly added inline comments to D1598: OP_MUL implementation.
Aug 9 2018, 07:58
danconnolly updated the summary of D1598: OP_MUL implementation.
Aug 9 2018, 07:57
danconnolly updated the summary of D1598: OP_MUL implementation.
Aug 9 2018, 07:56

Aug 8 2018

danconnolly updated the diff for D1598: OP_MUL implementation.

refactor based on re-organizing prior diffs

Aug 8 2018, 23:00
danconnolly added a reviewer for D1598: OP_MUL implementation: Restricted Project.
Aug 8 2018, 22:49
danconnolly updated the diff for D1606: OP_INVERT implementation.

refactor the diffs to be more coherent and scope refined

Aug 8 2018, 22:44
danconnolly added a reviewer for D1606: OP_INVERT implementation: Restricted Project.
Aug 8 2018, 22:41
danconnolly added a reviewer for D1631: Enable the magnetic opcode changes in the opcode tests: Restricted Project.
Aug 8 2018, 22:36
danconnolly created D1631: Enable the magnetic opcode changes in the opcode tests.
Aug 8 2018, 22:34
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

another rebase

Aug 8 2018, 21:40
danconnolly updated the diff for D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
  • specification has been updated to remove OP_2MUL & OP_2DIV
Aug 8 2018, 19:08
danconnolly added inline comments to D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Aug 8 2018, 19:05
danconnolly updated the summary of D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
Aug 8 2018, 18:44
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
  • remove OP_2MUL & OP_2DIV tests that were added for magnetic, they are no longer being re-enabled
Aug 8 2018, 18:42
danconnolly planned changes to D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

need to remove the extra tests added for OP_2MUL & OP_2DIV

Aug 8 2018, 18:00
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
  • split up tests into their own sections, they will be expanded later
  • merge CHECKDATASIG and MAGNETIC_OPCODES flags
  • update comment to reflect change in flag
Aug 8 2018, 17:57
danconnolly abandoned D1608: OP_2MUL & OP_2DIV implementation.

OP_2MUL & OP_2DIV removed from planned change.

Aug 8 2018, 12:41

Aug 3 2018

danconnolly requested review of D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..

The opcodes were disabled, not invalid. See lines 85-93 in interpreter.cpp

Aug 3 2018, 21:39

Aug 2 2018

danconnolly added inline comments to D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Aug 2 2018, 22:14

Jul 28 2018

danconnolly added a reviewer for D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp: Restricted Project.
Jul 28 2018, 12:49
danconnolly added a reviewer for D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update.: Restricted Project.
Jul 28 2018, 12:49
danconnolly planned changes to D1608: OP_2MUL & OP_2DIV implementation.

need to re-organize this, it has conflicting changes with some other of the diffs

Jul 28 2018, 12:47
danconnolly planned changes to D1606: OP_INVERT implementation.

the reorganiztion of script_tests.json shouldnt be in this diff

Jul 28 2018, 12:44
danconnolly planned changes to D1598: OP_MUL implementation.
Jul 28 2018, 12:42
danconnolly updated the test plan for D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp.
Jul 28 2018, 11:05
danconnolly updated the test plan for D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp.
Jul 28 2018, 11:04
danconnolly updated the summary of D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
Jul 28 2018, 10:27
danconnolly updated the summary of D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Jul 28 2018, 10:10

Jul 27 2018

danconnolly added inline comments to D1608: OP_2MUL & OP_2DIV implementation.
Jul 27 2018, 15:14
danconnolly created D1608: OP_2MUL & OP_2DIV implementation.
Jul 27 2018, 15:12

Jul 26 2018

danconnolly created D1606: OP_INVERT implementation.
Jul 26 2018, 23:46
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
  • split up tests into their own sections, they will be expanded later
  • merge CHECKDATASIG and MAGNETIC_OPCODES flags
  • rebase & correct extra CHECKDATASIG flag
  • update comment to reflect change in flag
Jul 26 2018, 22:31
danconnolly added a comment to D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

Yes, that was careless of me, sorry.

Jul 26 2018, 15:23
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

rebased and updated

Jul 26 2018, 07:04

Jul 25 2018

danconnolly updated the diff for D1598: OP_MUL implementation.
  • add negative zero test
Jul 25 2018, 22:40
danconnolly created D1598: OP_MUL implementation.
Jul 25 2018, 22:13
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
  • merge CHECKDATASIG and MAGNETIC_OPCODES flags
Jul 25 2018, 21:22
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..
  • merge CHECKDATASIG and MAGNETIC_OPCODES flags
Jul 25 2018, 21:21
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

Add a flag to gate opcodes activation for the magnetic upgrade & re-organize json tests

Jul 25 2018, 12:11
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

Add a flag to gate opcodes activation for the magnetic upgrade & organize json tests

Jul 25 2018, 12:10
danconnolly updated the diff for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade..

re-organize the json tests into their own groups

Jul 25 2018, 12:07
danconnolly created D1594: Rename monolith_opcodes.cpp to opcode_tests.cpp.
Jul 25 2018, 10:27
danconnolly created D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..
Jul 25 2018, 10:24
Herald added a reviewer for D1592: Add SCRIPT_ENABLE_MAGNETIC_OPCODES flag to gate opcodes activation for the Magnetic upgrade.: Restricted Project.
Jul 25 2018, 10:17

May 30 2018

danconnolly updated the diff for D1438: Add a NUM2BIN test with a 5 byte operand.

add test for other side of IMPOSSIBLE_ENCODING edge case & move expected result to output script

May 30 2018, 15:24

May 22 2018

danconnolly updated the summary of D1438: Add a NUM2BIN test with a 5 byte operand.
May 22 2018, 22:40
danconnolly updated the diff for D1438: Add a NUM2BIN test with a 5 byte operand.

shrink a number that is not minimally encoded - should pass

May 22 2018, 22:30
danconnolly updated the summary of D1438: Add a NUM2BIN test with a 5 byte operand.
May 22 2018, 22:29
danconnolly updated the diff for D1438: Add a NUM2BIN test with a 5 byte operand.

add several tests for NUM2BIN:

  • try to squeeze a 3 byte number into a 2 byte binary vector - IMPOSSIBLE_ENCODING error
  • convert a 520 byte number into a binary - should pass
  • convert a number that is not minimally encoded - should pass, minimal encoding does not apply to the first operand
  • use non-minimally encoded number for second operand - should fail, must be minimally encoded
  • use 5 byte second operand - should fail, second operand must be <= 4 bytes long
May 22 2018, 22:20
danconnolly updated the diff for D1438: Add a NUM2BIN test with a 5 byte operand.

@jasonbcox good plan. added new tests.

May 22 2018, 19:50
Herald added a reviewer for D1438: Add a NUM2BIN test with a 5 byte operand: Restricted Project.
May 22 2018, 18:25

Mar 25 2018

danconnolly added inline comments to D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 25 2018, 00:31

Mar 18 2018

danconnolly updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

fix T288 and misc small issues

Mar 18 2018, 07:17
danconnolly added inline comments to D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 18 2018, 07:14

Mar 17 2018

danconnolly planned changes to D1194: Set Monolith opcode enable script flag if monolith enabled.

Just a quick note: I'm not sure that the banscore test is valid. I want to split this diff in two, with the tests defined first to confirm behaviour before the changes.

Mar 17 2018, 08:20

Mar 16 2018

danconnolly added a comment to D1194: Set Monolith opcode enable script flag if monolith enabled.

This diff does not fix T288, the tests work around it.

Mar 16 2018, 19:31
danconnolly updated the test plan for D1194: Set Monolith opcode enable script flag if monolith enabled.
Mar 16 2018, 19:30
danconnolly updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.
  • fix non-activation of monolith script flag in AcceptToMemoryPoolWorker()
  • chain reorganization fixes
  • banscore test
Mar 16 2018, 19:20

Mar 15 2018

danconnolly updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

add functional tests, which are failing - flags not set properly when CScriptCheck:operator() in validation.cpp calls VerifyScript()

Mar 15 2018, 23:41

Mar 13 2018

danconnolly updated the diff for D1194: Set Monolith opcode enable script flag if monolith enabled.

minor update

Mar 13 2018, 12:17
Herald added a reviewer for D1194: Set Monolith opcode enable script flag if monolith enabled: Restricted Project.
Mar 13 2018, 12:14
danconnolly updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

resubmit D1103 - OP_NUM2BIN

Mar 13 2018, 06:27

Mar 12 2018

danconnolly updated the test plan for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
Mar 12 2018, 21:25
danconnolly updated the test plan for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.
Mar 12 2018, 21:23
danconnolly updated the diff for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

resubmit D1101, updated for underlying changes

Mar 12 2018, 21:23
danconnolly updated the diff for D1099: Adds OP_SPLIT functionality into interpreter.cpp.

resubmit D1099 - OP_SPLIT

Mar 12 2018, 20:52
danconnolly updated the test plan for D1099: Adds OP_SPLIT functionality into interpreter.cpp.
Mar 12 2018, 20:13
danconnolly updated the diff for D1097: Add support for CAT, and SPLIT opcodes.

resubmit D1097, corrected for changes in other diffs further down the stack

Mar 12 2018, 19:30
danconnolly updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

resubmit D1095 - op_mod

Mar 12 2018, 18:47
danconnolly updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

resubmit OP_DIV opcode

Mar 12 2018, 16:59
danconnolly updated the summary of D1090: Adds Bitwise functionality into interpreter.cpp.
Mar 12 2018, 10:37
danconnolly updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

remove erroneously included changes to script.py

Mar 12 2018, 10:34
danconnolly updated the summary of D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 12 2018, 09:45
danconnolly added inline comments to D1090: Adds Bitwise functionality into interpreter.cpp.
Mar 12 2018, 09:26
danconnolly updated the summary of D1090: Adds Bitwise functionality into interpreter.cpp.
Mar 12 2018, 09:13
danconnolly updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

moved flag from parent diff into this one

Mar 12 2018, 09:00

Mar 11 2018

danconnolly added a comment to D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

In diff https://reviews.bitcoinabc.org/D1141?id=3141#inline-4397 @deadalnix commented on the definition of OP_SPLIT that "You can have two enum entries with the same value.". The definition of OP_SPLIT in that diff replaced the definition of OP_SUBSTR, removing OP_SUBSTR in the process.

Mar 11 2018, 18:42
danconnolly updated the summary of D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 11 2018, 18:36
danconnolly updated the diff for D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

updates based on comments
remove SCRIPT_ENABLE_OPCODES_MONOLITH flag, move to separate diff
correct value of opcodes NUM2BIN and BIN2NUM, replacing LEFT & RIGHT
change MAX_DEFINED_OP_VALUE into FIRST_UNDEFINED_OP_VALUE

Mar 11 2018, 18:33
danconnolly updated the diff for D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 11 2018, 18:30
danconnolly added a comment to D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

Will move the flag up in the stack.

Mar 11 2018, 00:44

Mar 10 2018

danconnolly added inline comments to D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 10 2018, 23:24
danconnolly updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

reorganize D1095

Mar 10 2018, 22:24
danconnolly updated the test plan for D1093: Adds OP_DIV functionality into interpreter.cpp.
Mar 10 2018, 21:46
danconnolly added inline comments to D1093: Adds OP_DIV functionality into interpreter.cpp.
Mar 10 2018, 21:44
danconnolly updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

reorganize

Mar 10 2018, 19:53
danconnolly updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

reorganize D1090

Mar 10 2018, 18:11
danconnolly updated the test plan for D1090: Adds Bitwise functionality into interpreter.cpp.
Mar 10 2018, 14:57
danconnolly added inline comments to D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 10 2018, 09:40
danconnolly updated the diff for D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

reorganize the stack of changes to support re-enabled opcodes

Mar 10 2018, 09:32