Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (171 w, 7 h)

Recent Activity

Thu, Dec 12

emack accepted D17332: [mock-chronik-client] implement ts.
Thu, Dec 12, 02:01

Wed, Dec 11

emack requested changes to D17332: [mock-chronik-client] implement ts.
Wed, Dec 11, 10:27
emack accepted D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Wed, Dec 11, 01:52

Tue, Dec 10

emack accepted D17326: [Cashtab] Convert airdrop screen and deps to ts.
Tue, Dec 10, 08:13
emack requested changes to D15631: [chronik-client] Add support for validate-tx endpoint to ChronikClientNode.
Tue, Dec 10, 08:07
emack accepted D17328: [token-server] Bump free xec from 42 to 88.
Tue, Dec 10, 08:02
emack accepted D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Tue, Dec 10, 07:57

Sun, Dec 8

emack requested changes to D17318: [Cashtab] Convert Tx screen and its deps to typescript.
Sun, Dec 8, 09:34
emack accepted D17317: [monorepo] Update dockerfiles that build-wasm to include explorer.
Sun, Dec 8, 03:04

Sat, Dec 7

emack accepted D17311: Revert "Revert "[Cashtab] Convert wallet context to ts"".
Sat, Dec 7, 23:16
emack accepted D17310: [Cashtab] Convert TxHistory.js to ts.
Sat, Dec 7, 23:02
emack accepted D17309: [Cashtab] Reduce tx history rendering.

There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.

Sat, Dec 7, 22:59

Thu, Dec 5

emack accepted D17288: [Cashtab] Convert wallet context to ts.
Thu, Dec 5, 21:08
emack requested changes to D17288: [Cashtab] Convert wallet context to ts.
Thu, Dec 5, 14:46
emack accepted D17293: [ecash-herald] Tighten up daily summary msgs.
Thu, Dec 5, 14:18
emack accepted D17291: [Cashtab] Remove swap screen.

FWIW - The widget is working in prod for me

image.png (1×871 px, 66 KB)

Thu, Dec 5, 00:19

Wed, Dec 4

emack accepted D17289: [Cashtab] Update PWA splash screen colors.
Wed, Dec 4, 05:50

Tue, Dec 3

emack accepted D17279: [mock-chronik-client] Add new dummy method to allow Agora construction with MockChronikClient.
Tue, Dec 3, 07:35
emack accepted D17278: [Cashtab] Standardize mnemonic validation error msg.
Tue, Dec 3, 07:32
emack accepted D17273: [token-server] Bump icon upload byte ceiling.
Tue, Dec 3, 07:30

Mon, Dec 2

emack accepted D17271: [Cashtab] Make agora tiles more useful.
Mon, Dec 2, 06:14
emack requested changes to D17271: [Cashtab] Make agora tiles more useful.
Mon, Dec 2, 00:13

Sun, Dec 1

emack accepted D17262: [b58-ts] Set up CI publishing.
Sun, Dec 1, 14:07
emack accepted D17270: [Cashtab] Stop showing [object Object] on agora offers yet to populate token cache info.
Sun, Dec 1, 14:03
emack accepted D17269: [ecash-lib] Implement ecashaddrjs functions in ecash-lib.
Sun, Dec 1, 14:00

Sat, Nov 30

emack accepted D17219: [Cashtab] Support send token txs with bip21 query strings.
Sat, Nov 30, 10:23
emack accepted D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.
Sat, Nov 30, 10:22

Fri, Nov 29

emack requested changes to D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

Fri, Nov 29, 10:30
emack accepted D17241: [Cashtab] Update style element to match redesign.
Fri, Nov 29, 10:25
emack requested changes to D17219: [Cashtab] Support send token txs with bip21 query strings.
Fri, Nov 29, 10:24

Thu, Nov 28

emack accepted D17203: [cashtab] Support agora txs for ALP tokens.
Thu, Nov 28, 02:36

Wed, Nov 27

emack requested changes to D17203: [cashtab] Support agora txs for ALP tokens.
Wed, Nov 27, 11:00
emack accepted D17207: [Cashtab] Convert Send screen and some deps to ts.
Wed, Nov 27, 10:24
emack accepted D17186: [cashtab] UI Overhaul.
Wed, Nov 27, 10:13

Tue, Nov 26

emack accepted D17202: [ecash-herald] Remember to pass the staking info param for daily summary msg.
Tue, Nov 26, 13:32
emack requested changes to D17202: [ecash-herald] Remember to pass the staking info param for daily summary msg.
Tue, Nov 26, 10:33
emack requested changes to D17186: [cashtab] UI Overhaul.
Tue, Nov 26, 10:31

Mon, Nov 25

emack accepted D17196: [bip21] Introduce a spec for supporting simple token send txs.
Mon, Nov 25, 03:57
emack accepted D17195: [ecash-herald] Add network staking info to daily summaries.
Mon, Nov 25, 01:45
emack added a comment to D17196: [bip21] Introduce a spec for supporting simple token send txs.

is the exclusion of non-send token txs on the basis that they're not a use case for QR payments?

Mon, Nov 25, 01:28

Sun, Nov 24

emack accepted D17180: [ecash-herald] Add staker info to block msgs.
Sun, Nov 24, 12:48
emack accepted D17192: [Cashtab] Support ALP tokens.
Sun, Nov 24, 11:23

Sat, Nov 23

emack accepted D17191: [Cashtab] CreateTokenForm to typescript.
Sat, Nov 23, 01:38
emack accepted D17188: [Cashtab] Use available sk and pk rather than deriving from wif and ecc.
Sat, Nov 23, 01:16

Fri, Nov 22

emack accepted D17168: [Cashtab] Migrate to new wallet shape that includes ecash-lib-ready sk and pk.
Fri, Nov 22, 09:34

Thu, Nov 21

emack requested changes to D17168: [Cashtab] Migrate to new wallet shape that includes ecash-lib-ready sk and pk.
Thu, Nov 21, 23:53
emack accepted D17177: [chronik-client] Support isFinal key for Tx.
Thu, Nov 21, 23:20
emack accepted D17170: [ecashaddrjs] Stop using buffer and webpack.
Thu, Nov 21, 22:22
emack accepted D17175: [ecash-herald] Get arc lint to work for ts.
Thu, Nov 21, 05:08
emack accepted D17176: [ecash-herald] Show less info in daily msgs.
Thu, Nov 21, 05:03
emack accepted D17154: [Cashtab] Convert Token, validation, and other deps to ts.
Thu, Nov 21, 05:03
emack accepted D17173: [alias-server] Patch CI failures caused by Mongo Memory Server dep.
Thu, Nov 21, 05:01
emack accepted D17174: [token-server] Fix ts lint and add to arc lint.
Thu, Nov 21, 04:37
emack requested changes to D17154: [Cashtab] Convert Token, validation, and other deps to ts.
Thu, Nov 21, 04:16

Wed, Nov 20

emack accepted D17164: [ecash-herald] Patch bug in tracking per-token agora volume.
Wed, Nov 20, 06:25

Sun, Nov 17

emack accepted D17153: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support.
Sun, Nov 17, 02:54

Sat, Nov 16

emack accepted D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
Sat, Nov 16, 14:01
emack accepted D17146: [Cashtab] Show NFT offer on token page.
Sat, Nov 16, 13:58
emack requested changes to D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
Sat, Nov 16, 12:01
emack requested changes to D17146: [Cashtab] Show NFT offer on token page.
Sat, Nov 16, 11:41

Thu, Nov 14

emack accepted D17136: [ecash-herald] Standardize the way we convert satoshi values to formatted amounts.
Thu, Nov 14, 12:40
emack accepted D17128: [Cashtab] More improvements to agora partial sale tx parsing.
Thu, Nov 14, 10:32

Nov 13 2024

emack added a comment to D17128: [Cashtab] More improvements to agora partial sale tx parsing.

summary and test plan are still TBD?

Nov 13 2024, 21:47
emack accepted D17122: [Cashtab] Convert agora screen to typescript.
Nov 13 2024, 10:47
emack accepted D17127: [Cashtab] Modify csp headers to allow base64 font used in swiper.
Nov 13 2024, 07:03
emack accepted D17126: [Cashtab] Add type deps for ts conversion.
Nov 13 2024, 01:50
emack accepted D17123: [Cashtab] Remove redundant spinner from agora screen.
Nov 13 2024, 01:48

Nov 12 2024

emack accepted D17120: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales.
Nov 12 2024, 23:27
emack accepted D17119: [ecash-herald] Present daily total volume for agora.
Nov 12 2024, 23:11
emack accepted D17118: [ecash-herald] Lint for typescript.
Nov 12 2024, 23:04
emack accepted D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 12 2024, 22:53

Nov 10 2024

emack requested changes to D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 10 2024, 01:28

Nov 8 2024

emack accepted D17103: [Cashtab] Patch ts bug in button components and propagate type.
Nov 8 2024, 13:44
emack accepted D17102: [Cashtab] Patch unit test in wallet.
Nov 8 2024, 13:42
emack accepted D17101: [Cashtab] Correct tx history parsing of nft parent mint txs.
Nov 8 2024, 13:39
emack accepted D17099: [Cashtab] Patch overflow issues in Agora from long names and tickers.
Nov 8 2024, 13:07
emack accepted D17100: [Cashtab] slpv1 to ts.
Nov 8 2024, 10:04
emack accepted D17097: [Cashtab] Support minting additional NFT Parent tokens.
Nov 8 2024, 03:33
emack requested changes to D17091: [Cashtab] Upgrade slpv1 methods to ts.

Build aint healthy

Nov 8 2024, 03:32
emack accepted D17093: [Cashtab] Update and implement jest setup file.
Nov 8 2024, 03:03

Nov 7 2024

emack requested changes to D17091: [Cashtab] Upgrade slpv1 methods to ts.
Nov 7 2024, 10:34
emack requested changes to D17097: [Cashtab] Support minting additional NFT Parent tokens.
Nov 7 2024, 10:25
emack accepted D17096: [Cashtab] Improve styles for button components.
Nov 7 2024, 10:17
emack requested changes to D17093: [Cashtab] Update and implement jest setup file.

src/components/Swap/Swap.js: const sideshift = window.sideshift;

Nov 7 2024, 10:09
emack accepted D17080: [Cashtab] Wallet methods to ts.
Nov 7 2024, 10:01

Nov 6 2024

emack published D17087: [Cashtab] Alternate token icon source for animated images for review.
Nov 6 2024, 13:38
emack accepted D17083: [Cashtab] Add canvas mock to prevent annoying jest debug logs.
Nov 6 2024, 11:33
emack accepted D17081: [Cashtab] Add fn and test cases for agora oneshot fuel inputs.
Nov 6 2024, 11:05
emack requested changes to D17080: [Cashtab] Wallet methods to ts.
Nov 6 2024, 07:37
emack accepted D17084: [Cashtab] Add a jest setup file to avoid repeating global mocks.
Nov 6 2024, 07:30
emack accepted D17079: [Cashtab] Migrate CashtabSettings to ts.
Nov 6 2024, 03:10
emack accepted D17078: [Cashtab] Convert CashtabCache to ts.
Nov 6 2024, 03:06

Nov 5 2024

emack accepted D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 06:24
emack requested changes to D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 04:18

Nov 4 2024

emack accepted D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Nov 4 2024, 00:51
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.
Nov 4 2024, 00:43

Nov 3 2024

emack accepted D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Nov 3 2024, 11:52
emack requested changes to D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
  • the orderbook in manage listings become a "Buy token", which makes sense since you no longer have any offers left, but shouldn't it not be displayed at all?
Nov 3 2024, 11:24
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.

Have verified the merging of orderbooks for the same token offer, though I wasn't getting a duplicate key error in the first place on master (v2.49.1).

Nov 3 2024, 11:18
emack accepted D17060: [ecash-herald] Implement typescript.
Nov 3 2024, 11:03