Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (116 w, 3 d)

Recent Activity

Tue, Nov 21

emack closed D14728: [Cashtab][Alias] Sync pricing on new blocks.
Tue, Nov 21, 22:13
emack committed rABCcfa2e804dff0: [Cashtab][Alias] Sync pricing on new blocks (authored by emack).
[Cashtab][Alias] Sync pricing on new blocks
Tue, Nov 21, 22:13
emack requested review of D14728: [Cashtab][Alias] Sync pricing on new blocks.

wait for a new block to be found and observe the "New block found, refreshing alias prices" message in console

I think this message has been removed ?

Tue, Nov 21, 20:24
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Updated for pricing array length 0 check, diff summary and test plan.

Tue, Nov 21, 08:34
emack updated the summary of D14728: [Cashtab][Alias] Sync pricing on new blocks.
Tue, Nov 21, 08:23
emack updated the summary of D14728: [Cashtab][Alias] Sync pricing on new blocks.
Tue, Nov 21, 08:20

Sun, Nov 19

emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Updated array length checks, error message and price element index.

Sun, Nov 19, 21:21

Fri, Nov 17

emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Per tg chat, disabling alias registration if the pricing array from API has more than one entry. I've kept the Alias component itself still accessible as the user should still be able to check their registered aliases, which is separate from pricing matters.

Fri, Nov 17, 23:02

Thu, Nov 9

emack planned changes to D14759: [Cashtab][Swap] ChangeNow integration.

image.png (48×556 px, 12 KB)

Reaching out to the ChangeNow team on this. Potentially because local dev cashtab is accessed via http and there may be policies mandating https sources.

Thu, Nov 9, 07:09
emack updated the summary of D14759: [Cashtab][Swap] ChangeNow integration.
Thu, Nov 9, 07:08
emack requested review of D14759: [Cashtab][Swap] ChangeNow integration.
Thu, Nov 9, 07:07
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Removed debug logs

Thu, Nov 9, 02:00

Wed, Nov 8

emack closed D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Wed, Nov 8, 23:47
emack committed rABC8b10270ebb71: [Cashtab][Swap] Add swap component with SideShift integration (authored by emack).
[Cashtab][Swap] Add swap component with SideShift integration
Wed, Nov 8, 23:47
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Updated nit

Wed, Nov 8, 23:36
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Removed aliasFee state far and updated component to access directly from the aliasPrices object

Wed, Nov 8, 23:22
emack accepted D14736: [Cashtab] Add function to generate an OP_RETURN output for an airdrop tx.
Wed, Nov 8, 23:01
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Added real time localized pricing displays per alias input, improved not null checks, added default value for aliasPAram in queryAliasServer args.
LocalString formatting applied to pricing since it's likely to eventually be a large number in prod.

Wed, Nov 8, 04:33

Tue, Nov 7

emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Backing out extension changes

Tue, Nov 7, 01:07
emack added inline comments to D14728: [Cashtab][Alias] Sync pricing on new blocks.
Tue, Nov 7, 01:01
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Alias.js now pulls aliasPrices as a context variable and triggers a regresh if none exist.

Tue, Nov 7, 01:01

Sun, Nov 5

emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
  • parentAffiliatedId set to the official ABC account from Antony
  • Reverted settleAddress back to undefined otherwise the Receiving Address field will not be displayed in the widget. Whoever is managing the ABC account can just execute monthly withdrawals from the official account to the IFP address.
Sun, Nov 5, 12:30

Sat, Nov 4

emack closed D14269: [Chronik-client] - Cycle through backup instances on outage.
Sat, Nov 4, 11:11
emack committed rABCf9282f34b540: [Chronik-client] - Cycle through backup instances on outage (authored by emack).
[Chronik-client] - Cycle through backup instances on outage
Sat, Nov 4, 11:11
emack added a comment to D14728: [Cashtab][Alias] Sync pricing on new blocks.

Any block height related optimization will incur an API call to get the latest blockheight as a minimum.

Not with websockets ?

Sat, Nov 4, 11:06
emack requested changes to D14736: [Cashtab] Add function to generate an OP_RETURN output for an airdrop tx.
Sat, Nov 4, 02:56

Fri, Nov 3

emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

I must have missed something here

Fri, Nov 3, 23:57
emack closed D14713: [Cashtab][Alias] Check Alias function.
Fri, Nov 3, 14:55
emack committed rABC6954c1d261ed: [Cashtab][Alias] Check Alias function (authored by emack).
[Cashtab][Alias] Check Alias function
Fri, Nov 3, 14:55
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Rebase to master

Fri, Nov 3, 14:32
emack closed D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Fri, Nov 3, 14:13
emack committed rABC86052e98a0fb: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal (authored by emack).
[Cashtab][Alias] Increase pending warning emphasis on confirmation modal
Fri, Nov 3, 14:13
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.

Updated processChronikWsMsg() to refresh pricing every 90 blocks rather than every block

Fri, Nov 3, 07:19
emack updated the diff for D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.

Updated UI as follows

Fri, Nov 3, 00:11

Thu, Nov 2

emack closed D14719: [Cashtab] Seed warning confirmation check.
Thu, Nov 2, 22:04
emack committed rABC7d6047f1d2a8: [Cashtab] Seed warning confirmation check (authored by emack).
[Cashtab] Seed warning confirmation check
Thu, Nov 2, 22:04
emack requested review of D14713: [Cashtab][Alias] Check Alias function.

You should do an API call on each block and store the value locally, obviously a lookup for each keystroke is the wrong design.

this is a good idea but imo should be it's own diff. not necessarily related to just this UI change, easy enough to add into this UI -- but does require some new logic.

Thu, Nov 2, 21:59
emack updated the test plan for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Thu, Nov 2, 14:31
emack requested review of D14728: [Cashtab][Alias] Sync pricing on new blocks.
Thu, Nov 2, 14:31
emack updated the test plan for D14719: [Cashtab] Seed warning confirmation check.
Thu, Nov 2, 03:57
emack updated the diff for D14719: [Cashtab] Seed warning confirmation check.

Updated checkbox logic to toggle between showing and hiding the seed phrase in addition to the updated static warning message.

Thu, Nov 2, 03:56
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Updated UI per feedback.
Also note the snapshot test updates to unrelated components is due to the updates to src/assets/styles/theme.js from this diff which sits globally across the app.

Thu, Nov 2, 03:13
emack updated the summary of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Thu, Nov 2, 02:02
emack requested review of D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal.
Thu, Nov 2, 02:01

Wed, Nov 1

emack closed D14611: [Cashtab][Alias] Pending Aliases.
Wed, Nov 1, 22:49
emack committed rABC8e4b8d528fd7: [Cashtab][Alias] Pending Aliases (authored by emack).
[Cashtab][Alias] Pending Aliases
Wed, Nov 1, 22:49
emack updated subscribers of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Wed, Nov 1, 07:12
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Setting the IFP address as the settlement address.

Wed, Nov 1, 07:10
emack requested review of D14719: [Cashtab] Seed warning confirmation check.
Wed, Nov 1, 06:58
emack changed the visibility for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Wed, Nov 1, 03:46
emack updated the summary of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Wed, Nov 1, 01:15
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Added isValidSideshiftObj() along with unit tests to validation.js to check that the instantiated sideshift object contains the expected APIs. If not valid, an error is displayed in place of the button in Swap.js. This can be verified by malforming the sidieshift library url in /public/index.html header.

Wed, Nov 1, 01:14
emack added a comment to D14713: [Cashtab][Alias] Check Alias function.

Rejigged UI for reference:

Wed, Nov 1, 00:22
emack updated the diff for D14713: [Cashtab][Alias] Check Alias function.

Re-arranged UI per feedback, updated label for active wallet registration checkbox.

Wed, Nov 1, 00:21

Tue, Oct 31

emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Improved pending array filter and variable names.

Tue, Oct 31, 23:46
emack updated the summary of D14713: [Cashtab][Alias] Check Alias function.
Tue, Oct 31, 13:54
emack requested review of D14713: [Cashtab][Alias] Check Alias function.
Tue, Oct 31, 13:52
emack abandoned D14666: [Cashtab][Alias] Alias lookup facility.

Will re-use the existing registration field with a check button as a separate diff.

Tue, Oct 31, 13:31
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Added pendingAliasCounter to tally count of certain aliases within the pending array for the current address.

Tue, Oct 31, 13:22
emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.
Tue, Oct 31, 13:05
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Added conditional substring to the pending alias warning which indicates number of pending registrations for this wallet address.

Tue, Oct 31, 13:01
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.

Updated test snapshot for Home

Tue, Oct 31, 06:54
emack planned changes to D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Tue, Oct 31, 06:50
emack changed the visibility for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Tue, Oct 31, 06:47
emack requested review of D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Tue, Oct 31, 06:47
emack abandoned D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Tue, Oct 31, 06:47
emack planned changes to D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Tue, Oct 31, 02:55

Oct 29 2023

emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:28
emack updated the diff for D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).

Updated the Swap component to be a central portal for all Swap widgets rather than SideShift specific. It now houses both ChangeNow and SideShift.

Oct 29 2023, 01:18
emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:18

Oct 28 2023

emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:56
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:04
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:00
emack requested review of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 13:57
emack added a comment to D14269: [Chronik-client] - Cycle through backup instances on outage.

On a separate note, I've also carried out localized usage of this diff in /apps/examples and it tested fine.
i.e.

  1. Refreshed the dist folder within /modules/chronik-client repo via npm run build
  2. Go into /apps/examples and removed current client npm uninstall chronik-client
  3. Installed this diff via npm i ../../modules/chronik-client
  4. Go into /apps/examples/getDetailsFromTxid.js, import the client via the relative path above and instantiated ChronikClient constructor with an array of 1 mispelt url (simulated outage) and 1 correctly spelt url
  5. Executed the example via npm run getDetailsFromTxid <txid> and it should cycle past the 1st url and connects successfully on the 2nd url to return the transaction details.
Oct 28 2023, 09:06
emack added inline comments to D14269: [Chronik-client] - Cycle through backup instances on outage.
Oct 28 2023, 08:01
emack updated the diff for D14269: [Chronik-client] - Cycle through backup instances on outage.

Responding to feedback

Oct 28 2023, 08:00
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Full onchain pending alias check is now implemented in the post-registration-button-click logic (preparePreviewModal), which renders an additional sentence in the registration confirmation modal, depending on whether pending.length is > 0. The local pending check per keystroke is now removed due to low value.

Oct 28 2023, 05:11

Oct 27 2023

emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 21:37
emack requested review of D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Pending the pending discussion in D14611 before evaluating whether this search is redundant.

Oct 27 2023, 14:14
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Oct 27 2023, 11:43
emack requested review of D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 11:39
emack planned changes to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 11:29
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 09:58

Oct 26 2023

emack updated the diff for D14666: [Cashtab][Alias] Alias lookup facility.
  • Initialized aliasLookupName in formData
  • Using the newest pending prop in the /alias endpoint to distinguish between unregistered or pending confirmation aliases
  • Screenshots below:
Oct 26 2023, 23:27
emack added inline comments to D14269: [Chronik-client] - Cycle through backup instances on outage.
Oct 26 2023, 22:00
emack updated the diff for D14269: [Chronik-client] - Cycle through backup instances on outage.

Responding to feedback. Note: the XPI url was unstable recently and started breaking the test suite. Replaced all instances of this with the working XEC version in test.ts.

Oct 26 2023, 22:00

Oct 25 2023

emack accepted D14683: [alias-server] Return pending registrations for a specified alias.
Oct 25 2023, 21:57
emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.

Pending D14683

Oct 25 2023, 05:43
emack accepted D14681: [examples] Update dependencies.
Oct 25 2023, 02:03
emack added a comment to D14578: [Cashtab] Deprecate airdrops.

quick note - if you end up going through with this you'll need to remove this button from SendToken.js as well

image.png (129×448 px, 11 KB)

Oct 25 2023, 02:02
emack accepted D14682: [mock-chronik-client] Update dependencies.
Oct 25 2023, 01:57
emack requested changes to D14683: [alias-server] Return pending registrations for a specified alias.

Worth noting this would be implemented at the point of pressing the register button and not when the user is inputting the alias name with each keystroke being parsed for validity. I can add it as a conditional text render in the registration confirmation modal (preparePreviewModal).

Oct 25 2023, 01:53

Oct 24 2023

emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

The alias registration input field now detects whether an input (without needing to click Register Alias) already has a pending tx for this wallet and renders a non-blocking warning.

Oct 24 2023, 11:32

Oct 23 2023

teamcity awarded D14666: [Cashtab][Alias] Alias lookup facility a Haypence token.
Oct 23 2023, 13:21
emack updated the test plan for D14611: [Cashtab][Alias] Pending Aliases.
Oct 23 2023, 12:12

Oct 22 2023

emack requested review of D14666: [Cashtab][Alias] Alias lookup facility.
Oct 22 2023, 11:23

Oct 17 2023

emack requested review of D14611: [Cashtab][Alias] Pending Aliases.
Oct 17 2023, 11:18