Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (64 w, 3 d)

Recent Activity

Today

emack accepted D12670: [Cashtab] Deprecate BCH from getMintAddress.
Tue, Nov 29, 14:44
emack accepted D12669: [Cashtab] Add local function to convert hash160 to ecash: address.
Tue, Nov 29, 14:34
emack accepted D12668: [Cashtab] Deprecate BCH param from sendXec.
Tue, Nov 29, 14:11
emack accepted D12666: [Cashtab] Deprecate BCH param from signAndBuildTx function.
Tue, Nov 29, 14:00
emack accepted D12665: [Cashtab] Deprecate BCH param from generateTxOutput function.

Small nit on the generatTxOutput typo in the test plan

Tue, Nov 29, 13:54
emack accepted D12664: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function.
Tue, Nov 29, 13:48
emack accepted D12663: [Cashtab] Deprecate BCH param from generateTxInput function.
Tue, Nov 29, 13:42
emack accepted D12667: [Cashtab] Deprecate BCH param from getRecipientPublicKey function.
Tue, Nov 29, 13:35
emack accepted D12688: [Cashtab] Use XEC balance change to unock UI after token sends and burns.
Tue, Nov 29, 10:10

Yesterday

emack accepted D12657: [Cashtab] [Deprecate toLegacyCash p3/3] Remove now-unused functions, unit tests, and mocks.
Mon, Nov 28, 02:50
emack accepted D12656: [Cashtab] [Deprecate toLegacyCash p2] Stop converting ecash addresses to bitcoincash in Send.js for one-to-many.
Mon, Nov 28, 02:43
emack accepted D12655: [Cashtab] [Deprecate toLegacyCash p1] Stop converting ecash addresses to bitcoincash in Send.js.
Mon, Nov 28, 02:19
emack accepted D12654: [Cashtab] [Address simplification p4/4] Remove unused toLegacyToken function.
Mon, Nov 28, 02:11
emack accepted D12653: [Cashtab] [Address simplification p3/4] Deprecate BCH param from generateTokenTxOutput.
Mon, Nov 28, 01:58
emack accepted D12652: [Cashtab] [Address simplification p2/4] Stop converting to legacy format for Burn Token.
Mon, Nov 28, 01:47
emack accepted D12651: [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send Token.
Mon, Nov 28, 01:22

Sat, Nov 26

emack accepted D12647: [Cashtab] [xecjs-message upgrade p3/3] Remove debug logging and tests.
Sat, Nov 26, 12:51
emack accepted D12646: [Cashtab] [xecjs-message upgrade p2/3] Sign msgs with ecash prefix in xecjs-message.
Sat, Nov 26, 12:39
emack accepted D12645: [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs-message.
Sat, Nov 26, 12:26
emack accepted D12648: [Cashtab] Fallback to block time if timeFirstSeen is zero.
Sat, Nov 26, 12:08
emack abandoned D12402: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.toWIF.

superseded by D12414 stack

Sat, Nov 26, 05:20
emack abandoned D12401: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local HD node toWIF() logic.

superseded by D12414 stack

Sat, Nov 26, 05:20
emack abandoned D12398: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.derivePath.

superseded by D12414 stack

Sat, Nov 26, 05:19
emack abandoned D12399: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local HD node toPublicKey logic.

superseded by D12414 stack

Sat, Nov 26, 05:19
emack abandoned D12400: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.HDNode.toPublicKey.

superseded by D12414 stack

Sat, Nov 26, 05:19
emack abandoned D12397: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local HD node derivePath logic.

superseded by D12414 stack

Sat, Nov 26, 05:19
emack accepted D12640: [Cashtab] Patch overlapping text on amount input error Send.js.

Looks good across web, iOS and android. Tested via https://12640.netlify.app/

Sat, Nov 26, 05:06
emack accepted D12628: [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj.
Sat, Nov 26, 04:24
emack accepted D12627: [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing.
Sat, Nov 26, 04:07
emack accepted D12626: [Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug.
Sat, Nov 26, 03:50
emack accepted D12639: [Cashtab] [local opreturn encode p2/2] Simplify function.
Sat, Nov 26, 03:34
emack accepted D12629: [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode.
Sat, Nov 26, 03:17

Fri, Nov 25

emack accepted D12631: [Cashtab] Temp revert local ecpair.
Fri, Nov 25, 13:24
emack closed D12602: [Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references.
Fri, Nov 25, 11:23
emack closed D12601: [Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to burnToken.
Fri, Nov 25, 11:23
emack committed rABC1bfa6a5f0204: [Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to… (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to…
Fri, Nov 25, 11:23
emack committed rABC679d9d8d9fed: [Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH. (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.
Fri, Nov 25, 11:23
emack closed D12596: [Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken.
Fri, Nov 25, 11:23
emack closed D12595: [Cashtab] [BCH deprecation] [TxBuilder] Pt 5/8 - Add local TxBuilder to sendToken.
Fri, Nov 25, 11:23
emack committed rABC24830e711724: [Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH. (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH.
Fri, Nov 25, 11:23
emack committed rABCe19a8de204ba: [Cashtab] [BCH deprecation] [TxBuilder] Pt 5/8 - Add local TxBuilder to… (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 5/8 - Add local TxBuilder to…
Fri, Nov 25, 11:23
emack closed D12575: [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken.
Fri, Nov 25, 11:23
emack committed rABC80ab115d17af: [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH. (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.
Fri, Nov 25, 11:23
emack closed D12574: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to createToken.
Fri, Nov 25, 11:23
emack committed rABC2ca71af04e4c: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to… (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to…
Fri, Nov 25, 11:23
emack closed D12553: [Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec.
Fri, Nov 25, 11:23
emack committed rABCfb197ab77b4e: [Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH. (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH.
Fri, Nov 25, 11:23
emack closed D12541: [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module.
Fri, Nov 25, 11:23
emack committed rABC028567a5502f: [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building… (authored by emack).
[Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building…
Fri, Nov 25, 11:23
emack accepted D12619: [Cashtab] [ECPair from wif p3/3] Consistent camel case for ECPair.
Fri, Nov 25, 11:17
emack accepted D12592: [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array.
Fri, Nov 25, 11:00
emack accepted D12593: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array.
Fri, Nov 25, 10:45
emack accepted D12618: [Cashtab] [ECPair from wif p2/3] Deprecate BCH method.
Fri, Nov 25, 10:28
emack accepted D12616: [Cashtab] [ECPair from wif p1/3] Add local method.
Fri, Nov 25, 10:10
emack requested review of D12611: [Cashtab] [Wallet Export] Pt 1/ - Export wallets.
Fri, Nov 25, 08:25
emack added a comment to T1716: Support exporting all data.

Planned stack:

  • [Cashtab] [Wallet Export] Pt 1/ - Export saved wallet data
  • [Cashtab] [Wallet Export] Pt 2/ - Export encrypted saved wallet data
  • [Cashtab] [Wallet Export] Pt 3/ - Import encrypted saved wallets
  • [Cashtab] [Wallet Export] Pt 4/ - Export wallet contacts data
  • [Cashtab] [Wallet Export] Pt 5/ - Export encrypted wallet contacts data
  • [Cashtab] [Wallet Export] Pt 6/ - Import encrypted wallet contacts
  • [Cashtab] [Wallet Export] Pt 7/ - Export combined encrypted wallet data
  • [Cashtab] [Wallet Export] Pt 8/ - Import combined encrypted wallet data
Fri, Nov 25, 06:10 · Restricted Project

Thu, Nov 24

emack requested changes to D12592: [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array.

I'm still seeing the tokens array inside slpBalancesAndUtxos object

image.png (589×487 px, 70 KB)

Thu, Nov 24, 01:02

Wed, Nov 23

emack requested review of D12602: [Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references.
Wed, Nov 23, 23:36
emack requested review of D12601: [Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to burnToken.
Wed, Nov 23, 23:10
emack accepted D12590: [Cashtab] [Simplify wallet structure p1] Show desired end state.

Accepted subject to slpUtxos, tokens, and parsedTxHistory adjustments later in the stack

Wed, Nov 23, 22:37
emack requested changes to D12590: [Cashtab] [Simplify wallet structure p1] Show desired end state.
Wed, Nov 23, 12:13
emack requested review of D12596: [Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken.
Wed, Nov 23, 12:08
emack requested review of D12595: [Cashtab] [BCH deprecation] [TxBuilder] Pt 5/8 - Add local TxBuilder to sendToken.
Wed, Nov 23, 11:49
emack updated the diff for D12575: [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken.

rebase

Wed, Nov 23, 09:47
emack updated the diff for D12574: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to createToken.

rebase

Wed, Nov 23, 09:46
emack updated the diff for D12553: [Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec.

rebase

Wed, Nov 23, 09:46
emack updated the diff for D12541: [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module.

rebase

Wed, Nov 23, 09:45
emack closed D12586: [Cashtab] Migrate validateMnemonic from useWallet to validation.
Wed, Nov 23, 09:09
emack committed rABCd9508ce6dba1: [Cashtab] Migrate validateMnemonic from useWallet to validation (authored by emack).
[Cashtab] Migrate validateMnemonic from useWallet to validation
Wed, Nov 23, 09:09
emack updated the diff for D12586: [Cashtab] Migrate validateMnemonic from useWallet to validation.

removed redundant bip39 wordlist in unit tests

Wed, Nov 23, 09:06

Tue, Nov 22

emack requested review of D12586: [Cashtab] Migrate validateMnemonic from useWallet to validation.
Tue, Nov 22, 22:52
emack committed rABC66dff6ebbcf3: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList
Tue, Nov 22, 21:49
emack closed D12526: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 6/7 - Optimize bip39 bundle via webpack IgnorePlugin.
Tue, Nov 22, 21:49
emack closed D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.
Tue, Nov 22, 21:49
emack closed D12482: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 5/7 - Deprecate BCH.Mnemonic.
Tue, Nov 22, 21:49
emack committed rABCa4d3a4175893: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 5/7 - Deprecate BCH.Mnemonic (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 5/7 - Deprecate BCH.Mnemonic
Tue, Nov 22, 21:49
emack committed rABC7819f60206fe: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 6/7 - Optimize bip39 bundle via… (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 6/7 - Optimize bip39 bundle via…
Tue, Nov 22, 21:49
emack closed D12466: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 4/7 - Implement BCH.Mnemonic.validate locally.
Tue, Nov 22, 21:49
emack committed rABC870bf3d30637: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 4/7 - Implement BCH.Mnemonic.validate… (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 4/7 - Implement BCH.Mnemonic.validate…
Tue, Nov 22, 21:49
emack closed D12451: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate locally.
Tue, Nov 22, 21:49
emack closed D12452: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.wordLists locally.
Tue, Nov 22, 21:49
emack committed rABCd43065fdc871: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic. (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.
Tue, Nov 22, 21:49
emack committed rABC0a9bc99f3595: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate… (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate…
Tue, Nov 22, 21:49
emack closed D12450: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed locally.
Tue, Nov 22, 21:49
emack committed rABC56fe40261d9c: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed… (authored by emack).
[Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed…
Tue, Nov 22, 21:49
emack requested review of D12575: [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken.
Tue, Nov 22, 13:54
emack requested review of D12574: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to createToken.
Tue, Nov 22, 12:58
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.

Reverted migration of validateMnemonic back into useWallet. Will create a separate standalone diff to land this.

Tue, Nov 22, 12:09
emack accepted D12549: [Cashtab] Parse edge case eToken tx.
Tue, Nov 22, 10:47
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.
  • moved validateMnemonic from useWallet to validation
  • updated references to the new location in Configure and Onboarding components
  • added unit tests to validation.test.js
Tue, Nov 22, 10:38
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.

Updated unit tests

Tue, Nov 22, 08:04
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.

added uni tests

Tue, Nov 22, 07:59
emack accepted D12549: [Cashtab] Parse edge case eToken tx.
Tue, Nov 22, 07:21

Mon, Nov 21

emack requested review of D12553: [Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec.
Mon, Nov 21, 12:57
emack updated the test plan for D12541: [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module.
Mon, Nov 21, 12:31
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.

Removed the validateMnemonicWordList wrapper in validation.js and now useWallet.validateMnemonic() directly calls on bip39 and returns a boolean outcome validating the given mnemonic.

Mon, Nov 21, 12:18
emack accepted D12542: [Cashtab] Request persistent storage.
Mon, Nov 21, 10:50
emack claimed T1716: Support exporting all data.
Mon, Nov 21, 07:17 · Restricted Project

Sun, Nov 20

emack requested review of D12541: [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module.
Sun, Nov 20, 04:56
emack updated the diff for D12530: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList.

rebase

Sun, Nov 20, 00:23