Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (133 w, 5 d)

Recent Activity

Yesterday

emack requested changes to D15784: [Cashtab] Improve and standardize cashtab token cache.
Thu, Mar 28, 12:36

Wed, Mar 27

emack accepted D15794: [mock-chronik-client] Support history() calls without pageNumber and pageSize specified.
Wed, Mar 27, 22:51

Tue, Mar 26

emack accepted D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.
Tue, Mar 26, 14:18
emack requested changes to D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.

computer says no

Tue, Mar 26, 06:42
emack requested changes to D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.

Error workflow:

  1. Open Send and observe the camera auto opens as expected (since the config toggle is true)
  2. Toggle the auto open camera config to false
  3. Open Send and observe camera does not auto open
  4. Toggle the auto open camera config to true
  5. Open Send and the camera does not auto open again
  6. Despite refreshing app a few times, camera still does not auto open with the config set to true.
Tue, Mar 26, 02:14

Mon, Mar 25

emack accepted D15774: [Cashtab] Autosize the wallet select based on text width.
Mon, Mar 25, 04:22
emack requested changes to D15774: [Cashtab] Autosize the wallet select based on text width.

Tested ok, just a minor nit in function comments

Mon, Mar 25, 00:02

Sun, Mar 24

emack accepted D15773: [Cashtab] Use latest chronik-client.
Sun, Mar 24, 23:54
emack accepted D15772: [Cashtab] Better error handling for rendering txs.
Sun, Mar 24, 23:28
emack requested changes to D15772: [Cashtab] Better error handling for rendering txs.
Sun, Mar 24, 13:27
emack accepted D15769: [Cashtab] Replace antd notifications and pop-up modals with react-toastify.
Sun, Mar 24, 13:23
emack accepted D15771: [chronik-client] Add timeout failure to ws connections.
Sun, Mar 24, 13:20
emack accepted D15770: [Cashtab] Clean up upgrade modal component.
Sun, Mar 24, 02:21
emack requested changes to D15771: [chronik-client] Add timeout failure to ws connections.
Sun, Mar 24, 02:12
emack requested changes to D15769: [Cashtab] Replace antd notifications and pop-up modals with react-toastify.

It's not immediately clear whether each notification is an error, success or warning message at a quick glance. I would suggest using either a green tick/red cross/yellow exclamation mark to accompany each notification (via the icon prop) or customize the background color depending on the nature of the message. White text on black bg can be interpreted in different ways.

Sun, Mar 24, 02:05

Sat, Mar 23

emack accepted D15766: [Cashtab] Use in-node chronik to calculate airdrops.
Sat, Mar 23, 09:46

Fri, Mar 22

emack accepted D15764: [Cashtab] Change wallet from dropdown menu in header.

Much better

Fri, Mar 22, 23:49
emack requested changes to D15766: [Cashtab] Use in-node chronik to calculate airdrops.

Error workflow:

  1. 100 XEC airdrop for 1c6c9c64d70b285befe733f175d0f384538576876bd280b10587df81279d3f5e, which should give you the following:

image.png (149×466 px, 20 KB)

Fri, Mar 22, 23:44
emack requested changes to D15764: [Cashtab] Change wallet from dropdown menu in header.

Tested all ok but it looks really out of place with the thick border

image.png (200×290 px, 12 KB)

Fri, Mar 22, 14:09

Thu, Mar 21

emack accepted D15711: [Cashtab] Render onboarding screen if user does not have a wallet.
Thu, Mar 21, 10:56
emack accepted D15744: [token-server] Accept uploaded token icons.
Thu, Mar 21, 03:50
emack requested changes to D15711: [Cashtab] Render onboarding screen if user does not have a wallet.

I'm seeing a perma-lock on incognito mode (which has no existing wallet in storage).

  • No errors in console.
  • Already tried npm ci.
  • Reloaded and hard-refreshed multiple times.

Likely the cashtabLoaded state var isn't being set in the onboarding process?

Thu, Mar 21, 01:27
emack requested changes to D15744: [token-server] Accept uploaded token icons.

I'll ping you on tg to whitelist my IP. Given the changes it would be good if I can manually test the token creation process in case there's something not obvious to the int tests coverage.

image.png (246×359 px, 39 KB)

Thu, Mar 21, 00:51

Tue, Mar 19

emack accepted D15729: [Cashtab] Handle unknown tokens.
Tue, Mar 19, 09:59
emack accepted D15728: [Cashtab] Update ws onmessage handler so latest cashtabState is always available.
Tue, Mar 19, 07:14
emack added a comment to D15728: [Cashtab] Update ws onmessage handler so latest cashtabState is always available.

image.png (130×1 px, 24 KB)

Starting to see 120,000 ms being exceeded

Tue, Mar 19, 07:03
emack accepted D15731: [Cashtab] Default chronik server to ABC instance.
Tue, Mar 19, 06:51
emack added a comment to D15729: [Cashtab] Handle unknown tokens.

Is there a difference between an unknown token vs an invalid token that does not conform to SLPv1 or ALP standards?

Tue, Mar 19, 06:30
emack accepted D15701: [Cashtab] Build our own modal to stop using antd.
Tue, Mar 19, 06:26
emack closed D15672: [standards] Reserve op_return prefix for eCash Chat platform.
Tue, Mar 19, 06:24
emack committed rABCcf4c60913dd3: [standards] Reserve op_return prefix for eCash Chat platform (authored by emack).
[standards] Reserve op_return prefix for eCash Chat platform
Tue, Mar 19, 06:24

Sat, Mar 16

emack retitled D15672: [standards] Reserve op_return prefix for eCash Chat platform from [standards] Reserve op_return prefix for eCash Social platform to [standards] Reserve op_return prefix for eCash Chat platform.
Sat, Mar 16, 12:30
emack updated the diff for D15672: [standards] Reserve op_return prefix for eCash Chat platform.

Updated prefix reservation

Sat, Mar 16, 12:30
emack requested changes to D15701: [Cashtab] Build our own modal to stop using antd.
Sat, Mar 16, 09:47
emack added a comment to D15701: [Cashtab] Build our own modal to stop using antd.

If you toggle Send Confirmations in config to true, then send a normal XEC tx, that setting resets to false after tx broadcast.

Sat, Mar 16, 09:45
emack accepted D15710: [Cashtab] Patch improper useNavigate usage.
Sat, Mar 16, 09:26
emack accepted D15693: [Cashtab] Use in-node chronik.
Sat, Mar 16, 08:40

Fri, Mar 15

emack accepted D15703: [Cashtab] Clean up how fiat price for min token creation is displayed.
Fri, Mar 15, 11:02
emack requested changes to D15693: [Cashtab] Use in-node chronik.

Edge case: Send a token tx where you're sending the entire remaining token balance so that it needs to automatically route out of the SendToken.js and back to Home. The following bad state use warning is shown:

image.png (337×354 px, 48 KB)

Fri, Mar 15, 10:46

Wed, Mar 13

emack accepted D15679: [Cashtab] Improve Cashtab wallet shape.
Wed, Mar 13, 12:22
emack accepted D15684: [Cashtab] Create custom modal for version upgrades.
Wed, Mar 13, 12:19
emack requested changes to D15679: [Cashtab] Improve Cashtab wallet shape.
Wed, Mar 13, 11:51
emack requested changes to D15684: [Cashtab] Create custom modal for version upgrades.

So my steps were:

  1. Deploy v2.0.10 to netlify
  2. Create new wallet on there
  3. Bump version to v2.0.11, then redeploy to netlify
  4. Waited around with the wallet open but no modal.
  5. Closed and re-opened browser, upgrade modal shows up on load
  6. Click OK, cashtab refreshes but Configure.js is still showing v2.0.10
Wed, Mar 13, 08:48
emack accepted D15689: [Cashtab] Remove parenthesis around buttons.
Wed, Mar 13, 08:30
emack accepted D15678: [token-server] Add endpoint to check address eligiblity for token rewards.
Wed, Mar 13, 08:27

Tue, Mar 12

emack published D15672: [standards] Reserve op_return prefix for eCash Chat platform for review.
Tue, Mar 12, 23:20

Sat, Mar 9

emack requested changes to D15662: [Cashtab] Change wallet structure to store balanceSats as number instead of balances as object.
Sat, Mar 9, 05:44
emack closed D15656: [e.cash] Add extension to wallet page.
Sat, Mar 9, 05:30
emack committed rABC94450f474e27: [e.cash] Add extension to wallet page (authored by emack).
[e.cash] Add extension to wallet page
Sat, Mar 9, 05:30
teamcity awarded D15656: [e.cash] Add extension to wallet page a Piece of Eight token.
Sat, Mar 9, 05:21
emack accepted D15669: [Cashtab] Cleaner state setting in activateWallet.
Sat, Mar 9, 05:09
emack added a comment to D15656: [e.cash] Add extension to wallet page.

image.png (454×982 px, 84 KB)

Sat, Mar 9, 02:50
emack updated the diff for D15656: [e.cash] Add extension to wallet page.

Updated wed/extension logos and wording.

Sat, Mar 9, 02:50

Fri, Mar 8

emack accepted D15612: [Cashtab] Cashtab 2.0.0 - Migrate to new wallet management API.
Fri, Mar 8, 13:59
teamcity awarded D15656: [e.cash] Add extension to wallet page a Haypence token.
Fri, Mar 8, 13:43
emack requested review of D15656: [e.cash] Add extension to wallet page.
Fri, Mar 8, 13:42
emack requested changes to D15612: [Cashtab] Cashtab 2.0.0 - Migrate to new wallet management API.

Manual testing observations:

  • When switched to another wallet, the wallets[0] is updated but the separate wallet object is still on the previous wallet. Deleting this stale wallet in the wallet object does not update it.
  • No longer seeing that edge case where clicking Activate on another wallet loops back to the same wallet, until you click Activate a 2nd time
  • Wallet switching is soooo much faster now
Fri, Mar 8, 13:17

Thu, Mar 7

emack accepted D15647: [token-server] Add function getTxTimestamp to get best timestamp from a chronik Tx_InNode.
Thu, Mar 7, 09:44
emack accepted D15640: [mock-chronik-client] Move to modules.
Thu, Mar 7, 08:27

Wed, Mar 6

emack requested changes to D15640: [mock-chronik-client] Move to modules.

Error: Cannot find module '../../mock-chronik-client/mocks/mockChronikResponses'
Require stack:

  • /work/apps/examples/test/sendXec.test.js
Wed, Mar 6, 03:14
emack accepted D15638: [token-server] Add new function to determine if a given tx involves an address receiving a given tokenId.
Wed, Mar 6, 00:54
emack accepted D15639: [token-server] Upgrade chronik-client to get latest types.
Wed, Mar 6, 00:53
emack requested changes to D15638: [token-server] Add new function to determine if a given tx involves an address receiving a given tokenId.

Just so I'm clear on the underlying use case here, will this be used to parse through all tx history of the address to figure out whether the address has received this token at least once in its entire history, or is it to determine the user is currently holding a balance of this tokenId? If it's the latter then you can just use the etoken-list lib can't you?

Wed, Mar 6, 00:41
emack accepted D15630: [chronik-client] Improve organization of subscriptions in ws object.
Wed, Mar 6, 00:22
emack accepted D15637: [mock-chronik-client] Support ws.unsubscribe.
Wed, Mar 6, 00:01

Tue, Mar 5

emack accepted D15625: [token-server] Add function hasInputsFromOutputScript.
Tue, Mar 5, 22:12
emack requested changes to D15637: [mock-chronik-client] Support ws.unsubscribe.
Tue, Mar 5, 22:06
emack accepted D15613: [mock-chronik-client] Support sub/unsub address method for ws.

accepted with note

Tue, Mar 5, 21:53
emack accepted D15621: Revert "[mock-chronik-client] Publish as npm pkg and install where used".
Tue, Mar 5, 21:42
emack accepted D15626: [chronik-client] Improve type definition.
Tue, Mar 5, 07:21
emack added a comment to D15625: [token-server] Add function hasInputsFromOutputScript.

I assume txs like this self minting tx are out of scope for this token server right? The function will return false as the minter won't be in the inputs but I guess this wouldn't be generated out of cashtab anyway yea?

Tue, Mar 5, 07:09
emack accepted D15628: [chronik-client] Patch comment.
Tue, Mar 5, 03:31

Sun, Mar 3

emack accepted D15614: [mock-chronik-client] Publish as npm pkg and install where used.
Sun, Mar 3, 03:41
emack accepted D15611: [chronik-client] Sub and unsub to and from addresses for websocket.
Sun, Mar 3, 03:27

Sat, Mar 2

emack requested changes to D15611: [chronik-client] Sub and unsub to and from addresses for websocket.
Sat, Mar 2, 23:33
emack accepted D15609: [token-server] Implement typescript.
Sat, Mar 2, 23:23
emack accepted D15610: [Cashtab] Replace conflicting functions with more comprehensive validation function.
Sat, Mar 2, 22:39
emack planned changes to D15000: [Cashtab] Enable wallet switching from Home screen.
Sat, Mar 2, 13:33
emack planned changes to D15079: [Cashtab] Ignore function for tokens - pt 1 of 2.
Sat, Mar 2, 13:33
emack planned changes to D15188: [Cashtab] Tx History Pagination.
Sat, Mar 2, 13:33
emack planned changes to D15375: [Cashtab] Improve multi send value validation.
Sat, Mar 2, 13:33
emack planned changes to D15466: [Cashtab] Update alias.js with direct antd calls.
Sat, Mar 2, 13:33
emack planned changes to D15542: [Cashtab] Split out alias pricing validation errors.
Sat, Mar 2, 13:32
emack accepted D15606: [mock-chronik-client] Make sure assert rejects is called properly in tests.
Sat, Mar 2, 09:33
emack accepted D15607: [Cashtab] Fix bugs in parseChronikTx.
Sat, Mar 2, 08:48
emack accepted D15604: [Cashtab] Create and test new wallet creation and validation functions.
Sat, Mar 2, 08:25
emack accepted D15608: [Cashtab] Remove references to legacy ticker.
Sat, Mar 2, 08:03
emack accepted D15586: [token-server] Initialize a new app to manage rewards tokens.
Sat, Mar 2, 07:52

Fri, Mar 1

emack requested changes to D15586: [token-server] Initialize a new app to manage rewards tokens.
Fri, Mar 1, 12:17
emack accepted D15566: [Cashtab] Move cashtabCache to cashtabState.
Fri, Mar 1, 11:48

Thu, Feb 29

emack requested changes to D15566: [Cashtab] Move cashtabCache to cashtabState.
  1. I can see the reasoning for getting rid of token ID is because it's not in chronik-client's genesisInfo, but why are the other properties grouped together in index [1]? Isn't it simpler to have them as individual props? Is there a performance/caching consideration here?

image.png (365×473 px, 41 KB)

Thu, Feb 29, 12:46
emack accepted D15576: [Cashtab] Standardize price api mocks in test wrappers.
Thu, Feb 29, 11:42
emack accepted D15575: [Cashtab] Enable min fee sends for users with 1 million grumpy.

image.png (42×459 px, 1 KB)

This might actually drive up a price market for grump tokens lol

Thu, Feb 29, 05:38

Wed, Feb 28

emack accepted D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Wed, Feb 28, 23:52
emack added inline comments to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Wed, Feb 28, 13:30
emack added inline comments to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Wed, Feb 28, 13:27
emack requested changes to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Wed, Feb 28, 13:26
emack accepted D15564: [Cashtab] Implement standardized test wrappers in Receive.test.js.
Wed, Feb 28, 13:12
emack accepted D15572: [Cashtab] Remove obsolete cache dependencies.
Wed, Feb 28, 12:57
emack accepted D15567: [Cashtab] Upgrade signverifymsg tests.
Wed, Feb 28, 10:26