Page MenuHomePhabricator

emack (Ethan Q)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2021, 00:53 (7 w, 2 d)

Recent Activity

Fri, Oct 22

emack updated the diff for D10319: [Cashtab] Make the header balance a localeString.

Removed redundant else{} block

Fri, Oct 22, 06:46
emack updated the diff for D10332: [Cashtab] Convert calculated fiat amount string to locale string.
  • Added check for cashtabSettings edge case in Send.js
  • Removed the two redundant else{} blocks in Validation.js
  • Updated Send UI snapshots
Fri, Oct 22, 06:37
emack requested review of D10382: [Cashtab] Nav menu fix post label rebrand.
Fri, Oct 22, 04:46

Thu, Oct 21

emack updated the diff for D10319: [Cashtab] Make the header balance a localeString.

removed first else block per feedback, retained second else block as it is needed to check for an optional parameter rather than error checking.

Thu, Oct 21, 01:05

Wed, Oct 20

emack closed D10296: [Cashtab] Rebranding Token menu/button labels into eToken.
Wed, Oct 20, 23:49
emack committed rABCf3ea606b06a3: [Cashtab] Rebranding Token menu/button labels into eToken (authored by emack).
[Cashtab] Rebranding Token menu/button labels into eToken
Wed, Oct 20, 23:49
emack updated the diff for D10363: [Cashtab] Add ability to send an OP return msg in a tx.

Merge with formatting changes from prettier upgrade

Wed, Oct 20, 23:24
emack closed D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.
Wed, Oct 20, 23:06
emack committed rABCfbb4e2a94b18: [Cashtab] Remove Prettier from dependency tree and align formatting in Web… (authored by emack).
[Cashtab] Remove Prettier from dependency tree and align formatting in Web…
Wed, Oct 20, 23:06
emack added a comment to D10368: [Cashtab] Do not throw API error utxo with null isValid.

As far as I can tell this is only a linter update, you might have submitted the wrong branch

Wed, Oct 20, 09:03

Tue, Oct 19

emack updated the test plan for D10363: [Cashtab] Add ability to send an OP return msg in a tx.
Tue, Oct 19, 00:50
emack updated the diff for D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.

Added minimum prettier versioning to .arclint in repo root

Tue, Oct 19, 00:47
emack updated the diff for D10363: [Cashtab] Add ability to send an OP return msg in a tx.

Updated to check for blank string messages - tested ok on both normal op return string and empty strings. Empty strings no longer results in OP_RETURN outputs. Also changed to use strict operators.

Tue, Oct 19, 00:38

Sun, Oct 17

emack updated the diff for D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.

Updated package-lock.json

Sun, Oct 17, 12:06
emack requested review of D10364: [Cashtab] Improve visibility for domain migration msg.
Sun, Oct 17, 06:23
emack requested review of D10363: [Cashtab] Add ability to send an OP return msg in a tx.
Sun, Oct 17, 03:48

Sat, Oct 16

emack retitled D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder from [Cashtab] upgrade Prettier to latest version (2.4.1) to [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.
Sat, Oct 16, 01:22
emack updated the diff for D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.

Removed Prettier from dependency tree and kept formatting changes

Sat, Oct 16, 01:21

Fri, Oct 15

emack updated the diff for D10296: [Cashtab] Rebranding Token menu/button labels into eToken.

Reverted the whitespace removal by IDE, kept the TabLine style fixes

Fri, Oct 15, 03:56
emack updated the diff for D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.

Executed prettier --write . in the web/ folder and here are the files modified in place

Fri, Oct 15, 03:34
emack requested review of D10354: [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder.
Fri, Oct 15, 00:03

Thu, Oct 14

emack updated the diff for D10319: [Cashtab] Make the header balance a localeString.
  • wBalance variable changed to unformattedBalance
  • Whitespace removal reverted as it was a local IDE issue rather than Prettier (not upgraded).
Thu, Oct 14, 23:38
emack closed D10323: [Cashtab] Disable cash address highlighting and copying.
Thu, Oct 14, 23:23
emack committed rABC4fb64ce65f11: [Cashtab] Disable cash address highlighting and copying (authored by emack).
[Cashtab] Disable cash address highlighting and copying
Thu, Oct 14, 23:23
emack updated the diff for D10332: [Cashtab] Convert calculated fiat amount string to locale string.
  • Removal of whitespaces was due to local IDE rather than Prettier. This has since been disabled in my IDE and whitespace removal reverted.
  • fBalance variable changed to fiatBalance.
Thu, Oct 14, 23:13
emack updated the diff for D10296: [Cashtab] Rebranding Token menu/button labels into eToken.

Adjusted TabLine styled component in Wallet.js to fix the underline-moving rendering issue. Tested all ok in both web and browser extension mode, as well as via manual resizing of browser width.

Thu, Oct 14, 00:21

Wed, Oct 13

emack requested review of D10332: [Cashtab] Convert calculated fiat amount string to locale string.
Wed, Oct 13, 23:43
emack requested review of D10323: [Cashtab] Disable cash address highlighting and copying.
Wed, Oct 13, 08:23
emack requested review of D10319: [Cashtab] Make the header balance a localeString.
Wed, Oct 13, 06:19

Sun, Oct 10

emack added a comment to D10296: [Cashtab] Rebranding Token menu/button labels into eToken.

1.PNG (147×391 px, 13 KB)

Sun, Oct 10, 00:14
emack requested review of D10296: [Cashtab] Rebranding Token menu/button labels into eToken.
Sun, Oct 10, 00:08

Sat, Oct 9

emack abandoned D10295: [Cashtab] Rebranding Token menu/button labels into eToken.
Sat, Oct 9, 23:47
emack requested review of D10295: [Cashtab] Rebranding Token menu/button labels into eToken.
Sat, Oct 9, 04:32
emack abandoned D10287: [Cashtab] Rebranding Token menu/button labels into eToken.
Sat, Oct 9, 04:29

Fri, Oct 8

emack updated the diff for D10287: [Cashtab] Rebranding Token menu/button labels into eToken.

reverting arc lint formatting conflicts

Fri, Oct 8, 13:03
emack updated the diff for D10287: [Cashtab] Rebranding Token menu/button labels into eToken.

reverting arc lint formatting conflicts

Fri, Oct 8, 12:57
emack requested review of D10287: [Cashtab] Rebranding Token menu/button labels into eToken.
Fri, Oct 8, 12:51
emack abandoned D10275: [Cashtab] Rebranding Token menu/button labels into eToken.
Fri, Oct 8, 12:36
emack abandoned D10281: Revert "[Cashtab] Rebranding Token menu/button labels into eToken".
Fri, Oct 8, 10:21
emack requested review of D10281: Revert "[Cashtab] Rebranding Token menu/button labels into eToken".
Fri, Oct 8, 10:18

Thu, Oct 7

emack requested review of D10275: [Cashtab] Rebranding Token menu/button labels into eToken.
Thu, Oct 7, 00:18

Wed, Oct 6

emack closed D10252: [Cashtab] display balances for saved wallets.
Wed, Oct 6, 13:18
emack committed rABC938e0caca334: [Cashtab] display balances for saved wallets (authored by emack).
[Cashtab] display balances for saved wallets
Wed, Oct 6, 13:18
emack updated the diff for D10252: [Cashtab] display balances for saved wallets.

using currency.cashDecimals for maximumFractionalDigits parameter

Wed, Oct 6, 13:11
emack updated the diff for D10252: [Cashtab] display balances for saved wallets.

Updated React idiosyncrasies

Wed, Oct 6, 01:13

Tue, Oct 5

emack updated the diff for D10252: [Cashtab] display balances for saved wallets.

Minor adjustment to operator to avoid type coercion

Tue, Oct 5, 23:23
emack updated the diff for D10252: [Cashtab] display balances for saved wallets.

Added optional locale parameter for formatSavedBalance function and adjusted unit tests.

Tue, Oct 5, 13:08
emack abandoned D10239: SavedWallet balance display + enhancements.
Tue, Oct 5, 04:28
emack added a comment to D10252: [Cashtab] display balances for saved wallets.

UI screenshots below

1.PNG (270×620 px, 28 KB)

Tue, Oct 5, 01:05
emack added a comment to D10239: SavedWallet balance display + enhancements.

After further discussion with @bytesofman, due to issues with commit this diff will now be abandoned with a new fresh diff created (D10252).

Tue, Oct 5, 00:59
emack requested review of D10252: [Cashtab] display balances for saved wallets.
Tue, Oct 5, 00:57

Mon, Oct 4

emack updated the diff for D10239: SavedWallet balance display + enhancements.

Added try-catch loop to validation.js and reverted jest version in package.json

Mon, Oct 4, 23:40

Sat, Oct 2

emack updated the test plan for D10239: SavedWallet balance display + enhancements.
Sat, Oct 2, 06:13
emack updated the test plan for D10239: SavedWallet balance display + enhancements.
Sat, Oct 2, 06:03
emack updated the summary of D10239: SavedWallet balance display + enhancements.
Sat, Oct 2, 06:01
emack updated the diff for D10239: SavedWallet balance display + enhancements.

Summary:
Incorporates review feedback from Fabien and BytesOfMan from 2021-10-01

  • Created new function 'formatSavedBalance' in utils/validation.js to take a savedwallet balance as input and return a formated locale string so large XEC balances are legible
  • Imported the newly created locale string function into Configure/Configure.js and utilised as part of conditional rendering to mitigate edge cases that may prevent the app from rendering.
  • Added unit tests in validation.test.js to test edge case inputs for SWBalances, including undefined/null balances, zero and max supply trillion balances
  • Fixed overflow issue with long wallet names pushing buttons off the UI by adjusting overflow:hover css for both <SWName> and <SWBalance>
  • Added additional styling in Configuration.js's <SWBalance> component to enhance aesthetics and distinguish SWBalance values from SWName
  • Updated snapshot to fix earlier unit test errors
Sat, Oct 2, 05:53

Fri, Oct 1

emack requested review of D10239: SavedWallet balance display + enhancements.
Fri, Oct 1, 03:43