Page MenuHomePhabricator

floreslorca (sken)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 15 2018, 02:36 (53 w, 3 d)

Recent Activity

Fri, Mar 22

floreslorca updated the diff for D2681: [secp256k1] remove guava dep.

remove guava in build script

Fri, Mar 22, 22:44
floreslorca updated the diff for D2681: [secp256k1] remove guava dep.

remove guava dep in a single commit

Fri, Mar 22, 21:15
floreslorca added a comment to D2681: [secp256k1] remove guava dep.

huh i did rebase but it still not showing the proper diff

Fri, Mar 22, 20:34
floreslorca updated the diff for D2681: [secp256k1] remove guava dep.

rebase master

Fri, Mar 22, 20:32
floreslorca committed rABC737ff23ed292: [secp256k1] fix java secp256k1 test (authored by floreslorca).
[secp256k1] fix java secp256k1 test
Fri, Mar 22, 19:37
floreslorca closed D2685: [secp256k1] fix java secp256k1 test.
Fri, Mar 22, 19:37
floreslorca updated the diff for D2685: [secp256k1] fix java secp256k1 test.

rebase

Fri, Mar 22, 18:40

Thu, Mar 21

floreslorca updated the diff for D2681: [secp256k1] remove guava dep.

remove indentation

Thu, Mar 21, 04:40

Wed, Mar 20

floreslorca requested review of D2681: [secp256k1] remove guava dep.
Wed, Mar 20, 06:09
floreslorca requested review of D2685: [secp256k1] fix java secp256k1 test.
Wed, Mar 20, 06:08

Fri, Mar 15

floreslorca added a comment to D2685: [secp256k1] fix java secp256k1 test.

Is that test plan sufficient? It would be great if we can get this moving. I already finished the schnorr jni bindings but they depend on this and https://reviews.bitcoinabc.org/D2681. plus another commit that allows compressed/not compressed

Fri, Mar 15, 18:31

Wed, Mar 13

floreslorca added a comment to D2681: [secp256k1] remove guava dep.

depends on these

Wed, Mar 13, 20:44
floreslorca updated the test plan for D2685: [secp256k1] fix java secp256k1 test.
Wed, Mar 13, 20:35
floreslorca updated the test plan for D2681: [secp256k1] remove guava dep.
Wed, Mar 13, 20:34
floreslorca added a comment to D2685: [secp256k1] fix java secp256k1 test.

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

Wed, Mar 13, 20:30

Tue, Mar 12

Herald added a reviewer for D2685: [secp256k1] fix java secp256k1 test: deadalnix.
Tue, Mar 12, 22:55
floreslorca updated the test plan for D2681: [secp256k1] remove guava dep.
Tue, Mar 12, 01:05
floreslorca updated the test plan for D2681: [secp256k1] remove guava dep.
Tue, Mar 12, 01:05
Herald added a reviewer for D2681: [secp256k1] remove guava dep: deadalnix.
Tue, Mar 12, 00:53